[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #32 from David Gustafsson <glasklas at gmail.com> ---
@Katrin Fischer Sorry about the late reply.

1) I don't know if I can summarize it better than the current commit message,
perhaps I could add "instead of falling back to the default rule (overwrite),
which was the previous behavior. Previously the wildcard filter rules where
only applied if no other filter value would match. The added tests should also
be equivalent to performing manual testing, so don't really see why we would
need both, but I guess I could add some simple case to be performed in the
staff interface.

2) Gave this some thought and I think there is a relatively simple way to add
rules depending on existing rules that would result in this patch not at all
affecting behavior for current used defined rules. Will add a database
migration  for this.

3) Haven't done this for any other patch, so a little bit uncertain what it
should contain.

About your rules the wildcard filter rule will be merged in to the rule-sets of
both the other rules. If the filter value is z3950 rule 2 and 4 will be
applied, if batchmod 4 and five. If instead of 245 you had *, the wildcard
filter rule (for tag 300) would not be included since the rule for z3950 and
batchmod would always match, and rules with a specific filter value take
precedence over wildcard filter rules if they match. (As summarized with
"Fallback to overlay rules with wildcard filter if no match found for exact
filter match." in the commit message.

-- 
You are receiving this mail because:
You are watching all bug changes.