[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #51 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
I was a bit too quick to signoff the patches. That indeed doesn't look like a
change that can only have automated tests (thanks for these though) without
some basic manual testing.

So I tried something based on comment 0

1. Administration => record overlay rules
2. Add this:
Module Filter                     Tag Preset  Added Appended Removed Deleted
Source Z39.50                     245 Protect Skip  Skip     Skip    Skip
Source *                          300 Protect Skip  Skip     Skip    Skip
Source Batch record modification  245 Protect Skip  Skip     Skip    Skip
3. Add MARC modification templates:
Update existing or add new field 245$a with value CATSCATSCATSCATS
Update existing or add new field 300$a with value CATSCATSCATSCATS
4. Find a record that has those field (likely any record would)
5. Use batch record modification on the record
6. 300$a should have been catified (expected, that's the bug)
7. 245$a is preserved
8. Change the values of the two subfields to something else
9. Apply the patch, restart services
10. Use batch record modification on the record
11. 300$a should be preserved, cat protection should have worked

But no it still got changed :(

It's the first time I'm using record overlay rules so there is likely a mistake
there.
Either that or there is still a bug.
So in the end, test plan needed or bug found.

-- 
You are receiving this mail because:
You are watching all bug changes.