[Koha-bugs] [Bug 36251] Patron search by letter broken in holds

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36251

--- Comment #2 from Jonathan Druart <jonathan.druart at gmail.com> ---
Created attachment 162861
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162861&action=edit
Bug 36251: (bug 35329 follow-up) Fix patron search by first letter when placing
a hold

Most of the patrons searches open in a modal. Except:
* the main one (members-home)
* when placing a hold
* when requesting an article
(did I miss one?)

The patron-search.inc BLOCKs need a parent block to know where to locate
the elements (form, table, etc), because we can have several patron
searches on the same page.

Bug 35329 reused '#searchresults':
  10 [% SET search_results_block_id = 'searchresults' %]
which is used on the main patron search.
The ones in the modal are correctly handled: we build the parent node in
the "patron_search_modal" block.
But for the 2 others the parent block id is wrong.

On reserve/request.tt we have one already, so we set the TT variable from the
.tt file
On circ/request-article we don't have one already, so we can reuse
searchresults (could be more specific however to include 'patrons'...)

Test plan:
Browse patrons by first letter when placing a hold and requesting an
article

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.