[Koha-bugs] [Bug 36243] ILL "Edit request" action is broken

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36243

--- Comment #7 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
(In reply to Tomás Cohen Arazi from comment #6)
> Can we add the _form suffix to the op parameter?

Yes, we can. And we should. Though it'll require a rewrite on how $op is
handled in ill-requests.pl and ill-requests.tt.
The focus of this bug is to fix the regression.

ill-requests.pl handles an edit_action "form" and an edit_action "save" in the
same $op eq 'edit_action', which means these would have to be decoupled to
cud-edit_action and edit_action_form.
The same would have to be made for cud-create, cud-generic_confirm, cud-delete
(?) and possibly others.
We'd also have to account for the fact that existing backends may have not yet
adopted these new $op names (See get_op_param_deprecation in Illrequest.pm)

In short, my suggestion would be to push this refactor/clean-up work to its own
bug, but I'm obviously happy to discuss if you or others disagree.

-- 
You are receiving this mail because:
You are watching all bug changes.