[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122

--- Comment #6 from Matthias Le Gac <matthias.le-gac at inlibro.com> ---
Created attachment 162962
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162962&action=edit
Bug 36122: NEW_SUGGESTION is sent for every modification to the suggestion

Test plan :

To recreate:
1. Enable EmailPurchaseSuggestions

2. Go to a patron's account and add an email address, a different one than the
one used for EmailPurchaseSuggestions

3. Create a suggestion from the OPAC
   3.1. Go to the OPAC and log in as a patron
   3.2. Go to Your account > Purchase suggestions
   3.3. Click New purchase suggestion
   3.4. Enter a title
   3.5. Click Submit your suggestion

4. Check the message_queue, there should be one NEW_SUGGESTION message sent to
whichever address you chose in EmailPurchaseSuggestions (in a fresh db, there
should be 1 entry in message_queue)

5. Update the suggestion to accepted 
   5.1. In the staff interface, go to Acquisitions > Suggestions
   5.2. In the suggestions list, check the box next to the suggestion
   5.3. At the bottom of the screen, choose Mark selected as: Accepted
   5.4. Click Submit

6. Check the message_queue again, there should be one ACCEPTED message sent to
the patron and a new NEW_SUGGESTION message sent to whichever address you chose
in EmailPurchaseSuggestions (in a fresh db, there should now be 3 entries in
message_queue)

7. Order the suggestion
   7.1. Go to Acquisitions
   7.2. Search for a vendor
   7.3. Click New > Basket
   7.4. Enter a basket name
   (Optional: for testing I like to change Create items when: cataloging the
record)
   7.5. Click Save
   7.6. Click Add to basket
   7.7. Click From a suggestion
   7.8. Click Order next to the suggestion
   7.9. Enter order details
   7.10. Click Save
   7.11. Click Close basket
   7.12. Click Yes, close

8. Check the message_queue again, there should be one ORDERED message sent to
the patron and a new NEW_SUGGESTION message sent to whichever address you chose
in EmailPurchaseSuggestions (in a fresh db, there should now be 5 entries in
message_queue)

9. Apply the patch

10. now repeat steps 3 to 8 but :
    step 4 you have one NEW_SUGGESTION message in message_queue
    step 6 you have only one ACCEPTED message in message_queue
    step 8 you have only one ORDERED message in message_queue

The NEW_SUGGESTION are now sent only on the submit of the suggestion and not on
each steps.

-- 
You are receiving this mail because:
You are watching all bug changes.