[Koha-bugs] [Bug 15278] [Omnibus] Port default slips and notices from bespoke syntax to Template Toolkit

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Mar 8 18:33:23 CET 2024


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278

--- Comment #13 from Christopher Brannon <cbrannon at cdalibrary.org> ---
(In reply to Emily Lamancusa from comment #12)
> One more thing to consider: do we just update the default text in
> sample_notices.yml for new installations at this point, or do we also
> include dbrevs for existing installations that use the default notice text?
> 
> Normally, we don't update the default notice text for existing installations
> unless there is a breaking change. However, since the goal is to eventually
> deprecate the old syntax, which will be a breaking change, it might be
> better to update the defaults on both new and existing installations
> together... It will be unavoidable for libraries with customized notices to
> need to update their own notices eventually. However, I'm sure there are
> libraries who rely on the default notices and may not be familiar with
> customizing their notices at all, and I could see it being a major issue if
> a large number of their notices, which they haven't touched, stop working.
> 
> One could argue that we should wait until we actually introduce the breaking
> change to update the default notice text on existing installations, but IMO
> it makes more sense to do it now rather than tracking down what the default
> used to be sometime later. (Granted, we will still probably miss some
> installations that have older "default" versions of notices whose defaults
> have already been changed in the past, but I still think we should prevent
> problems as much as we can now.)
> 
> The downside is that it makes the current task harder, and introduces a
> chance of bugs/regressions...but I still think it's worth it to avoid even
> more difficulties later.

Could you keep the old syntax functional for existing users and give them a
version or two to update their notices/slips?  Maybe only change the default
notices that have not been modified from install?  It seems reasonable to give
existing users time to clean up their own notices with the new tools.  That
way, if there are any complications or something missed, they some wiggle room
before the old stuff goes away.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list