[Koha-bugs] [Bug 35919] Add record sources CRUD

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919

--- Comment #26 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #24)
> I don't understand why you stubborn and obstinate to do things differently.
> I have said that 10x on bug 32607, then here again.

Maybe because some things didn't exist when this was submitted in the first
place? Or maybe some things were rewritten by the time this got (finally) some
eyes on it.

I really thought I had covered all the remaining things. I removed all of the
contentious snippets.

I will try to understand your concerns. Vue is not my whellhouse. This is the
first time I work with Vue, trying to help someone else's dev to move forward.
And even learnt Cypress and wrote the darn tests for a trivial CRUD page!

> 1. computed title instead of the logic in template
> 2. retrieving the client api from setup()
> 3. _has_value should not be needed, we have form validation already
> 4. you should clean the api-client, why do you deal with headers and json
> stringify? we don't need it in other places!
> 5. in the routes:
>     BeforeUnloadEvent() {
>         window.location.href = "/cgi-bin/koha/admin/admin-home.pl";
>     },
> Why?
> 6. Why do you name the add/edit component "Edit" when all others are named
> "AddForm"?
> 
> 7. Why calling the client api this way:
>   .then(() => something())
> when all existing occurrences do:
>   .then(
>     success => something(),
>     error => {},
>   );
> 8.Edit.vue
>     Object.keys(response).forEach(key => {
>         this.row[key] = response[key]
>     })
> What's the point of this??
> 
> Some are blocker, some are weirdness, others are better than what exist but
> different.
> 
> I let you decide the status of this.

-- 
You are receiving this mail because:
You are watching all bug changes.