[Koha-bugs] [Bug 19605] ILL backends should be pluggable through regular Koha plugins

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605

--- Comment #28 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Sorry for the noise, I forgot to stamp my signature.

Remarks:

* I will submit on a follow-up bug an idea for some error checking we are
lacking here. No rush though. Will do on monday for sure.
* I didn't understand why you changed the expandTemplate method name here. No
problem for me but we usually do it on a separate report.
* I'm not sure we should tag 'this is the new way' in the code, as it might be
confusing for readers a couple months later. I fixed this in one place, making
the code and comments assume 'plugins is the way' and the 'old one' is a
'fallback' mechanism. I prefer such terminology.

This all looks great. Awesome job! Sorry for the delay!

-- 
You are receiving this mail because:
You are watching all bug changes.