[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122

--- Comment #11 from Matthias Le Gac <matthias.le-gac at inlibro.com> ---
(In reply to Lucas Gass from comment #10)
> Mattais,
> 
> Can you review these tests? Something seems not quite right:
> 
> # Subtest: store
>     1..8
>     ok 1 - If suggesteddate not passed in, it will default to today
>     ok 2 - If suggesteddate passed in, it should be taken into account
>     ok 3 - If suggestion id modified, suggesteddate should not be modified
>     ok 4 - If EmailPurchaseSuggestions is not enabled, a message should not
> be sent
>     not ok 5 - No message was sent
> 
>     #   Failed test 'No message was sent'
>     #   at /kohadevbox/koha/t/db_dependent/Koha/Suggestions.t line 89.
>     ok 6 - If the status of suggestion is not set to ASKED, a message should
> not be sent
>     ok 7 - store raises an exception on invalid STATUS
>     ok 8 - UNKNOWN status stored
>     # Looks like you failed 1 test of 8.
> not ok 1 - store
> 
> 
> Thanks!

I can't reproduce the problem, I've tried different situations but test 5
passes every time. Can you add these print "print STDERR "syspref: " .
$syspref->variable . " value :" . $syspref->value . "\n";" to line 85 and 86
(before and after the syspref store line) and tell me what you get?
To be sure that the changes made to the preferences have been good.

-- 
You are receiving this mail because:
You are watching all bug changes.