[Koha-bugs] [Bug 36297] Avoid using var named "t" in templates
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Thu Mar 14 11:37:27 CET 2024
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36297
--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Pedro Amorim from comment #1)
> This may be a non-issue (?) if it is indeed a template toolkit bug and it
> gets fixed upstream, the problem is that the value of 't' persists even
> after the end of the loop.
> Having said that, we may also just decide that using 't' as a variable name
> (anywhere) in TT is bad practice, because it may conflict with the
> translation method 't' we use.
I don't think we can count on this being fixed upstream any time soon. I think
it's reasonable for use to fix the existing instances and perhaps add a unit
test to grep for "FOREACH t IN" in all our templates.
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list