[Koha-bugs] [Bug 36302] Patron search from search bar broken

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Mar 15 12:18:03 CET 2024


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302

--- Comment #31 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
I don't agree with this behavior, i.e. redirecting to the single search result
if only one is returned:
1) Maybe this is the norm? But I have personally not seen other search systems
with this behavior.
2) We're not consistent: Some tables in Koha (most?) return a single result if
only one is found, not redirect happens.
3) It's artificial, unexpected and a pain to maintain, as we've proven here.

Having said that, we've gone to great lengths in making sure this historic
behavior is kept, and it appears we've reached a consensus that, in Firefox,
when clicking the "back" button from the patron detail page, being redirected
to it again is what was happening before the CSRF work, meaning this patch
fixes the search issue introduced by CSRF and keeps the original behaviour.

(In reply to Julian Maurice from comment #30)
> From the test plan:
> > 6) Press the browser 'back' button and notice it works as expected (both Chrome+Firefox)
> What is the expected behaviour ? I get "this page has expired" error

When I first tested my patch I was sure it had the same behavior on both
browsers, but having tested it again after Joubu's comment, it appears it does
not.

The current expected behavior:
Chrome: You get redirected to whatever page you started the header patron
search from. 
Firefox: You get redirected to patrons-home and immediately redirected to the
single patron detail page afterwards, regardless of where you started the
header patron search form.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list