[Koha-bugs] [Bug 36139] Bug 35518 follow-up: fix AutoSwitchPatron

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36139

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #7 from David Nind <david at davidnind.com> ---
(In reply to Michael Hafen from comment #6)
>   There are four patches because the `git bz apply` command references the
> parent bug, which is already in master as commits 90b6f68616 and b577b65670.
> Please try `git bz apply 36139` instead.
>   The patch file here squashes the last two patches on the parent bug (those
> two should probably be removed from there or something, since I mistakenly
> added them after the patch had been pushed).
>   This will at least take care of the 'Barcode not found' error, and I think
> clearing the $patron variable should be harmless at that point in the file. 
> (Looking over the code again, I don't know why it wasn't switching patrons
> for me, the $patron variable clearly gets reset in the $findborrower block
> below.)
>   I'll leave the status as is, just in case there is anything else that
> causes the patch to not apply.

Hi Michael.

My apologies! I was reading things incorrectly, and as you spotted I applied
the wrong patch!

The patch does apply, now that I have used the correct bug number!

Things now work as expected: with AutoSwitchPatron enabled, the patron is
swicthed and the only message that is now displayed is:

Patron was automatically switched by reading the patron card during checking
out. Ensure you are working with the right patron.

Sign off on the way.

David

-- 
You are receiving this mail because:
You are watching all bug changes.