[Koha-bugs] [Bug 35919] Add record sources CRUD

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

--- Comment #39 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Marking NSO again, as I rewrote most of the Vue part of this dev.

Some things I'm not comfortable with, but happy to follow the current standard
practice for now, and evolve later.

I kept the URL rewrite rule we originally submitted. I think requiring the
trailing slash (/) if my rewrite avoids it, doesn't make sense.

I can submit a bug for redoing the rest of the rewrites this way if required by
QA (if this applies, as I'm not familiar with the little details the other
modules might have making them requiring this).

I also liked it more when the API client was instantiated globally instead on
each place it is used. As it is a stateless object it should cause no issues. I
moved it to match the current practice and will file a separate bug to restore
the original implementation and discuss it in place.

Thanks everyone!

-- 
You are receiving this mail because:
You are watching all bug changes.