[Koha-bugs] [Bug 34886] Regression in when hold button appears

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34886

--- Comment #44 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
On 34886 we did:
-        $can_item_be_reserved = $can_item_be_reserved ||
IsAvailableForItemLevelRequest($item, $patron, undef);
+        $can_item_be_reserved = $can_item_be_reserved || $patron &&
IsAvailableForItemLevelRequest($item, $patron, undef);

And there was noted that this causes the regression repeated here in
description? Could you explain that? This is just a very logical check before
calling IsAvailableForItemLevelRequest? Which you should not for anonymous..

Note that this test
$can_item_be_reserved || CountItemsIssued($biblionumber) ||
$biblio->has_items_waiting_or_intransit
determines the Place Hold button visibility. And without a patron it will
always be just an educated guess if some patron can reserve or not. This test
was not adjusted on 34694?

-- 
You are receiving this mail because:
You are watching all bug changes.