[Koha-bugs] [Bug 33348] Show authority heading use with Elasticsearch

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33348

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
             Status|Needs Signoff               |Failed QA

--- Comment #12 from David Nind <david at davidnind.com> ---
>From my testing:

1. The tests fail after the patches are applied - see [4].

2. Authority finder plugin when editing a record and trying to find an
authority term (for example for a 650 entry): does not display any results, so
can't confirm that it works. May be affected by the CSRF changes - see step 6
of my testing notes.

Testing notes using KTD:

1. Start up KTD with Elasticsearch: ktd --es8 up
2. Apply the patches, update the database (updatedatabase), and restart
services (restart_all).
3. Search system preferences for ShowHeadingUse - it should be set to 'Don't
show'.
4. Do an authority search, for example: perl 
5. Confirm it works as expected and no new information is shown in the search
results, as ShowHeadingUse is disabled. [1]
6. Search for and edit a bibliographic record (for example: Programming perl,
record = 146):
   . Go to one of the authority fields (1xx, 6xx or 7xx) (for example: 650)
   . Repeat the tag (such as 650)
   . Launch the authority finder plugin
   . Do an authority search and confirm it works as expected and no new
information is shown - see [3], not currently working in master - this may be
because of the CSRF changes (bugs 34478 and 36192)
7. Set the ShowHeadingUse system preference to 'Show'.
8. Repeat steps 4 to 6 and confirm that the 'Heading use' column now shows, and
correctly displays what the heading is used for based on 008/14-16. [2]
9. Edit tag 008 for a record (for example: Perl (Computer language),
authid=1525):
   . change 14-16 to '|- No attempt to code'
   . in the authority search for that term, these entries are displayed in the
heading use column:
     x Main/Added Entry
     x Subject
     x Series Title
10. Tests should pass: prove t/Koha/SearchEngine/Elasticsearch/Search.t
11. Bonus test: Test steps 7-9 using the Zebra search engine.
12. Bonus test: Test with Elasticsearch before the patches are applied. The
heading use column is displayed, but the values are not correctly displayed -
that is, they all display as follows irrespective of the values in 008/14-16:
     x Main/Added Entry
     x Subject
     x Series Title

[1] What is shown for authority search results with ShowHeadingUse set to
'Don't show':

Standard search results are shown for an authority search with details listed
under these columns:
. Summary: lists terms
. Heading type: lists the type of term, such as 'Topical Term'
. Used: shows how many records the term is used in, for example '1 record(s),
with a link to the record(s)
. Action column: Actions button - dropdown displays actions available

[2] What is shown for authority search results with ShowHeadingUse set to
'Show':

Same as in [1], with an extra column before the actions column:
. Heading use: lists what the heading can be used for, for example for Perl
(Computer language):
  ✔ Main/Added Entry
  ✔ Subject
  x Series Title

[3] Expected the authority finder plug to show standard authority search
results, similar to [1]. However, on the current master no search results are
displayed. Maybe this is 

[4] Tests fail for me after the patches are applied (they passed before they
were applied):

prove t/Koha/SearchEngine/Elasticsearch/Search.t
t/Koha/SearchEngine/Elasticsearch/Search.t .. 1/2 
    #   Failed test 'Valid main heading with ShowHeadingUse'
    #   at t/Koha/SearchEngine/Elasticsearch/Search.t line 95.
    #          got: undef
    #     expected: '1'

    #   Failed test 'Valid main heading with ShowHeadingUse'
    #   at t/Koha/SearchEngine/Elasticsearch/Search.t line 98.
    #          got: undef
    #     expected: '1'
    # Looks like you failed 2 tests of 7.
t/Koha/SearchEngine/Elasticsearch/Search.t .. 2/2 
#   Failed test 'search_auth_compat'
#   at t/Koha/SearchEngine/Elasticsearch/Search.t line 99.
# Looks like you failed 1 test of 2.
t/Koha/SearchEngine/Elasticsearch/Search.t .. Dubious, test returned 1 (wstat
256, 0x100)
Failed 1/2 subtests 

Test Summary Report
-------------------
t/Koha/SearchEngine/Elasticsearch/Search.t (Wstat: 256 Tests: 2 Failed: 1)
  Failed test:  2
  Non-zero exit status: 1
Files=1, Tests=2,  1 wallclock secs ( 0.01 usr  0.01 sys +  0.85 cusr  0.12
csys =  0.99 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.