[Koha-bugs] [Bug 36368] Cannot save new patron after error

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36368

--- Comment #9 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
(In reply to Marcel de Rooy from comment #8)
>     $op = 'add_form'  if ( $op eq 'cud-insert' );
>     $op = 'edit_form' if ( $op eq 'cud-save' );
>     %data=%newdata;
>     $template->param( updtype => ($op eq 'add' ?'I':'M'));  # used to check
> for $op eq "cud-insert"... but we just changed $op!
> 
> Looks like we are not done here yet. See above.
> We are looking for 'add' but I see add_form ?
> 
> FQA

So it seems. But I'm wondering do we really need that line? Starting from line
628 we have two if statements. First is used to check if $op equals "add_form"
and if that's true updtype is "I". And in line 636 we check if $op equals
"edit_form" and set updtype as "M". So why do we set updtype param already in
that $template->param( updtype => ($op eq 'add' ?'I':'M'));?

-- 
You are receiving this mail because:
You are watching all bug changes.