[Koha-bugs] [Bug 36135] Add tool to batch modify holds

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #19 from Lucas Gass <lucas at bywatersolutions.com> ---
This looks good but there are some small fixes to be made: 

1.  WARN        installer/data/mysql/atomicupdate/bug_36135.pl
   WARN   tidiness
                The file is less tidy than before (bad/messy lines before: 0,
now: 4)

Perltidy your atomicupdate

2.      forbidden pattern: simple-quote string (line 312)

Line 312: tools/batch_modify_holds.tt, needs double quotes, not single. 

3.    FAIL        tt_valid
                lines 134

This probably needs to be something like: 

[% IF hold.found %]
    <tr class="highlighted-row">
[% ELSE %]
    <tr>
[% END %]

4. Line 123: <th>Title</title>
5. Line 111: Missing a closing </div>


6. Overall there needs to be some improvement to the HTML:

<label for="suspend_until">Expiration date:</label>
<label for="suspend_until">Suspended until:</label> 

These should probably be <legend> not <label>. 

<li> elements inside of <li>? Not a blocker but should these be separate
fieldsets? 


7. These both use the ID "to" and they should use #expirationdate_to and
#suspend_until_to, respectively.


 56                                         <li>
 57                                             <label
for="expirationdate_to">To</label>
 58                                             <input type="text" size="10"
id="to" name="expirationdate_to" class="flatpickr"/>
 59                                         </li>


 91                                             <label
for="suspend_until_to">To</label>
 92                                             <input type="text" size="10"
id="to" name="suspend_until_to" class="flatpickr"/>

-- 
You are receiving this mail because:
You are watching all bug changes.