[Koha-bugs] [Bug 36431] SIP2: Checkin does not show difference between WasTransfered and NeedsTransfer

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36431

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Kyle M Hall from comment #2)
> In both of those code paths, there is indeed a real transfer. In the case of
> WasTransfered, it means a transfer was initiated, but the item has been
> checked in at the library the transfer originated from, so the destination
> and location in this case are not the same. Am I mistaken?

We are not talking about the same situation. You describe a valid case where a
transfer exists. But I am looking at the situation where the item is in another
branch and has been checked out and checked in again. In that case
WasTransfered can be set also (depending on AutomaticItemReturn):

Circulation L2519-
        if  (C4::Context->preference("AutomaticItemReturn"    ) or
            (C4::Context->preference("UseBranchTransferLimits") and
             ! IsBranchTransferAllowed($branch, $returnbranch,
$item->$BranchTransferLimitsType )
           )) {
            ModItemTransfer($item->itemnumber, $branch, $returnbranch,
$transfer_trigger, { skip_record_index => 1 });
            $messages->{'WasTransfered'} = $returnbranch;
            $messages->{'TransferTrigger'} = $transfer_trigger;
        } else {
            $messages->{'NeedsTransfer'} = $returnbranch;
            $messages->{'TransferTrigger'} = $transfer_trigger;
        }

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.