[Koha-bugs] [Bug 9762] Log circulation overrides

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #12 from Lucas Gass <lucas at bywatersolutions.com> ---
Lots of issues here. 

1. renew.pl now fails with this error:

Could not compile /kohadevbox/koha/circ/renew.pl: Global symbol "$borrower"
requires explicit package name (did you forget to declare "my $borrower"?) at
/kohadevbox/koha/circ/renew.pl line 67.

2. Looks like some debugging code is leftover 

3. request.pl has a whole block of code commented out starting with: 

# elsif ( C4::Context->preference('AllowHoldPolicyOverride') ){

4. Why remove the check for "unless( $skip_record_index )" in AddRenewal? I
think there are times when we want to skip indexing. 

5.  FAIL        C4/Circulation.pm
   FAIL   pod coverage
                POD is missing for CanBookBeReturned

6.  FAIL        circ/renew.pl
   WARN   tidiness
                The file is less tidy than before (bad/messy lines before: 28,
now: 44)
   FAIL   valid
                Global symbol "$borrower" requires explicit package name (did
you forget to declare "my $borrower"?)
                Global symbol "$issue" requires explicit package name (did you
forget to declare "my $issue"?)
                Global symbol "$borrower" requires explicit package name (did
you forget to declare "my $borrower"?)
                Global symbol "$borrower" requires explicit package name (did
you forget to declare "my $borrower"?)
                Global symbol "$borrower" requires explicit package name (did
you forget to declare "my $borrower"?)
                Global symbol "$borrower" requires explicit package name (did
you forget to declare "my $borrower"?)
                circ/renew.pl had compilation errors.


7. Changes to CanBookBeIssued and AddRenewal probably need test coverage.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.