[Koha-bugs] [Bug 36449] New: Patron->store falls back to stored password when modifying patron

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36449

            Bug ID: 36449
           Summary: Patron->store falls back to stored password when
                    modifying patron
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

At some point we added this in patron->store (ModMember-labeled part):

# Password must be updated using $self->set_password
                $self->password($self_from_storage->password);

I stumbled over that requirement in a custom script updating specific patron
accounts.
But we do allow to set the password in the AddMember part. Which feels
inconsistent at the least..

But why do we silently(!) ignore a new password here? A warn might have been
handy too ;)
Couldnt we just add a call to set_password in store and perhaps add a param to
not explicitly save it (when coming from store) or something like that?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.