[Koha-bugs] [Bug 36449] Patron->store falls back to stored password when modifying patron

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36449

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #1)
> Coming from bug 21087. I don't have time right now to deep dive into this
> but maybe the answer is there?

Ah thanks. Yes thats the one:

From: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed, 25 Jul 2018 10:38:48 -0300
Subject: [PATCH] Bug 21087: Do not store the password in ->store for existing
 patrons

When ->store is called on an existing patron we must not save the
password, but keep the one in DB instead.
There is a dedicated method (update_password) to call when the password
need to be updated

Signed-off-by: John Doe <you at example.com>


Why did John Doe sign that one off? LOL

It would be nice to know the reasons why we should not do it. We can always
call the dedicated method from store (to perform needed checks etc)..
There was no discussion about this in that report btw.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.