[Koha-bugs] [Bug 36159] Patron imports record a change for non-text columns that are not in the import file

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36159

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #162689|0                           |1
        is obsolete|                            |

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 164038
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164038&action=edit
Bug 36159: Patron imports record a change for non-text columns that are not in
the import file

When importing patrons we assume a default of '' for borrower columns not
supplied in the file.

When saving we compare the new object we built to the one form the database -
for columns are that are not text type we get undef from the db and '' in the
object we make. This means we see a difference and log into the BorrowersLog:

   "date_renewed" : {
      "after" : "",
      "before" : null
   },
   "dateofbirth" : {
      "after" : "",
      "before" : null
   },
   "debarred" : {
      "after" : "",
      "before" : null
   },
   "flags" : {
      "after" : "",
      "before" : null
   },
   "gonenoaddress" : {
      "after" : "",
      "before" : null
   },
   "lost" : {
      "after" : "",
      "before" : null
   },
   "password_expiration_date" : {
      "after" : "",
      "before" : null
   },
   "sms_provider_id" : {
      "after" : "",
      "before" : null
   }
}

This can mean a lot of useless logging in sites that do automated imports

Test Plan:
1) Enable 'BorrowersLog' system preference
2) Import the borrowers file attach do this bug report file, matchig on
cardnuber, and overwriting
   Contents of the borrowers file are :
surname,firstname,branchcode,categorycode,cardnumber,dateenrolled,patron_attributes,lastseen
Acosta,Ednb,CPL,PT,23529001000463,02/01/2013,,
3) Check the logs, note the modification of columns that have no date
4) Import the file again with the same settings
5) Note the new action log
6) Apply this patch
7) Restart all the things!
8) Import the file again with the same settings
9) Note no new action log was created!

Signed-off-by: Brendan Lawlor <blawlor at clamsnet.org>

-- 
You are receiving this mail because:
You are watching all bug changes.