[koha-commits] main Koha release repository branch master updated. v3.12.00-beta1-915-ga36b3ad

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  a36b3ad43a6a91f800d0d8a148a217d738236d7e (commit)
       via  07716ca15bdc8164dcbc6d70fa1e3f5b8bffcff3 (commit)
      from  5868490f026d0632416fdb78a6c0e7047f1e0df5 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a36b3ad43a6a91f800d0d8a148a217d738236d7e
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Tue Aug 13 16:15:30 2013 +0000

    Bug 7785: (follow-up) standardize POD
    
    This makes the POD for the columns() function consistent
    with the rest of C4/Members.pm.  It also removes a note
    that can be relegated to the bug report and the Git
    history.
    
    Also, since C4::Members::columns() is not actually a
    class method, this patch changes the invocation to
    not call it that way.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

commit 07716ca15bdc8164dcbc6d70fa1e3f5b8bffcff3
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Sat Jun 29 20:46:51 2013 -0400

    Bug 7785: remove MySQL-specific syntax from C4::Members::columns()
    
    The initial thought was to remove this function. However,
    tools/import_borrowers.pl uses it. So rather than remove
    it to solve the problem, it was reworked to a more generic
    solution which runs faster.
    
    By accessing $sth->{NAME} directly, the driver becomes
    responsible for filling it correctly. This happens when a SELECT
    is done on the borrowers table. It does not even have to have
    data in the result set!
    
    The columns method could be more generic and used elsewhere too.
    Comparison between the old method and the STH method showed a
    significant time difference. The old method took 35 seconds
    for 40k iterations versus 19 seconds for the same amount of
    iterations with the STH method regardless of the size of the
    borrowers table.
    
    Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Members.pm                    |   36 ++++++++++++++++++++++++++++++++++--
 t/db_dependent/Members_columns.t |   24 ++++++++++++++++++++++++
 tools/import_borrowers.pl        |    2 +-
 3 files changed, 59 insertions(+), 3 deletions(-)
 create mode 100644 t/db_dependent/Members_columns.t


hooks/post-receive
-- 
main Koha release repository