[koha-commits] main Koha release repository branch master updated. v3.12.00-beta1-1011-g6751c5d
Git repo owner
gitmaster at git.koha-community.org
Wed Aug 28 17:06:13 CEST 2013
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 6751c5dc7c963defd0a31adfd46d0665abf41cd6 (commit)
via 3c61f95fb41152994ca2807eee87dc8e13ba219d (commit)
from a58c5334c96105315ee3bf1cbb62d8c1aab82f0c (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 6751c5dc7c963defd0a31adfd46d0665abf41cd6
Author: Galen Charlton <gmc at esilibrary.com>
Date: Wed Aug 28 15:16:28 2013 +0000
Bug 10693: (follow-up) fix parameter checking in CreateBranchTransferLimit()
There is nothing prevent '0' from being used as a library code.
To test:
Run prove -v t/db_dependent/Circulation_transfers.t and verify that
the tests pass.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
commit 3c61f95fb41152994ca2807eee87dc8e13ba219d
Author: Kenza Zaki <kenza.zaki at biblibre.com>
Date: Wed Aug 7 16:35:35 2013 +0200
Bug 10693: CreateBranchTransferLimit's return value in C4::Circulation.pm should be more explicit
This patch test if the parameters $toBranch and $fromBranch are given.
If not, CreateBranchTransferLimit now returns undef.
This patch also fixes and adds some regression tests in
t/db_dependent/Circulation_transfers.t
NOTE:
Currently, we can add a transferlimit to nonexistent branches because
in the database branch_transfer_limits.toBranch
and branch_transfer_limits.fromBranch aren't foreign keys.
To test:
prove t/db_dependent/Circulation_transfers.t
t/db_dependent/Circulation_transfers.t .. ok
All tests successful.
Files=1, Tests=15, 18 wallclock secs ( 0.02 usr 0.01 sys + 0.42 cusr 0.00 csys = 0.45 CPU)
Result: PASS
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
All tests and QA script pass.
-----------------------------------------------------------------------
Summary of changes:
C4/Circulation.pm | 4 ++--
t/db_dependent/Circulation_transfers.t | 13 ++++++++++---
2 files changed, 12 insertions(+), 5 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list