[koha-commits] main Koha release repository branch new/bug_7228 created. v3.12.00-beta1-429-g3269d35

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, new/bug_7228 has been created
        at  3269d358e55ca2d702be9f544749eca59f057206 (commit)

- Log -----------------------------------------------------------------
commit 3269d358e55ca2d702be9f544749eca59f057206
Author: Christophe Croullebois <christophe.croullebois at biblibre.com>
Date:   Thu Apr 18 12:55:18 2013 +0200

    Bug 7228: can't add items in an order with Modify
    
    We have a message if we want to add items and we can't add, substract only.
    It's ok if we choose to create items on ordering, in this case koha can't add items, just substract
    and in this case we have to delete manually the items(s) in the catalog.
    But if via the syspref AcqCreateItem we choose to create items when receiving this limitation is not usefull
    The patch just checks if the syspref AcqCreateItem is on 'ordering'
    if not the message is not shown and we can add items
    
    Signed-off-by: Mathieu Saby <mathieu.saby at univ-rennes2.fr>
    Here is the test I made for signing off :
    after applying the patch
    - syspref AcqCreateItem  : create items on RECEIVING
    - in a basket, create an order (quantity = 1)
    - save the order
    - reopen the order
    - change the quantity (2 instead of 1)
    - save the order
    => changing quantity was not possible before the patch
    
    - syspref AcqCreateItem  : create items on CATALOGING
    - in a basket, create an order (quantity = 1)
    - save the order
    - reopen the order
    - change the quantity (2 instead of 1)
    - save the order
    => changing quantity was not possible before the patch
    
    - syspref AcqCreateItem  : create items on ORDERING
    - in a basket, create an order (click on "add" to add an item => quantity = 1)
    - save the order
    - reopen the order
    - try to change the quantity (2 instead of 1), without clicking on "add" to create a new item => you cannot (alert message)
    => the behavior is the same as before the patch
    
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Copied test plan from bug report.
    Template only change deactivating the Javascript that blocks
    you from changing the quantity when AcqCreateItem is set to
    something else than 'ordering'.
    Passes all tests and QA script.
    Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>

commit 4563f7bc34a6921ee6abaa5889963bb1ce4749d8
Merge: b7d0c50 598dfe2
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date:   Wed May 1 08:17:06 2013 -0400

    Merge branch 'bug_10033' into 3.14-master

-----------------------------------------------------------------------


hooks/post-receive
-- 
main Koha release repository