[koha-commits] main Koha release repository branch master updated. v3.12.00-beta1-1230-ge276bea
Git repo owner
gitmaster at git.koha-community.org
Tue Oct 8 16:16:13 CEST 2013
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via e276bea3eee02aeaf2c49edc19a095735c5e5359 (commit)
from b9c85431ddf967ecadf88ee9d2cbe14ac95d5be4 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit e276bea3eee02aeaf2c49edc19a095735c5e5359
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu Sep 19 12:18:11 2013 -0400
Bug 10917: allow staff to update hold pickup location without modify_holds_priority
A librarian cannot modify a hold's pickup location unless he or she has
the permission modify_holds_priority. This appears to be a bug and not
by design. The reason the update fails is due to the priority not being
passed to ModReserve. The priority is not displayed when a librarian
does not have the modify_holds_priority permission.
Test Plan:
1) Remove the modify_holds_priority from your logged in user
* User cannot be a superlibrarian
2) Attempt to change the pickup location for a hold
3) Note the change fails
4) Apply this patch
5) Repeat step 2
6) Note the change succeeds
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Template change only.
Passes all tests and QA script.
Tested:
- Confirmed that changing the pickup location is not
possible in master without the modify_holds_priority
permission
- Confirmed that the patch fixes the problem - pickup
location can now be changed with and without the
permission
- Pickup location can still not be changed, when
IndependentBranches is activated
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
-----------------------------------------------------------------------
Summary of changes:
.../prog/en/modules/reserve/request.tt | 31 +++++++++++++-------
1 file changed, 20 insertions(+), 11 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list