[koha-commits] main Koha release repository branch 3.18.x updated. v3.18.05.1-74-gafc3aa4

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.18.x has been updated
       via  afc3aa4007d7051028dba95d5462b886ba91644c (commit)
      from  05a7b7e457f3b1b380e23987481ca122c3fe964f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit afc3aa4007d7051028dba95d5462b886ba91644c
Author: Jacek Ablewicz <abl at biblos.pk.edu.pl>
Date:   Mon Mar 23 15:21:53 2015 +0100

    Bug 10906 - Reimported records into Koha are imported only as DEFAULT frameworks, not what they were originally
    
    Existing framework code is currently not retained when local record
    gets replaced during batch import, or when the restore/reverse function
    is being used.
    
    This patch fixes aforementioned issues by correcting outdated GetBiblio()
    calls in C4/ImportBatch.pm
    
    To test:
    
    1/ try to replicate the issue: import some MARC records with
    "Tools -> Stage MARC records for import" etc., using test setup,
    matching rules and so on such that some existing records will get
    replaced with imported ones
    2/ observe that records replaced during import now open in the editor
    with 'Default' framework, even if they have some other framework
    set up previously
    3/ apply patch
    4/ redo 1/, confirming that this problem is no longer replicable
    5/ try use 'restore' function with some freshly imported
    records, ensure that original framework code got retained
    in the records which had their imports reverted
    
    NOTE: I confirmed this change by
    1) git grep "=\s*GetBiblio\s*("
       -- this shows how GetBiblio is called elsewhere.
          It differed! So then...
    2) vi C4/Biblio.pm
       /sub GetBiblio
       -- find the right one, notice it only returns a HASH ref,
          not an array.
    
    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    (cherry picked from commit 7c2fad1bafc38d7ed70e9508293136d89d77879c)
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-----------------------------------------------------------------------

Summary of changes:
 C4/ImportBatch.pm |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository