[koha-commits] main Koha release repository branch master updated. v3.20.00-112-g717fa84

Sun Jun 7 23:57:19 CEST 2015

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  717fa8440dad2f67043641db31a5b5ad2b361bb1 (commit)
       via  af6bb0b4db384903d73af6de4e219ba530959ee3 (commit)
       via  7f4a7f2eb393d0578837a3a91f4b62b741baa3dc (commit)
       via  5132d5f991515b86a9282b214a9418b65b4c0881 (commit)
       via  7e440d700904fde37b54138da0e7a9c38ff2637a (commit)
       via  5f5903737eeb614d66b34e270120698c00de5a59 (commit)
       via  c671784321b1ebcf9aca18c061ec30bed3e89a58 (commit)
       via  3ef7bfc6cf5b43784a9edc212a4bfc07b1d34b35 (commit)
       via  46419b797bfb53bfbff6f8f83c5e016859ac48fa (commit)
      from  5a02cf9b48685d3b71397f86a862b2d7535a68b6 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 717fa8440dad2f67043641db31a5b5ad2b361bb1
Author: Galen Charlton <gmcharlt at gmail.com>
Date:   Thu Jun 4 16:11:44 2015 -0400

    Bug 14334: t/db_dependent/Letters.t AutoCommit fix

    TEST PLAN
    ----------
    1) git reset --hard origin/master
    2) prove t/db_dependent/Letters.t
       -- horrible failure about transaction
    3) apply this patch
    4) prove t/db_dependent/Letters.t
       -- no issues
    5) koha qa test tools.

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

commit af6bb0b4db384903d73af6de4e219ba530959ee3
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Thu Jun 4 16:08:22 2015 -0400

    Bug 14334: t/db_dependent/Budgets.t AutoCommit fix

    TEST PLAN
    ----------
    1) git reset --hard origin/master
    2) prove t/db_dependent/Budgets.t
       -- horrible failure about transaction
    3) apply this patch
    4) prove t/db_dependent/Budgets.t
       -- no issues
    5) koha qa test tools.

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

commit 7f4a7f2eb393d0578837a3a91f4b62b741baa3dc
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Thu Jun 4 16:01:20 2015 -0400

    Bug 14334: t/db_dependent/Bookseller.t AutoCommit fix

    TEST PLAN
    ----------
    1) git reset --hard origin/master
    2) prove t/db_dependent/Bookseller.t
       -- horrible failure about transaction
    3) apply this patch
    4) prove t/db_dependent/Bookseller.t
       -- no issues
    5) koha qa test tools.

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

commit 5132d5f991515b86a9282b214a9418b65b4c0881
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Thu Jun 4 09:15:24 2015 +0200

    Bug 14327: Fix js error "TypeError: events is null" in additem.js

    If you have no item plugins, the events variable in BindPluginEvents
    of additem.js will be null. So testing events.length will generate
    the described error.
    This patch adds a check to prevent that from happening again.

    Test plan:
    [1] Do not yet apply this patch !
    [2] Temporarily remove framework plugins from your items (in ACQ or default
        framework). Probably you have to clear dateaccessioned.pl and
        barcode.pl.
    [3] Open js console in your browser.
    [4] Go to Acquisition. Open a basket and add an order from a new empty
        record.
    [5] You should see js error: "TypeError: events is null" (additem.js:176)
    [6] Apply this patch and reload the page (make sure that you refresh so
        that the new javascript code is read).
    [7] The TypeError should be gone.
    [8] Restore the framework plugins from step 2. Refresh the page again and
        verify that they still work as expected.

    Signed-off-by: Jonathan Druart <jonathan.druart at koha-community.org>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

commit 7e440d700904fde37b54138da0e7a9c38ff2637a
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Jun 4 07:13:01 2015 -0400

    Bug 14318: iDreamBooks doesn't work when Koha is using https

    If a Koha server is configured to run over SSL, all iDreamBooks content
    is blocked due to the fact that a secure page is requesting an insecure
    endpoint. This is due to the fact that the urls for iDreamBooks use http
    and not https. A simple fix would be to switch them to https since
    browsers have to qualms about loading a secure data endpoint from an
    insecure one.

    Test Plan:
    1) Enable iDreamBooks
    2) Set up your OPAC to use https
    3) Verify iDreamBooks content continues to work

    Note: tested Chrome and IE, so that the IE change would be validated.
          Discovered isbn semi-colon issue that is beyond scope of this bug.

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

commit 5f5903737eeb614d66b34e270120698c00de5a59
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Fri Jun 5 09:58:50 2015 -0400

    Bug 14342: Unit tests in t/db_dependent/Context.t failing due to Bug 13967

    The introduction of system preference objects in bug 13967 has caused
    the current testing regimen to fail do to the mixing of DBI mocking and
    DBIx::Class.

    Test Plan:
    1) Apply this patch
    2) prove t/db_dependent/Context.t

    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

commit c671784321b1ebcf9aca18c061ec30bed3e89a58
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Fri Jun 5 10:56:56 2015 -0300

    Bug 14339: C4::Context->preference should return undef if DB is not populated

    The current behaviour for C4::Context->preference when the DB is not still
    populated with tables is to return undef. This is used by C4::Auth to identify
    the need of running the installer.

    This behaviour got broken by bug 13967, which lets DB errors to escalate and
    thus Koha gets broken instead of prompting for install.

    This patch wraps Koha::Config::Sysprefs->find inside an eval and sets undef if needed.

    To test:
    - In current master, drop the DB
    - Load OPAC and Intranet
    => FAIL: notice an ugly software error.
    - Apply the patch
    - Load the OPAC
    => SUCCESS: Maintenance mode screen is shown
    - Load Intranet
    => SUCCESS: You are prompted the DB credentials to run the web installer.
    - Sign off :-D

    Tomas

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

commit 3ef7bfc6cf5b43784a9edc212a4bfc07b1d34b35
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Fri Jun 5 16:08:23 2015 -0300

    Bug 14346: (folowup) Fix previously existing POD

    This patch makes koha-qa.pl happy by fixing POD issues prior
    to this bug.

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

commit 46419b797bfb53bfbff6f8f83c5e016859ac48fa
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Fri Jun 5 14:52:36 2015 -0300

    Bug 14346: t/Biblio.t fails because of new warning

    Running

     $ prove t/Biblio.t

    fails because of us now using DBIx to retrieve sysprefs. Then our mocked DBI is not "supported" by DBIx hence a warning that makes our test fail (there is one more warning now).

    The cool thing about this, is that it actually helped spot a situation where GetMarcBiblio is doing wrong things because is not checking its parameters are undefined, so we have the chance to fix it.

    This patch makes GetMarcBiblio return undef if no biblionumber is passed, and
    also raises a conveniently carped warning. This change is tested in t/Biblio.t with new tests.

    To test:
    - In current master, run
      $ prove t/Biblio.t
    => FAIL: a test detects a wrong warning count and fails.
    - Apply the patch and run
      $ prove t/Biblio.t
    => SUCCESS: Tests now pass, and there are 2 new ones.
    - Sign off :-D

    Regards

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-----------------------------------------------------------------------

Summary of changes:
 C4/Biblio.pm                                       |   21 +++---
 C4/Context.pm                                      |    3 +-
 koha-tmpl/intranet-tmpl/prog/en/js/additem.js      |    4 +-
 .../admin/preferences/enhanced_content.pref        |    6 +-
 .../opac-tmpl/bootstrap/en/modules/opac-detail.tt  |    6 +-
 .../opac-tmpl/bootstrap/en/modules/opac-results.tt |    4 +-
 t/Biblio.t                                         |   15 +++--
 t/db_dependent/Bookseller.t                        |    8 ++-
 t/db_dependent/Budgets.t                           |    7 +-
 t/db_dependent/Context.t                           |   70 +++++++++++---------
 t/db_dependent/Letters.t                           |    8 ++-
 11 files changed, 88 insertions(+), 64 deletions(-)

hooks/post-receive
-- 
main Koha release repository