[koha-commits] main Koha release repository branch master updated. v16.11.00-1014-g61ca4de

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  61ca4deee3f94bb30183a7f68a6ccc8e349ee0b9 (commit)
       via  542ac21b94a8eec05b3f194f5ffbe4e19f511738 (commit)
       via  3e1d76dbc0e98bb8a0d66c99a9c9b1afa936e62e (commit)
      from  7a4f3c17a8fe518534658009d075dcdc1d537b62 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 61ca4deee3f94bb30183a7f68a6ccc8e349ee0b9
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Fri May 12 09:25:23 2017 +0200

    Bug 18579: Fix call to append_fields, fix tests
    
    MARC::Record::append_fields takes a list of MARC::Field (not an arrayref)
    
    Use $record->subfield() instead of $record->field()->subfield() to avoid errors
    when field doesn't exist
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 542ac21b94a8eec05b3f194f5ffbe4e19f511738
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Thu May 11 13:07:37 2017 -0300

    Bug 18579: Make EmbedItemsAvailability handle control fields correctly
    
    This patch makes the EmbedItemsAvailability filter handle the biblio.biblionumber > control field mapping gracefully.
    Right now, it was assuming a regular data field was used, and such is not the case for UNIMARC (001).
    
    To test:
    - Apply the tests patch
    - Run:
      $ sudo koha-shell kohadev
     k$ cd kohaclone
     k$ prove t/db_dependent/Koha/Filter/EmbedItemsAvailability.t
    => FAIL: Tests fail to run
    - Apply this patch
    - Run:
     k$ prove t/db_dependent/Koha/Filter/EmbedItemsAvailability.t
    => SUCCESS: Tests pass!
    - Sign off :-D
    
    Sponsored-by: ByWater Solutions
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 3e1d76dbc0e98bb8a0d66c99a9c9b1afa936e62e
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Thu May 11 13:04:18 2017 -0300

    Bug 18579: Regression tests
    
    This patch makes sure the tests have the biblio.biblionumber mapping mocked
    so we test the case where the mapping is to a control field instead of just
    regular data fields (in the case of UNIMARC).
    
    To test:
    - Apply the patch
    - Run:
      $ prove t/db_dependent/Koha/Filter/EmbedItemsAvailability.t
    => FAIL: Tests fail due to an attemp to access a subfield on a control field.
    
    Sponsored-by: ByWater Solutions
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/Filter/MARC/EmbedItemsAvailability.pm         |    6 +++--
 .../Koha/Filter/EmbedItemsAvailability.t           |   24 ++++++++++++++++++--
 2 files changed, 26 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
main Koha release repository