[koha-commits] main Koha release repository branch master updated. v17.05.00-527-g185927f
Git repo owner
gitmaster at git.koha-community.org
Fri Sep 1 18:06:35 CEST 2017
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 185927f20981f36757c97fd33cc4c8ccd0ad5a3a (commit)
via b66b86402cd84026f7dabaa2e567a1956b9bbe86 (commit)
via 8901f5702a7c6755c1f84cde01d75765687bb060 (commit)
via d928038a523b7ef44257ddfe97c405173c9b3b2e (commit)
via 0e744d49b557e3401ae7b700b1410b022a4e851c (commit)
via 0fc3f19605d3979333dc333237205b9bef6ab60b (commit)
via 57427f7a10c887964fa4d4397c6ec238af2bc694 (commit)
via 327495b5e0ec4de47d20bd27d6a1c5b88e0be191 (commit)
via 4934ee4a1601bd268a7153b7189387bb073dd11f (commit)
via f1b0dae9a6055e8ba5e9a9638af32060c1e17e33 (commit)
via 48f54016a7accfc0cc43bf01cbac70a8482bc3f9 (commit)
via bb31d99065c468fbec2443cd15894b03657a24d5 (commit)
via 8fd0847c82adbcaf0af3285dd9cfc5e646ba6500 (commit)
via a932d05ace6500a3b67888aad1306e58cfa8014f (commit)
via 65bce82b1fb32d3d98fe4d4ef1e1738a97749632 (commit)
via 6c1504cfdb301cb0f9f3a14b5db31a63f5c3b0a5 (commit)
via 2e9165001f69312255ad1b6706f040784460d5d1 (commit)
via 16c25a36988b47fb9fcbabd91fdace5f98f9caed (commit)
via 7db6067dc4cc55bee771fedb31e2454b72123ac0 (commit)
via 786deba62beb5a52a543af5415610e14f7d0a8c5 (commit)
via d0e3891e251a6a11188d70a5480af0e44b8c1fb0 (commit)
via 515e62992893b72c54a34311088a9442a37d8138 (commit)
via a887aeb2dff4e52f35f1f64bfc267867987cbb53 (commit)
via 82f183c5ea802e3231cb2442cf32474c92bd6ab4 (commit)
via ee49d5698a11ee5806aff8c8581fa22002435cff (commit)
via 947834f1821449faf9148f06c84f5638b0941435 (commit)
via 391bf4f38dcaa89745115409d01cca9cd1e99dce (commit)
via f24e339dd603e015557107048d1a678293cb2e65 (commit)
via f10f6a19c53beb37e3ee0808ef6bb18bd88bef8a (commit)
via ae7e0ee56a17ae2a0c6fdaa96c6b04229aabca74 (commit)
via 9d207f3832bc49232f30e8d7dbf2ac60e3ab9699 (commit)
via 8c90bb78c9fe411c5ea549f8100939e29b7a4bc1 (commit)
via 7abe6e9670ecb9b879e3b8c237fd9fad35f5ff18 (commit)
via ff4f0858950c37eeede38b2f067841602b97d7ba (commit)
via 7f27ef71e26720604b738c86c084b91858ef7c1a (commit)
via 9cc7268362219e39b22aebb03a83e013f467d93a (commit)
via 10311769d460a775aa8c8ee8a190836a8f2b1f1e (commit)
via 8d08254b2202353517c16f34172cb92dcdd5befa (commit)
via 85b963d11fb5d8674ca6b0ec60821663f9d8cf19 (commit)
via 831d75d09c276f25f919cbdc16c8e4105fe8ddc9 (commit)
via ccac8ba6d3799c52adc80298b96a8efaf05c4a9e (commit)
via 239589b119c88a321fb8245f859855c41dda6566 (commit)
via d5ea914f4dc41f78dbb3a59f894f6ecbb9a1afa4 (commit)
via 51a65731c0fa15c37351ce6bc478fa6dc63fc64f (commit)
from d51059807690797aa4d16b0c0dd2932235a3b683 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 185927f20981f36757c97fd33cc4c8ccd0ad5a3a
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Aug 11 15:39:53 2017 +0000
Bug 19076 - followup - delete fines from additional renewal
Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit b66b86402cd84026f7dabaa2e567a1956b9bbe86
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Aug 10 15:20:58 2017 +0000
Bug 19076 - Move issue logging in AddIssue into condtional clause
Currently AddIssue tests if renewal, but logs an issue even if so. This
patch moves the logging into the conditional so a log entry is only
added if we aren't renewing (as renewals are logged separately)
To test:
1 - prove t/db_dependent/Circulation.t - one test should fail
2 - Enable both issue and renewal logs
3 - Checkout an item to a patron
4 - View the logs - the issue is captured
5 - Checkout the item to the patron again and confirm renewal
6 - Both an issue and a renewal are logged
7 - Apply patch
8 Repeat 1-6, tests should pass and only renewal should be logged
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 8901f5702a7c6755c1f84cde01d75765687bb060
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Aug 10 15:20:19 2017 +0000
Bug 19076 - unit tests
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d928038a523b7ef44257ddfe97c405173c9b3b2e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Aug 28 14:00:28 2017 -0300
Bug 19081: Do not list plugins that have been uninstalled
Under plack, can_load should not check if a package is in cache, but
reload it. Otherwise plugins that have been uninstalled will still get
listed.
The error raised by can_load must only be displayed if the plugin has
been removed.
Test plan:
1/ Upload a plugin
2/ Note the plugin is listed as installed
3/ Modify the package of the plugin to add a compilation error (use
'Foo' for instance)
4/ Reload the page
5/ The plugin is not listed and a warning appear in the logs
6/ Remove the compilation error and uninstall the plugin
7/ The plugin is no longer listed and no warning appear in the logs
Signed-off-by: Lee Jamison <ldjamison at marywood.edu>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Bug 19081: Remove useless $plugin_file variable
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 0e744d49b557e3401ae7b700b1410b022a4e851c
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Mon Aug 28 08:51:24 2017 +0200
Bug 19004: [QA Follow-up] No need to check item-level_itypes again
As Jonathan pointed out, GetItem already called effective_itemtype.
So we can just use $item->{itype} here.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 0fc3f19605d3979333dc333237205b9bef6ab60b
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Wed Aug 9 16:30:03 2017 +0200
Bug 19004: Adjust AddReturn for retrieving item type
In the regular situation, you can get itemtype via biblio and then
biblioitem as well as via biblioitem (at least when item-level_itypes
is set to biblio).
But since Koha unfortunately defined two relations in item, one for
biblioitemnumber (the good one) and one for biblionumber (redundant),
TestBuilder (correctly) builds one biblioitem and two biblios.
If you item-level_itypes to biblio record, this will result in failing tests
when calling AddReturn (in this case Koha/Patrons.t).
It will crash on:
Can't call method "itemtype" on an undefined value at C4/Circulation.pm line 1826.
Cause: AddReturn goes via the biblionumber to biblio and than to
biblioitems, and it does not find a biblioitem. (Not a fault from TestBuilder
but a database design problem.)
This patch makes a small change in AddReturn to retrieve the itemtype via
biblioitem. It actually is a shorter road than items->biblio->biblioitems.
Note: I do not test the Biblioitems->find call, since we already checked
the GetItem call before and we have a foreign key constraint.
I did not call $item->effective_itemtype since we still use GetItem; this
could be done later.
Adjusted Circulation/Returns.t too: If we add an item with TestBuilder and
we called AddBiblio before, we should link biblioitemnumber as well.
Test plan:
[1] Do not apply this patch yet.
[2] Set item-level_itypes to biblio record.
[3] Run t/db_dependent/Koha/Patrons.t. (It should fail.)
[4] Apply this patch.
[5] Run t/db_dependent/Koha/Patrons.t again.
[6] Run t/db_dependent/Circulation/Returns.t
[7] Git grep on AddReturn and run a few other tests calling it.
Note: Bugs 19070/19071 address three tests that call AddReturn too.
[8] In the interface, check in a book.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Note: Bugs 19070 and 19071 are already pushed. The command in comment #4
has all the tests successful.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 57427f7a10c887964fa4d4397c6ec238af2bc694
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Sun Jul 30 16:53:00 2017 +0200
Bug 19004: Patrons.t should create its own data for enrollment fees.
If the patron categories J, K, YA would not exist, Patrons.t would fail.
Test plan:
[1] Remove one of these patron categories.
[2] Run t/db_dependent/Koha/Patrons.t
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 327495b5e0ec4de47d20bd27d6a1c5b88e0be191
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sat Aug 19 10:22:44 2017 +0200
Bug 14316: Clarify meaning of record number in Batch record modification tool
Same change as the first patch, but for the batch record
modification tool.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 4934ee4a1601bd268a7153b7189387bb073dd11f
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Mon Jun 8 02:03:34 2015 +0200
Bug 14316: Clarify meaning of record number in Batch record deletion tool
Changes the label from 'list of record numbers...' to
'List of biblionumbers or authority ids...' to make it
more clear to the user which kind of input is expected.
To test:
- Go to Tools > Batch record deletion
- Check the new description
- Decide if it's more clear or not
Signed-off-by: Marc Veron <veron at veron.ch>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f1b0dae9a6055e8ba5e9a9638af32060c1e17e33
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Sep 1 08:41:51 2017 -0400
Bug 18946 [QA Followup] - code cleanup
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 48f54016a7accfc0cc43bf01cbac70a8482bc3f9
Author: Karam Qubsi <karamqubsi at gmail.com>
Date: Wed Jul 19 00:06:48 2017 +0800
Bug 18946 - Change language from external web fails
How to reproduce:
1. Get a multilingüal Koha like
http://demo1.orex.es/cgi-bin/koha/opac-changelanguage.pl?language=en
http://demo1.orex.es/cgi-bin/koha/opac-changelanguage.pl?language=es-ES
2. Copy that urls to any web page in an other domain -it must be in some
host - and try to link to the spanish or english version,it will keep you in the same position.
3. Apply this patch and try again , everything should work fine .
Signed-off-by: Hugo Agud <hagud at orex.es>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit bb31d99065c468fbec2443cd15894b03657a24d5
Author: Lari Taskula <lari.taskula at jns.fi>
Date: Wed May 31 17:03:54 2017 +0300
Bug 18692 - intranet part
Fixes misplaced columns introduced by previous patch and adds the "-" for phone
transport type.
To test:
1. Set SMSSendDriver system preference on
2. Go to intranet messaging preferences
3. By default you should see checkboxes for all messages for SMS
4. Ensure columns are not misplaced (pushing one column too much to the right)
5. Delete sms method from one of the messages in message_transports table
6. Observe that "-" is displayed instead of checkbox for that message for SMS
7. Repeat same for TalkingTechItivaPhoneNotification system preference.
By default it may not have transports in message_transports, so make sure
to assign some in order to have the checkboxes visible.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 8fd0847c82adbcaf0af3285dd9cfc5e646ba6500
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Thu Jun 1 17:22:42 2017 +0200
Bug 18692 - same with syspref TalkingTechItivaPhone
Fixes misplaced columns introduced by previous patch and adds the "-" for phone
transport type.
To test:
1. Set SMSSendDriver system preference on
2. Go to intra and OPAC messaging preferences
3. By default you should see checkboxes for all messages for SMS
4. Ensure columns are not misplaced (pushing one column too much to the right)
5. Delete sms method from one of the messages in message_transports table
6. Observe that "-" is displayed instead of checkbox for that message for SMS
7. Repeat same for TalkingTechItivaPhoneNotification system preference.
By default it may not have transports in message_transports, so make sure
to assign some in order to have the checkboxes visible.
https://bugs.koha-community.org/show_bug.cgi?id=8692
Signed-off-by: Michael Andrew Cabus <michael at bywatersolutons.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit a932d05ace6500a3b67888aad1306e58cfa8014f
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Mon May 29 16:32:18 2017 +0200
Bug 18692 - When SMS is enabled the OPAC messaging table is misaligned
Bug 6726 had corrected the fact that when SMS is enabled the messaging table is missing a column.
Bug 6458 has broken this.
The SMS column is missing an else case with cell containing only "-" like other columns.
Test plan :
- set SMSSendDriver preference empty
- go to OPAC patron messaging
- column SMS should not be visible
- set SMSSendDriver preference not empty
- go to OPAC patron messaging
- column SMS appears with checkboxes
Signed-off-by: Michael Andrew Cabus <michael at bywatersolutons.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 65bce82b1fb32d3d98fe4d4ef1e1738a97749632
Author: Marc Véron <veron at veron.ch>
Date: Wed Aug 9 09:46:02 2017 +0200
Bug 18636: Sysprefs: Add explanation for conflict autonumbernum / BorrowerMandatoryFields
This patch adds a note to the system preferences autonembernum and
BorrowerMandatoryFields regarding a conflict if automembernum is on
and BorrowerMandatoryFields contains cardnumber.
To reproduce issue: See initial comment.
To test:
- Apply patch
- Verify that in system preferences note appears with both prefs
automembernum and BorrowerMandatoryFields
Followed test plan, works as described
Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 6c1504cfdb301cb0f9f3a14b5db31a63f5c3b0a5
Author: Marc Véron <veron at veron.ch>
Date: Tue Jun 27 18:50:44 2017 +0200
Bug 16485: collection column in Item search is always empty
This patch fills the column 'Collection' in item search from the item values.
To test:
- Go to item search
- Reproduce issue from initial comment
- Apply patch
- Verify that the column 'Collection' is filled
Still to do, but outside of my datatable skills:
Filter by drop down in the column header does a substring search.
Example: Filter for 'Fiction" returns both 'Fiction' and 'Non-fiction' items.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Laurence Rault <laurence.rault at biblibre.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 2e9165001f69312255ad1b6706f040784460d5d1
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date: Wed Aug 2 17:12:44 2017 +0100
Bug 19024 Do not unset order cancelled status on basket close
On closing a basket, status is updated to ordered for orders not
completed. However the operation was resetting the status for
cancelled as well as new orders.
While display is correct from the basket view (it checks the
cancellation date). The status in the acquisitions tab from the
catalogue view reverts erroneously to ordered.
This patch adds cancelled to the statuses not updated on basket
close.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 16c25a36988b47fb9fcbabd91fdace5f98f9caed
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date: Tue Aug 15 11:44:12 2017 +0100
Bug 19024 Fix some infelicities of phrasing in test messages
The test messages were awkwardly phrased, re phrase them to
sound more natuaral. Patch is cosmetic (grammar) only
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 7db6067dc4cc55bee771fedb31e2454b72123ac0
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Aug 9 16:09:32 2017 -0300
Bug 19024: Add tests
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 786deba62beb5a52a543af5415610e14f7d0a8c5
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Fri Aug 18 08:36:59 2017 +0000
Bug 9857 - Follow-up - Fix for searches with su= or su:
When the initial search is su=.../su:... the links was
not constructed correctly. With this change, it should
be the case.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d0e3891e251a6a11188d70a5480af0e44b8c1fb0
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Fri Dec 4 01:17:50 2015 +0100
Bug 9857: Did you mean? uses wrong punctuation in search links
The link changes the search links generated by the plugins
from an=authid to an:authid, as suggested by Jared on the
bug report.
- Turn on the AuthorityFile und ExplodedTerms plugins
for the OPAC from the "Did you mean" section of the
administration module
- Search a term in your OPAC where one or several
authorities exist.
A last name or a place name might work well.
- Verify that there are suggestions displayed on top of
your result list.
- Verify that the link created is something like:
/cgi-bin/koha/opac-search.pl?q=an=14084
- Apply patch.
- Verify the link has changed a little and still works
correctly:
/cgi-bin/koha/opac-search.pl?q=an:14084
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 515e62992893b72c54a34311088a9442a37d8138
Author: Alex Buckley <alexbuckley at catalyst.net.nz>
Date: Wed Jul 12 10:09:48 2017 +1200
Bug 18621: Added in value attribute to dateexpiry field
Test plan:
1. Create a patron category with the dateexpiry value of 29/9/2017
2. Create a patron user from that patron category (which I'll refer to as patron A) with the date
expiry value of 1/10/2017 and submit the form
3. Notice that the manual dateexpiry you have submitted is correctly
displayed
4. Create a duplicate patron with the same firstname and surname and
patron A, and set the date expiry value of 1/10/2017 and submit the form
5. The form displays a duplicate patron message. Notice that the dateexpiry input box is empty now
6. Select the new member (not a duplicate member) option in the
messagebox
7. The form successfully submits and notice that the date expiry value
displayed is that of the patron category (i.e. it is 29/9/2017) not the
dateexpiry value of 1/10/2017 that you manually set for this patron
8. Apply patch
9. Repeat step 4
10. The form displays a duplicate patron message. Notice the dateexpiry input box still
contains the value you entered which is 1/10/2017. Select the new member
(not a duplicate member) option in the messagebox
11. The form successfully submits and notice that the date expiry value
displayed is 1/10/2017 that you manually set for this patron
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit a887aeb2dff4e52f35f1f64bfc267867987cbb53
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Fri Aug 18 00:14:52 2017 +0200
Bug 19129 - Follow-up - Add changes to patron duplicate warning
Adds logic from the previous fix to the brief patron summary
shown when checking a possible patron duplicate.
Bonus: Also fixes missing patron category description there.
To Test:
- Add 2 patrons
- Add a patron with the same surname and firstname as an
existing patron in order to trigger the duplicate message
- Click "View existing patron"
- Verify display is correct when existing patron is
- an organisation
- not an organisation
- Verify that the patron category description shows
Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 82f183c5ea802e3231cb2442cf32474c92bd6ab4
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Thu Aug 17 14:51:08 2017 +0000
Bug 19129 - Clean up Details tab for Organisation patrons
Problem: A patron category "I" would cause display problems
on the details in the intranet. This is because the templates
confused patron category "I" with patron type "I" (organisation).
Patch:
- Cleans up variable confusion between categorycode and
categorytype.
- The template contained code to change the labels below
the address to 'Organisational phone:" etc., I have removed
this part as it does not match the edit form anymore.
- Initials, date of birth and gender are still hidden for
organisation - matching the edit form.
Bonus:
- The patron category description was missing on the
right and left side of the details tab. Now it displays.
- Fixes some html issues:
- doubled up class attribute in a tag
- doubled up </li></li>
To test:
- Create 3 patrons
- patron category code doesn't matter, but category type organisation
- patron category code 'I', category type NOT organisation
- patron category code NOT I, category type NOT organisaton
- Check details tab in patron account in staff for all 3
- Verify patron category description shows correctly
- Verify information added to the account displays correctly
(phone numbers, emails, ...)
Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ee49d5698a11ee5806aff8c8581fa22002435cff
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Sep 1 09:56:09 2017 +0000
Bug 11580 - [QA Followup] Remove debug statements
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 947834f1821449faf9148f06c84f5638b0941435
Author: Baptiste Wojtkowski <baptiste.wojtkowski at biblibre.com>
Date: Thu Feb 23 16:21:05 2017 +0000
Bug 11580 : Added unit test
Added one unit test when the syspref useDaysMode is active.
This does not move code anymore
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 391bf4f38dcaa89745115409d01cca9cd1e99dce
Author: Sophie Meynieux <sophie.meynieux at biblibre.com>
Date: Wed Nov 16 16:46:04 2016 +0100
Bug 11580 - If returnBeforeExpiry is ON, use calendar to calculate return date not on closed day (depending on useDaysMode)
Test plan:
1. ReturnBeforeExpiry is activated
2. useDaysMode is different from "circulation rules only"
3. Set expiry date of a patron to a near date
4. Set a closed day on calendar for this date
5. Do a checkout
Without patch, return date will be patron expiration date
With the patch, return date will be last open day before patron expiration day
Signed-off-by: Claire Gravely <claire_gravely at hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f24e339dd603e015557107048d1a678293cb2e65
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Tue Jun 27 04:14:47 2017 +0000
Bug 16726: [FOLLOW-UP] Putting text in h1
Works as outlined in test plan, search terms now appear at top as h1 as well
Signed-off-by: Dilan Johnpullé <dilan at calyx.net.au>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f10f6a19c53beb37e3ee0808ef6bb18bd88bef8a
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Wed Jun 7 02:09:36 2017 +0000
Bug 16726: Clear text in syspref searchbox after submitting
To test:
1) Go to Admin -> search for a system preference
2) Notice your search stays in the search box (this is inconsistent with
search behaviour across Koha)
3) Apply patch and refresh page
4) Make another search
5) Confirm search still works as expected and search terms have been
cleared from search box
6) Confirm search terms show at the top of the results
Sponsored-by: Catalyst IT
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ae7e0ee56a17ae2a0c6fdaa96c6b04229aabca74
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Tue Dec 20 16:58:05 2016 +0100
Bug 17797: Add XSLT_Handler in opac/unapi
Replaces some code by a call to existing module.
Removes the $@->code and $@->message calls.
Test plan
[1] Run /cgi-bin/koha/unapi?id=koha:biblionumber:[number]&format=marcxml
[2] Try some variations.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 9d207f3832bc49232f30e8d7dbf2ac60e3ab9699
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Wed Aug 30 12:06:36 2017 -0400
Bug 19209 [Followup] - Ensure checkouts don't prevent deleting patrons
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 8c90bb78c9fe411c5ea549f8100939e29b7a4bc1
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Aug 30 12:30:05 2017 -0300
Bug 19209: (QA followup) Improve tests
This path merges the pager() test and adds search results count tests
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 7abe6e9670ecb9b879e3b8c237fd9fad35f5ff18
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Aug 30 12:09:37 2017 -0300
Bug 19209: Add ->is_paged method to Koha::Objects
This patch adds ->is_paged to Koha::Objects. It is inherited from the underlying resultset
from DBIC so there's no code besides adding it to the known methods in AUTOLOAD.
Tests are added for the newly exported method.
To test:
- Apply this patch
- Run:
$ sudo koha-shell kohadev
k$ cd kohaclone
k$ prove t/db_dependent/Koha/Objects.t
=> SUCCESS: Tests pass!
- Sign off :-D
Sponsored-by: Camden County
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ff4f0858950c37eeede38b2f067841602b97d7ba
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Jun 15 11:07:03 2017 -0400
Bug 18812 - SIP Patron status does not respect OverduesBlockCirc
To test:
1 - Set 'OverduesBlockCirc' to block
2 - Find or create a patron with overdues
3 - Perform a SIP patron lookup on that patron
misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL
--patron {userid or cardnumber} --password {pass} -m patron_information
4 - Note the first character of response is a ' '
5 - Apply patch
6 - Restart memcached, apache, and plack
7 - Perform SIP patron lookup
8 - Note the first character of response is 'Y'
9 - prove t/db_dependent/SIP/Patron.t
10 - Test should return green
Signed-off-by: Chris Kirby <chris.kirby at ilsleypubliclibrary.org>
Works as advertised
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 7f27ef71e26720604b738c86c084b91858ef7c1a
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Aug 7 17:29:43 2017 -0300
Bug 19056: Replace C4::Reserves::GetReserveCount with Koha::Patron->holds->count
This subroutine is only used once and can easily be replaced with
Koha::Patron->holds->count
Test plan:
- Set maxreserves=5
- Place 3 holds for a given patron
- Place again 3 holds for this patron
3+3 > 5 => The holds must not be placed
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 9cc7268362219e39b22aebb03a83e013f467d93a
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Aug 7 17:25:15 2017 -0300
Bug 19055: Remove C4::Reserves::GetReservesToBranch
This subroutine is no longer in used and can be removed
Test plan:
git grep GetReservesToBranch
must not return any results
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 10311769d460a775aa8c8ee8a190836a8f2b1f1e
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon Jul 31 09:18:15 2017 -0400
Bug 19007 - Allow paypal payments via debit or credit card again
A recent change in Paypal has removed the previous default option of paying via debit or credit card without an account. To bring this option back, we need to send an additional parameter to the PayPal API.
Test Plan:
1) Enable paypal for your Koha instance
2) Ensure you are not logged in to PayPal
3) Attempt to pay a fine via PayPal
4) Not the the "Pay with Debit or Credit Card" option is missing
5) Apply this patch
6) Refresh opac-account.pl
7) Attempt to make a payment via PayPal again
8) Note the option "Pay with Debit or Credit Card" is now available
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: George Williams <gwilliams at nekls.org>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 8d08254b2202353517c16f34172cb92dcdd5befa
Author: Marc Véron <veron at veron.ch>
Date: Sat Feb 18 18:35:39 2017 +0100
Bug 14353 - Show 'damaged' and other status on the 'place holds' page in staff
This patch adds status 'Damaged' to 'Information' 'Status' in the items
table on 'Place hold' page.
To test:
- Apply patch
- In staff client, try to place an item level hold for items with 'Damaged'
status.
- Verify that the status 'Damaged' appears in the column 'Information'.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 85b963d11fb5d8674ca6b0ec60821663f9d8cf19
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Feb 26 14:46:45 2016 +0000
Bug 15924 - Coce not enabled on lists
To test:
Enable Coce and disable other image services
Load a list and not there are no covers
Apply patch
Load a list and note there are covers
https://bugs.koha-community.org/show_bug.cgi?id=15924
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 831d75d09c276f25f919cbdc16c8e4105fe8ddc9
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Wed Aug 30 10:35:03 2017 -0400
Bug 19208 - Pay select option doesn't pay the selected fine
The "Pay selected" option on the Fines tab in the borrower account page doesn't work as intended.
The fine on top of the list gets the amount deducted, even if another fine is choosen from the list.
Test Plan:
1) Create two or three fines, using the Create manual invoice function.
2) Choose one of the fines (not the one on the top) and click Pay selected
3) Pay a partial amount
4) Go back to the Pay fines tab an notice that the fine you selected has not changed. Instead, either the top fine or the total (see attachment) has ben affected.
5) Apply this patch
6) Repeat steps 1-3
7) Note the correct fine is paid
Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace at sub.su.se>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ccac8ba6d3799c52adc80298b96a8efaf05c4a9e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Sep 1 12:58:18 2017 -0300
Bug 18718: DBRev 17.05.00.005
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 239589b119c88a321fb8245f859855c41dda6566
Author: Marc Véron <veron at veron.ch>
Date: Fri Jun 2 12:11:47 2017 +0200
Bug 18718: Language selector in staff header menu similar to OPAC
This patch adds a language selector menu to the top menu of staff client
similar to the OPAC.
Display of language selectors at top, bottom or both can be configured
with system preference StaffLangSelectorModer. It defaults to bottom.
To test:
- Apply patch
- Udate database
- Restart plack and memchached
- Go to staff client, verify that language selector displays at
the bottom of the page (as before)
- Go to system preferences, verify that there is a new preference
StaffLanguageSelectorMode (name similar to the sypref ror OPAC), and
that it is set to 'footer'
- Change mode for top, both and footer and verify, go to staff client
and verify for each that the language selector displays as appropriate
(Amended for comment #2 2017-06-02 mv)
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d5ea914f4dc41f78dbb3a59f894f6ecbb9a1afa4
Author: Serhij Dubyk {Сергій Дубик} <serhijdubyk at gmail.com>
Date: Tue Aug 22 17:19:32 2017 +0300
Bug 17827 - Untranslatable "by" in MARC21slim2intranetResults.xsl
Signed-off-by: Serhij Dubyk {Сергій Дубик} <serhijdubyk at gmail.com>
The "by" after the title was not translatable in the result
lists of the intranet. This patch fixes it by removing
a comment, that caused a problem with the translation
scripts.
To test:
Test:
Before this patch in file en-GB-marc-MARC21.po present next paragraph:
msgid "by "
msgstr " by "
According string "by " in the file MARC21slim2intranetResults.xsl can not be translated (in other languages).
After applying this patch performed next command:
cd /usr/share/koha/misc/translator
sudo env KOHA_CONF=/etc/koha/sites/mykohainstance/koha-conf.xml PERL5LIB=/usr/share/koha/lib perl -I /usr/share/koha/lib "./translate" update
Now in the file en-GB-marc-MARC21.po present the following (modified) paragraph:
msgid "by "
msgstr " by "
https://bugs.koha-community.org/show_bug.cgi?id=17827
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 51a65731c0fa15c37351ce6bc478fa6dc63fc64f
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Tue Aug 29 04:51:40 2017 +0000
Bug 19194: Check itemtype is defined when receiving an order
To test:
1) Find a record with an item that has no itemtype (or remove the
itemtype of an item)
2) Go to Acquisitions -> Find a vendor or make a new one -> create a new
basket
3) Add the record from Step 1 to your basket
4) Close the basket
5) Go back to the vendor and click 'Receive shipments'
6) Put in an invoice number, click Next
7) Click the Receive link for your item
8) Confirm you see an internal server error
9) Apply the patch and refresh the page
10) The error should be gone and behaviour should continue as expected
Sponsored-by: Catalyst IT
Signed-off-by: Lee Jamison <ldjamison at marywood.edu>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
-----------------------------------------------------------------------
Summary of changes:
C4/Acquisition.pm | 6 +-
C4/Circulation.pm | 22 +++---
C4/Reserves.pm | 53 --------------
C4/SIP/ILS/Patron.pm | 3 +-
Koha.pm | 2 +-
Koha/Objects.pm | 2 +-
Koha/Plugins.pm | 6 +-
Koha/SuggestionEngine/Plugin/AuthorityFile.pm | 5 +-
Koha/SuggestionEngine/Plugin/ExplodedTerms.pm | 7 +-
acqui/orderreceive.pl | 4 +-
installer/data/mysql/sysprefs.sql | 3 +-
installer/data/mysql/updatedatabase.pl | 10 +++
.../en/includes/catalogue/itemsearch_item.json.inc | 3 +-
.../intranet-tmpl/prog/en/includes/circ-menu.inc | 7 +-
.../intranet-tmpl/prog/en/includes/header.inc | 1 +
.../prog/en/includes/intranet-bottom.inc | 4 +-
.../prog/en/includes/langmenu-staff-top.inc} | 10 +--
.../prog/en/includes/members-toolbar.inc | 4 +-
.../prog/en/includes/messaging-preference-form.inc | 20 ++++--
.../prog/en/includes/prefs-admin-search.inc | 2 +-
.../prog/en/modules/admin/preferences.tt | 2 +
.../prog/en/modules/admin/preferences/patrons.pref | 2 +
.../en/modules/admin/preferences/staff_client.pref | 7 ++
.../prog/en/modules/catalogue/itemsearch.tt | 4 +-
.../prog/en/modules/members/memberentrygen.tt | 2 +-
.../prog/en/modules/members/moremember-brief.tt | 28 +++-----
.../prog/en/modules/members/moremember.tt | 74 +++++++++-----------
.../prog/en/modules/members/paycollect.tt | 2 -
.../prog/en/modules/reserve/request.tt | 4 +-
.../prog/en/modules/tools/batch_delete_records.tt | 2 +-
.../en/modules/tools/batch_record_modification.tt | 2 +-
.../prog/en/xslt/MARC21slim2intranetResults.xsl | 2 +-
.../bootstrap/en/modules/opac-messaging.tt | 10 ++-
.../opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 20 +++++-
members/moremember.pl | 6 +-
members/paycollect.pl | 5 +-
opac/opac-account-pay.pl | 1 +
opac/opac-changelanguage.pl | 14 ++--
opac/unapi | 27 +++----
reserve/request.pl | 3 +-
t/db_dependent/Acquisition/close_reopen_basket.t | 15 +++-
t/db_dependent/Circulation.t | 17 ++++-
t/db_dependent/Circulation/Returns.t | 4 +-
t/db_dependent/Circulation/dateexpiry.t | 22 +++++-
t/db_dependent/Holds.t | 5 +-
t/db_dependent/Koha/Objects.t | 36 ++++++++--
t/db_dependent/Koha/Patrons.t | 16 ++---
t/db_dependent/SIP/Patron.t | 34 ++++++++-
48 files changed, 313 insertions(+), 227 deletions(-)
copy koha-tmpl/{opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc => intranet-tmpl/prog/en/includes/langmenu-staff-top.inc} (72%)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list