[koha-commits] main Koha release repository branch master updated. v17.11.00-1039-g8538886

Tue Apr 3 16:55:49 CEST 2018

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  8538886cb91f977d6109bfd035d4d8348ad108dc (commit)
       via  6e32e62d46d5fae8806a41eadaec701531913764 (commit)
       via  bfdd5150c1e01f7167bb1702cebba218dfeec38e (commit)
       via  bc001c2352fee419a2bbe20c0cf707afd9e5bd78 (commit)
       via  509892fd00cf6b7a5d65e2aef9d615bf35806cbe (commit)
       via  a53471e8bbf4dcb071fabc956fa41c467c4c8c88 (commit)
       via  83082242a50c1f33f11080e47e51d0cdcf961939 (commit)
       via  0161a106e757627d95043401c29c6ab10faa6bdb (commit)
       via  0b4e3dd343b8757e402a943fdb6c4d349f9b1e10 (commit)
       via  3c4677efc765979643315c238c405843fe9be654 (commit)
       via  0265c4ae29f860f36baccc9b09537b3cc0368274 (commit)
       via  52af054b6091ee3256f3d87f58ab8e2d29134c32 (commit)
       via  98d0c990bf33bbe8ce76126181f64f078087fa45 (commit)
       via  ac7ea9e10e8db92c91e9e436a7f32af2f8623782 (commit)
       via  d4b680155247ef0289e8728a7416a734410c12f6 (commit)
       via  0f907342c88e318ee6e774f8c085370681bc1af8 (commit)
       via  94e3caf32b481e557351eadf1c0657c6b9ad5dd0 (commit)
       via  b5bbda68fa7d73469f625d40ccee346f48db40bd (commit)
       via  28c39d5c8642d167b66446ab36dedc447dc076c9 (commit)
       via  6e9ed1a823c6ed9bf9c5f0b57e9c4185b67c0cf3 (commit)
       via  39c2a696b007097bdc286f166c62902c90b14cf3 (commit)
      from  92c1eb7db3d46c1495afd6181514be72bdb703c2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 8538886cb91f977d6109bfd035d4d8348ad108dc
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Apr 3 09:52:57 2018 -0300

    Bug 19935: (follow-up) Replace GetPendingIssues - opac-user.pl

    Syntax issue, can be squashed on pushing.

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 6e32e62d46d5fae8806a41eadaec701531913764
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Apr 3 09:49:54 2018 -0300

    Bug 19935: Use ->checkouts when ->pending_checkouts->count was used

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit bfdd5150c1e01f7167bb1702cebba218dfeec38e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Jan 8 12:32:55 2018 -0300

    Bug 19935: Replace GetPendingIssues - Remove the residue

    Here we are, no more occurrences of GetPendingIssues, we can remove the
    tests and subroutine \o/

    Signed-off-by: Benjamin Rokseth <benjamin.rokseth at deichman.no>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit bc001c2352fee419a2bbe20c0cf707afd9e5bd78
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Jan 8 12:23:42 2018 -0300

    Bug 19935: Replace GetPendingIssues - SIP

    Sounds like we do not need related fields or 'overdue' flag here.
    No idea how to confirm there is no regression here.

    Signed-off-by: Benjamin Rokseth <benjamin.rokseth at deichman.no>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 509892fd00cf6b7a5d65e2aef9d615bf35806cbe
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Jan 8 12:06:59 2018 -0300

    Bug 19935: Replace GetPendingIssues - sco-main

    Same as previously, we do not need all the prefetched values here, just
    a few.

    Test plan:
    Use the self checkout module to check some items out

    Signed-off-by: Benjamin Rokseth <benjamin.rokseth at deichman.no>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit a53471e8bbf4dcb071fabc956fa41c467c4c8c88
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Jan 8 11:59:29 2018 -0300

    Bug 19935: Replace GetPendingIssues - opac-user.pl

    At first glance we just need the biblio title and the subtitle (in
    addition of the fines info), we should not need the prefetch.

    Test plan:
    Loggin at the OPAC, on the summary page you should see your checkouts
    and overdues with the correct values

    Signed-off-by: Benjamin Rokseth <benjamin.rokseth at deichman.no>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 83082242a50c1f33f11080e47e51d0cdcf961939
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Jan 8 11:47:46 2018 -0300

    Bug 19935: Replace GetPendingIssues - opac-ics.pl

    We only need the biblio title and the barcode, we should not need the
    whole prefetch.

    Test plan:
    On your OPAC summary page export your checkout list using the
    "Download as iCal/.ics file" link.
    Before and after the patchset, the generated files must be the same

    Signed-off-by: Benjamin Rokseth <benjamin.rokseth at deichman.no>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 0161a106e757627d95043401c29c6ab10faa6bdb
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Jan 8 11:40:10 2018 -0300

    Bug 19935: Replace GetPendingIssues - summary-print

    We are in the notices part, so we need to fetch all the data to avoid
    regressions.

    Test plan:
    Print a summary slip before and after this patch.
    They must be the same

    Signed-off-by: Benjamin Rokseth <benjamin.rokseth at deichman.no>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 0b4e3dd343b8757e402a943fdb6c4d349f9b1e10
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Jan 8 11:16:09 2018 -0300

    Bug 19935: Replace GetPendingIssues - deletemem.pl

    Same as previously, we just want Koha::Patron->checkouts->count to know
    if a patron has checkouts.

    Test plan:
    Confirm that you cannot delete a patron's card if they have pending checkouts

    Signed-off-by: Benjamin Rokseth <benjamin.rokseth at deichman.no>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 3c4677efc765979643315c238c405843fe9be654
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Jan 8 11:15:02 2018 -0300

    Bug 19935: Replace GetPendingIssues - Discharges

    We should actually use Koha::Patron->checkouts here to avoid the
    prefetch.

    Test plan:
    A patron with checkouts cannot get a discharge

    Signed-off-by: Benjamin Rokseth <benjamin.rokseth at deichman.no>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 0265c4ae29f860f36baccc9b09537b3cc0368274
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Jan 8 11:10:50 2018 -0300

    Bug 19935: Replace GetPendingIssues - ILSDI

    Here we should only access to what we want in the template, but let do
    it as it for now.

    Test plan:
    Hit
    /cgi-bin/koha/ilsdi.pl?service=GetPatronInfo&patron_id=542&show_contact=0&show_loans=1

    With 42 a borrowernumber with checkouts

    Before and after these patches the XML must be the same

    Signed-off-by: Benjamin Rokseth <benjamin.rokseth at deichman.no>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 52af054b6091ee3256f3d87f58ab8e2d29134c32
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Jan 8 15:49:18 2018 -0300

    Bug 19935: Replace GetPendingIssues - IssueSlip

    Luckily we have a good test coverage here!

    Test plan:
    Print issue slips before and after these patches (with overdues, etc.)
    They should be the same.

    Signed-off-by: Benjamin Rokseth <benjamin.rokseth at deichman.no>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 98d0c990bf33bbe8ce76126181f64f078087fa45
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Jan 8 15:49:03 2018 -0300

    Bug 19935: Add Koha::Patron->pending_checkouts

    To move this subroutine out of the C4 namespace we face the same
    problematic as bug 17553 (with GetOverduesForPatron).
    We need to provide an equivalent method and so return all the related
    value for a given checkout.
    We can acchieve the easily using Koha::Object->unblessed_all_relateds,
    but we need to keep in mind that it is a temporary move.
    Indeed we will want to use our API to only access/retrive values we really need.
    The whole trick could be removed when the current syntax for notices
    will be deprecated and removed.

    Note: this method returns the same number of elements than ->checkouts
    They indeed returns the same things, but it sounds better to me to have a
    different method to highlight (from the callers) where does it come
    from (C4::Members::GetPendingIssues).

    Signed-off-by: Benjamin Rokseth <benjamin.rokseth at deichman.no>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit ac7ea9e10e8db92c91e9e436a7f32af2f8623782
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Tue Apr 3 12:28:21 2018 +0000

    Bug 17553: (follow-up) Adjust number of tests

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit d4b680155247ef0289e8728a7416a734410c12f6
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Jan 8 13:19:51 2018 -0300

    Bug 17553: Move GetOverduesForPatron to Koha::Patron->get_overdues

    With the help of Koha::Object->unblessed_all_relateds we are going to
    replace GetOverduesForPatron without introducing regressions (hopefully)
    on both template notice syntaxes.

    Test plan:
    0/ Do not apply any patches
    1/ Check some items in to a given patron, with and without overdues.
    2/ Print the overdues slip (Circulation module > Print > Print overdues)
    3/ Apply these patches
    4/ Print again and compare the result
    => The 2 generated slips must be exactly the same

    Signed-off-by: Benjamin Rokseth <benjamin.rokseth at deichman.no>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 0f907342c88e318ee6e774f8c085370681bc1af8
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Nov 4 10:23:56 2016 +0000

    Bug 17553: Move existing tests

    Signed-off-by: Benjamin Rokseth <benjamin.rokseth at deichman.no>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 94e3caf32b481e557351eadf1c0657c6b9ad5dd0
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Jan 8 13:48:28 2018 -0300

    Bug 19926: Add tests for Koha::Object->unblessed_all_relateds

    Signed-off-by: Benjamin Rokseth <benjamin.rokseth at deichman.no>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit b5bbda68fa7d73469f625d40ccee346f48db40bd
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Jan 8 13:19:16 2018 -0300

    Bug 19926: Add the Koha::Object->unblessed_all_relateds method

    In order to refactor our legacy code step-by-step, we will need to
    provide code with the exact same behaviors and then improve it.

    The same idea appears for the TT syntax for notices: we will want to
    deprecate the existing syntax in order to support only one syntax.
    Currently we fetch all the values from the related tables, without
    knowing which are actually used.

    I am suggestion to introduce a Koha::Object->unblessed_all_relateds
    method which will return a hash containing all the fields from the
    related tables (with the problems we know: collision in column names).
    It is the existing behavior of GetOverduesForPatron and GetPendingIssues
    for instance, they are used to send notices and so we have to provide
    all the data needed.

    See dependent bugs to understand the context and test this patch.

    Signed-off-by: Benjamin Rokseth <benjamin.rokseth at deichman.no>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 28c39d5c8642d167b66446ab36dedc447dc076c9
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Apr 3 11:21:28 2018 -0300

    Bug 7143: Update about page for new dev - Roch D'Amour

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 6e9ed1a823c6ed9bf9c5f0b57e9c4185b67c0cf3
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Apr 3 11:18:08 2018 -0300

    Bug 7143: Update about page for new dev - Philippe Audet-Fortin

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 39c2a696b007097bdc286f166c62902c90b14cf3
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Apr 3 11:16:53 2018 -0300

    Bug 7143: Update about page for new releases

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-----------------------------------------------------------------------

Summary of changes:
 C4/ILSDI/Services.pm                               |   12 +-
 C4/Members.pm                                      |  205 ++++++--------------
 C4/SIP/ILS/Patron.pm                               |    2 +-
 Koha/Object.pm                                     |   45 ++++-
 Koha/Patron.pm                                     |   31 +++
 Koha/Patron/Discharge.pm                           |   13 +-
 docs/history.txt                                   |    9 +
 koha-tmpl/intranet-tmpl/prog/en/modules/about.tt   |    2 +
 .../opac-tmpl/bootstrap/en/modules/opac-user.tt    |    6 +-
 members/deletemem.pl                               |    4 +-
 members/print_overdues.pl                          |    5 +-
 members/summary-print.pl                           |   31 ++-
 opac/opac-ics.pl                                   |    8 +-
 opac/opac-user.pl                                  |    9 +-
 opac/sco/sco-main.pl                               |   21 +-
 t/db_dependent/Koha/Object.t                       |   58 +++++-
 t/db_dependent/Koha/Patrons.t                      |   84 +++++++-
 t/db_dependent/Members/GetOverdues.t               |   80 --------
 t/db_dependent/Members/GetPendingIssues.t          |  130 -------------
 19 files changed, 337 insertions(+), 418 deletions(-)
 delete mode 100644 t/db_dependent/Members/GetOverdues.t
 delete mode 100644 t/db_dependent/Members/GetPendingIssues.t

hooks/post-receive
-- 
main Koha release repository