[koha-commits] main Koha release repository branch 17.11.x updated. v17.11.01-71-g5d3265f
Git repo owner
gitmaster at git.koha-community.org
Mon Jan 15 17:12:21 CET 2018
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 17.11.x has been updated
via 5d3265f52751d70cb87b7919cb0258ffb7c2e768 (commit)
via afbbfce0eeafb8dc9703d9c7fa3c3a0434155cfb (commit)
via e1bfe98d856ca849a48c728118a9e05fcbe2b31c (commit)
via ff374c3d3e9be828491821356c0b1790fa3d397f (commit)
via d8080061a64726c3d466f187c223fe4c5234b806 (commit)
via 564acdc4cd7e12885e4d470a929536fb25e442cd (commit)
via c916d0001bd03a764ec0b1926a2ca4327e356ea0 (commit)
via 6e9a466a7a0fde6a7706ef80ae773ac53d9fc57e (commit)
via df899212b25250cfac412f14478e481acdd6672a (commit)
via 8386f544b1bf68891b0ce2f68741e9d0115a0d49 (commit)
via 28c3c611ff43313d4072a65afeb389b708103075 (commit)
via a0072fa491e8607a9aad54d8e07db5d20fefbbfe (commit)
via 0693c4be77bb92035426d924bded72939a2d912c (commit)
via e6553d44fb39180b28f19a93a15ce370c874d631 (commit)
via 505ca939df661aae758d91d95ba237e32a9fa6b9 (commit)
via f20d2f1ea37906c7bbc4be1935fb80295f771152 (commit)
via 5ff8eca26c8d42cbca1c1e8b6b4ee10f2c45a387 (commit)
via ab7ea3ff3834e1429f1b3244ee45468c43e58684 (commit)
via 7934fea0c4c36f81b943de6c2016f8cedf53486c (commit)
via 9521925be40572163b98a3fd0edbdffb7e32dc72 (commit)
via 412c02f49bf60e6a515f9a605f26120d8221cd1c (commit)
via 1792ab3d813839b61b060967f4d4f174462eaaa7 (commit)
via 806ad212f5c5c765abd657de7891bc41ed24dfcf (commit)
via 809dc7c9c5557307e5ae4f3443a7529b28b02311 (commit)
via 2e5f4af8390478953771656a4cec511503225386 (commit)
via 38a6d9eeb6ffacd8406753dac4f5cd96702b330c (commit)
via cf917b5d4bb4d625ba72202e411071b803f95bab (commit)
via 9924fa4bd287ac665eb6e0c2adc7e7cea165f3f7 (commit)
via be960cc0cda7bb8dbe9a55a3a6e5e1aa0812f006 (commit)
via ad99cd0f41f792dcd0f308cc31dde16f58bb1522 (commit)
via d17e661d30ed614a0790b54cf385da3b539f4a34 (commit)
via 128d163e1baf7d203373883e03980e3a5f1b2d6c (commit)
via 1a7c6c4b202da3246a20705e6a3e8c88340151cb (commit)
via e52486eeba13987c926ecf0c952644e5bacdc2b0 (commit)
via f4c1712f58b8e90704893fb501c5cfc9d12f02a2 (commit)
via 3006819d317725cdf18ba8f7dfe2894c306bdbf8 (commit)
via 522873ac3a7071c86fb243f4cebee0a8108e9d20 (commit)
via 4ea54b678256b164fe9a951a44889ab3502c63b5 (commit)
via 55824b09d63ee83a8358c6e6f7740f664d3b86e3 (commit)
from 5be4704347610d269e7d3401f50af46b3202869a (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 5d3265f52751d70cb87b7919cb0258ffb7c2e768
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Mon Jan 8 15:37:45 2018 +0000
Bug 16782: (QA follow-up) Use Koha.Preference for staffClientBaseURL and provide classes
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit afbbfce0eeafb8dc9703d9c7fa3c3a0434155cfb
Author: Liz Rea <liz at catalyst.net.nz>
Date: Thu Oct 19 16:23:43 2017 +1300
Bug 16782: Disclose JSON URL for reports on the saved report page
It has always annoyed me that you had to look at the help to divine the url for a report.
This patch works it out and displays it for you in a new column on the saved reports table.
Requirements:
- OPACBaseURL and staffClientBaseURL preferences must be set for the urls to be complete. It's ok if they are not, but it's better if they are.
- You must have a saved report that is public to your OPAC, and one that is not public.
To test:
- create a public saved report and a private staff report. They can be anything.
- view the saved reports page, note that under a new heading of JSON URL the link to the json feed for that report shows.
- copying and pasting that link into the address bar, or clicking it, should take you to the results of the selected report.
sponsored-by: Catalyst IT
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Bug 16782 - missing </td>, fixed now
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit e1bfe98d856ca849a48c728118a9e05fcbe2b31c
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Oct 24 19:11:28 2017 +0000
Bug 18417: (follow-up) Document new shortcuts in dropdown
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit ff374c3d3e9be828491821356c0b1790fa3d397f
Author: Jesse Weaver <pianohacker at gmail.com>
Date: Tue Nov 10 12:02:06 2015 -0700
Bug 18417: Advanced Editor (Rancor) add shortcuts for copyright symbols (C) (P)
To test:
1 - Apply patch
2 - Open advanced cataloging editor
3 - Try using Alt+P and Alt+C and note symbols are added
4 - Save record and ensure symbols are saved
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit d8080061a64726c3d466f187c223fe4c5234b806
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Jan 3 18:12:33 2018 -0300
Bug 19913: Fix embedded HTML5 videos at the OPAC
Caused by
commit 752aef4593f1aa2d64700bf9738e7e03907eb1cd
Bug 18754: Translatability: Get rid of exposed tt directives in opac-detail.tt
A space is missing between 'source' and 'src'
Test plan:
Set HTML5MediaEnabled to OPAC
Put a video link to 856$u
See the OPAC detail page, tab video, click the video
=> Should play with this patch applied
Note that this does not affect intranet
Signed-off-by: George Williams <george at nekls.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 564acdc4cd7e12885e4d470a929536fb25e442cd
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Jan 4 10:27:57 2018 -0300
Bug 19914: Add an id to the Delete button on the library list view
To ease selenium tests, see bug 19243.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit c916d0001bd03a764ec0b1926a2ca4327e356ea0
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Jan 5 11:42:03 2018 -0300
Bug 19899: Restore Item floats feature - do not crash
Error is "The method noreturn is not covered by tests!"
caused by commit 6eade474ed3a84a5ba372a26ac27bf9fb4bd2299
Bug 18276: Remove GetBiblioFromItemNumber - Easy ones
When the "Return policy" (var returnbranch) is set to "Item floats" (value noreturn)
the library must be the current library (from userenv).
This behaviour is used in C4::Circulation::AddReturn
On bug 18276 I assumed that the value was either holdingbranch or
homebranch, and forgot it could be "noreturn"
Test plan:
Set Return policy to Item floats
Check an item in
=> without this patch it explodes
=> With this patch applied it will check the item in
Signed-off-by: Mohd Hafiz Yusoff <mhby87 at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 6e9a466a7a0fde6a7706ef80ae773ac53d9fc57e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Jan 5 11:09:09 2018 -0300
Bug 19918: Close span tag in opac-registration-confirmation.tt
Introduced by:
commit 06f4950aa21ff889cff81f27b2f4e79788db193f
Bug 13599 - Add patron cardnumber to self registration confirmation
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit df899212b25250cfac412f14478e481acdd6672a
Author: Victor Grousset <victor.grousset at biblibre.com>
Date: Wed Dec 13 20:16:54 2017 +0100
Bug 19807: Make IntranetCatalogSearchPulldown honor IntranetNumbersPreferPhrase
This patch
- fixes callnum and sn
- Removes unecessary syspref transmission to the template.
As the template directly reads the syspref
Test plan:
1. Set sysprefs IntranetCatalogSearchPulldown and
IntranetNumbersPreferPhrase to true
2. Go to staff:/cgi-bin/koha/catalogue/search.pl
3. "search for" → "call number" and write anything that won't match a
call number in the field
4. Then you should see
«No results match your search for 'callnum,phr: [...]»
5. Go to the staff homepage
6. Click on "Search the catalog"
7. Do the same search as previouly
8. Then you should see
«No results match your search for 'callnum,wrdl: [...]»
This shows that IntranetNumbersPreferPhrase isn't honored
9. Apply this patch
10. Redo the same two searches and see that phr will now be always used.
So IntranetNumbersPreferPhrase is honored
Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 8386f544b1bf68891b0ce2f68741e9d0115a0d49
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Tue Feb 28 14:26:22 2017 +0100
Bug 18183: jQuery append error related to script tags in cloneItemBlock
See the detailed explanation of the error on Bugzilla.
As a workaround, we move the append of clone to outeritemblock before the
append of data (long string with item fields and script tags) to clone.
This patch also moves two vars inside the success function, since they are
not used outside of it.
Test plan:
[1] Set AcqCreateItem to receiving.
[2] Receive an order. Verify that adding, updating or deleting an item block
still works as expected.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 28c3c611ff43313d4072a65afeb389b708103075
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Dec 19 15:51:42 2017 -0300
Bug 19798: Fix print transfer slip
... and maybe other bugs as well
What happens here is that $itemnumber is no longer set when barcode is
passed.
Test plan:
1. Check in available/not on hold item at a non owning library.
2. Click print slip
3. Item's info must be displayed on the slip
Signed-off-by: Björn Nylén <bjorn.nylen at ub.lu.se>
Signed-off-by: Björn Nylén <bjorn.nylen at ub.lu.se>
Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit a0072fa491e8607a9aad54d8e07db5d20fefbbfe
Author: Liz Rea <liz at catalyst.net.nz>
Date: Tue Sep 19 15:29:22 2017 +1200
Bug 19338: Fix sorting by dates in opac-account.tt
To test:
Find an account with lots of fines/payments
load up the borrower's account in the OPAC
note that the sort on the dates sorts by day, and not by date.
apply this patch
reload the page, note that the sort on the dates is now correct.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 0693c4be77bb92035426d924bded72939a2d912c
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Dec 20 19:48:13 2017 +0000
Bug 19860: Make staff client home page responsive
This patch rewrites the markup of the staff client home page to use the
Bootstrap grid instead of the YUI grid, taking advantage of Bootstrap's
built-in responsiveness.
This patch does not affect the logo and search form in the header. It
will be necessary to address search forms in another patch.
To test, apply the patch and clear your browser cache if necessary. For
better results, apply the patch for Bug 19851 as well.
- View the staff client home page and test the layout at various browser
widths.
- Test with and without news items
- Test with and without content in IntranetmainUserblock
Signed-off-by: Dominic Pichette <dominic.pichette at inlibro.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit e6553d44fb39180b28f19a93a15ce370c874d631
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Dec 20 17:09:30 2017 +0000
Bug 19851: Improve responsive layout handling of staff client menu bar
This patch modifies CSS and markup in the staff client header to
override the default responsive style of the menu bar. The changed
layout will keep the menu bar items in a horizontal line at lower screen
widths.
To test, apply the patch and clear your browser cache if necessary.
- Log in to the staff client and confirm that the appearance of the
menu bar at the top of the screen looks correct at various browser
widths.
- Confirm that the logged-in user menu label and help link expand and
collapse according to browser width.
Signed-off-by: Dominic Pichette <dominic.pichette at inlibro.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 505ca939df661aae758d91d95ba237e32a9fa6b9
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri May 20 12:19:49 2016 -0400
Bug 16764: Update printers administration page
This patch updates the template for printers administration according to
current interface guidelines.
- Custom JavaScript form validation is removed in favor of the built-in
form validation plugin.
- Printer-specific header search form is removed, along with server-side
pagination code. The functionality of both is now taken care of the
adding DataTables sorting and pagination to the table.
- Edit and delete links are styled as Boostrap buttons with Font Awesome
icons.
- Confirmation dialogs are updated to use Font Awesome icons.
To test properly you will need to add multiple printers.
- Apply the patch and open /cgi-bin/koha/admin/printers.pl (there is no
menu link for the page).
- When no printers exist you should see a message dialog saying so.
- Add a new printer. Confirm that printer name and queue are required
fields.
- After adding multiple printers, confirm that the table of printers is
correctly sorted and searched by the DataTables plugin.
- Delete a printer and verify that the confirmation dialog is correctly
styled.
Signed-off-by: Marc Véron <veron at veron.ch>
Update: rebased and updated Bootstrap 3 classes
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit f20d2f1ea37906c7bbc4be1935fb80295f771152
Author: Lari Taskula <lari.taskula at jns.fi>
Date: Thu Dec 21 13:56:34 2017 +0200
Bug 19857: Use BorrowerUnwantedField system preference for SMS provider selection
Optionally hide SMS provider field in patron modification screen with
BorrowerUnwantedField system preference.
To test:
1. Apply patch
2. Append BorrowerUnwantedField with sms_provider_id and save changes
3. Go to patron modification screen in staff client
4. Observe the SMS provider selection is now hidden
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 5ff8eca26c8d42cbca1c1e8b6b4ee10f2c45a387
Author: Frédéric Demians <f.demians at tamil.fr>
Date: Mon Dec 11 08:41:05 2017 +0100
Bug 19788: Preserve case sensitivity when creating Local preferences
Fix a bug tranforming new local preference variable name in lowercase.
TO TEST:
1. Admin > System preferences > Local use
2. Button New preference. Fill variable field with 'TESTfoo'. Click
Save.
3. The new variable is named: 'testfoo'.
4. Apply the patch.
5. Button New preference. Fill variable field with 'TESTfoo2'. Click
Save.
6. The new variable is properly named: 'TESTfoo2'.
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit ab7ea3ff3834e1429f1b3244ee45468c43e58684
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Dec 19 11:56:07 2017 -0300
Bug 19788: Add a test
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 7934fea0c4c36f81b943de6c2016f8cedf53486c
Author: David Bourgault <david.bourgault at inlibro.com>
Date: Mon Nov 27 16:05:48 2017 -0500
Bug 19702: Correct cookie path in Basket.js
This corrects the cookie path in bootstrap/js/basket.js. It used to take
the default value (current page path), but will now be "/"
Test plan:
0) Visit the OPAC, add a book to your basket
1) Navigate to the OPAC's homepage (www.domain.com, without the
/cgi-bin/koha)
-> The basket will display as empty
2) Apply patch
3) Clear your cookies and your cache
4) Redo step 1)
-> Basket will display correctly
Patch applies without issue and functions as descibed.
Signed-off-by: Dilan Johnpullé <dilan at calyx.net.au>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 9521925be40572163b98a3fd0edbdffb7e32dc72
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Dec 19 15:45:53 2017 -0300
Bug 19840: And avoid XSS...
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 412c02f49bf60e6a515f9a605f26120d8221cd1c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Dec 19 15:40:45 2017 -0300
Bug 19840: Fix - display patron note on checkin
If a patron let a note on the checkout (AllowCheckoutNotes), it is
supposed to be displayed when checked in.
Test plan:
1/ Enable AllowCheckoutNotes
2/ Check an item out
3/ At the opac let a note on the checkout
4/ Check the item in
=> With this patch applied you should see the notes displayed
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 1792ab3d813839b61b060967f4d4f174462eaaa7
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Mon Nov 13 17:18:44 2017 +0000
Bug 19621: Use Koha.Preference on template side to display/hide "Routing lists" tab
Patch applies without issue and functions as described.
Signed-off-by: Dilan Johnpullé <dilan at calyx.net.au>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 806ad212f5c5c765abd657de7891bc41ed24dfcf
Author: Janusz Kaczmarek <januszop at gmail.com>
Date: Sat Nov 25 02:28:02 2017 +0100
Bug 18458: Fix subfields ordering when Merging authority records
While doing a merge, if a subfield(s) precedes the controlled subfields
(like $i before $a in 7XX, which comes before $a -- rare but will
become more and more usual) after merging will be moved to the end.
This is not right.
The patch (with AuthorityMergeMode == loose) make merge consider the
subfields order: all subfields which originally were found before
the first controlled subfield (e.g. $i before $a in 7XX / MARC 21)
will remain in the front, the rest of not controlled subfields that
should remain in the field will come after the subfields copied
from authority rec.
As a bonus, $9 will be placed at the end.
To test:
0) Have AuthorityMergeMode == loose;
1) Have some field in bibliorecord, controlled by an authority, with
extra subfield(s) (i.e. not present in authority rec.) placed at the
beginning of the field;
2) Open (not necessarily edit) and save the connected authority;
3) See that the extra subfieds were moved to the end of the field
(and $9 is in the front);
4) Apply the patch;
5) Reorder subfields in biblio field;
6) Open (not necessarily edit) and save the connected authority;
7) See that the order has been conserved, additionally $9 the last
subfield in the field.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Amended:
Moved field creation to its original place. Changed $9 handling. Simplified the following add_subfields for loop. Edited comments.
Restored the append_fields_ordered call (see comment6).
With this patch, the Merge.t test now passes.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 809dc7c9c5557307e5ae4f3443a7529b28b02311
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Dec 8 13:45:55 2017 +0100
Bug 18458: Add a subtest in Merge.t
This test illustrates the problem we have if you run it without the
second patch. And it serves to demonstrate that we resolved the
situation if you run it after the second patch.
Test plan:
[1] Without the second patch: The last subtest should fail.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 2e5f4af8390478953771656a4cec511503225386
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu Dec 14 10:31:17 2017 -0500
Bug 19813: Make MarcItemFieldsToOrder handle non-existing tags
MarcItemFieldsToOrder defines how Koha looks at tags in order records to generate item data.
Let's look at a simplified case:
homebranch: 955$a
holdingbranch: 956$a
So, here we are looking at 955 for the home branch, and 956 for the holding branch. So, it should make sense that Koha requires that these fields exist in equal number in the record. That is, for each 955, there should be a corresponding 956.
Let's look at a different case:
homebranch: 946$a|975$a
holdingbranch: 946$a|975$a
In this case, we are using the fallback behavior. VendorA stores the branch data in 946, and VendorB stores it in 975. This seems like it would work, but it won't! That's because Koha is expecting there to be the same number of 946's as there are 975's! In reality, the VendorA records will have a number of 946's, and *zero* 975's. The inverse will be true for VendorB.
Koha should be able to skip those tags that simply don't exist in the record.
Test Plan:
1) Set MarcItemFieldsToOrder to something like:
homebranch: 946$a|975$a
holdingbranch: 946$a|975$a
budget_code: 946$f|975$f
itype: 946$y|975$y
notforloan: 946$l|975$l
ccode: 946$t|975$c
quantity: 946$q|975$q
price: 946$p|975$p
itemcallnumber: 946$n|975$n
loc: 946$c|975$t
2) Create a record using only the 975 tag for item building data
3) Import the record into Koha
4) Create a basket
5) Attempt to add the record to the basket
6) Note the unequal fields error
7) Apply this patch
8) Reload the page
9) No error!
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Marci Chen <mchen at mckinneytexas.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Amended: Fix typo occurrance and theses.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 38a6d9eeb6ffacd8406753dac4f5cd96702b330c
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Dec 22 11:20:13 2017 +0100
Bug 19200: (QA follow-up) Simplify call to GetBasketAsCSV
If no profile_id is passed, GetBasketAsCSV will fallback to default itself.
No need to make the distinction in basket.pl.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit cf917b5d4bb4d625ba72202e411071b803f95bab
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Tue Aug 29 21:07:39 2017 +0000
Bug 19200: Preventing warns when exporting a basket
To test:
1) Go to Tools -> CSV profiles -> New CSV Profile
2) Create a new CSV profile with any name of SQL fields. Ensure profile
type: SQL and usage: basket export in acquisition
3) Go to Acquisitions -> Find or create a vendor -> Use or create a
basket
4) Click the dropdown menu next to the 'Export as CSV' button. There
should be a 'Default' option and your new CSV profile (at least)
5) Click the 'Default' option. Notice warns
6) Click the 'Export as CSV' button. Notice warns
7) Click your new CSV profile option. Notice warns
8) Apply patch and refresh page
9) Repeat steps 5-7, confirm that warns do not show
10) Confirm export still works as expected
Sponsored-by: Catalyst IT
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 9924fa4bd287ac665eb6e0c2adc7e7cea165f3f7
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Dec 22 14:04:52 2017 -0300
Bug 19760: Fix Config.t test
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit be960cc0cda7bb8dbe9a55a3a6e5e1aa0812f006
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Dec 6 13:58:04 2017 -0300
Bug 19760: Die if koha-conf is not accessible
We got a lot of support questions because scripts are executed without
the correct environment/user.
We could die and provide more useful information
Tested on my kohadevbox VM by:
1) sudo chmod a-rx /etc/koha/sites/kohadev/koha-conf.xml
2) run help.pl from the command line to produce the desired die message
3) sudo chmod a+rx /etc/koha/sites/kohadev/koha-conf.xml
4) rerun help.pl successfully
Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Bug 19760: Change wording
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit ad99cd0f41f792dcd0f308cc31dde16f58bb1522
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Dec 21 12:42:03 2017 -0300
Bug 19429: Rename .delete to .delete_invoice
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit d17e661d30ed614a0790b54cf385da3b539f4a34
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Dec 21 14:45:51 2017 -0300
Bug 19867: Prevent HouseboundRoles.t to fail randomly
Here is just a guess but we need to tell TestBuilder the values of
housebound_deliverer and housebound_chooser to make sure it will not be
1
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
I manually tested setting to the opposite values in the tests, and
verified those values made the tests fail due to count problems.
The fix is valid.
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 128d163e1baf7d203373883e03980e3a5f1b2d6c
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Tue Oct 3 02:47:40 2017 +0000
Bug 19401: Add confirm message when deleting invoice
To test:
1) Go to Acquisitions
2) Go to Invoices (left nav menu)
3) Click Search (no need to filter results)
4) Click dropdown menu for an invoice, click Details
5) Click Delete
6) Notice invoice is deleted instantly
7) Apply patch and repeat steps 4 and 5
8) Confirm the confirm message shows and works as expected
Sponsored-by: Catalyst IT
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 1a7c6c4b202da3246a20705e6a3e8c88340151cb
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Tue Oct 10 02:17:36 2017 +0000
Bug 19429: Add confirm message when deleting invoice from invoice search page
To test:
To test:
1) Go to Acquisitions
2) Go to Invoices (left nav menu)
3) Click Search (no need to filter results)
4) Click dropdown menu for an invoice, click Delete
5) Notice invoice is deleted instantly
6) Apply patch and repeat steps 3 and 4
7) Confirm the confirm message shows and works as expected
Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit e52486eeba13987c926ecf0c952644e5bacdc2b0
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Dec 20 18:59:39 2017 -0300
Bug 19756: Fix encoding issues during the update DB process
To display the output of the updatedatabase.pl under Plack, we redirect
the output to a temporary file, read it, then display it.
We need to open it specifying the correct encoding (utf-8).
Test plan:
1. MariaDB [koha_kohadev]> update systempreferences set value="17.1100000"
where variable="version";
2. restart plack
3. Login
4. Make the update from the interface
=> Without this patch you will see encoding issue:
Upgrade to 17.12.00.000 done (TÄ“ tÅia, tÄ“ haumatia)
=> With this patch applied you will see :
Upgrade to 17.12.00.000 done (Tē tōia, tē haumatia)
Signed-off-by: Liz Rea <liz at catalyst.net.nz>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit f4c1712f58b8e90704893fb501c5cfc9d12f02a2
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Nov 9 15:54:12 2017 +0000
Bug 19573: Link to make a new list in masthead in OPAC only appears / works if no other list already exists
This patch corrects the OPAC masthead include file so that the "New
list" link will appear whether or not the logged-in user has existing
private lists.
To test, apply the patch and log into the OPAC as both a user with
private lists and a user without private lists. The header's "Lists"
dropdown menu should include a "New list" link in both cases.
Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 3006819d317725cdf18ba8f7dfe2894c306bdbf8
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Dec 21 12:57:11 2017 -0300
Bug 11976: Fix sorting issues
The last column must be sortable, and dates must use title-string
I removed the class on the th (did not seem useful as we have an id
already)
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 522873ac3a7071c86fb243f4cebee0a8108e9d20
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Thu Oct 26 11:41:34 2017 -0400
Bug 11976: Add Publication date to subscription table (opac) + column settings
This patch adds the column settings feature to the subscription list at
the OPAC.
It also adds a new column (Publication date) to this table
Using Home->Administration->Column Settings->OPAC->subscriptionst
the fields visibility can be toggled.
TEST PLAN
---------
1) Have a subscription where you have received at least once.
2) Look for it in OPAC and note the date is the received date, not the publication date
3) Apply patch
4) Log in to staff client
5) Home->Administration->Column Settings->OPAC->subscriptionst
6) Set visibility as desired.
7) Refresh OPAC page
-- everything should be as expected.
8) run koha qa test tools.
Signed-off-by: David Bourgault <david.bourgault at inlibro.com>
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 4ea54b678256b164fe9a951a44889ab3502c63b5
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Fri Dec 1 15:21:56 2017 +0000
Bug 19725: OAI-PMH - Use biblio_metadata.timestamp
Since bug 17196, biblioitems.timestamp is not always updated after a
change in the MARC record.
Filtering should be based on biblio_metadata.timestamp instead.
Test plan:
1. prove t/db_dependent/OAI/Server.t
2. Verify that it SUCCEEDS
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 55824b09d63ee83a8358c6e6f7740f664d3b86e3
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Fri Dec 1 15:18:04 2017 +0000
Bug 19725: Add failing test
Also fix tests for UNIMARC
Test plan:
1. prove t/db_dependent/OAI/Server.t
2. Verify that it FAILS
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/AuthoritiesMarc.pm | 31 +-
C4/Context.pm | 3 +-
Koha/Config.pm | 2 +-
Koha/OAI/Server/ListBase.pm | 6 +-
acqui/addorderiso2709.pl | 25 +-
acqui/basket.pl | 8 +-
admin/columns_settings.yml | 11 +
admin/printers.pl | 16 +-
catalogue/search.pl | 3 -
circ/returns.pl | 10 +-
installer/install.pl | 4 +-
.../lib/koha/cateditor/marc-editor.js | 8 +
koha-tmpl/intranet-tmpl/prog/css/mainpage.css | 12 +-
koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 71 ++++
.../intranet-tmpl/prog/en/includes/circ-menu.inc | 2 +-
.../prog/en/includes/doc-head-close.inc | 2 +-
.../intranet-tmpl/prog/en/includes/header.inc | 83 +++--
.../prog/en/includes/printers-admin-search.inc | 30 --
.../prog/en/includes/search_indexes.inc | 5 +-
.../intranet-tmpl/prog/en/modules/acqui/invoice.tt | 5 +-
.../prog/en/modules/acqui/invoices.tt | 6 +-
.../prog/en/modules/admin/branches.tt | 2 +-
.../prog/en/modules/admin/printers.tt | 162 ++++-----
.../prog/en/modules/cataloguing/editor.tt | 8 +
.../intranet-tmpl/prog/en/modules/circ/returns.tt | 2 +-
.../intranet-tmpl/prog/en/modules/intranet-main.tt | 369 ++++++++++----------
.../prog/en/modules/members/memberentrygen.tt | 2 +
.../en/modules/reports/guided_reports_start.tt | 16 +-
koha-tmpl/intranet-tmpl/prog/js/additem.js | 6 +-
.../opac-tmpl/bootstrap/en/includes/masthead.inc | 2 +-
.../opac-tmpl/bootstrap/en/modules/opac-account.tt | 10 +-
.../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 36 +-
.../en/modules/opac-registration-confirmation.tt | 2 +-
koha-tmpl/opac-tmpl/bootstrap/js/basket.js | 4 +-
members/boraccount.pl | 1 -
members/deletemem.pl | 1 -
members/files.pl | 1 -
members/mancredit.pl | 1 -
members/maninvoice.pl | 1 -
members/member-flags.pl | 1 -
members/member-password.pl | 1 -
members/moremember.pl | 1 -
members/notices.pl | 1 -
members/pay.pl | 1 -
members/paycollect.pl | 1 -
members/purchase-suggestions.pl | 1 -
members/readingrec.pl | 1 -
members/routing-lists.pl | 1 -
members/statistics.pl | 1 -
t/Koha/Config.t | 6 +-
t/db_dependent/Authority/Merge.t | 27 +-
t/db_dependent/Context.t | 4 +-
t/db_dependent/OAI/Server.t | 62 ++--
t/db_dependent/Patron/HouseboundRoles.t | 4 +-
tools/viewlog.pl | 1 -
55 files changed, 613 insertions(+), 470 deletions(-)
delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/printers-admin-search.inc
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list