From gitmaster at git.koha-community.org  Mon Apr  1 14:16:16 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Mon, 01 Apr 2019 12:16:16 +0000
Subject: [koha-commits] main Koha release repository branch 18.11.x updated.
	v18.11.04-21-g16e2505
Message-ID: <E1hAvrM-0000wD-Rm@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  16e250542de43eadf62bc9354329912be84c3420 (commit)
       via  d5aa7655a643a5a4868a47b8aae5371438993580 (commit)
       via  38bbe82aa07aa9a1a3cc33e00b5b8e459eb28a30 (commit)
       via  34e0f9874f91b22c8fd24f76de74bb3c126d2a1e (commit)
       via  e3e64974d830a8699e8648a82d21a7ffce502955 (commit)
       via  3b423071227ee3f9300907bb9e89cff26012aa29 (commit)
       via  54de33967101173c72865e97fce0fd220e2d0842 (commit)
       via  ac1fdfe2258940cf4b7003d816b0e1723ed8963c (commit)
       via  df86121423c4770fe6d4971efeb5341e5a0b8825 (commit)
       via  4c095218790767f14a9edae4386174b53a752b44 (commit)
       via  9ef8a3e328e281bef98fe33a50f975322c26c25a (commit)
       via  c1d1880aeaf58052bc7782b30f57745a4bb78045 (commit)
       via  aa631b60e49f128bf7bbbe91e248f0af03e5f656 (commit)
       via  e180d8f46074a5088d517b154cd34526f3466d96 (commit)
       via  49d3cd6a7bcca45fbd5954ee49a4d13ba6224f22 (commit)
       via  b875f2668d9605b90d7d2acb0ea8ec4da2f62fec (commit)
       via  58497e1bc5de57fa1a9c20a7502714cc9e2bd3fd (commit)
       via  70d465be6a43b45807b769725b48d5654c606e71 (commit)
       via  f4d9c3ae9f79b40eadae34b74b78adbb4ae43a06 (commit)
       via  6826b12c74a345e50306add57061493beab7096b (commit)
       via  a0cefc86535244b0a603506daf5633a096d5c043 (commit)
      from  319ef905cdb6724e605fab0365580248b9c3c61c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 16e250542de43eadf62bc9354329912be84c3420
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Fri Mar 8 10:12:50 2019 +0100

    Bug 21049: Set 007/00 when selecting material type (Rancor)
    
    There is a 1-1 relationship between the material type values and the
    position 00 of 007 field. Selecting a material type should set this
    position's value.
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 856425db1e156ee4faf1aae70b0a78845711ba43)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit d5aa7655a643a5a4868a47b8aae5371438993580
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Wed Mar 6 08:43:18 2019 +0100

    Bug 21049: Fix value of material select for Rancor 007 widget
    
    The material type is selected in accordance with position 0 of 007
    
    Test plan:
    1. Create a new record using the advanced editor
    2. Select a material type for field 007 and set at least the position 0
       of this field
    3. Save the record and reload the page
    4. The material type should remain selected
    5. Try with all available material types
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit e85294a738da7cce2a4897998ffa795f977b4cd7)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 38bbe82aa07aa9a1a3cc33e00b5b8e459eb28a30
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue Mar 19 12:41:26 2019 +0000

    Bug 22536: Display problem in Holds to Pull report
    
    This patch modifies the display of several values in the holds to pull
    report so that they can be displayed as lists instead of as chunks of
    HTML generated in SQL.
    
    This patch modifies the SQL in pendingreserves.pl so that values can be
    formatted in the same way that holding branch is. The better long-term
    solution is to remove SQL from pendingreserves.pl altogether, but this
    is a quick fix.
    
    This patch also makes a couple of minor markup changes to fix
    validation.
    
    To test, apply the patch and go to Circulation -> Holds to pull. To see
    the changes the patch makes your holds to pull list should have titles
    with multiple items at multiple branches, with call number, copy number,
    and enumeration data. These values should all be displayed in bulleted
    lists.
    
    Signed-off-by: David Roberts <david.roberts at ptfs-europe.com>
    Signed-off-by: Bin Wen <bin.wen at inlibro.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 9a321c128fed457bf6d11d2ce7ee7edf7dd28004)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 34e0f9874f91b22c8fd24f76de74bb3c126d2a1e
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Fri Mar 22 13:19:51 2019 +0000

    Bug 22560: Forgotten password "token expired" page still shows boxes to reset password
    
    This patch modifies the OPAC password recovery template so that the new
    password entry form doesn't appear if the patron has followed an invalid
    or expired link.
    
    This patch also corrects the markup in the page title.
    
    To test, apply the patch and follow the process for resetting a
    forgotten password. When you follow the password recovery link, modify
    the URL so that the "uniqueKey" parameter is different.
    
    The page should show an error message. The password entry form should
    not appear.
    
    Check the page title in the browser's title bar. It should look correct.
    
    https://bugs.koha-community.org/show_bug.cgi?id=22520
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 7ac1457ffc27cf6ec5a3a7bab6abc8a010e02b6a)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit e3e64974d830a8699e8648a82d21a7ffce502955
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Fri Mar 22 12:57:31 2019 +0000

    Bug 22561: Forgotten password requirements hint doesn't list all rules for new passwords
    
    This patch modifies a few templates in the OPAC so that all available
    information on password requirements is displayed for each case where
    the patron is setting a password:
    
     - If the RequireStrongPassword system preference is set, a message
       should appear listing strong password requirements and minimum
       password length.
     - If RequireStrongPassword is not set, the message should only ask for
       a minimum password length.
    
    To test, apply the patch and enable the PatronSelfRegistration and
    OpacResetPassword preferences.
    
    On the following pages, test with RequireStrongPassword both on and
    off. The correct messages should appear.
    
     - OPAC -> Forgot password. Follow the process to reset your password
       until you reach the step where you are entering the new password.
     - OPAC -> Register here. Check the password section of the registration
       form.
     - OPAC -> Log in -> Change your password.
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 50be1c4006e0a1d7e3b537bd849bc77f7a6bb56f)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 3b423071227ee3f9300907bb9e89cff26012aa29
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Wed Feb 20 11:26:40 2019 -0300

    Bug 17746: (QA follow-up) Make set_password.pl generate a password if required
    
    This patch makes the set_password.pl script generate the password if it
    is not passed as an argument.
    
    It also changes the behaviour of set_password.pl: it will now print the
    userid and password (generated or not) to mimick the behaviour from
    koha-reset-passwd.
    
    The koha-reset-passwd gets simplified as it doesn't generate the random
    password anymore, it passes the responsability to set_password.pl
    
    To test:
    - Follow the steps from the original platch
    - Verify all behaves as expected
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 3ef48c8708736e9d5b16e462e520302c007cb4c1)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 54de33967101173c72865e97fce0fd220e2d0842
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Feb 4 15:09:34 2019 -0300

    Bug 17746: Add misc/admin/set_password.pl script
    
    This patch introduces a script that allows changing a patron's password.
    The change overrides the defined password enforcement policy.
    
    If multiple conditions are passed to match on the patron, they all need
    to match. Otherwise an error message is printed.
    
    Attributes to search the patron on:
    - cardnumber
    - patron_id (a.k.a. borrowernumber)
    - userid
    
    we usually know some of them, but if we specify more than one, they need
    to match a patron, together.
    
    To test:
    1) Apply this patch
    2) Have a known patron (i.e. you know the cardnumber, the borrowernumber
       and the userid).
    3) Run:
      $ kshell
     k$ perl misc/admin/set_password.pl --cardnumber <the_card_number> \
                                        --password a_password
    4) Verify you can login with the new password
    5) Repeat 3) through 5) with --patron_id and --userid
    => SUCCESS: You can login in all cases
    6) Try combining some or all the parameters
    => SUCCESS: It fails when it should, it succeeds when it should
    7) Sign off :-D
    
    Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit e2f6542e1ebbd15977b47c86d2a9ef55fa0c5e9b)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit ac1fdfe2258940cf4b7003d816b0e1723ed8963c
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Tue Feb 5 14:04:12 2019 -0300

    Bug 17746: Make koha-reset-passwd user set_password.pl
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 0cd4ca289bd2e1bd11fdbd015225a909971ce213)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit df86121423c4770fe6d4971efeb5341e5a0b8825
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Wed Mar 20 16:24:42 2019 +0000

    Bug 22550: OPAC suggestion form doesn't require mandatory fields
    
    Test plan:
    1. OPAC->login->your purchase suggestions->New purchase suggestion
    2. Click button "Submit your suggestion" directly without filling in any field.
       Empty suggestion record was added succeffully.
    3. Apply the patch.
    4. Click button "Submit your suggestion" directly without filling in any field.
       The required fields should be labeled in red.
       (you can change the mandatory fields by preference 'OPACSuggestionMandatoryFields')
    
    Signed-off-by: Bin Wen <bin.wen at inlibro.com>
    
    Signed-off-by: Jogiraju,T. <rajujogi.t at gmail.com>
    
    Signed-off-by: Jogiraju,T. <rajujogi.t at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 28e7f1d4e7a114b04d6940463f47351466a638dd)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 4c095218790767f14a9edae4386174b53a752b44
Author: Ere Maijala <ere.maijala at helsinki.fi>
Date:   Tue Mar 12 11:29:33 2019 +0200

    Bug 22495: Restore Elasticsearch mapping for su-geo
    
    Test plan:
    1. Reset mappings
    2. Run perl misc/search_tools/rebuild_elastic_search.pl -d -b -v
    3. Do a search and verify that the Places facet works
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 53b059afbb5731373a92a3ebaaceea4e1d656363)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 9ef8a3e328e281bef98fe33a50f975322c26c25a
Author: Ere Maijala <ere.maijala at helsinki.fi>
Date:   Mon Dec 17 16:22:58 2018 +0200

    Bug 21974: Make Elasticsearch connection settings configurable
    
    Default settings are appended in get_elasticsearch_params so that there's a central place for them. Defaults can be overridden in koha-conf.xml.
    
    Test plan:
    
    1. Verify that searches still work with the patch applied.
    2. Verify that search fails after adding the following under <elasticsearch> in koha-conf.xml:
    <cxn_pool>Static</cxn_pool>
    3. Verify that search fails after adding the following under <elasticsearch> in koha-conf.xml:
    <cxn_pool>FOO</cxn_pool>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 65f35447e93008810cec3eba63a286b9940d5824)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit c1d1880aeaf58052bc7782b30f57745a4bb78045
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon Mar 25 12:58:39 2019 +0000

    Bug 21622: (RM follow-up) adjust for changes from bug 21282
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 18f9c3eb514f5733c55d92b16bd0f38d29161290)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit aa631b60e49f128bf7bbbe91e248f0af03e5f656
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Feb 27 14:49:35 2019 -0300

    Bug 21998: Silent tests
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit e9fa69ca64e78cc9ea540e3fed1e9ffb1b3488fe)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit e180d8f46074a5088d517b154cd34526f3466d96
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Tue Dec 18 11:53:21 2018 +0000

    Bug 21998: Throw exception on bad pattern
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit ee73d577ed564d98e77cf25fcdadcbc594f7217c)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 49d3cd6a7bcca45fbd5954ee49a4d13ba6224f22
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Wed Sep 19 15:36:36 2018 +0200

    Bug 21998: Add pattern parameter in Koha::Token
    
    Allow a pattern too in Koha::Token->generate. Only supported length.
    Does not affect CSRF calls. So tiny change without further impact.
    
    Test plan:
    Run  t/Token.t
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit b794643bb075c0aa5de81f2481ae1df56f674309)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit b875f2668d9605b90d7d2acb0ea8ec4da2f62fec
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Tue Feb 26 09:16:05 2019 +0000

    Bug 19661: (follow-up) Use Basic auth in tests
    
    Test plan:
    
    prove t/db_dependent/api/v1/acquisitions_funds.t
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 48484173e26bf9859984860a17089f09de5c8b6a)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 58497e1bc5de57fa1a9c20a7502714cc9e2bd3fd
Author: Matthias Meusburger <matthias.meusburger at biblibre.com>
Date:   Tue Jan 15 10:46:04 2019 +0100

    Bug 19661: Add and change properties and parameters to conform to the funds RFC.
    
    Also, perform an exact search when searching on the fund owner id.
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 6e98cc4503cedba411371d4005be41b5822569c8)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 70d465be6a43b45807b769725b48d5654c606e71
Author: Matthias Meusburger <matthias.meusburger at biblibre.com>
Date:   Wed Jan 17 11:49:14 2018 +0100

    Bug 19661: Use Koha::Acquisition::Funds instead of C4::Budgets
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit b6be4024196c9e62363eabf0d2ad0b9f9141d15c)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit f4d9c3ae9f79b40eadae34b74b78adbb4ae43a06
Author: Matthias Meusburger <matthias.meusburger at biblibre.com>
Date:   Thu Oct 12 07:55:12 2017 +0000

    Bug 19661: REST API - Funds Endpoint
    
    This patch adds a new route to the REST api:
    
    /api/v1/acquisitions/funds/
    
    Signed-off-by: David Bourgault <david.bourgault at inlibro.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 717975abebe938a5e79ffc07055ed6190b43f206)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 6826b12c74a345e50306add57061493beab7096b
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Mar 22 19:20:55 2019 +0000

    Bug 21948: Compiled CSS
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 7a9a8f2f08e4b74af712d59e1f1f9f0a7b3205a0)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit a0cefc86535244b0a603506daf5633a096d5c043
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue Dec 4 19:53:29 2018 +0000

    Bug 21948: Clean up style of item detail page
    
    This patch removes some page-specific style from the item detail page in
    the staff client and adds some markup in order to trigger a more
    generally-used style.
    
    This patch also adds a font-awesome icon to the "Edit item" link on the
    page.
    
    To test, apply the patch and regenerate the staff client CSS. Open a
    bibliographic record and view the "Items tab."
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 32020105e8494ba82a8a505711c5047560c9d304)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 .../BasketGroups.pm => Exceptions/Token.pm}        |   35 +++--
 Koha/REST/V1/Acquisitions/Funds.pm                 |  134 ++++++++++++++++++++
 Koha/SearchEngine/Elasticsearch.pm                 |   13 +-
 Koha/Token.pm                                      |   22 +++-
 acqui/ordered.pl                                   |    2 +-
 acqui/spent.pl                                     |    4 +-
 admin/searchengine/elasticsearch/mappings.yaml     |   19 +++
 api/v1/swagger/definitions.json                    |    3 +
 api/v1/swagger/definitions/fund.json               |  101 +++++++++++++++
 api/v1/swagger/parameters.json                     |    5 +-
 api/v1/swagger/parameters/fund.json                |    9 ++
 api/v1/swagger/paths.json                          |    3 +
 api/v1/swagger/paths/acquisitions_funds.json       |   73 +++++++++++
 api/v1/swagger/x-primitives.json                   |    6 +
 circ/pendingreserves.pl                            |   12 +-
 debian/scripts/koha-reset-passwd                   |   61 ++++++---
 .../intranet-tmpl/lib/koha/cateditor/widget.js     |    2 +-
 .../intranet-tmpl/prog/css/src/staff-global.scss   |   16 ---
 koha-tmpl/intranet-tmpl/prog/css/staff-global.css  |    2 +-
 .../prog/en/includes/cateditor-widgets-marc21.inc  |   33 ++++-
 .../prog/en/modules/catalogue/moredetail.tt        |   12 +-
 .../prog/en/modules/circ/pendingreserves.tt        |   51 +++++++-
 .../bootstrap/en/modules/opac-memberentry.tt       |    8 +-
 .../opac-tmpl/bootstrap/en/modules/opac-passwd.tt  |    7 +-
 .../bootstrap/en/modules/opac-password-recovery.tt |   12 +-
 .../bootstrap/en/modules/opac-suggestions.tt       |    2 +-
 misc/admin/set_password.pl                         |  129 +++++++++++++++++++
 t/Token.t                                          |   14 +-
 t/db_dependent/api/v1/acquisitions_funds.t         |   84 ++++++++++++
 29 files changed, 781 insertions(+), 93 deletions(-)
 copy Koha/{Acquisition/BasketGroups.pm => Exceptions/Token.pm} (57%)
 create mode 100644 Koha/REST/V1/Acquisitions/Funds.pm
 create mode 100644 api/v1/swagger/definitions/fund.json
 create mode 100644 api/v1/swagger/parameters/fund.json
 create mode 100644 api/v1/swagger/paths/acquisitions_funds.json
 create mode 100755 misc/admin/set_password.pl
 create mode 100644 t/db_dependent/api/v1/acquisitions_funds.t


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Mon Apr  1 16:27:23 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Mon, 01 Apr 2019 14:27:23 +0000
Subject: [koha-commits] main Koha release repository branch 18.11.x updated.
	v18.11.04-35-g1c31c10
Message-ID: <E1hAxuF-00064I-Nc@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  1c31c10539d2393ab640e103fe8829e6422e4717 (commit)
       via  a7738f6177477baef332ddf8b13d85d1186e8cf6 (commit)
       via  a1ff8ba5e1de2047e8e5ee6afd268a7c2a889e91 (commit)
       via  22d46b5d307f64fb7a4e2a553624ed42e6566bab (commit)
       via  9cf4f1a30d0aeb62bd3c37504c6ab447bedf778e (commit)
       via  701aec8443e99268f12ad0a3f54c48cee16b9d7d (commit)
       via  ab1895b1adc2d2175907e2ca922b22df00dec3fe (commit)
       via  1a4a1170eedc79723cf46f6b44f82198702330e2 (commit)
       via  8192499d5b5e72a3d3ced773378dfa9f8df82dba (commit)
       via  cb724e71474b7d4f998a1a4996c9971ac9a86de2 (commit)
       via  3736f2f1888d246947c09f220a9db474b0452c36 (commit)
       via  0a1b3d10843c6e9dcfd208810dfc24c224f29647 (commit)
       via  34dba63bfe8d6ce4b5b1838b07581b629cac9f33 (commit)
       via  b37bb2bbada259602c4f66922bd673d4dbcc4438 (commit)
      from  16e250542de43eadf62bc9354329912be84c3420 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 1c31c10539d2393ab640e103fe8829e6422e4717
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Mar 29 13:17:14 2019 +0000

    Bug 13895: (follow-up) Add Modern::Perl
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 94206510d7a7641e0e283738f56249c90f7d632e)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit a7738f6177477baef332ddf8b13d85d1186e8cf6
Author: Lucas Gass <lucas at bywatersolutions.com>
Date:   Tue Mar 26 11:17:31 2019 +0000

    Bug 22586: IntranetReportsHomeHTML no longer renders as HTML on reports-home.pl
    
    As of 18.11 the IntranetReportsHomeHTML syspref no longer renders HTML
    on report-home.pl. I think this is being filtered wrong in the template.
    
    Test Plan:
    
    1) Edit IntranetReportsHomeHTML, set to "<p>Test</p>"
    2) View a report, note that you see the html p tags are displayed
    litterly
    3) Apply this patch
    4) Reload the page
    5) Note the p tags are rendered as html
    
    Signed-off-by: George Williams <george at nekls.org>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 7aaa10e0922b21f1c9ed40ede0d3dfc0a63c2832)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit a1ff8ba5e1de2047e8e5ee6afd268a7c2a889e91
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Wed Mar 27 15:37:51 2019 +0100

    Bug 22596: use raw TT filter in items search with custom field
    
    When items search is with a custom field using authorised values, html TT filter is breaking the JS, it should use raw.
    
    Test plan :
    1) Go to Administration > Item search fields
    2) Define a search field with an authorised values category
    3) Go to items search
    4) Use the "New field" link
    5) Check use of custom field is OK
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit eb7e0f018c479024f0ceacb9f0c235b556ec2979)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 22d46b5d307f64fb7a4e2a553624ed42e6566bab
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Wed Mar 27 14:23:18 2019 -0300

    Bug 13895: (QA follow-up) Make the class plural
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit eabcec1d6c172e0e590aa497eae0c264bcd2b5dc)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 9cf4f1a30d0aeb62bd3c37504c6ab447bedf778e
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Wed Mar 13 16:25:38 2019 +0000

    Bug 13895: Fix test
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 583328e3f8c2e1827419185628069ad8c9979943)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 701aec8443e99268f12ad0a3f54c48cee16b9d7d
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Wed Mar 13 16:03:09 2019 +0000

    Bug 13895: Adapt naming according to voted RFC
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit a142369b309068ed2ba5d34f033f4e047483401d)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit ab1895b1adc2d2175907e2ca922b22df00dec3fe
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Mon Feb 25 22:17:01 2019 +0000

    Bug 13895: (follow-up) Fix POST response
    
    Test plan:
    prove t/db_dependent/api/v1/chcekouts.t
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 47ad7afccaf1ca0ae7b8dbfad9998aaac6d9a938)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 1a4a1170eedc79723cf46f6b44f82198702330e2
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Thu Feb 21 00:26:17 2019 +0000

    Bug 13895: Change renewal endpoint
    
    Instead of PUT on /checkout/{checkout_id} endpoint, you should now call
    POST on /checkouts/{checkout_id}/renewal
    
    Test plan:
    prove t/db_dependent/api/v1/checkouts.t
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 95d23bc3c38f3cd6a4e6be3aac451c3899cccc83)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 8192499d5b5e72a3d3ced773378dfa9f8df82dba
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Thu Feb 21 00:15:22 2019 +0000

    Bug 13895: Refactor test using REST Basic auth
    
    Test plan:
    prove t/db_dependent/api/v1/checkouts.t
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit a0148b440a4f05c6a6d216c85b03ea502b0da95b)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit cb724e71474b7d4f998a1a4996c9971ac9a86de2
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Wed Feb 20 21:42:36 2019 +0000

    Bug 13895: Remove create_item and create_biblio subs from test
    
    Test plan:
    prove t/db_dependent/api/v1/checkouts.t
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit a7e704382fa97ba08c8d2d57f6a818e76e858770)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 3736f2f1888d246947c09f220a9db474b0452c36
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Wed Feb 20 21:30:49 2019 +0000

    Bug 13895: Remove the opac checks in privileged endpoint
    
    Test plan:
    prove t/db_dependent/api/v1/checkouts.t
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 4672e6e6c40cf595da7e836525e5b6e486f78efe)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 0a1b3d10843c6e9dcfd208810dfc24c224f29647
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Mon Feb 4 14:22:54 2019 +0000

    Bug 13895: (follow-up) Adapt checkout endpoint to openapi, update terminology
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 1dfb57164fd6d986b110caa695a3baf9800ff93a)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 34dba63bfe8d6ce4b5b1838b07581b629cac9f33
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Nov 10 16:16:49 2017 -0300

    Bug 13895: (QA follow-up) Adjust OpenAPI definitions for checkouts
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit b63fd774c181b96e514122c0d693f222b99b1cdd)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit b37bb2bbada259602c4f66922bd673d4dbcc4438
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Mon Mar 23 13:10:46 2015 +0100

    Bug 13895: Add API routes for checkouts retrieval and renewal
    
    GET /checkouts?borrowernumber={borrowernumber}
    GET /checkouts/{checkout_id}
    PUT /checkouts/{checkout_id}
    
    + unit tests in t/db_dependent/api/v1/checkouts.t
    
    Test plan:
    1. Open a browser tab on Koha staff and log in (to create CGISESSID
       cookie). You should have permission circulate_remaining_permissions.
    2. Go to http://yourlibrary/api/v1/checkouts?borrowernumber=XXX (replace
       XXX with a borrowernumber that has checkouts) and check you receive
       correct data
    3. Go to http://yourlibrary/api/v1/checkouts/YYY (replace YYY with an
       existing checkout id) and check you receive correct data
    4. Send PUT requests to http://yourlibrary/api/v1/checkouts/YYY until
       the maximum number of renewals is reached (you should have a 403
       error)
    5. Run unit tests in t/db_dependent/api/v1/checkouts.t
    
    Depends on bugs 16699 and 14868
    
    Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>
    
    Signed-off-by: Lari Taskula <larit at student.uef.fi>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit e3f2e346f884e2ba6e4a8f43709955f776a259de)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/REST/V1/Checkouts.pm                          |  211 ++++++++++++++++++++
 Koha/Schema/Result/Issue.pm                        |    5 +
 api/v1/swagger/definitions.json                    |    6 +
 api/v1/swagger/definitions/checkout.json           |   69 +++++++
 .../definitions/{holds.json => checkouts.json}     |    2 +-
 api/v1/swagger/parameters.json                     |    3 +
 api/v1/swagger/parameters/checkout.json            |    9 +
 api/v1/swagger/paths.json                          |    9 +
 api/v1/swagger/paths/checkouts.json                |   96 +++++++++
 .../prog/en/modules/catalogue/itemsearch.tt        |    2 +-
 .../prog/en/modules/reports/reports-home.tt        |    3 +-
 t/db_dependent/api/v1/checkouts.t                  |  156 +++++++++++++++
 12 files changed, 568 insertions(+), 3 deletions(-)
 create mode 100644 Koha/REST/V1/Checkouts.pm
 create mode 100644 api/v1/swagger/definitions/checkout.json
 copy api/v1/swagger/definitions/{holds.json => checkouts.json} (58%)
 create mode 100644 api/v1/swagger/parameters/checkout.json
 create mode 100644 api/v1/swagger/paths/checkouts.json
 create mode 100644 t/db_dependent/api/v1/checkouts.t


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Mon Apr  1 17:56:30 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Mon, 01 Apr 2019 15:56:30 +0000
Subject: [koha-commits] main Koha release repository branch 18.05.x updated.
	v18.05.11-7-g1212797
Message-ID: <E1hAzIU-0000fm-60@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  12127972ad15bfd71d764c4db5dd5afa7638f487 (commit)
       via  66550615441e84a00d5252018697baca20c5bf11 (commit)
      from  c15a41bcddcd052d3e8f79af35cb2c4118e567a8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 12127972ad15bfd71d764c4db5dd5afa7638f487
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Wed Mar 20 15:52:07 2019 +0000

    Bug 13763: (follow-up) Strip leading whitespace characters from input barcode
    
    this makes the work with barcodes from input consistant on checking out,
         checking in and renewing
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 28ff4f6393e65ebfca60c05611fafc926f1fb239)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 2712e1ee55208332db4ec01310f58b8fa0b882c6)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit 66550615441e84a00d5252018697baca20c5bf11
Author: Hayley Mapley <hayleymapley at catalyst.net.nz>
Date:   Thu Mar 14 04:58:31 2019 +0000

    Bug 13763: Added check for filter syspref in renew.pl
    
    In Circulation->Renew, the renew feature does not check the system
    preference itemBarcodeFilter to see whether the barcode needs to be
    converted. This patch fixes this, adding a check for the system pref and
    applying it accordingly to convert the barcode if it is needed.
    
    Test plan:
    1) In Circulation->Renew, enter a barcode that you know exists in the
    catalogue but add extra spaces, breaking up the barcode. Note that this
    fails with a warning that says 'No item matches this barcode'
    
    2) In system Preferences, set the itemBarcodeInputFilter pref to Remove
    spaces and repeat step1. Note that the result is the same as in step 1
    
    3) Apply the patch
    
    4) Repeat step 1, and note that the filter removes the spaces and the
    item is renewed (or gives an error that indicates it recognises the
    barcode)
    
    Sponsored-by: Catalyst IT
    Signed-off-by: Bin Wen <bin.wen at inlibro.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 48e9082043115416063e66217db60f0054b68088)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 4505ad4dc52c5384866c157c08ba6a5a6c95a619)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 circ/renew.pl |    2 ++
 1 file changed, 2 insertions(+)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Mon Apr  1 17:59:45 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Mon, 01 Apr 2019 15:59:45 +0000
Subject: [koha-commits] main Koha release repository branch 18.05.x updated.
	v18.05.11-9-gde8cf34
Message-ID: <E1hAzLd-0000lw-Pf@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  de8cf34eb76d434b780032cb3bd812b5baff3444 (commit)
       via  3b01a0b0029a6ee01275a54efa294d9a03a9e5f4 (commit)
      from  12127972ad15bfd71d764c4db5dd5afa7638f487 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit de8cf34eb76d434b780032cb3bd812b5baff3444
Author: Blou <philippe.blouin at inlibro.com>
Date:   Tue Sep 11 14:42:03 2018 -0400

    Bug 21130: (Follow up OPAC Results) Prevent HTML class from being translated
    
    This fixes the same issue where "title" is being translated (in fr-CA at least) and thus
    break the javascript impacting the result display in the OPAC
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 5334e0f32a8b93c407c2bfc931397a0ae70b8d64)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit afce1b2a92ba186db56ed225d2b242158be4bd0c)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit 3b01a0b0029a6ee01275a54efa294d9a03a9e5f4
Author: David Bourgault <dav.bour at gmail.com>
Date:   Fri Jul 27 17:13:42 2018 -0400

    Bug 21130: Prevent HTML class from being translated
    
    Adds a xsl:value-of tag to prevent the value from being translated.
    
    TEST PLAN
    0) Apply patch
    1) Translate
    2) In the opac, div.record has not changed
    
    NOTE:
    I don't know if this bug affects all translations, I noticed it when translating to fr-CA.
    The fix will work for all languages.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit e64fb90311a9f2b37b49fc670962089cbb3d32de)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 84787c1eee9db11f779273ba5f83ddd4d8f91efb)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl  |    2 +-
 koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Mon Apr  1 18:03:35 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Mon, 01 Apr 2019 16:03:35 +0000
Subject: [koha-commits] main Koha release repository branch 18.05.x updated.
	v18.05.11-10-g8779029
Message-ID: <E1hAzPL-0000wH-Hu@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  87790299605e2d1fad5f781ebc7ff9b180294dbf (commit)
      from  de8cf34eb76d434b780032cb3bd812b5baff3444 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 87790299605e2d1fad5f781ebc7ff9b180294dbf
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Wed Feb 6 02:02:11 2019 +0000

    Bug 13735: Update PrepareItemrecordDisplay to use maxlength
    
    The PrepareItemrecordDisplay method used to generate the item
    display on receiving serials was using a hardcoded maxlength
    of 255 on input fields. This patch updates it to use the
    maxlength defined in the frameworks instead as the normal
    item form does.
    
    To test:
    - Create or reuse an existing subscription
    - Make note of the framework the record uses
    - Add an item on receive
    - Check the maxlength on the various fields is set to 255
      (check source code or use developer tools)
    - You can also verify that by adding a long note to
      one of the note fields
    - Apply patch
    - Repeat tests, the maxlength should now be 9999
    - In your framework settings, change the length of one
      of the subfields to another value
    - Verify that the item form reflects the change
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 0429aadc217f05a98bbaa51f955b835ac552fd7a)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 1c267af1438d31a967593f942321d040cd26d34e)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Items.pm |   14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Mon Apr  1 18:41:44 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Mon, 01 Apr 2019 16:41:44 +0000
Subject: [koha-commits] main Koha release repository branch 18.05.x updated.
	v18.05.11-13-g9fe361a
Message-ID: <E1hB00G-0002FW-Gv@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  9fe361a491ebf82697ab1e4b6d439f218f300623 (commit)
       via  c6651b872421cce5415694fbf173c38a094c1321 (commit)
       via  a12ad9f12260bed9732bcaa4b663c109a3b4572e (commit)
      from  87790299605e2d1fad5f781ebc7ff9b180294dbf (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 9fe361a491ebf82697ab1e4b6d439f218f300623
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Wed Feb 20 11:26:40 2019 -0300

    Bug 17746: (QA follow-up) Make set_password.pl generate a password if required
    
    This patch makes the set_password.pl script generate the password if it
    is not passed as an argument.
    
    It also changes the behaviour of set_password.pl: it will now print the
    userid and password (generated or not) to mimick the behaviour from
    koha-reset-passwd.
    
    The koha-reset-passwd gets simplified as it doesn't generate the random
    password anymore, it passes the responsability to set_password.pl
    
    To test:
    - Follow the steps from the original platch
    - Verify all behaves as expected
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 3ef48c8708736e9d5b16e462e520302c007cb4c1)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 3b423071227ee3f9300907bb9e89cff26012aa29)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit c6651b872421cce5415694fbf173c38a094c1321
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Feb 4 15:09:34 2019 -0300

    Bug 17746: Add misc/admin/set_password.pl script
    
    This patch introduces a script that allows changing a patron's password.
    The change overrides the defined password enforcement policy.
    
    If multiple conditions are passed to match on the patron, they all need
    to match. Otherwise an error message is printed.
    
    Attributes to search the patron on:
    - cardnumber
    - patron_id (a.k.a. borrowernumber)
    - userid
    
    we usually know some of them, but if we specify more than one, they need
    to match a patron, together.
    
    To test:
    1) Apply this patch
    2) Have a known patron (i.e. you know the cardnumber, the borrowernumber
       and the userid).
    3) Run:
      $ kshell
     k$ perl misc/admin/set_password.pl --cardnumber <the_card_number> \
                                        --password a_password
    4) Verify you can login with the new password
    5) Repeat 3) through 5) with --patron_id and --userid
    => SUCCESS: You can login in all cases
    6) Try combining some or all the parameters
    => SUCCESS: It fails when it should, it succeeds when it should
    7) Sign off :-D
    
    Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit e2f6542e1ebbd15977b47c86d2a9ef55fa0c5e9b)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 54de33967101173c72865e97fce0fd220e2d0842)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit a12ad9f12260bed9732bcaa4b663c109a3b4572e
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Tue Feb 5 14:04:12 2019 -0300

    Bug 17746: Make koha-reset-passwd user set_password.pl
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 0cd4ca289bd2e1bd11fdbd015225a909971ce213)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit ac1fdfe2258940cf4b7003d816b0e1723ed8963c)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 debian/scripts/koha-reset-passwd |   61 ++++++++++++------
 misc/admin/set_password.pl       |  129 ++++++++++++++++++++++++++++++++++++++
 2 files changed, 171 insertions(+), 19 deletions(-)
 create mode 100755 misc/admin/set_password.pl


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Mon Apr  1 18:51:30 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Mon, 01 Apr 2019 16:51:30 +0000
Subject: [koha-commits] main Koha release repository branch 18.05.x updated.
	v18.05.11-14-g061e95f
Message-ID: <E1hB09i-0002bt-Jl@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  061e95f4b170053b395830e29d9c959abcb0bd43 (commit)
      from  9fe361a491ebf82697ab1e4b6d439f218f300623 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 061e95f4b170053b395830e29d9c959abcb0bd43
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Fri Mar 22 12:57:31 2019 +0000

    Bug 22561: Forgotten password requirements hint doesn't list all rules for new passwords
    
    This patch modifies a few templates in the OPAC so that all available
    information on password requirements is displayed for each case where
    the patron is setting a password:
    
     - If the RequireStrongPassword system preference is set, a message
       should appear listing strong password requirements and minimum
       password length.
     - If RequireStrongPassword is not set, the message should only ask for
       a minimum password length.
    
    To test, apply the patch and enable the PatronSelfRegistration and
    OpacResetPassword preferences.
    
    On the following pages, test with RequireStrongPassword both on and
    off. The correct messages should appear.
    
     - OPAC -> Forgot password. Follow the process to reset your password
       until you reach the step where you are entering the new password.
     - OPAC -> Register here. Check the password section of the registration
       form.
     - OPAC -> Log in -> Change your password.
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 50be1c4006e0a1d7e3b537bd849bc77f7a6bb56f)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit e3e64974d830a8699e8648a82d21a7ffce502955)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt   |    8 ++++++--
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-passwd.tt        |    7 ++++++-
 .../opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt   |    8 ++++++--
 3 files changed, 18 insertions(+), 5 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Mon Apr  1 18:55:53 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Mon, 01 Apr 2019 16:55:53 +0000
Subject: [koha-commits] main Koha release repository branch 18.05.x updated.
	v18.05.11-15-g3ade1f5
Message-ID: <E1hB0Dx-0002k9-QN@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  3ade1f52cd4ef73e44997726f8de56d0a9cac810 (commit)
      from  061e95f4b170053b395830e29d9c959abcb0bd43 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 3ade1f52cd4ef73e44997726f8de56d0a9cac810
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Fri Mar 22 13:19:51 2019 +0000

    Bug 22560: Forgotten password "token expired" page still shows boxes to reset password
    
    This patch modifies the OPAC password recovery template so that the new
    password entry form doesn't appear if the patron has followed an invalid
    or expired link.
    
    This patch also corrects the markup in the page title.
    
    To test, apply the patch and follow the process for resetting a
    forgotten password. When you follow the password recovery link, modify
    the URL so that the "uniqueKey" parameter is different.
    
    The page should show an error message. The password entry form should
    not appear.
    
    Check the page title in the browser's title bar. It should look correct.
    
    https://bugs.koha-community.org/show_bug.cgi?id=22520
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 7ac1457ffc27cf6ec5a3a7bab6abc8a010e02b6a)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 34e0f9874f91b22c8fd24f76de74bb3c126d2a1e)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Mon Apr  1 18:59:37 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Mon, 01 Apr 2019 16:59:37 +0000
Subject: [koha-commits] main Koha release repository branch 18.05.x updated.
	v18.05.11-16-g9116cba
Message-ID: <E1hB0HZ-0002sO-2k@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  9116cba3506b1129ed4165734a18fb66b3b8191a (commit)
      from  3ade1f52cd4ef73e44997726f8de56d0a9cac810 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 9116cba3506b1129ed4165734a18fb66b3b8191a
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue Mar 19 12:41:26 2019 +0000

    Bug 22536: Display problem in Holds to Pull report
    
    This patch modifies the display of several values in the holds to pull
    report so that they can be displayed as lists instead of as chunks of
    HTML generated in SQL.
    
    This patch modifies the SQL in pendingreserves.pl so that values can be
    formatted in the same way that holding branch is. The better long-term
    solution is to remove SQL from pendingreserves.pl altogether, but this
    is a quick fix.
    
    This patch also makes a couple of minor markup changes to fix
    validation.
    
    To test, apply the patch and go to Circulation -> Holds to pull. To see
    the changes the patch makes your holds to pull list should have titles
    with multiple items at multiple branches, with call number, copy number,
    and enumeration data. These values should all be displayed in bulleted
    lists.
    
    Signed-off-by: David Roberts <david.roberts at ptfs-europe.com>
    Signed-off-by: Bin Wen <bin.wen at inlibro.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 9a321c128fed457bf6d11d2ce7ee7edf7dd28004)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 38bbe82aa07aa9a1a3cc33e00b5b8e459eb28a30)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 circ/pendingreserves.pl                            |   12 ++---
 .../prog/en/modules/circ/pendingreserves.tt        |   51 +++++++++++++++++---
 2 files changed, 50 insertions(+), 13 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Mon Apr  1 19:04:29 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Mon, 01 Apr 2019 17:04:29 +0000
Subject: [koha-commits] main Koha release repository branch 18.05.x updated.
	v18.05.11-18-gc8eee1b
Message-ID: <E1hB0MH-00038p-3C@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  c8eee1b25761c5f3867fffc48c2e03ceab56e4ce (commit)
       via  b25c4196b8174b375d8c13ccb8dee145c5d784b6 (commit)
      from  9116cba3506b1129ed4165734a18fb66b3b8191a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c8eee1b25761c5f3867fffc48c2e03ceab56e4ce
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Fri Mar 8 10:12:50 2019 +0100

    Bug 21049: Set 007/00 when selecting material type (Rancor)
    
    There is a 1-1 relationship between the material type values and the
    position 00 of 007 field. Selecting a material type should set this
    position's value.
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 856425db1e156ee4faf1aae70b0a78845711ba43)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 16e250542de43eadf62bc9354329912be84c3420)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit b25c4196b8174b375d8c13ccb8dee145c5d784b6
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Wed Mar 6 08:43:18 2019 +0100

    Bug 21049: Fix value of material select for Rancor 007 widget
    
    The material type is selected in accordance with position 0 of 007
    
    Test plan:
    1. Create a new record using the advanced editor
    2. Select a material type for field 007 and set at least the position 0
       of this field
    3. Save the record and reload the page
    4. The material type should remain selected
    5. Try with all available material types
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit e85294a738da7cce2a4897998ffa795f977b4cd7)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit d5aa7655a643a5a4868a47b8aae5371438993580)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 .../intranet-tmpl/lib/koha/cateditor/widget.js     |    2 +-
 .../prog/en/includes/cateditor-widgets-marc21.inc  |   33 +++++++++++++++++++-
 2 files changed, 33 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Fri Apr  5 15:24:49 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Fri, 05 Apr 2019 13:24:49 +0000
Subject: [koha-commits] main Koha release repository branch master updated.
	v18.11.00-1025-g41e0ff7
Message-ID: <E1hCOpt-0007lY-3j@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  41e0ff7cd6240c2c9ba2d1bec816b191ef091eb1 (commit)
       via  3eee6f3091fcb621152af7f4db6441c98cb74558 (commit)
       via  c786e4de2369de34ce26610309cbce53534446d3 (commit)
       via  29dd8d62943c303c60284e0430b1b7230891b97a (commit)
       via  fc188dfc825eb81fb6969305e8945b95138cbd41 (commit)
       via  8629a11601371a0c20505c5b1f70a45745068e02 (commit)
       via  54cf1df239e3b83ae5550e3ef499038dd5597d95 (commit)
       via  0e0a3173859d4374087e99e1a7cd929c8da61c76 (commit)
       via  05e49e6be98723f67ec85a5843fad1fc9787925f (commit)
       via  40503c8fa86e6c4480ec8ca59e28f0c6f394502d (commit)
       via  b1c70a3c7e667137e54c88a2e02b5ca5ad5ee10b (commit)
       via  ced69febf3de17691d885e9ee7e03ef46c28b2ae (commit)
       via  cf95f0a7e6897d3dc4b90c92ffad19230379d7cb (commit)
       via  a5fcd93f72687e946d9bfbdc2541ed4a18704125 (commit)
       via  f6bc67e851722451a970d085f51fb11fb03e21b3 (commit)
      from  6666918dd661b0207366becefd1480257197a353 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 41e0ff7cd6240c2c9ba2d1bec816b191ef091eb1
Author: Hayley Mapley <hayleymapley at catalyst.net.nz>
Date:   Thu Mar 7 20:28:48 2019 +0000

    Bug 21003: Made Edit keywords more consistent in add_items-step2.tt
    
    When adding a course reserve with a barcode that already exists, the
    title, breadcrumbs, and legend of the form all specify that the user is
    editing, and not adding, the book.
    
    Test plan:
    Same as comment 1
    
    Signed-off-by: Devinim <kohadevinim at devinim.com.tr>
    Signed-off-by: Bin Wen <bin.wen at inlibro.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 3eee6f3091fcb621152af7f4db6441c98cb74558
Author: Hayley Mapley <hayleymapley at catalyst.net.nz>
Date:   Thu Mar 7 02:50:12 2019 +0000

    Bug 21003: Removed warning and changed wording on add_items-step2.tt
    
    When editing an item in a Course Reserve, the page displayed is the same
    that is displayed when adding an item to a Course Reserve. This patch
    removes the warning 'This course already has this item on reserve' when
    the item is being edited, as well as changes the title, breadcrumbs, and
    header of the div. This patch also Changes the header of the div to say
    'Edit 'book_name' in 'course_name'' instead of 'Add 'book_name' to
    'course_name'' when adding items to a course reserve if the item is
    already present.
    
    To test:
    1) Create a new course in Course Reserves (you will need Course
        Reserves enabled in syspref)
    2) Add an item by clicking the Add reserves button
    3) Click the edit button on the right hand side of the item listing
    under the Reserves heading
    4) Observe that the warning 'The course already has this item on reserve' appears, and that the title, breadcrumbs and
    header of the div all say Add/Reserve
    5) Apply the patch
    6) Repeat step 3 and observe that the title, breadcrumbs and header of
    the div now say Edit
    7) Also verify that when adding a reserve with a barcode that does not
    yet exist in the course reserves that the warning 'The course already...' is not displayed and that the header of the div says Add
    8) Finally verify that when adding a reserve with a barcode that DOES
    exist in the course reserves that the warning 'The course already...' IS
    displayed and the header of the div says Edit
    9) Sign off!
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit c786e4de2369de34ce26610309cbce53534446d3
Author: Hayley Mapley <hayleymapley at catalyst.net.nz>
Date:   Thu Mar 14 03:47:59 2019 +0000

    Bug 12441: Search.pl conditional checks and displays using same syspref
    
    Script search.pl checks OPACdefaultSortField and OPACdefaultSortOrder, but
    shows defaultSortField and defaultSortOrder when using Advanced Search
    in the staff client.
    
    Test plan:
    Apply the patch and then check that the Advanced Search uses
    defaultSortOrder and defaultSortField sysprefs instead of the OPAC
    sysprefs in the conditional. Check that sort behaviour in Advanced
    Search still functions as expected. (It should do - this doesn't change
    what displays, just improves consistency).
    
    Sponsored-by: Catalyst IT
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 29dd8d62943c303c60284e0430b1b7230891b97a
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Sat Mar 23 09:43:47 2019 +0000

    Bug 13782: Compiled CSS
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit fc188dfc825eb81fb6969305e8945b95138cbd41
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Fri Mar 22 18:16:33 2019 +0000

    Bug 13782: RSS for news needs a bit of styling
    
    This patch makes a number of updates to the display of news in the OPAC.
    I hope that this makes OPAC news nicer/easier to read. It includes style
    changes to make the RSS link look better too.
    
    To test, apply the patch and regenerate the OPAC CSS. You should have
    multiple active news items. View the OPAC news with varied values of
    NewsAuthorDisplay and OpacNewsLibrarySelect.
    
    Test the single news item view. Test with Quotes on and off, and with
    OpacMainUserBlock populated or not.
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 8629a11601371a0c20505c5b1f70a45745068e02
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Fri Mar 22 16:43:51 2019 +0000

    Bug 22568: Replace RSS icon in the OPAC with Font Awesome
    
    This patch removes the RSS icon image (feed-icon-16x16.png) from the
    OPAC and replaces it with Font Awesome icons styled to match.
    
    To test, apply the patch and regenerate the OPAC CSS. View the
    following pages, confirming that the RSS icon looks correct:
    
     - OPAC home page (RSS news icon)
     - Search results page (Subscribe to search)
     - Recent comments
     - Search history
     - Lists -> View list
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 54cf1df239e3b83ae5550e3ef499038dd5597d95
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Thu Mar 7 16:04:25 2019 +0000

    Bug 22475: Shelving location doesn't appear on tags list view
    
    This patch corrects the tags list view so that shelving location appears
    correctly. Previously the template tried to display a variable which was
    empty.
    
    To test, apply the patch and locate an title which has both a tag
    applied to it and a shelving location defined for one or more items. Go
    to Tools -> Tags and click the tag to view titles with that tag. In the
    location column of the table the shelving location should appear along
    with library and call number.
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 0e0a3173859d4374087e99e1a7cd929c8da61c76
Author: Bj?rn Nyl?n <bjorn.nylen at ub.lu.se>
Date:   Thu Mar 28 10:28:29 2019 +0100

    Bug 10345: Increment copy number when adding multiple copies.
    
    To test:
    1. Add multiple copies of an item with data in the 'Copy number' field. Note that tha data will be identical for all items.
    2. Apply patch.
    3. Add multiple copies of an item with a positive integer (ie. only digits) in the 'Copy number' field. Note that the copy number is incremented for each item.
    4. Add multiple copies of an item with some other type of data in the 'Copy number' field. Note that the copy number field remains unchanged for the added items.
    
    Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 05e49e6be98723f67ec85a5843fad1fc9787925f
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Tue Apr 2 09:57:35 2019 +0200

    Bug 22620: OPAC description for CCODE in opac-reserve.tt
    
    Bug 20450 added CCODE to opac-reserve.tt using AuthorisedValues TT plugin.
    
    This patch changes the plugin call so that it requests OPAC description.
    
    Test plan :
    1) Define a CCODE with staff and OPAC descriptions
    2) Apply this collection on an item
    3) At OPAC, place an hold on this item
    4) Verify the collection display correctly OPAC description and not staff description
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 40503c8fa86e6c4480ec8ca59e28f0c6f394502d
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue Mar 26 14:11:28 2019 +0000

    Bug 22575: Item type administration uses invalid error class for dialog
    
    This patch modifies the item types administration script so that it
    passes a valid message type to the template, where the type is used as a
    CSS class. "Error" is a nonexistent dialog class. It should be "alert."
    
    To test, apply the patch and go to Administration -> Item types.
    
     - Try to delete an item type which is in use. The style of the error
       dialog should be correct.
     - Try to add an item type using a code which already exists. The error
       should look correct.
    
    Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
    Signed-off-by: Bin Wen <bin.wen at inlibro.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit b1c70a3c7e667137e54c88a2e02b5ca5ad5ee10b
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Thu Feb 28 13:12:59 2019 +0000

    Bug 22432: Star ratings plugin replacement missing from a couple pages
    
    This patch modifies two templates to conform to the change to the start
    ratings plugin: Overdrive search results and RecordedBooks search
    results.
    
    On the Overdrive page, the star ratings are now correctly displayed
    using the new plugin. On the RecordedBooks page, star ratings code has
    been removed because it is unused. RecordedBooks doesn't provide ratings
    information in their API.
    
    To test you need credentials for both Overdrive and RecordedBooks. Apply
    the patch and enable both services.
    
     - In the OPAC, perform a search that will return results from Overdrive
       and RecordedBooks.
     - Open the search results for each of those services.
       - On the Overdrive search results page, star ratings should appear
         correctly (in read-only mode).
       - On the RecordedBooks page everything should look the same.
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit ced69febf3de17691d885e9ee7e03ef46c28b2ae
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Sat Mar 23 08:51:15 2019 +0000

    Bug 22607: DBRev 18.12.00.037
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit cf95f0a7e6897d3dc4b90c92ffad19230379d7cb
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Fri Mar 29 08:13:48 2019 +0000

    Bug 22607: Change default value in issues.renewals to '0'.
    
    This patch change renewals column of issues and old_issues tables.
    
    Now it is NOT NULL default 0. It does not make sense when number of
    renewals is undefined, it is always integer with value zero or more
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit a5fcd93f72687e946d9bfbdc2541ed4a18704125
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Tue Apr 2 00:34:43 2019 +0000

    Bug 22619: Fix null empty behaviour for new rules
    
    To test:
     1 - Go to Admin->Circulation and fines rules
     2 - Set All/All rules ot have a limit for Current checkouts allowed (and onsite checkouts allowed)
     3 - Select an itemtype to add a new rule
     4 - Save without entering any values
     5 - Note that new rule displays with the same numebr as the all/all rule
     6 - Check the DB, not no lines were added to circulation_rules table
     7 - Delete the rule from the staff client
     8 - Apply patch
     9 - Repeat, note the new rule is unlimited
    10 - Run selenium tests
    11 - They pass!
    12 - Check no rules/itemtypes are added to your system by the tests
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit f6bc67e851722451a970d085f51fb11fb03e21b3
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Mon Apr 1 12:16:51 2019 +0100

    Bug 22611: Correction for call to get create_item in EDI.pm
    
    There was a typo in the addition of a call to
    effective_create_items causing processing to abort after adding
    a single copy.
    
    This patch reverts to using the C4::Context call as used for the
    first copy created, the intended call to effective_create_items
    is a wrapper around that as the field in the basket is guaranteed
    to be null (its not set when we call AddBasket). Being consistent
    and explicit in what we call should guard against future changes
    in dependencies exposing the logic flaw
    
    Added some comments to make logical flow of code clearer
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha.pm                                            |    2 +-
 Koha/EDI.pm                                        |    6 +-
 admin/itemtypes.pl                                 |   10 +-
 admin/smart-rules.pl                               |    5 +-
 catalogue/search.pl                                |    4 +-
 cataloguing/additem.pl                             |    8 ++
 course_reserves/add_items.pl                       |    2 +
 installer/data/mysql/kohastructure.sql             |    4 +-
 installer/data/mysql/updatedatabase.pl             |   14 +++
 .../en/modules/course_reserves/add_items-step2.tt  |   12 ++-
 .../en/modules/course_reserves/course-details.tt   |    2 +-
 .../intranet-tmpl/prog/en/modules/tags/list.tt     |    5 +-
 koha-tmpl/opac-tmpl/bootstrap/css/opac.css         |    2 +-
 koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss    |   55 +++++++++--
 .../opac-tmpl/bootstrap/en/modules/opac-main.tt    |  102 ++++++++++++--------
 .../bootstrap/en/modules/opac-overdrive-search.tt  |   22 +++--
 .../en/modules/opac-recordedbooks-search.tt        |   10 +-
 .../opac-tmpl/bootstrap/en/modules/opac-reserve.tt |    2 +-
 .../opac-tmpl/bootstrap/en/modules/opac-results.tt |    9 +-
 .../bootstrap/en/modules/opac-search-history.tt    |   16 ++-
 .../opac-tmpl/bootstrap/en/modules/opac-shelves.tt |    2 +-
 .../bootstrap/en/modules/opac-showreviews.tt       |    2 +-
 .../opac-tmpl/bootstrap/images/feed-icon-16x16.png |  Bin 764 -> 0 bytes
 t/db_dependent/selenium/administration_tasks.t     |   18 +++-
 24 files changed, 217 insertions(+), 97 deletions(-)
 delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/images/feed-icon-16x16.png


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Mon Apr  8 11:14:27 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Mon, 08 Apr 2019 09:14:27 +0000
Subject: [koha-commits] main Koha release repository branch 18.11.x updated.
	v18.11.04-36-g170cdc4
Message-ID: <E1hDQMF-00062y-4z@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  170cdc4b01ce53a4ac114ab4d2d45b14af50627f (commit)
      from  1c31c10539d2393ab640e103fe8829e6422e4717 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 170cdc4b01ce53a4ac114ab4d2d45b14af50627f
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Sat Apr 6 10:19:14 2019 +0000

    Bug 22648: Fix typo in SQL in smart-rules.pl
    
    Fixes 2 SQL statements for setting the maximum
    number of checkouts possible.
    
    To test:
    - In 18.11
    - Verify that setting Default checkout, hold and return policy works
    - Verfiy that setting Default checkout, ohld and return policy by
      patron category works
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 admin/smart-rules.pl |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Wed Apr 10 22:29:30 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Wed, 10 Apr 2019 20:29:30 +0000
Subject: [koha-commits] main Koha release repository branch master updated.
	v18.11.00-1050-g35921d3
Message-ID: <E1hEJqc-0006f7-PF@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  35921d30a99f3f4c4cdb21438c8516444a10f24c (commit)
       via  ea7245631ebfb16d4921a6cf7b4b46799a241ff9 (commit)
       via  e90cb16d79f611caa3cd6d6cbbca4ea01d7a8077 (commit)
       via  5b11c25fe76415078d1b48956512c29c0b2030b1 (commit)
       via  383ec1f51b4c505ac23471f8b5ee1622dc862787 (commit)
       via  192e3baa75f16891582244595fe305292b886dda (commit)
       via  d6122ff78d4344441ed45ceb26ed09af83a15d15 (commit)
       via  ec78d0cddbb5cf5455a2c67130062917a0a23484 (commit)
       via  ea3cbef473a8b542b58341ef38beb9f7be20f4a1 (commit)
       via  247d0d1df1ee5cc7f3184d8ac6ab35373af739b3 (commit)
       via  313df03ed06f8c4229b38d0306c380214d895c4e (commit)
       via  fa53eb4cfa1d0c2125fc3097e6d2328899fc4259 (commit)
       via  d7a5925aa0a7a185c8671d8c9989d80bdf2c0939 (commit)
       via  e98dacf9f1f8464f0db394da6bc1152f96713597 (commit)
       via  0b931d5de3c4fe9fa2b4823d9b8727b28a46aa7c (commit)
       via  bdb157645538667cd23f8563ee6700e697a4adc8 (commit)
       via  6d4eb48dd47599dfd9738e1ae125abfa9f1109ee (commit)
       via  34b1713d86602cbfb9d7c6f68dccf7b293d18dce (commit)
       via  a55e50cf62438ce356e8373ee1d03686d3f96e04 (commit)
       via  b1171d9ef399d68e49044fbc2cb17efbeeaee093 (commit)
       via  d2e189ca1c4f11d12435008053336563af2dd911 (commit)
       via  125de75517b64a95b93dead4b1fa5c2326f007eb (commit)
       via  c5bc2563a856981eab29637fb2da0f6f014c0d6b (commit)
       via  9ec4d86636ffd4a11863cafe8d4eddb6e55c13db (commit)
       via  b763b4698b31c8d32f482f13b50e89b58f68c443 (commit)
      from  41e0ff7cd6240c2c9ba2d1bec816b191ef091eb1 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 35921d30a99f3f4c4cdb21438c8516444a10f24c
Author: Magnus Enger <magnus at libriotech.no>
Date:   Fri Apr 5 10:03:58 2019 +0200

    Bug 22646: Fix use of PrivacyPolicyURL
    
    To test:
    
    PatronSelfRegistration = Allow
    PatronSelfRegistrationDefaultCategory = PT (or some other real category)
    GDPR_Policy = Enforced
    PrivacyPolicyURL = Some URL
    
    - Go to <opac>/cgi-bin/koha/opac-memberentry.pl and verify that the text "privacy
      policy" displays a link to the current page, not the URL in PrivacyPolicyURL
    - Go to Administration > System preferences > Patrons > Privacy
    - Verify that the descriptions of GDPR_Policy and PrivacyPolicyURL does not
      mention that PrivacyPolicyURL needs to be set if GDPR_Policy is set.
    - Apply the patch
    - Verify that opac-memberentry.pl now links to the URL in PrivacyPolicyURL
    - Verify that the syspref descriptions mention the relationship between them
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Bin Wen <bin.wen at inlibro.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit ea7245631ebfb16d4921a6cf7b4b46799a241ff9
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Thu Mar 14 13:15:01 2019 +0000

    Bug 21013: Missing itemtype for checkut makes patron summary print explode
    
    This patch moves retrieval of the item type description from the script
    to the template using the ItemTypes template plugin.
    
    To test, apply the patch and locate an item which is checked out to
    someone. Modify the database record for that item to remove the item
    type (items.itype).
    
    View the print summary for the patron who has that item checked out. The
    page should display correctly. Checked-out items which have an item type
    should show that item type description correctly.
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit e90cb16d79f611caa3cd6d6cbbca4ea01d7a8077
Author: Ere Maijala <ere.maijala at helsinki.fi>
Date:   Fri Mar 8 13:27:26 2019 +0200

    Bug 22295: Make Elasticsearch query builder group multi-term queries
    
    Test plan:
    
    1. Do an advanced search for
    Title = new
    AND
    Title = york
    2. Verify that the results match an advanced search for:
    Title = new york
    3. Verify that tests in t/db_dependent/Koha/SearchEngine/Elasticsearch still pass
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 5b11c25fe76415078d1b48956512c29c0b2030b1
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Tue Apr 9 15:59:14 2019 -0300

    Bug 22675: Fix SCO behaviour on non-existent barcodes
    
    Bug 21206 replaced GetItem for Koha::Items->find, and introduced this
    problem. This patch verifies $item is defined before attempting to use
    its methods.
    
    To test:
    - Log into SCO
    - Type an invalid barcode
    => FAIL: Things explode :-/
    - Apply this patch, reload
    - Type an invalid barcode
    => SUCCESS: A nice error message is displayed :-D
    - Sign off :-D
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 383ec1f51b4c505ac23471f8b5ee1622dc862787
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue Apr 9 13:21:08 2019 +0000

    Bug 22553: Unchecking a subpermission does not uncheck the top level permission
    
    This patch makes a minor change to the set permissions page's JavaScript
    so that unchecking a subpermission will uncheck the top level
    permission.
    
    To test, apply the patch and open the "Set permissions" page for a
    patron.
    
     - Expand a permission with multiple subpermissions.
     - Check the top level permission. All subpermissions should be checked.
     - Uncheck one of the subpermissions. The top level permission should
       now be unchecked.
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 192e3baa75f16891582244595fe305292b886dda
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Sat Mar 23 11:44:53 2019 +0000

    Bug 22288: Correct item search in batchMod by barcode file
    
    To test:
    1 - Have a list of barcodes that exist in your catalog
    2 - Go to Tools->Batch item modification
    3 - Attempt to modify items using the list
    4 - Get an error page
    5 - Apply patch
    6 - Repeat
    7 - Modification should work correctly
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit d6122ff78d4344441ed45ceb26ed09af83a15d15
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Mar 4 16:07:22 2019 -0300

    Bug 22390: Never copy items if original order has been created from a subscription
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Tiny change to the code comment: serial => subscription order
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit ec78d0cddbb5cf5455a2c67130062917a0a23484
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Feb 21 14:48:24 2019 -0300

    Bug 22390: (bug 15184 follow-up) Use aqorders.subscriptionid instead of biblio.serial
    
    It seems that we made a wrong assumption on bug 15184, see
      commit d658cb6f7ecb18845a78d4708ee63ad1126f220f
      Bug 15184: Do copy items for not a serial OR if items are created on ordering
    
    To know if an order has been created from a subscription we should check
    $order->subscriptionid instead of the $biblio->serial flag
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit ea3cbef473a8b542b58341ef38beb9f7be20f4a1
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Tue Apr 2 18:02:14 2019 +0000

    Bug 22618: Move tests to t/db_dependent/Acquisition.t
    
    prove -v t/db_dependent/Acquisition.t
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 247d0d1df1ee5cc7f3184d8ac6ab35373af739b3
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Sat Mar 23 08:13:13 2019 +0000

    Bug 22641: Use raw filter on html slip
    
    To test:
    Enable SCO
    Load a patron
    Hit finish, print slip
    Note slip shows as raw html
    Apply patch
    Repeat, get a correctly formatted slip
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    https://bugs.koha-community.org/show_bug.cgi?id=22068
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 313df03ed06f8c4229b38d0306c380214d895c4e
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon Dec 24 15:59:22 2018 +0000

    Bug 17978: Unit tests for changes
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit fa53eb4cfa1d0c2125fc3097e6d2328899fc4259
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon Dec 24 14:33:51 2018 +0000

    Bug 17978: Check if hold can be placed before placing on placerequest.pl
    
    To test:
     1 - Set an All/All/All rule with reserves limited 2 to
     2 - Search in the staff side
     3 - Select all records (or more than 2) from the results
     4 - Click 'Place hold'
     5 - Find a patron, place holds
     6 - You get more holds than you should
     7 - Delete those holds
     8 - Apply patch
     9 - Search and select more than 2 records
    10 - Find patron, place holds
    11 - Only 2 holds are placed
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit d7a5925aa0a7a185c8671d8c9989d80bdf2c0939
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Tue Dec 19 14:20:56 2017 -0500

    Bug 17978: Circ rules will not limit holds
    
    The crux of this issue is that all those holds are unfilled record level holds. The code that checks for the number of holds the user already has *always* uses a branchcode of some form. Because of this, any open record level holds are completely ignored for this purpose.
    
    Test Plan:
    1) Set ReservesControlBranch to "item's home library"
    2) Set an All libraries/All Patrons/All itemtypes rules limiting a patron to 2 holds
    3) Place 3 record level holds, you can but you should not be able to!
    4) Delete the holds
    5) Apply this patch
    6) Attempt to place 3 record level holds
    7) Note that you cannot!
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit e98dacf9f1f8464f0db394da6bc1152f96713597
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Apr 5 15:13:36 2019 -0300

    Bug 22068: (QA follow-up) Return meaningful error codes
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 0b931d5de3c4fe9fa2b4823d9b8727b28a46aa7c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Feb 14 17:03:17 2019 -0300

    Bug 22068: Prevent patrons to cancel article request they did not create
    
    opac-article-request-cancel.pl doesn't check that the article request to
    be cancelled actually belongs to the logged-in borrower. This results in
    any logged-in user being able to cancel any article request just by
    changing the id in the URL.
    
    Test plan:
    - Login with Patron P1, create an article request
    - Cancel it
    - Create another one
    - Copy the cancellation link (must be /cgi-bin/koha/opac-article-request-cancel.pl?id=X)
    - Login with Patron P2
    - Hit the cancellation link
    => Without this patch the article request is cancelled
    => With this patch applied there is a 404 redirection
    
    Note that the 404 will also appears when the article request id does not
    exist.
    
    Signed-off-by: Ere Maijala <ere.maijala at helsinki.fi>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit bdb157645538667cd23f8563ee6700e697a4adc8
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Apr 10 19:57:10 2019 +0000

    Bug 22600: Schema updates
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 6d4eb48dd47599dfd9738e1ae125abfa9f1109ee
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Apr 10 19:55:14 2019 +0000

    Bug 22600: DBRev 18.12.00.039
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 34b1713d86602cbfb9d7c6f68dccf7b293d18dce
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Apr 10 19:53:39 2019 +0000

    Bug 22512: DBRev 18.12.00.038
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit a55e50cf62438ce356e8373ee1d03686d3f96e04
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Tue Apr 9 11:58:19 2019 -0300

    Bug 22600: (QA follow-up) Raise an exception on missing interface param
    
    This patch makes add_credit and add_debit raise a
    Koha::Exceptions::MissingParameter exception if the 'interface'
    parameter is ommited.
    
    The database will fail to generate the line anyways in strict mode, and
    we better handle it gracefuly.
    
    Bonus: fixed the TODOs in the tests.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit b1171d9ef399d68e49044fbc2cb17efbeeaee093
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Fri Mar 29 09:46:12 2019 +0000

    Bug 22600: Update Tests adding 'interface' as needed
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit d2e189ca1c4f11d12435008053336563af2dd911
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Thu Mar 28 14:32:05 2019 +0000

    Bug 22600: Set 'commandline' interface appropriately
    
    This patch change Koha::Cron to be a more generic Koha::Script class and
    update all commanline driven scripts to use it.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 125de75517b64a95b93dead4b1fa5c2326f007eb
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Mon Mar 25 19:04:58 2019 +0000

    Bug 22600: Add 'cron' to interface types and set appropriately
    
    This patch adds 'cron' as a valid interface and sets it appropriately for
    existing cron scripts.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit c5bc2563a856981eab29637fb2da0f6f014c0d6b
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Thu Mar 28 11:33:00 2019 +0000

    Bug 22600: Add 'api' to interface types and set appropriately
    
    This patch adds 'api' as a valid interface and sets it appropriately for
    both the new REST api and previous /svc/ api's.  Handling to keep the
    interface of a logged in session is included such that if the OPAC or
    Intranet use the API's internally via a Cookie we will maintain the
    interface throughout the session.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 9ec4d86636ffd4a11863cafe8d4eddb6e55c13db
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Thu Mar 28 10:00:22 2019 +0000

    Bug 22600: Add 'interface' to accountlines
    
    This patch adds the 'interface' field to the accountlines table and
    updates all Koha::Object routines and calls to use it.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit b763b4698b31c8d32f482f13b50e89b58f68c443
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Thu Mar 14 12:14:17 2019 +0000

    Bug 22512: Add status field to accountlines
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Accounts.pm                                     |    3 +
 C4/Auth.pm                                         |    6 +
 C4/Circulation.pm                                  |   10 +-
 C4/Context.pm                                      |    8 +-
 C4/Log.pm                                          |    2 +-
 C4/Overdues.pm                                     |   14 +-
 C4/Reserves.pm                                     |    3 +-
 C4/SIP/ILS/Transaction/FeePayment.pm               |   16 +-
 C4/SIP/SIPServer.pm                                |    4 +
 Koha.pm                                            |    2 +-
 Koha/Account.pm                                    |   36 +++-
 Koha/Account/Line.pm                               |    7 +-
 Koha/Acquisition/Order.pm                          |    2 +-
 Koha/Hold.pm                                       |    9 +-
 Koha/Patron.pm                                     |    7 +-
 Koha/REST/V1/Auth.pm                               |    2 +
 Koha/REST/V1/Patrons/Account.pm                    |    1 +
 Koha/Schema/Result/Accountline.pm                  |   20 +-
 Koha/Schema/Result/Issue.pm                        |    9 +-
 Koha/Schema/Result/OldIssue.pm                     |    9 +-
 Koha/Script.pm                                     |   76 ++++++++
 Koha/SearchEngine/Elasticsearch/QueryBuilder.pm    |    1 +
 installer/data/mysql/kohastructure.sql             |    2 +
 installer/data/mysql/updatedatabase.pl             |   72 +++++++
 .../prog/en/modules/admin/preferences/patrons.pref |    2 +
 .../prog/en/modules/members/member-flags.tt        |   16 +-
 .../prog/en/modules/members/moremember-print.tt    |    3 +-
 .../bootstrap/en/modules/opac-memberentry.tt       |    2 +-
 .../bootstrap/en/modules/sco/printslip.tt          |    6 +-
 members/mancredit.pl                               |    3 +-
 members/pay.pl                                     |    2 +
 members/paycollect.pl                              |    3 +
 members/summary-print.pl                           |    3 -
 misc/admin/koha-preferences                        |    1 +
 misc/batchCompareMARCvsFrameworks.pl               |    1 +
 misc/batchDeleteUnusedSubfields.pl                 |    1 +
 misc/batchImportMARCWithBiblionumbers.pl           |    1 +
 misc/batchRebuildBiblioTables.pl                   |    1 +
 misc/batchRebuildItemsTables.pl                    |    1 +
 misc/batchRepairMissingBiblionumbers.pl            |    2 +-
 misc/batchdeletebiblios.pl                         |    1 +
 misc/check_sysprefs.pl                             |    1 +
 misc/commit_file.pl                                |    1 +
 misc/cronjobs/advance_notices.pl                   |    2 +-
 .../cronjobs/automatic_item_modification_by_age.pl |    1 +
 misc/cronjobs/automatic_renewals.pl                |    2 +-
 misc/cronjobs/batch_anonymise.pl                   |    1 +
 misc/cronjobs/build_browser_and_cloud.pl           |    1 +
 misc/cronjobs/cart_to_shelf.pl                     |    1 +
 misc/cronjobs/check-url-quick.pl                   |    2 +
 misc/cronjobs/check-url.pl                         |    2 +
 misc/cronjobs/cleanup_database.pl                  |    1 +
 misc/cronjobs/cloud-kw.pl                          |    4 +-
 misc/cronjobs/create_koc_db.pl                     |    3 +-
 misc/cronjobs/delete_expired_opac_registrations.pl |    1 +
 misc/cronjobs/delete_items.pl                      |    2 +
 misc/cronjobs/delete_patrons.pl                    |    1 +
 misc/cronjobs/delete_records_via_leader.pl         |    1 +
 misc/cronjobs/edi_cron.pl                          |    1 +
 misc/cronjobs/fines.pl                             |    1 +
 misc/cronjobs/gather_print_notices.pl              |    1 +
 misc/cronjobs/holds/auto_unsuspend_holds.pl        |    1 +
 misc/cronjobs/holds/build_holds_queue.pl           |    1 +
 misc/cronjobs/holds/cancel_expired_holds.pl        |    1 +
 misc/cronjobs/holds/cancel_unfilled_holds.pl       |    1 +
 misc/cronjobs/import_webservice_batch.pl           |    1 +
 misc/cronjobs/j2a.pl                               |    1 +
 misc/cronjobs/longoverdue.pl                       |    2 +
 misc/cronjobs/membership_expiry.pl                 |    1 +
 misc/cronjobs/merge_authorities.pl                 |    5 +-
 misc/cronjobs/notice_unprocessed_suggestions.pl    |    1 +
 misc/cronjobs/overdue_notices.pl                   |    2 +-
 misc/cronjobs/process_message_queue.pl             |    2 +
 misc/cronjobs/purge_suggestions.pl                 |    2 +
 misc/cronjobs/reconcile_balances.pl                |    2 +-
 misc/cronjobs/remove_temporary_edifiles.pl         |    1 +
 misc/cronjobs/rss/rss.pl                           |    2 +
 misc/cronjobs/runreport.pl                         |    1 +
 misc/cronjobs/serialsUpdate.pl                     |    1 +
 misc/cronjobs/share_usage_with_koha_community.pl   |    1 +
 misc/cronjobs/sitemap.pl                           |    2 +
 .../cronjobs/social_data/get_report_social_data.pl |    2 +
 misc/cronjobs/social_data/update_social_data.pl    |    2 +
 misc/cronjobs/staticfines.pl                       |    1 +
 misc/cronjobs/stockrotation.pl                     |    2 +
 .../thirdparty/TalkingTech_itiva_inbound.pl        |    1 +
 .../thirdparty/TalkingTech_itiva_outbound.pl       |    1 +
 misc/cronjobs/update_totalissues.pl                |    2 +
 misc/devel/create_superlibrarian.pl                |    1 +
 misc/devel/populate_db.pl                          |    1 +
 misc/export_borrowers.pl                           |    1 +
 misc/export_records.pl                             |    1 +
 misc/exportauth.pl                                 |    1 +
 misc/import_patrons.pl                             |    1 +
 misc/link_bibs_to_authorities.pl                   |    1 +
 misc/maintenance/UNIMARC_fix_collectiontitle.pl    |    1 +
 .../UNIMARC_sync_date_created_with_marc_biblio.pl  |    1 +
 misc/maintenance/auth_show_hidden_data.pl          |    1 +
 .../borrowers-force-messaging-defaults.pl          |    1 +
 misc/maintenance/cmp_sysprefs.pl                   |    1 +
 misc/maintenance/fix_accountlines_date.pl          |    1 +
 .../fix_accountlines_rmdupfines_bug8253.pl         |    1 +
 misc/maintenance/fix_mysql_constraints.pl          |    1 +
 misc/maintenance/fix_tags_weight.pl                |    1 +
 .../maintenance/make_zebra_dom_cfg_from_record_abs |    1 +
 misc/maintenance/process_record_through_filter.pl  |    2 +
 misc/maintenance/remove_items_from_biblioitems.pl  |    1 +
 misc/maintenance/sanitize_records.pl               |    2 +
 .../maintenance/search_for_data_inconsistencies.pl |    1 +
 misc/maintenance/touch_all_biblios.pl              |    2 +
 misc/maintenance/touch_all_items.pl                |    2 +
 misc/maintenance/update_authorities.pl             |    1 +
 misc/migration_tools/buildCOUNTRY.pl               |    1 +
 misc/migration_tools/buildEDITORS.pl               |    1 +
 misc/migration_tools/buildLANG.pl                  |    1 +
 misc/migration_tools/build_oai_sets.pl             |    1 +
 misc/migration_tools/bulkmarcimport.pl             |    1 +
 misc/migration_tools/checkNonIndexedBiblios.pl     |    1 +
 misc/migration_tools/create_analytical_rel.pl      |    1 +
 misc/migration_tools/fix_onloan.pl                 |    4 +-
 misc/migration_tools/import_lexile.pl              |    1 +
 misc/migration_tools/rebuild_zebra.pl              |    1 +
 misc/migration_tools/remove_unused_authorities.pl  |    1 +
 misc/migration_tools/switch_marc21_series_info.pl  |    1 +
 misc/migration_tools/upgradeitems.pl               |    4 +-
 misc/mod_zebraqueue.pl                             |    1 +
 misc/recreateIssueStatistics.pl                    |    2 +
 misc/search_tools/rebuild_elastic_search.pl        |    1 +
 misc/stage_file.pl                                 |    1 +
 offline_circ/process_koc.pl                        |    2 +-
 opac/opac-account-pay-paypal-return.pl             |    3 +-
 opac/opac-article-request-cancel.pl                |   13 +-
 opac/sco/sco-main.pl                               |    3 +-
 reserve/placerequest.pl                            |   14 +-
 t/Acquisition.t                                    |   68 -------
 t/Context.t                                        |    3 +-
 .../rotatingCollections.pl => t/Koha/Script.t      |   45 +++--
 .../rotatingCollections.pl => t/Koha/Script_cron.t |   45 +++--
 t/db_dependent/Accounts.t                          |   75 ++++----
 t/db_dependent/Acquisition.t                       |   45 ++++-
 t/db_dependent/Circulation.t                       |   21 ++-
 .../Circulation/NoIssuesChargeGuarantees.t         |    2 +-
 t/db_dependent/Holds.t                             |   18 +-
 t/db_dependent/Koha/Account.t                      |  196 ++++++++++++--------
 t/db_dependent/Koha/Account/Lines.t                |   64 ++++---
 t/db_dependent/Koha/Acquisition/Order.t            |   73 +++++++-
 .../Koha/SearchEngine/Elasticsearch/QueryBuilder.t |   32 +++-
 t/db_dependent/api/v1/patrons_accounts.t           |   11 +-
 tools/batchMod.pl                                  |    4 +-
 149 files changed, 878 insertions(+), 353 deletions(-)
 create mode 100644 Koha/Script.pm
 delete mode 100644 t/Acquisition.t
 copy rotating_collections/rotatingCollections.pl => t/Koha/Script.t (51%)
 mode change 100755 => 100644
 copy rotating_collections/rotatingCollections.pl => t/Koha/Script_cron.t (51%)
 mode change 100755 => 100644


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Thu Apr 11 16:10:23 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Thu, 11 Apr 2019 14:10:23 +0000
Subject: [koha-commits] main Koha release repository branch master updated.
	v18.11.00-1083-g08f02c1
Message-ID: <E1hEaPH-0003RY-IL@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  08f02c1aa5a6ae1f1ee3b10a086831c1a2dbcb66 (commit)
       via  ccc2b4b073113b2c0603437b5a84d4544ede16e4 (commit)
       via  968c888e1579ab28ec165819a011612d8b8f5570 (commit)
       via  f7869ad48b8f2f86f2b912aad1c3dcbd1a5679c1 (commit)
       via  a5f3d405f56202beb4426da52f3bf4019f26484b (commit)
       via  761b410f99cbbfff8e353c538fde2b6816408795 (commit)
       via  275dee5f9b9a26b3490bf3646c71c78a2d8647eb (commit)
       via  1493c42e7bae5bffab430072587b7aa0527f6fc7 (commit)
       via  7208ac6196a8619dbb0cca3b6f01480f4c46cab1 (commit)
       via  19b9aacfbae616f7198cd93ebdbd97115d204c5b (commit)
       via  9cbc5f2aa072ec41a70fd1fa1de4f684fcd695e9 (commit)
       via  3db5feb900d3e6a6400767c771afe78bab0fa880 (commit)
       via  fbdb2b2be009140be6f9b5b84c765741bc828a3c (commit)
       via  b215c7d55195a4912fb3ab585aba6ee44581f746 (commit)
       via  3323a428eaf662a0ba1a31b2cb56002a7372461a (commit)
       via  7acb5394e1f62728c90a1d18e988c23a3e2862d2 (commit)
       via  edf173e6ef1fa6de6e07f41c229799733456901a (commit)
       via  d498c2563d76c05a1e819d63d8b56f732c3a7768 (commit)
       via  d8a196cc9decd19a5401907adc64c7dee80a0c55 (commit)
       via  a1eba24391b4653f842a1767a48ac8b9f470b8ea (commit)
       via  9c0197a8d1b1a29f28de4b91e6605ae0a1088235 (commit)
       via  5768ea9532e0ee19b77346e2ba13681339b18017 (commit)
       via  bc5e84eedc7132c64452e7f37e5a825f6d17c9bd (commit)
       via  a00e1467b9754432196df838b6e000262b7251e7 (commit)
       via  7d550eb1b3b10f82c8463e85beb63184952fc4f1 (commit)
       via  30ab16657b10dbe8e5c42f1f3900a31c3506bb25 (commit)
       via  083f789b9548ec70d86dc48911df1bc9febda619 (commit)
       via  bfeac6486516f185d9882d294d5000ab773c7dd5 (commit)
       via  3c2ce5df6f550fd2452b978e1b5f7ac54e66b092 (commit)
       via  3e9989568e171ebcfc73df80c49556e0b663a8ae (commit)
       via  679fdaebb1a611859a968f22b85c37fbc00b055b (commit)
       via  64740260e51b4249dbc99d151dadfb173cde5298 (commit)
       via  d3059e6c94f324d6984368fa8b8e77ad1dfbcf71 (commit)
      from  35921d30a99f3f4c4cdb21438c8516444a10f24c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 08f02c1aa5a6ae1f1ee3b10a086831c1a2dbcb66
Author: Hayley Mapley <hayleymapley at catalyst.net.nz>
Date:   Mon Apr 8 10:25:11 2019 +1200

    Bug 19630: Removed constant message from Status column
    
    Test plan:
    Same as initial test plan, except that when a hold has no status that
    the Status column for that hold should be blank instead of saying
    "Hold has been placed".
    
    Sponsored-by: Catalyst IT
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit ccc2b4b073113b2c0603437b5a84d4544ede16e4
Author: Hayley Mapley <hayleymapley at catalyst.net.nz>
Date:   Thu Mar 14 21:37:36 2019 +0000

    Bug 19630: Added Status column to Patron Holds table
    
    When a hold has been suspended or is waiting, the status
    message appears in the Barcode column of the Holds table. This patch
    fixes this by adding a separate Status column which details the status
    of the Hold, whether it has been suspended, or is in transit, etc.
    
    Test plan:
    1) Place an item level hold and a 'Next Available' record level hold for
    a patron.
    2) View the holds in Patrons->Patron details for that Patron in the Check out and Details tabs
    3) Suspend one of the holds, and note that the status appears in the
    barcode column
    4) Set a hold to be waiting for pickup, and note the status appears in
    the barcode column
    5) Apply the patch
    6) Check the same holds and note that the statuses now appear in the new
    column called Status, and note that if a hold has status effect that the
    row reads "Hold has been placed"
    7) Verify that this is the case in both the Holds tables (in Check out
        tab and Details tab)
    
    Sponsored-by: Catalyst IT
    Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos at inLibro.com>
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 968c888e1579ab28ec165819a011612d8b8f5570
Author: Hayley Mapley <hayleymapley at catalyst.net.nz>
Date:   Thu Mar 14 04:14:57 2019 +0000

    Bug 19497: Removed title (tooltip) from Edit button in items_search_fields.tt
    
    This patch removes the tooltip that appears when hovering over the Edit button
    of Item Search Fields in the staff client. This was done for consistency reasons,
    including that this tooltip is not translated and tooltips do not appear to be
    on the majority of buttons in the staff client.
    
    Test plan:
    1) In Home->Administration->Item search fields create a new search field
    if you haven't got any already
    2) Observe the tooltip that appears when hovering over the Edit button in
    the Item serach fields table.
    3) Apply the patch and observe that the tool tip no longer appears.
    
    Sponsored-by: Catalyst IT
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit f7869ad48b8f2f86f2b912aad1c3dcbd1a5679c1
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Apr 11 13:39:10 2019 +0000

    Bug 19670: DBRev 18.12.00.041
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit a5f3d405f56202beb4426da52f3bf4019f26484b
Author: Ere Maijala <ere.maijala at helsinki.fi>
Date:   Thu Mar 14 14:33:18 2019 +0200

    Bug 19670: Change Collation of marc_field to allow mixed case mappings
    
    Test plan:
    1. Apply patch and update database
    2. Verify that you can add a search field mapping for both 100a and 100A.
    3. Verify that the above also works with a newly-created database.
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 761b410f99cbbfff8e353c538fde2b6816408795
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Wed Mar 6 19:02:50 2019 +0000

    Bug 22444: currencies_manage permission doesn't provide link to manage currencies when selected alone
    
    This patch modifies the acquisitions sidebar menu so that it checks
    properly for the currencies_manage permission.
    
    This patch also removes the menu link directly to the administration
    home page. Since we're removing the check on the general
    "CAN_user_parameters" permission it doesn't make sense to assume the
    page is accessible.
    
    To test, apply the patch and modifiy a staff user so that they have no
    "parameters" permissions but do have "currencies_manage" permission.
    
    Go to the Acquisitions home page. There should be a link to currencies
    management in the sidebar menu.
    
    Perform the same test with a user who has "parameters" permissions but
    not "currencies_manage" permission. There should be no link to
    currencies in the acquisitions sidebar menu. The user should have access
    to the administrative home page.
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 275dee5f9b9a26b3490bf3646c71c78a2d8647eb
Author: Maryse Simard <maryse.simard at inlibro.com>
Date:   Thu Feb 7 08:24:03 2019 -0500

    Bug 21263: Pickup library not set correctly when using Default holds policy
    
    In the case of a specific item hold, it can only be fulfilled if the pickup library
    matches the hold fulfillment policy. Therefore, if OPACAllowUserToChooseBranch is
    set to don't allow, the pickup library should correspond to the policy.
    
    In case of hold that does not specify an item, the homebranch or holdingbranch
    can't be determined at this time, so the pickup library still defaults to the
    homebranch of the borrower. Same if there is no policy or it states 'any'.
    
    To test:
    - Make sure OPACAllowUserToChooseBranch is set to don't allow
    - Make sure you have two branches A and B
    - Have one item whose homebranch is B
    - Have one user whose homebranch is A
    - Make sure the circulation rules allow the user to reserve the item's item type
    
    1. Go to Administration > Circulation and fines rules
    2. Create a Default holds policy by item type for that item type
        - Item type = item's item type
        - Hold policy = From any library
        - Hold pickup library match = item's home library
        - Return policy = item returns home
    3. Go to the OPAC and log in with the user's credentials
    4. Search for the item
    5. Click on "Place hold"
    6. Select a specific item and confirm hold
    7. In the user's file on the OPAC and check the reservation's pickup library. It should be the item's homebranch
    
    You can then repeat the steps for 'item's holding library' or 'any library' as
    the Hold pickup library match. It should also work the same way if there is no
    'Default holds policy by item type' for this item type but a 'Default checkout,
    hold and return policy' set.
    
    Finally, check that placing a hold without selecting a specific item still
    defaults the pickup library to the borrower's homebranch.
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 1493c42e7bae5bffab430072587b7aa0527f6fc7
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date:   Fri Apr 5 14:45:39 2019 +0100

    Bug 22121: Display 'Price paid' on ILL requests according to CurrencyFormat pref
    
    To test:
    - Install BLDSS backend
      see: https://wiki.koha-community.org/wiki/ILL_backends
    - Add a new BLDSS ILL request
    - Edit ILL request
    - Fill in Price paid field
    - Verify Price paid is formatted correctly on 'Manage ILL request'
      page
    
    Signed-off-by: Ethan Amohia <ethan.amohia at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    https://bugs.koha-community.org/show_bug.cgi?id=22121
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 7208ac6196a8619dbb0cca3b6f01480f4c46cab1
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Mar 7 09:14:25 2019 -0300

    Bug 22472: Make column_exists early return if the table does not exist
    
    On the way we move TableExists to C4::Installer, where it belongs to.
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 19b9aacfbae616f7198cd93ebdbd97115d204c5b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Mar 7 09:14:06 2019 -0300

    Bug 22472: Add tests
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 9cbc5f2aa072ec41a70fd1fa1de4f684fcd695e9
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Thu Apr 4 00:56:43 2019 +0000

    Bug 21659: Change link to basket group edit page
    
    I have taken another look at other links like the one
    from acq order search and changed the link to not lead
    to the vendor's basket group page but to the edit page
    of the invidividual basket group.
    
    To test:
    - Same as first patch, verify links now lead
      to the basket grou edit page
    
    https://bugs.koha-community.org/show_bug.cgi?id=21650
    
    Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos at inLibro.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 3db5feb900d3e6a6400767c771afe78bab0fa880
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Mon Mar 11 16:24:16 2019 +0000

    Bug 21659: Fix links to basket groups from order receive page
    
    Fixes a problem with the template variables on the order
    receive page, so that the links to basket groups work
    correctly again.
    
    To test:
    - Create some orders with and without basket groups
    - Receive shipment
    - Verify that the basket group links for pending orders work right
    - Receive an order line
    - Verify that the basket group links for received orders work right
    
    Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos at inLibro.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit fbdb2b2be009140be6f9b5b84c765741bc828a3c
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Wed Apr 3 22:35:38 2019 +0200

    Bug 22634: Standardize table creation for stockrotation* tables in kohastructure.sql
    
    The existing pattern is:
    DROP TABLE IF EXISTS ...
    CRATE TABLE
    
    Stockrotation was using:
    CREATE TABLE IF NOT EXISTS ...
    which would not recreate the table in a database it's already
    existing in possibly causing mismatches in table structure.
    
    To test:
    - Drop your database
    - Run through the web installer
    - Make sure there are no Database/SQL errors
    - Makse sure the 4 stockrotation tables have been created
    
    Signed-off-by: Fr?d?ric Demians <f.demians at tamil.fr>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit b215c7d55195a4912fb3ab585aba6ee44581f746
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Wed Apr 3 19:28:38 2019 +0000

    Bug 22631: Make links on barcode on hold summary page consistent (bug 21070)
    
    Bug 21070 changed the link on the holds summary so the barcode
    would link to the item on moredetail for an item level hold.
    
    If a hold is already waiting, the link still goes to the detail
    page of the record. This patch changes it so the barcode always
    links to the item.
    
    To test:
    - Place some item level holds on a record
    - Verify the barcodes on the hold summary page link to
      moredetail.pl
    - Return one of the items so that the hold is waiting
    - Verify the barcode links to the record detail page now
    - Apply patch
    - Verify barcodes for pending and waiting holds now both
      link to moredetail.pl
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Bin Wen <bin.wen at inlibro.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 3323a428eaf662a0ba1a31b2cb56002a7372461a
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Mon Apr 1 19:15:18 2019 +0000

    Bug 22624: Show OPAC description for authorised values in OPAC
    
    Patch adds the IS_OPAC parameter to a few GetByCode calls in
    OPAC files.
    
    To test:
    - Add different OPAC and intranet descriptions to some authorised
      value categories:
      - TERM
      - DEPARTMENT
      - LOC
      - CCODE
    - Create a new course using the values and adding items to it
    - Check the course reserves overview and detail pages in OPAC
    - Verify Department, term, location, and collection show
      the OPAC description if existing
    - Create a subscription, make sure a default location is selected
    - Check the OPAC detail page, subscription tab for this subsription
      in the OPAC
    - Verify the location of the subscription displays correctly
    
    Signed-off-by: Mika?l Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 7acb5394e1f62728c90a1d18e988c23a3e2862d2
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Thu Apr 4 18:27:28 2019 +0000

    Bug 13629: SingleBranchMode removes both library and availability search from advanced search
    
    This patch modifies the OPAC advanced search form so that it is possible
    to limit searches to available items even if there is only one library.
    
    To test, apply the patch and go to the advanced search page in the OPAC.
    
     - With only one library configured: There should be a section labeled
       "Availability" with just the "only available" checkbox.
    
     - With multiple libraries: The section should be labeled "Location and
       availability" and should have the library dropdown and the
       availability checkbox.
    
    Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit edf173e6ef1fa6de6e07f41c229799733456901a
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Thu Apr 4 14:05:21 2019 +0000

    Bug 14358: Changing the module refreshes the page and resets library choice
    
    This patch makes an incremental change towards fixing Bug 14358: The
    "New notice" button is converted to a dropdown button which asks the
    user to select a module to start with.
    
    To test, apply the patch and go to Tools -> Notices. Test the "New
    notice" button and confirm that module selections are reflected in the
    notice add form you are shown.
    
    Signed-off-by: Mika?l Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit d498c2563d76c05a1e819d63d8b56f732c3a7768
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Apr 11 12:30:50 2019 +0000

    Bug 22680: Compiled CSS
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit d8a196cc9decd19a5401907adc64c7dee80a0c55
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Wed Apr 10 17:55:22 2019 +0000

    Bug 22680: OPAC language footer not positioned correctly
    
    This patch modifies the OPAC CSS so that the language-selection footer
    is positioned correctly.
    
    To test, apply the patch and rebuild the OPAC CSS.
    
    - Enable one or more translations in the OPAC
    - View a page in the OPAC which can display in your browser without a
      vertical scrollbar (for instance, the OPAC main page with no news
      items or OpacMainUserBlock).
      - The language-selection footer should appear at the bottom of the
        screen. At smaller browser heights the footer should scroll
        offscreen.
      - Test with content in the opaccredits system preference, and with
        OpacKohaUrl enabled. The footer should still be positioned
        correctly.
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit a1eba24391b4653f842a1767a48ac8b9f470b8ea
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Apr 11 12:26:21 2019 +0000

    Bug 22626: (RM follow-up) Adjust column after 12166
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 9c0197a8d1b1a29f28de4b91e6605ae0a1088235
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue Apr 9 16:06:27 2019 +0000

    Bug 22626: 'Filter paid transactions' broken on Transactions tab in staff
    
    This patch changes a parameter in the function which filters the
    DataTable of transactions. The addition of more columns to the table
    changed the index of the column which is being filtered.
    
    To test, apply the patch and locate a patron who has multiple fines or
    charges, some of them paid. Go to Accounting -> Transactions. Test the
    "Filter paid transactions" link. Table rows which show "0.00" in the
    "Oustanding" column should be hidden.
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 5768ea9532e0ee19b77346e2ba13681339b18017
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Apr 11 12:21:01 2019 +0000

    Bug 12166: DBRev 18.12.00.040
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit bc5e84eedc7132c64452e7f37e5a825f6d17c9bd
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Tue Apr 9 09:19:16 2019 +0100

    Bug 12166: (QA follow-up) Update test for description
    
    Update the relevant test to check for 'description eq title' as aposed
    to the old 'description eq "Reserve Charge - title"'.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit a00e1467b9754432196df838b6e000262b7251e7
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Sat Apr 6 13:16:56 2019 +0000

    Bug 12166: (follow-up) Fix sequence of columns in OPAC
    
    Type and description column headings were switched.
    
    To test:
    - Check the table headings of the fines table in the
      OPAC fines table match the content
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 7d550eb1b3b10f82c8463e85beb63184952fc4f1
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Sat Apr 6 12:11:38 2019 +0000

    Bug 12166: (follow-up) Remove 'Reserve Charge' from descriptions in accountlines
    
    With the prior 'Hold fee' will be displayed in OPAC and staff, so
    the 'Reserve Charge' would just be an untranslatable double up
    of information.
    
    To test:
    - Make sure you create some Reserve Charges prior to applying this
      patch set
    - Verify they show in staff and OPAC account
    - Apply patch
    - Run database update
    - Verfy the "Rental Charge - " is gone and old and new entries
      match now
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 30ab16657b10dbe8e5c42f1f3900a31c3506bb25
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Thu Apr 4 15:44:30 2019 +0000

    Bug 12166: Improve display of Reserve charges in patron account
    
    This patch makes changes to the way hold fees are recorded and displayed
    in the OPAC and staff client:
    
     - No English strings should be stored in the accountline description.
     - The accounttype code should be used to display what kind of charge it
       is.
    
    To test, apply the patch and go to the staff client:
    
     - Configure a patron category to have a hold fee.
     - Place one or more holds for a patron in that category.
     - On the patron's record, view Accounting -> Make a payment
       - There should be a separate column for "Account type" showing "Hold
         fee" for the hold charges.
       - There should be no "Res" or "Reserve Charge" text in the
         description column--just the title.
     - Switch to the "Transactions" tab. The display should be similar.
     - In the OPAC, log in as a patron who has hold fees on their account.
       - View the "your fines" page to confirm that the information is
         displayed correctly there as well.
    
     - Place a hold for a patron who incurs hold charges.
     - Log in to the self-checkout module as that patron and check out an
       item which will fulfill that hold.
     - The correct fine information should be saved to accountlines: A "Res"
       type with a description consisting only of the title.
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 083f789b9548ec70d86dc48911df1bc9febda619
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Feb 27 12:45:47 2019 -0500

    Bug 20937: Truncate items for print notices when user has an email
    
    To test:
     1 - Set PrintNoticesMaxLines to 1
     2 - Checkout 2 (or more) items to a patron and make them overdue to trigger a
    notice
     3 - Make sure the patron has an email
     4 - Make sure the notice you are sending is set to 'print' as the type
     5 - Run overdue_notices.pl without the 'nomail' option
     6 - Find the message and note all items have been added
     7 - Apply patch
     8 - Clear the message queue
     9 - Re-run overdue_notices.pl
    10 - Confirm the message now has only 1 item.
    11 - Set PrintNoticesMaxLines to 0
    12 - Clear the message queue
    13 - Re-run overdue_notices.pl
    14 - Confirm the message has 2 items as expected
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit bfeac6486516f185d9882d294d5000ab773c7dd5
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Sun Apr 7 16:25:28 2019 +0000

    Bug 22075: Fix encoding problem with RIS export in OPAC
    
    When exporting a record with diacritics in RIS
    format from the detail page in OPAC the encoding
    is not correct and the diacritics appear broken.
    
    This patch fixes it.
    
    To test:
    - Find or create a record with some special
      chars in your OPAC
    - Go to the detail page
    - Save as > RIS
    - Verify the diacritics are broken in an editor
    - Apply patch
    - Repeat and verify everything now displays correctly
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 3c2ce5df6f550fd2452b978e1b5f7ac54e66b092
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon Mar 25 12:55:03 2019 +0000

    Bug 22541: Invoice adjustments should show invoice number and include link on ordered.pl and spent.pl
    
    To test:
     1 - Find a vendor in acquisitions
     2 - Click 'receive shipment'
     3 - Create an invoice
     4 - Click 'Finish receiving'
     5 - Add an adjustment that encumbers while open and update adjustments
     6 - Go to acqui-home and click on the ordered total for the fund with the adjustment
     7 - Note the invoice adjustment shows the invoice id and does not link
     8 - Add another invoice and another adjustment, but close the invoice this time
     9 - Go to acqui-home and click on the spent total for the fund with the adjustment
    10 - Note the invoice adjustment shows the invoice id and does not link
    11 - Apply patch
    12 - Visit the spent and ordered pages and note the adjustments show invoicenumber and are links
    13 - prove -v t/db_dependent/Koha/Acquisition/Invoice/Adjustments.t
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 3e9989568e171ebcfc73df80c49556e0b663a8ae
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Wed Mar 27 16:19:29 2019 +0100

    Bug 22595: Items search is mixing inputs
    
    Items search is using inputs and selects from search form to create an Ajax call.
    
    In this call selects are parsed before inputs.
    But a custom search field can be used with authorised values and used after a regular search field.
    In this case the "q" param is not ordered like the "name" param.
    
    Test plan :
    1) Go to Administration > Item search fields
    2) Define a search field with an authorised values category
    3) Go to items search
    4) Use a regular filter like call number
    5) Click on new field
    6) Use custom field with an authorised value
    7) Perform search
    => Without patch you get wrong resuts, authorised value is used as value for first field
    => You can see this by listening traffic in Firebug, look at params "f" and "q"
    8) Check some combinaison of select and input filters
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 679fdaebb1a611859a968f22b85c37fbc00b055b
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Thu Jan 31 14:29:45 2019 +0000

    Bug 22250: Clean up Mana KB integration with serials and reports
    
    This patch makes many changes to templates and JavaScript related to the
    integration of Mana with serials reports:
    
     - Many incorrect uses of the raw filter with html
     - Corrections to Bootstrap modal markup
     - Untranslatable strings moved out of JavaScript
     - Removed markup and JavaScript related to reports comments, a feature
       which doesn't exist in this version.
    
      New include file: mana/mana-comment-status.inc
    
      This file contains hidden-by-default messages which are shown during
      the process of submitting a comment on a subscription.
    
      New include file: mana/mana-share-report.inc
    
      This file contains the "Share report" modal markup formerly in
      guided_reports_start.tt
    
      New JavaScript file: mana.js
    
      Previously mana.inc, an include file containing only JavaScript which
      didn't include any template processing.
    
      Changed: mana/mana-report-search-result.inc
    
      This include file is now a full template so that jQuery's load()
      function can be used to pull its contents into the reports search
      modal.
    
      Changed: svc/mana/search
    
      This script was returning json-encoded HTML. Now it returns regular
      HTML.
    
    To test you must have Mana configured and enabled. Apply the patch and
    go to Reports -> Saved reports.
    
     - Choose New report -> New SQL from Mana. A "Mana search" modal should
       appear.
       - Perform a search which will return results, e.g. "circulation."
       - A "Loading" indicator should appear while the results are being
         retrieved. It should disappear when results appear.
       - Results should appear in the DataTable with sorting, paging, and
         search options.
       - In the "Notes" column, notes longer than 200 characters should be
         truncated with a "Show more" link. Clicking it should expand the
         comment and reveal a "Show less" link in its place.
       - Click the "Import" button (previously "Use"). The button icon
         should change to a loading indicator.
       - When the import is complete you should be redirected to a view of
         your new report.
    
    Go to Serials and click the "Search on Mana" link in the sidebar.
    
     - Perform a search for a serial
     - Results should appear in a DataTable with sorting, paging, and search
       options.
     - Sorting by title should ignore articles "a," "an," and "the."
    
    Create a new subscription or edit an existing subscription which will
    match a record in Mana.
    
     - On the second step of adding/editing the subscription a message
       should appear at the top of the form, "Searching for subscription in
       Mana Knowledge Base," with a loading icon.
     - When searching has completed a "Show Mana results" link should
       appear.
     - Clicking the link should trigger a modal showing search results which
       match your subscription, displayed in a DataTable with sorting,
       paging, and search options.
     - The last column of the table should contain "Import" and "Report"
       buttons.
       - Clicking the "Report" button should trigger a menu. Any existing
         comments will be listed as well as a "New comment" item.
         - Clicking an existing comment should cause the menu to close and a
           "Submitting comment" message to appear. It should be shortly
           replaced with a "Your comment has been submitted" message.
         - Clicking "New comment" should reveal a comment form.
           - It should not be possible to submit an empty comment.
           - Clicking the "cancel" link should redisplay the search results.
           - Submitting a new comment should trigger a "Submitting comment"
             message followed by a "Your comment has been submitted"
             message.
       - In the table of search results, click the "Import" button
         (previously "Use"). The button icon should change to a loading
         indicator.
         - The modal should close and the data from Mana should be loaded
           into the subscription entry form.
    
    View the detail page of a subscription which has saved with Mana data.
    
      - There should be a "Report mistake" button in the toolbar. Clicking
        it should reveal a menu of comments like the one you saw previously.
         - Clicking an existing comment should cause the menu to close and a
           "Submitting comment" message to appear. It should be shortly
           replaced with a "Your comment has been submitted" message.
         - Clicking "New comment" should reveal a comment form modal.
           - It should not be possible to submit an empty comment.
           - Clicking the "cancel" link should hide the modal.
           - Submitting a new comment should trigger a "Submitting comment"
             message followed by a "Your comment has been submitted"
             message.
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 64740260e51b4249dbc99d151dadfb173cde5298
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Tue Mar 12 11:11:45 2019 +0000

    Bug 19747: Add link to article requests help page
    
    Newer manuals contain information about article requests.
    This patch adds the link to the article request section
    in the manual.
    
    To test:
    - Activate ArticleRequests system preference
    - Go to Circulation > Article requests
    - Click on Help
    - Verify that you end up in the proper section of the manual
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit d3059e6c94f324d6984368fa8b8e77ad1dfbcf71
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Wed Apr 3 15:59:20 2019 +0100

    Bug 20912: (QA follow-up) Fix for missed signature failure
    
    We missed a change in calling parameters passed to CalcDateDue in AddRenewal
    during the initial QAing. This patch corrects the call and adds a test to catch
    regressions.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Acquisition.pm                                  |    1 -
 C4/Circulation.pm                                  |    2 +-
 C4/Installer.pm                                    |   16 +-
 C4/Reserves.pm                                     |    2 +-
 Koha.pm                                            |    2 +-
 Koha/Acquisition/Invoice/Adjustment.pm             |   15 ++
 Koha/Manual.pm                                     |    1 +
 acqui/ordered.pl                                   |    2 +-
 acqui/spent.pl                                     |    2 +-
 installer/data/mysql/kohastructure.sql             |   11 +-
 installer/data/mysql/updatedatabase.pl             |   36 +--
 .../intranet-tmpl/prog/en/includes/accounts.inc    |    1 +
 .../prog/en/includes/acquisitions-menu.inc         |    3 +-
 .../intranet-tmpl/prog/en/includes/holds_table.inc |    2 +-
 koha-tmpl/intranet-tmpl/prog/en/includes/mana.inc  |   44 ----
 .../prog/en/includes/mana/mana-comment-status.inc  |   10 +
 .../en/includes/mana/mana-report-search-result.inc |  190 +++++++++------
 .../prog/en/includes/mana/mana-share-report.inc    |   95 ++++++++
 .../mana/mana-subscription-search-result.inc       |  138 ++++++-----
 .../prog/en/includes/reports-toolbar.inc           |  133 +++--------
 .../prog/en/includes/serials-toolbar.inc           |  102 ++++----
 .../intranet-tmpl/prog/en/modules/acqui/ordered.tt |    6 +-
 .../intranet-tmpl/prog/en/modules/acqui/parcel.tt  |    4 +-
 .../intranet-tmpl/prog/en/modules/acqui/spent.tt   |   12 +-
 .../prog/en/modules/admin/items_search_fields.tt   |    2 +-
 .../prog/en/modules/catalogue/itemsearch.tt        |   18 +-
 .../prog/en/modules/circ/circulation.tt            |    1 +
 .../prog/en/modules/ill/ill-requests.tt            |    7 +-
 .../en/modules/mana/mana-report-search-result.tt   |    2 +-
 .../mana/mana-subscription-search-result.tt        |    2 +-
 .../prog/en/modules/members/boraccount.tt          |   11 +-
 .../prog/en/modules/members/moremember.tt          |    1 +
 .../intranet-tmpl/prog/en/modules/members/pay.tt   |   32 +--
 .../en/modules/reports/guided_reports_start.tt     |  213 ++++++++---------
 .../prog/en/modules/serials/serials-search.tt      |    1 -
 .../prog/en/modules/serials/subscription-add.tt    |   42 +++-
 .../prog/en/modules/serials/subscription-detail.tt |   12 +-
 .../intranet-tmpl/prog/en/modules/tools/letter.tt  |   26 +-
 koha-tmpl/intranet-tmpl/prog/js/holds.js           |   70 +++---
 koha-tmpl/intranet-tmpl/prog/js/mana.js            |   83 +++++++
 .../intranet-tmpl/prog/js/subscription-add.js      |  249 +++++++++++---------
 koha-tmpl/opac-tmpl/bootstrap/css/opac.css         |    2 +-
 koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss    |   12 +-
 .../bootstrap/en/includes/account-table.inc        |   14 +-
 .../bootstrap/en/modules/opac-advsearch.tt         |   17 +-
 .../bootstrap/en/modules/opac-course-details.tt    |    8 +-
 .../bootstrap/en/modules/opac-course-reserves.tt   |    2 +-
 .../opac-tmpl/bootstrap/en/modules/opac-detail.tt  |    4 +-
 misc/cronjobs/overdue_notices.pl                   |    2 +
 opac/opac-export.pl                                |    7 +
 opac/opac-reserve.pl                               |   14 ++
 opac/sco/sco-main.pl                               |    2 +-
 svc/mana/search                                    |    5 +-
 t/db_dependent/Circulation.t                       |    9 +-
 t/db_dependent/Installer.t                         |    8 +-
 .../Koha/Acquisition/Invoice/Adjustments.t         |   10 +-
 t/db_dependent/Reserves.t                          |    2 +-
 57 files changed, 1002 insertions(+), 718 deletions(-)
 delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/mana.inc
 create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/mana/mana-comment-status.inc
 create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/mana/mana-share-report.inc
 create mode 100644 koha-tmpl/intranet-tmpl/prog/js/mana.js


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Fri Apr 12 14:03:10 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Fri, 12 Apr 2019 12:03:10 +0000
Subject: [koha-commits] main Koha release repository branch master updated.
	v18.11.00-1102-g8eb22ef
Message-ID: <E1hEuti-0003iS-CF@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  8eb22efa0893849e2967e34c821c018c6405f8d3 (commit)
       via  d9e9c8545171524c1d1771a98642aa94cc17e74c (commit)
       via  776e552b40258b960c964d7d0baa6a801db23d24 (commit)
       via  8ad273c12592fd8fe0bb18c4d542e714cc4252dc (commit)
       via  cff05f88725e51001ad7c8b409f352570909d460 (commit)
       via  7ff3f68e20ae8739799ec015a82a7eb7a25cf1bf (commit)
       via  65de5781f2b7fa3bc2e8598573050725b2aeaca0 (commit)
       via  73bc117b057bd5ea73c4075d586b644b0cafe00b (commit)
       via  7b90dace95e4c289a2b36b5f95d9116dbd5440db (commit)
       via  8c038b9eab64d16c08a66218ab5bc631ce6a0b09 (commit)
       via  2ecca43004685408d999e2b0a765c55a32c404c5 (commit)
       via  dbe541a99bcd0753f5c050bfdf3b786399c78b1d (commit)
       via  994245e09b6a19df14a4319ed231cc2c5bf087ed (commit)
       via  1fe39ed657bbc1e45181860cc1d9a2d29aff08d6 (commit)
       via  920ac202dc1f91e51f43dd07822636c5bbee6a48 (commit)
       via  0f02c37aab5e2b2cbffbc2fb84e16b5355a33bcf (commit)
       via  8c7bc8946b4d100da841916b4fe5fa12c2505fb5 (commit)
       via  79f1008c7ed97117c248c6aead8742bc64dd0353 (commit)
       via  8b3f1cb151787d742886a328225ceb07d202f2f5 (commit)
      from  08f02c1aa5a6ae1f1ee3b10a086831c1a2dbcb66 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 8eb22efa0893849e2967e34c821c018c6405f8d3
Author: Thatcher Leonard <thatcher.f.leonard at gmail.com>
Date:   Wed Apr 10 23:23:46 2019 +0000

    Bug 18584: Our legacy code contains trailing-spaces
    
    This patch removes trailing spaces and replaces tab characters with
    spaces in the branch transfer limits template.
    
    Mentored-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit d9e9c8545171524c1d1771a98642aa94cc17e74c
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Apr 12 02:01:05 2019 +0000

    Bug 21953: DBRev 18.12.00.043
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 776e552b40258b960c964d7d0baa6a801db23d24
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Tue Apr 9 12:03:22 2019 +0100

    Bug 21953: Clarify PF = Lost item processing fee
    
    Currently PF is only ever used for lost item processing fees. This patch
    alters the end user faceing description to clarify that.
    
    Note: It may be nice to make the code more descriptive too at some
    point, but that can happen in another bug in my opinion.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 8ad273c12592fd8fe0bb18c4d542e714cc4252dc
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Tue Apr 9 12:00:16 2019 +0100

    Bug 21953: (QA follow-up) Corrections to DB Update
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit cff05f88725e51001ad7c8b409f352570909d460
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Mar 6 16:09:06 2019 -0300

    Bug 21953: Update existing rows in DB
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
    Test plan passes.
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 7ff3f68e20ae8739799ec015a82a7eb7a25cf1bf
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Mar 6 16:00:09 2019 -0300

    Bug 21953: Add tests
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 65de5781f2b7fa3bc2e8598573050725b2aeaca0
Author: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com>
Date:   Thu Dec 20 17:12:21 2018 -0500

    Bug 21953: Term 'Lost item' untranslatable
    
    This patch removes the hardcoded untranslatable string
    'Lost item' from C4/Circulation.pm.
    
    To test:
    1) Make sure the system preference WhenLostChargeReplacementFee is set to Charge
    2) Optional: in Administration > Item types, add a default replacement cost to
    the item type you plan to use
    3) Loan an item out to a patron
    (If there is no default replacement cost, make sure the item has a replacement
    price)
    4) In the patron's account > Details > Loans, click on the item's barcode
    5) Set the lost status to Lost
    6) Go back to the patron's account > Fines
    7) Notice it is written 'Lost item , Lost item title barcode (title)'
    8) If you have another language installed, switch to the other language
    and notice the second Lost item is still in English
    9) Apply the patch
    10) Redo steps 3-6
    11) Notice it is written 'Lost item, title barcode (title)'
    12) Optional: switch to another language, notice there is no English string
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 73bc117b057bd5ea73c4075d586b644b0cafe00b
Author: Arthur Suzuki <arthur.suzuki at biblibre.com>
Date:   Wed Mar 27 15:49:04 2019 +0100

    Bug 22597: Remove "more_subfields_xml" from GetPatronInfo response
    
    Test plan
    1/ Set an item with some xml data in more_subfields_xml
    2/ Issue this item to a borrower
    3/ Query the webservice with GetPatronInfo methods and show_loans=1 params
    4/ Check no <more_subfields_xml> tags are returned in the xml response from the webservice
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 7b90dace95e4c289a2b36b5f95d9116dbd5440db
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Wed Feb 6 00:14:01 2019 +0000

    Bug 19648: Revise marc21_field_007.xml
    
    - Removes some doubled up entries
    - Fixes some whitespace issues
    - Adds some missing entries, for example:
        007, nonprojected graphic, secondary support material a-c
    
    To test:
      - Verify that the 007 cataloging plugin works correctly and
        matches standard:
        http://www.loc.gov/marc/bibliographic/bd007k.html
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 8c038b9eab64d16c08a66218ab5bc631ce6a0b09
Author: Liz Rea <wizzyrea at gmail.com>
Date:   Tue Apr 9 17:49:00 2019 +0000

    Bug 18387: (QA Follow up) adding specificity to error template.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 2ecca43004685408d999e2b0a765c55a32c404c5
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon Jul 9 13:30:38 2018 +0000

    Bug 18387: Allow sco-user to access errors templates
    
    To test:
     1 - Enable AuthoSelfCheck prefs
     2 - In opacuserjs or scouserjs add a fetch of an unreachable resources
     3 - Visit the SCO
     4 - Sign in as a patron then click 'finish'
     5 - Say 'yes' to receipt
     6 - Note you are directed to log in
     7 - Apply patch
     8 - Restart all the things
     9 - Repeat 4 & 5
    10 - Sucess, receipt prints
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit dbe541a99bcd0753f5c050bfdf3b786399c78b1d
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Tue Apr 9 13:24:05 2019 +0100

    Bug 22628: Add VOID and FFOR to relevant templates
    
    This patch adds the VOID and FFOR codes to the releveant templates for
    display purposes
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 994245e09b6a19df14a4319ed231cc2c5bf087ed
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Apr 12 01:43:44 2019 +0000

    Bug 21891: DBRev 18.12.00.042
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 1fe39ed657bbc1e45181860cc1d9a2d29aff08d6
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Thu Apr 11 11:03:20 2019 +0000

    Bug 21891: (follow-up) Update database to set blank values to "default"
    
    This patch adds a database update which will update any blank values of
    the XSLTDetailsDisplay system preference to "default." Although a blank
    value will still result in the default XSLT view, it's more consistent
    with the other XSLT preferences to use "default."
    
    To test, apply the patch and set the XSLTDetailsDisplay to a blank
    value. Run the database update. The value of the XSLTDetailsDisplay
    system preference should now be "default."
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 920ac202dc1f91e51f43dd07822636c5bbee6a48
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue Nov 27 17:32:51 2018 +0000

    Bug 21891: Remove non-XSLT detail view in the staff client
    
    This patch removes the non-XSLT markup from the bibliographic detail
    page in the staff client. The XSLTDetailsDisplay preference has
    been altered to accommodate this change. A blank value in
    XSLTDetailsDisplay will now be equivalent to "default."
    
    To test, apply the patch and set the value of XSLTDetailsDisplay to
    either blank or "default."
    
    View the detail page for a bibliographic record in the staff client. The
    XSLT view should be shown.
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 0f02c37aab5e2b2cbffbc2fb84e16b5355a33bcf
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Wed Apr 10 20:42:22 2019 +0000

    Bug 22501: Add raw filter to course reserves summary page
    
    Fixes another place where the public note is shown:
    - Course reserves module start/summary page
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 8c7bc8946b4d100da841916b4fe5fa12c2505fb5
Author: Liz Rea <wizzyrea at gmail.com>
Date:   Tue Apr 9 17:56:43 2019 +0000

    Bug 22501: (QA follow-up) use $raw for the note in the intranet
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 79f1008c7ed97117c248c6aead8742bc64dd0353
Author: Lucas Gass <lucas at bywatersolutions.com>
Date:   Tue Mar 26 17:41:36 2019 +0000

    Bug 22501: OPAC course reserves notes should allow html links
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 8b3f1cb151787d742886a328225ceb07d202f2f5
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Mon Apr 8 18:04:14 2019 +0100

    Bug 22642: Corrections to updatedatebase for bug 12395
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Auth.pm                                         |    2 +-
 C4/Circulation.pm                                  |    2 +-
 C4/ILSDI/Services.pm                               |    1 +
 Koha.pm                                            |    2 +-
 catalogue/detail.pl                                |    2 +-
 installer/data/mysql/updatedatabase.pl             |   17 +-
 .../prog/en/data/marc21_field_007.xml              |   89 ++++++-----
 .../intranet-tmpl/prog/en/includes/accounts.inc    |    3 +-
 .../en/modules/admin/branch_transfer_limits.tt     |   78 +++++-----
 .../en/modules/admin/preferences/staff_client.pref |    2 +-
 .../prog/en/modules/catalogue/detail.tt            |  162 +-------------------
 .../en/modules/course_reserves/course-details.tt   |    2 +-
 .../en/modules/course_reserves/course-reserves.tt  |    4 +-
 .../bootstrap/en/includes/account-table.inc        |    4 +-
 .../bootstrap/en/modules/opac-course-reserves.tt   |    2 +-
 t/db_dependent/Circulation.t                       |    8 +
 16 files changed, 124 insertions(+), 256 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Fri Apr 12 15:17:19 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Fri, 12 Apr 2019 13:17:19 +0000
Subject: [koha-commits] main Koha release repository branch master updated.
	v18.11.00-1120-g7e218b8
Message-ID: <E1hEw3T-0006F3-Pm@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  7e218b81e6f7e4cf8bb8be3aef547cd1c1aac573 (commit)
       via  76599035cb9f604ea4a94928c82cc8efb396ea73 (commit)
       via  8c1bd93a3b1fd37e157173e8a1e813def70b1fa3 (commit)
       via  7205a02a19885d3a1baaab56c8e8749635501104 (commit)
       via  861fe06ab72be3d905ee5aaa1eca273454354a7a (commit)
       via  e155e6d5bba7b48245b2679d5f0b28d46761db93 (commit)
       via  d96fc928560e5353a805ec079bbde26a7e8dc4ce (commit)
       via  a6466f1f3b02915f0c4e578ce13455ad3aacf46c (commit)
       via  13f953317a64f66303db46424baacf15d962c0bd (commit)
       via  6388ffd7025290b1ca3e4c9b7a1ae67dfb63ed72 (commit)
       via  0059dc5a4041f13db11689f9df1bc6475ab45172 (commit)
       via  376d1a70232e7c0e96adbd7c5300ce593c0e120a (commit)
       via  e55b627603450313954b98704e73d0baa3ed56f9 (commit)
       via  dea4f3caaadabc8977453615eb162d8403fa5b5d (commit)
       via  e8fc66f0f612ce6516089894b28899522d13021e (commit)
       via  ace782a1f354c675661d70fa9714ed114364c4b9 (commit)
       via  698efcc0aa2ae48b879b843857e6f12316d5ba83 (commit)
       via  a0e61d8c3e94f2b9e990cc2b60668187047b24bb (commit)
      from  8eb22efa0893849e2967e34c821c018c6405f8d3 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 7e218b81e6f7e4cf8bb8be3aef547cd1c1aac573
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Apr 12 02:52:58 2019 +0000

    Bug 21953: (follow-up) Fix test count
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 76599035cb9f604ea4a94928c82cc8efb396ea73
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Apr 12 02:52:02 2019 +0000

    Bug 10796: Schema changes
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 8c1bd93a3b1fd37e157173e8a1e813def70b1fa3
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Apr 12 02:41:53 2019 +0000

    Bug 10796: DBRev 18.12.00.045
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 7205a02a19885d3a1baaab56c8e8749635501104
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Apr 12 02:36:26 2019 +0000

    Bug 21890: DBRev 18.12.00.044
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 861fe06ab72be3d905ee5aaa1eca273454354a7a
Author: Liz Rea <wizzyrea at gmail.com>
Date:   Wed Mar 27 19:16:56 2019 +0000

    Bug 10796: (QA follow-up) Changing password recovery verbiage for users who are disallowed online password resets
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit e155e6d5bba7b48245b2679d5f0b28d46761db93
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Wed Feb 20 13:58:35 2019 -0300

    Bug 10796: Use $category->effective_change_password in the OPAC
    
    This patch makes the OPAC pages that rely on OpacPasswordChange use the
    current patron's category to make the decision to allow password change
    or not.
    
    It does so by making sure all the places in which OpacPasswordChange was
    used, use $logged_in_user->category->effective_change_password instead.
    
    Special attention is required on the case of opac-registration-verify.pl
    in which the use of an unblessed Koha::Patron object is changed in
    favour of the blessed object, so we can actually use the new method to
    make a decision on the text to display.
    
    To test:
    - Go through the OPAC pages, check that the password change strings and
    links are displayed only whne appropriate.
    - Sign off :-D
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit d96fc928560e5353a805ec079bbde26a7e8dc4ce
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Wed Feb 20 13:36:55 2019 -0300

    Bug 10796: Handle can_change_password on the staff interface
    
    This patch makes the staff interface handle the new flag when editing
    the categories. I didn't add the flag to the list of categories table
    because it makes it too big, but can be easily added if required by
    users or QA.
    
    To test:
    - Along with other patches from this bug, edit patron categories
    => SUCCESS: Notice the changes are correctly stored
    - Sign off :-D
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit a6466f1f3b02915f0c4e578ce13455ad3aacf46c
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Wed Feb 20 13:26:18 2019 -0300

    Bug 10796: Add Koha::Patron::Category->effective_change_password method
    
    This method checks whether the local $self->change_password is set to
    override the OpacPasswordChange syspref (i.e. if it is set to a
    bool) or undef, in which case it falls back to the value of the syspref
    
    To test:
    - Apply this patches
    - Make sure the DB is updated:
      $ updatedatabase
    - Update the schema files:
      $ dbic
    - Run:
      $ kshell
     k$ prove t/db_dependent/Koha/Patron/Category.t
    => SUCCESS: Tests pass!
    - Sign off :-D
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 13f953317a64f66303db46424baacf15d962c0bd
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Wed Feb 20 13:18:00 2019 -0300

    Bug 10796: DB update
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 6388ffd7025290b1ca3e4c9b7a1ae67dfb63ed72
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Mon Apr 1 18:46:21 2019 +0100

    Bug 21890: (QA follow-up) Use List::Util::any
    
    When possible it's a good idea to use `any` from List::Util to shortcut
    on the first occurence of a truthy value.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 0059dc5a4041f13db11689f9df1bc6475ab45172
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Mar 22 11:22:00 2019 -0300

    Bug 21890: Wrap message in span
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 376d1a70232e7c0e96adbd7c5300ce593c0e120a
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Thu Jan 31 16:29:30 2019 -0300

    Bug 21890: Allow restricting password resets by patron category
    
    This patch makes the templates relying on the OpacResetPassword syspref
    use the introduced TT plugin method instead by changing:
    
    [% IF Koha.Preference('OpacResetPassword') %]
    
    =>
    
    [% IF Categories.can_any_reset_password %]
    
    To test:
    - Verify that all the places in which the 'forgot password' link is
    displayed in OPAC keep working, provided there's at least one category
    that has the flag set
    - Attempt to recover the password for a patron that belong to a valid
    category (i.e. that has the flag set)
    => SUCCESS: You can go through the normal process
    - Attempt to recover the password for a patron that belongs to a
    category with the flag unset.
    => SUCCESS: Once Koha identifies your category, you are told you are not
    allowed to do it
    - Sign off :-D
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit e55b627603450313954b98704e73d0baa3ed56f9
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Thu Jan 31 16:27:10 2019 -0300

    Bug 21890: Add can_any_reset_password() to the Categories TT plugin
    
    This patch introduces a method to the Koha::Template::Plugin::Categories
    TT plugin. This methods queries for categories filtering them by
    effective_reset_password flag set, and returns a boolean representing the fact
    that there's at least one category allowed.
    
    To test:
    - Apply this patch
    - Run:
      $ kshell
     k$ prove t/db_dependent/Template/Plugin/Categories.t
    => SUCCESS: Tests pass!
    - Sign off :-D
    
    Caveat: this patch/tests require the schema to be updated
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit dea4f3caaadabc8977453615eb162d8403fa5b5d
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Tue Feb 5 16:44:14 2019 -0300

    Bug 21890: Add Koha::Patron::Category->effective_reset_password method
    
    This method checks wether the local $self->reset_password is set to
    override the OpacResetPassword syspref (i.e. if it is set to a bool) or
    undef, in which case if falls back to the value of the syspref.
    
    To test:
    - Apply this patches
    - Make sure the DB is updated:
      $ updatedatabase
    - Update the schema files:
      $ dbic
    - Run:
      $ kshell
     k$ prove t/db_dependent/Koha/Patron/Category.t
    => SUCCESS: Tests pass!
    - Sign off :-D
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit e8fc66f0f612ce6516089894b28899522d13021e
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Thu Jan 31 16:28:39 2019 -0300

    Bug 21890: Handle can_reset_password on the staff interface
    
    This patch makes the staff interface handle the new flag when editing
    the categories. I didn't add the flag to the list of categories table
    because it makes it too big, but can be easily added if required by
    users or QA.
    
    To test:
    - Along with other patches from this bug, edit patron categories
    => SUCCESS: Notice the changes are correctly stored
    - Sign off :-D
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit ace782a1f354c675661d70fa9714ed114364c4b9
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Thu Jan 31 16:25:59 2019 -0300

    Bug 21890: DB updates
    
    This patch adds a new column to the categories table:
    'reset_password' which is a boolean, and represents, well... that. The
    value itself is nullable.
    
    The idea is that OpacResetPassword governs the general behaviour, and
    this can be overriden at category-level.
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 698efcc0aa2ae48b879b843857e6f12316d5ba83
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Fri Mar 29 19:01:19 2019 +0000

    Bug 21582: Use CodeMirror for *UserJS & *UserCSS
    
    This patch adds CodeMirror syntax highlighting by default to JS and CSS
    system preferences. HTML preferences will use CodeMirror editors if
    UseWYSIWYGinSystemPreferences is disabled.
    
    Three new CodeMirror files are added to support three new syntax
    highlighting modes: XML (for HTML), CSS, and JS.
    
    A new option is added to *.pref file configurations for textareas which
    are intended for HTML, JS, or CSS: syntax. This option is passed to the
    CodeMirror configuration to control syntax highlighting mode.
    
    Textareas without a syntax option specified will not have CodeMirror
    enabled.
    
    To test, apply the patch and go to Administration -> System preferences.
    
    Test the behavior of several preferences which use <textarea> as their
    input. For example:
    
    - OPACUserJS (JS)
    - IntranetUserCSS (CSS)
    - OpacHeader (HTML)
    - BibtexExportAdditionalFields (no highlighting)
    
    Text entry in each of these should have the correct syntax highlighting
    applied to them. All data should be saved correctly.
    
    Test with UseWYSIWYGinSystemPreferences both on and off.
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit a0e61d8c3e94f2b9e990cc2b60668187047b24bb
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Wed Mar 27 08:35:27 2019 -0400

    Bug 22594: Validate SMS messaging numbers using the E.164 format
    
    Many SMS messaging services reject numbers that do not conform to the E.164 international public telecommunication
    numbering plan.
    
    We already tell patrons on the OPAC "Please enter numbers only. (123) 456-7890 would be entered as 1234567890."
    but we do not enforce this. We should be validating the patron's SMS number on both the staff side and the patron
    self-service for updating the SMS number.
    
    Test plan:
    1) Apply this patch
    2) Enable SMS message ( you can set to Email to enable )
    3) Test entering and updating SMS numbers on the OPAC and staff
       interfaces.
    4) Note you can only enter a 1 to 14 digit number with an optional + sign
       at the beginning ( used to indicate the number includes a country calling code )
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha.pm                                            |    2 +-
 Koha/Patron/Category.pm                            |   32 +
 Koha/Schema/Result/Category.pm                     |   18 +-
 Koha/Template/Plugin/Categories.pm                 |   12 +
 admin/categories.pl                                |    9 +
 admin/preferences.pl                               |    4 +-
 installer/data/mysql/kohastructure.sql             |    2 +
 installer/data/mysql/updatedatabase.pl             |   30 +
 koha-tmpl/intranet-tmpl/lib/codemirror/css.js      |  833 ++++++++++++++++++
 koha-tmpl/intranet-tmpl/lib/codemirror/css.min.js  |    1 +
 .../intranet-tmpl/lib/codemirror/javascript.js     |  900 ++++++++++++++++++++
 .../intranet-tmpl/lib/codemirror/javascript.min.js |    1 +
 koha-tmpl/intranet-tmpl/lib/codemirror/xml.js      |  402 +++++++++
 koha-tmpl/intranet-tmpl/lib/codemirror/xml.min.js  |    1 +
 koha-tmpl/intranet-tmpl/prog/css/preferences.css   |    6 +
 .../prog/en/includes/validator-strings.inc         |    3 +-
 .../prog/en/modules/admin/categories.tt            |   64 ++
 .../prog/en/modules/admin/preferences.tt           |   18 +-
 .../en/modules/admin/preferences/cataloguing.pref  |    1 +
 .../en/modules/admin/preferences/circulation.pref  |    6 +
 .../prog/en/modules/admin/preferences/opac.pref    |   43 +-
 .../en/modules/admin/preferences/staff_client.pref |    4 +
 koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt    |    3 +-
 .../prog/en/modules/members/memberentrygen.tt      |    1 +
 koha-tmpl/intranet-tmpl/prog/js/members.js         |   12 +
 .../intranet-tmpl/prog/js/pages/preferences.js     |   51 +-
 .../opac-tmpl/bootstrap/en/includes/masthead.inc   |    3 +-
 .../opac-tmpl/bootstrap/en/includes/usermenu.inc   |    2 +-
 .../opac-tmpl/bootstrap/en/modules/opac-auth.tt    |    3 +-
 .../opac-tmpl/bootstrap/en/modules/opac-main.tt    |    3 +-
 .../bootstrap/en/modules/opac-messaging.tt         |    2 +-
 .../opac-tmpl/bootstrap/en/modules/opac-passwd.tt  |    4 +-
 .../bootstrap/en/modules/opac-password-recovery.tt |    5 +-
 .../en/modules/opac-registration-confirmation.tt   |    8 +-
 opac/opac-memberentry.pl                           |    3 -
 opac/opac-passwd.pl                                |    2 +-
 opac/opac-password-recovery.pl                     |   58 +-
 opac/opac-registration-verify.pl                   |    5 +-
 t/db_dependent/Circulation.t                       |    2 +-
 t/db_dependent/Koha/Patron/Category.t              |  146 ++++
 t/db_dependent/Template/Plugin/Categories.t        |   26 +-
 41 files changed, 2649 insertions(+), 82 deletions(-)
 create mode 100644 koha-tmpl/intranet-tmpl/lib/codemirror/css.js
 create mode 100644 koha-tmpl/intranet-tmpl/lib/codemirror/css.min.js
 create mode 100644 koha-tmpl/intranet-tmpl/lib/codemirror/javascript.js
 create mode 100644 koha-tmpl/intranet-tmpl/lib/codemirror/javascript.min.js
 create mode 100644 koha-tmpl/intranet-tmpl/lib/codemirror/xml.js
 create mode 100644 koha-tmpl/intranet-tmpl/lib/codemirror/xml.min.js
 create mode 100644 t/db_dependent/Koha/Patron/Category.t


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Mon Apr 15 13:22:33 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Mon, 15 Apr 2019 11:22:33 +0000
Subject: [koha-commits] main Koha release repository branch 18.11.x updated.
	v18.11.04-53-gdc4e072
Message-ID: <E1hFzh3-0000QZ-LE@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  dc4e072039c127d28554d46a3f1cbe6dac921d91 (commit)
       via  58e38db49f9d979f7e3b031c5549649c0d8f7481 (commit)
       via  c9e93eea638092c06dcfbcc27c8985683e0916c1 (commit)
       via  1716917fb5f6c6bd5b84fa01e8bedd2a1f0bba1b (commit)
       via  7a7fdac0b263baac5d196c83b17e2c7d830b930d (commit)
       via  912a97f8b49b89d03ed524bed2072db0a50c4527 (commit)
       via  dc32211a8ea12e67453e5af9edaac0a73b52e2de (commit)
       via  df88d3c87a11feb17b7949d2a3567220a07bc196 (commit)
       via  7c39ad305da2c337743fc5122c5a7b5220dea98f (commit)
       via  8a2e6473d7c974a5a0cdccc49be7086789bc6c0e (commit)
       via  8c781986eef08d136939c96f2920d73f54f38888 (commit)
       via  625265be742d27fb27e6b501df1e38e65ad1a878 (commit)
       via  8a501d6e6368d7e72e349bf9909d62acfff6dd49 (commit)
       via  7f81521067d5fcca8ba399a280515ce8942c7284 (commit)
       via  7619c90e0670c2f5dd10d3c0c03a8d3b38ff4f85 (commit)
       via  fd22ef99fe0d78bce28d659323bd8401067f198b (commit)
       via  4a2e88549505afbf28c2e0236f81012789262496 (commit)
      from  170cdc4b01ce53a4ac114ab4d2d45b14af50627f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit dc4e072039c127d28554d46a3f1cbe6dac921d91
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Tue Apr 2 18:02:14 2019 +0000

    Bug 22618: Move tests to t/db_dependent/Acquisition.t
    
    prove -v t/db_dependent/Acquisition.t
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit ea3cbef473a8b542b58341ef38beb9f7be20f4a1)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 58e38db49f9d979f7e3b031c5549649c0d8f7481
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Sat Mar 23 08:13:13 2019 +0000

    Bug 22641: Use raw filter on html slip
    
    To test:
    Enable SCO
    Load a patron
    Hit finish, print slip
    Note slip shows as raw html
    Apply patch
    Repeat, get a correctly formatted slip
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    https://bugs.koha-community.org/show_bug.cgi?id=22068
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 247d0d1df1ee5cc7f3184d8ac6ab35373af739b3)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit c9e93eea638092c06dcfbcc27c8985683e0916c1
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon Dec 24 15:59:22 2018 +0000

    Bug 17978: Unit tests for changes
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 313df03ed06f8c4229b38d0306c380214d895c4e)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 1716917fb5f6c6bd5b84fa01e8bedd2a1f0bba1b
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon Dec 24 14:33:51 2018 +0000

    Bug 17978: Check if hold can be placed before placing on placerequest.pl
    
    To test:
     1 - Set an All/All/All rule with reserves limited 2 to
     2 - Search in the staff side
     3 - Select all records (or more than 2) from the results
     4 - Click 'Place hold'
     5 - Find a patron, place holds
     6 - You get more holds than you should
     7 - Delete those holds
     8 - Apply patch
     9 - Search and select more than 2 records
    10 - Find patron, place holds
    11 - Only 2 holds are placed
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit fa53eb4cfa1d0c2125fc3097e6d2328899fc4259)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 7a7fdac0b263baac5d196c83b17e2c7d830b930d
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Tue Dec 19 14:20:56 2017 -0500

    Bug 17978: Circ rules will not limit holds
    
    The crux of this issue is that all those holds are unfilled record level holds. The code that checks for the number of holds the user already has *always* uses a branchcode of some form. Because of this, any open record level holds are completely ignored for this purpose.
    
    Test Plan:
    1) Set ReservesControlBranch to "item's home library"
    2) Set an All libraries/All Patrons/All itemtypes rules limiting a patron to 2 holds
    3) Place 3 record level holds, you can but you should not be able to!
    4) Delete the holds
    5) Apply this patch
    6) Attempt to place 3 record level holds
    7) Note that you cannot!
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit d7a5925aa0a7a185c8671d8c9989d80bdf2c0939)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 912a97f8b49b89d03ed524bed2072db0a50c4527
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Apr 5 15:13:36 2019 -0300

    Bug 22068: (QA follow-up) Return meaningful error codes
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit e98dacf9f1f8464f0db394da6bc1152f96713597)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit dc32211a8ea12e67453e5af9edaac0a73b52e2de
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Feb 14 17:03:17 2019 -0300

    Bug 22068: Prevent patrons to cancel article request they did not create
    
    opac-article-request-cancel.pl doesn't check that the article request to
    be cancelled actually belongs to the logged-in borrower. This results in
    any logged-in user being able to cancel any article request just by
    changing the id in the URL.
    
    Test plan:
    - Login with Patron P1, create an article request
    - Cancel it
    - Create another one
    - Copy the cancellation link (must be /cgi-bin/koha/opac-article-request-cancel.pl?id=X)
    - Login with Patron P2
    - Hit the cancellation link
    => Without this patch the article request is cancelled
    => With this patch applied there is a 404 redirection
    
    Note that the 404 will also appears when the article request id does not
    exist.
    
    Signed-off-by: Ere Maijala <ere.maijala at helsinki.fi>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 0b931d5de3c4fe9fa2b4823d9b8727b28a46aa7c)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit df88d3c87a11feb17b7949d2a3567220a07bc196
Author: Hayley Mapley <hayleymapley at catalyst.net.nz>
Date:   Thu Mar 7 20:28:48 2019 +0000

    Bug 21003: Made Edit keywords more consistent in add_items-step2.tt
    
    When adding a course reserve with a barcode that already exists, the
    title, breadcrumbs, and legend of the form all specify that the user is
    editing, and not adding, the book.
    
    Test plan:
    Same as comment 1
    
    Signed-off-by: Devinim <kohadevinim at devinim.com.tr>
    Signed-off-by: Bin Wen <bin.wen at inlibro.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 41e0ff7cd6240c2c9ba2d1bec816b191ef091eb1)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 7c39ad305da2c337743fc5122c5a7b5220dea98f
Author: Hayley Mapley <hayleymapley at catalyst.net.nz>
Date:   Thu Mar 7 02:50:12 2019 +0000

    Bug 21003: Removed warning and changed wording on add_items-step2.tt
    
    When editing an item in a Course Reserve, the page displayed is the same
    that is displayed when adding an item to a Course Reserve. This patch
    removes the warning 'This course already has this item on reserve' when
    the item is being edited, as well as changes the title, breadcrumbs, and
    header of the div. This patch also Changes the header of the div to say
    'Edit 'book_name' in 'course_name'' instead of 'Add 'book_name' to
    'course_name'' when adding items to a course reserve if the item is
    already present.
    
    To test:
    1) Create a new course in Course Reserves (you will need Course
        Reserves enabled in syspref)
    2) Add an item by clicking the Add reserves button
    3) Click the edit button on the right hand side of the item listing
    under the Reserves heading
    4) Observe that the warning 'The course already has this item on reserve' appears, and that the title, breadcrumbs and
    header of the div all say Add/Reserve
    5) Apply the patch
    6) Repeat step 3 and observe that the title, breadcrumbs and header of
    the div now say Edit
    7) Also verify that when adding a reserve with a barcode that does not
    yet exist in the course reserves that the warning 'The course already...' is not displayed and that the header of the div says Add
    8) Finally verify that when adding a reserve with a barcode that DOES
    exist in the course reserves that the warning 'The course already...' IS
    displayed and the header of the div says Edit
    9) Sign off!
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 3eee6f3091fcb621152af7f4db6441c98cb74558)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 8a2e6473d7c974a5a0cdccc49be7086789bc6c0e
Author: Hayley Mapley <hayleymapley at catalyst.net.nz>
Date:   Thu Mar 14 03:47:59 2019 +0000

    Bug 12441: Search.pl conditional checks and displays using same syspref
    
    Script search.pl checks OPACdefaultSortField and OPACdefaultSortOrder, but
    shows defaultSortField and defaultSortOrder when using Advanced Search
    in the staff client.
    
    Test plan:
    Apply the patch and then check that the Advanced Search uses
    defaultSortOrder and defaultSortField sysprefs instead of the OPAC
    sysprefs in the conditional. Check that sort behaviour in Advanced
    Search still functions as expected. (It should do - this doesn't change
    what displays, just improves consistency).
    
    Sponsored-by: Catalyst IT
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit c786e4de2369de34ce26610309cbce53534446d3)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 8c781986eef08d136939c96f2920d73f54f38888
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Thu Mar 7 16:04:25 2019 +0000

    Bug 22475: Shelving location doesn't appear on tags list view
    
    This patch corrects the tags list view so that shelving location appears
    correctly. Previously the template tried to display a variable which was
    empty.
    
    To test, apply the patch and locate an title which has both a tag
    applied to it and a shelving location defined for one or more items. Go
    to Tools -> Tags and click the tag to view titles with that tag. In the
    location column of the table the shelving location should appear along
    with library and call number.
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 54cf1df239e3b83ae5550e3ef499038dd5597d95)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 625265be742d27fb27e6b501df1e38e65ad1a878
Author: Bj?rn Nyl?n <bjorn.nylen at ub.lu.se>
Date:   Thu Mar 28 10:28:29 2019 +0100

    Bug 10345: Increment copy number when adding multiple copies.
    
    To test:
    1. Add multiple copies of an item with data in the 'Copy number' field. Note that tha data will be identical for all items.
    2. Apply patch.
    3. Add multiple copies of an item with a positive integer (ie. only digits) in the 'Copy number' field. Note that the copy number is incremented for each item.
    4. Add multiple copies of an item with some other type of data in the 'Copy number' field. Note that the copy number field remains unchanged for the added items.
    
    Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 0e0a3173859d4374087e99e1a7cd929c8da61c76)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 8a501d6e6368d7e72e349bf9909d62acfff6dd49
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Tue Apr 2 09:57:35 2019 +0200

    Bug 22620: OPAC description for CCODE in opac-reserve.tt
    
    Bug 20450 added CCODE to opac-reserve.tt using AuthorisedValues TT plugin.
    
    This patch changes the plugin call so that it requests OPAC description.
    
    Test plan :
    1) Define a CCODE with staff and OPAC descriptions
    2) Apply this collection on an item
    3) At OPAC, place an hold on this item
    4) Verify the collection display correctly OPAC description and not staff description
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 05e49e6be98723f67ec85a5843fad1fc9787925f)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 7f81521067d5fcca8ba399a280515ce8942c7284
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue Mar 26 14:11:28 2019 +0000

    Bug 22575: Item type administration uses invalid error class for dialog
    
    This patch modifies the item types administration script so that it
    passes a valid message type to the template, where the type is used as a
    CSS class. "Error" is a nonexistent dialog class. It should be "alert."
    
    To test, apply the patch and go to Administration -> Item types.
    
     - Try to delete an item type which is in use. The style of the error
       dialog should be correct.
     - Try to add an item type using a code which already exists. The error
       should look correct.
    
    Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
    Signed-off-by: Bin Wen <bin.wen at inlibro.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 40503c8fa86e6c4480ec8ca59e28f0c6f394502d)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 7619c90e0670c2f5dd10d3c0c03a8d3b38ff4f85
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Sat Mar 23 08:51:15 2019 +0000

    Bug 22607: DBRev 18.11.04.001
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit ced69febf3de17691d885e9ee7e03ef46c28b2ae)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit fd22ef99fe0d78bce28d659323bd8401067f198b
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Fri Mar 29 08:13:48 2019 +0000

    Bug 22607: Change default value in issues.renewals to '0'.
    
    This patch change renewals column of issues and old_issues tables.
    
    Now it is NOT NULL default 0. It does not make sense when number of
    renewals is undefined, it is always integer with value zero or more
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit cf95f0a7e6897d3dc4b90c92ffad19230379d7cb)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 4a2e88549505afbf28c2e0236f81012789262496
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Mon Apr 1 12:16:51 2019 +0100

    Bug 22611: Correction for call to get create_item in EDI.pm
    
    There was a typo in the addition of a call to
    effective_create_items causing processing to abort after adding
    a single copy.
    
    This patch reverts to using the C4::Context call as used for the
    first copy created, the intended call to effective_create_items
    is a wrapper around that as the field in the basket is guaranteed
    to be null (its not set when we call AddBasket). Being consistent
    and explicit in what we call should guard against future changes
    in dependencies exposing the logic flaw
    
    Added some comments to make logical flow of code clearer
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit f6bc67e851722451a970d085f51fb11fb03e21b3)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Reserves.pm                                     |    2 +-
 Koha.pm                                            |    2 +-
 Koha/EDI.pm                                        |    6 +-
 admin/itemtypes.pl                                 |   10 +--
 catalogue/search.pl                                |    4 +-
 cataloguing/additem.pl                             |    8 ++
 course_reserves/add_items.pl                       |    2 +
 installer/data/mysql/kohastructure.sql             |    4 +-
 installer/data/mysql/updatedatabase.pl             |   14 ++++
 .../en/modules/course_reserves/add_items-step2.tt  |   12 ++-
 .../en/modules/course_reserves/course-details.tt   |    2 +-
 .../intranet-tmpl/prog/en/modules/tags/list.tt     |    5 +-
 .../opac-tmpl/bootstrap/en/modules/opac-reserve.tt |    2 +-
 .../bootstrap/en/modules/sco/printslip.tt          |    6 +-
 opac/opac-article-request-cancel.pl                |   13 +++-
 reserve/placerequest.pl                            |   14 ++--
 t/Acquisition.t                                    |   68 -----------------
 t/db_dependent/Acquisition.t                       |   80 +++++++++++++++++++-
 t/db_dependent/Holds.t                             |   18 ++++-
 19 files changed, 172 insertions(+), 100 deletions(-)
 delete mode 100644 t/Acquisition.t


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Mon Apr 15 14:17:15 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Mon, 15 Apr 2019 12:17:15 +0000
Subject: [koha-commits] main Koha release repository branch 18.11.x updated.
	v18.11.04-60-g0853986
Message-ID: <E1hG0Xz-0001iX-BS@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  0853986d05d0f13b2033727b975dc7b620aef3e5 (commit)
       via  e78da403bdf3f5d678d7371d58954a2173fa7458 (commit)
       via  1247af85216fc0664de8c667d282aa9c7e605f35 (commit)
       via  8f8bcbbc0dc9f0f1145f7fd30f14749dcddfec26 (commit)
       via  d8eb572eeeffcc35cb9a09534eddd802a6871fb6 (commit)
       via  ec27c57240493a793c91ec96de4448b007e5a972 (commit)
       via  290d2376a213249d8c52c38302dfffe68079ff55 (commit)
      from  dc4e072039c127d28554d46a3f1cbe6dac921d91 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 0853986d05d0f13b2033727b975dc7b620aef3e5
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Mon Apr 15 12:57:54 2019 +0100

    Bug 22618: (RMaint follow-up) Backport fix
    
    Remove tests for bug 15774 not in 18.11.x series that somehow got
    wrongly introduced by the above bug bug backport
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit e78da403bdf3f5d678d7371d58954a2173fa7458
Author: Magnus Enger <magnus at libriotech.no>
Date:   Fri Apr 5 10:03:58 2019 +0200

    Bug 22646: Fix use of PrivacyPolicyURL
    
    To test:
    
    PatronSelfRegistration = Allow
    PatronSelfRegistrationDefaultCategory = PT (or some other real category)
    GDPR_Policy = Enforced
    PrivacyPolicyURL = Some URL
    
    - Go to <opac>/cgi-bin/koha/opac-memberentry.pl and verify that the text "privacy
      policy" displays a link to the current page, not the URL in PrivacyPolicyURL
    - Go to Administration > System preferences > Patrons > Privacy
    - Verify that the descriptions of GDPR_Policy and PrivacyPolicyURL does not
      mention that PrivacyPolicyURL needs to be set if GDPR_Policy is set.
    - Apply the patch
    - Verify that opac-memberentry.pl now links to the URL in PrivacyPolicyURL
    - Verify that the syspref descriptions mention the relationship between them
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Bin Wen <bin.wen at inlibro.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 35921d30a99f3f4c4cdb21438c8516444a10f24c)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 1247af85216fc0664de8c667d282aa9c7e605f35
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Thu Mar 14 13:15:01 2019 +0000

    Bug 21013: Missing itemtype for checkut makes patron summary print explode
    
    This patch moves retrieval of the item type description from the script
    to the template using the ItemTypes template plugin.
    
    To test, apply the patch and locate an item which is checked out to
    someone. Modify the database record for that item to remove the item
    type (items.itype).
    
    View the print summary for the patron who has that item checked out. The
    page should display correctly. Checked-out items which have an item type
    should show that item type description correctly.
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit ea7245631ebfb16d4921a6cf7b4b46799a241ff9)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 8f8bcbbc0dc9f0f1145f7fd30f14749dcddfec26
Author: Ere Maijala <ere.maijala at helsinki.fi>
Date:   Fri Mar 8 13:27:26 2019 +0200

    Bug 22295: Make Elasticsearch query builder group multi-term queries
    
    Test plan:
    
    1. Do an advanced search for
    Title = new
    AND
    Title = york
    2. Verify that the results match an advanced search for:
    Title = new york
    3. Verify that tests in t/db_dependent/Koha/SearchEngine/Elasticsearch still pass
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit e90cb16d79f611caa3cd6d6cbbca4ea01d7a8077)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit d8eb572eeeffcc35cb9a09534eddd802a6871fb6
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Sat Mar 23 11:44:53 2019 +0000

    Bug 22288: Correct item search in batchMod by barcode file
    
    To test:
    1 - Have a list of barcodes that exist in your catalog
    2 - Go to Tools->Batch item modification
    3 - Attempt to modify items using the list
    4 - Get an error page
    5 - Apply patch
    6 - Repeat
    7 - Modification should work correctly
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 192e3baa75f16891582244595fe305292b886dda)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit ec27c57240493a793c91ec96de4448b007e5a972
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Mar 4 16:07:22 2019 -0300

    Bug 22390: Never copy items if original order has been created from a subscription
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Tiny change to the code comment: serial => subscription order
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit d6122ff78d4344441ed45ceb26ed09af83a15d15)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 290d2376a213249d8c52c38302dfffe68079ff55
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Feb 21 14:48:24 2019 -0300

    Bug 22390: (bug 15184 follow-up) Use aqorders.subscriptionid instead of biblio.serial
    
    It seems that we made a wrong assumption on bug 15184, see
      commit d658cb6f7ecb18845a78d4708ee63ad1126f220f
      Bug 15184: Do copy items for not a serial OR if items are created on ordering
    
    To know if an order has been created from a subscription we should check
    $order->subscriptionid instead of the $biblio->serial flag
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit ec78d0cddbb5cf5455a2c67130062917a0a23484)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/Acquisition/Order.pm                          |    2 +-
 Koha/SearchEngine/Elasticsearch/QueryBuilder.pm    |    1 +
 .../prog/en/modules/admin/preferences/patrons.pref |    2 +
 .../prog/en/modules/members/moremember-print.tt    |    3 +-
 .../bootstrap/en/modules/opac-memberentry.tt       |    2 +-
 members/summary-print.pl                           |    3 -
 t/db_dependent/Acquisition.t                       |   35 ----------
 t/db_dependent/Koha/Acquisition/Order.t            |   73 +++++++++++++++++++-
 .../Koha/SearchEngine/Elasticsearch/QueryBuilder.t |   32 ++++++++-
 tools/batchMod.pl                                  |    4 +-
 10 files changed, 111 insertions(+), 46 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Mon Apr 15 14:41:31 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Mon, 15 Apr 2019 12:41:31 +0000
Subject: [koha-commits] main Koha release repository branch 18.11.x updated.
	v18.11.04-65-g746b393
Message-ID: <E1hG0vT-00030f-OJ@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  746b3930d5556d14d4fcc6a64612561edf8fef96 (commit)
       via  ad2a3c5e8034d82edda187aa113029eb4f07b4bb (commit)
       via  07b8478a19e078408c37d9259f5b6110afaffa08 (commit)
       via  f394977ae621fce1923852779feda9aa7f69cdf7 (commit)
       via  a3fe896ebf719caa465660374e35ec78003ab210 (commit)
      from  0853986d05d0f13b2033727b975dc7b620aef3e5 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 746b3930d5556d14d4fcc6a64612561edf8fef96
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Feb 27 12:45:47 2019 -0500

    Bug 20937: Truncate items for print notices when user has an email
    
    To test:
     1 - Set PrintNoticesMaxLines to 1
     2 - Checkout 2 (or more) items to a patron and make them overdue to trigger a
    notice
     3 - Make sure the patron has an email
     4 - Make sure the notice you are sending is set to 'print' as the type
     5 - Run overdue_notices.pl without the 'nomail' option
     6 - Find the message and note all items have been added
     7 - Apply patch
     8 - Clear the message queue
     9 - Re-run overdue_notices.pl
    10 - Confirm the message now has only 1 item.
    11 - Set PrintNoticesMaxLines to 0
    12 - Clear the message queue
    13 - Re-run overdue_notices.pl
    14 - Confirm the message has 2 items as expected
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 083f789b9548ec70d86dc48911df1bc9febda619)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit ad2a3c5e8034d82edda187aa113029eb4f07b4bb
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Sun Apr 7 16:25:28 2019 +0000

    Bug 22075: Fix encoding problem with RIS export in OPAC
    
    When exporting a record with diacritics in RIS
    format from the detail page in OPAC the encoding
    is not correct and the diacritics appear broken.
    
    This patch fixes it.
    
    To test:
    - Find or create a record with some special
      chars in your OPAC
    - Go to the detail page
    - Save as > RIS
    - Verify the diacritics are broken in an editor
    - Apply patch
    - Repeat and verify everything now displays correctly
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit bfeac6486516f185d9882d294d5000ab773c7dd5)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 07b8478a19e078408c37d9259f5b6110afaffa08
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon Mar 25 12:55:03 2019 +0000

    Bug 22541: Invoice adjustments should show invoice number and include link on ordered.pl and spent.pl
    
    To test:
     1 - Find a vendor in acquisitions
     2 - Click 'receive shipment'
     3 - Create an invoice
     4 - Click 'Finish receiving'
     5 - Add an adjustment that encumbers while open and update adjustments
     6 - Go to acqui-home and click on the ordered total for the fund with the adjustment
     7 - Note the invoice adjustment shows the invoice id and does not link
     8 - Add another invoice and another adjustment, but close the invoice this time
     9 - Go to acqui-home and click on the spent total for the fund with the adjustment
    10 - Note the invoice adjustment shows the invoice id and does not link
    11 - Apply patch
    12 - Visit the spent and ordered pages and note the adjustments show invoicenumber and are links
    13 - prove -v t/db_dependent/Koha/Acquisition/Invoice/Adjustments.t
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 3c2ce5df6f550fd2452b978e1b5f7ac54e66b092)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit f394977ae621fce1923852779feda9aa7f69cdf7
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Wed Mar 27 16:19:29 2019 +0100

    Bug 22595: Items search is mixing inputs
    
    Items search is using inputs and selects from search form to create an Ajax call.
    
    In this call selects are parsed before inputs.
    But a custom search field can be used with authorised values and used after a regular search field.
    In this case the "q" param is not ordered like the "name" param.
    
    Test plan :
    1) Go to Administration > Item search fields
    2) Define a search field with an authorised values category
    3) Go to items search
    4) Use a regular filter like call number
    5) Click on new field
    6) Use custom field with an authorised value
    7) Perform search
    => Without patch you get wrong resuts, authorised value is used as value for first field
    => You can see this by listening traffic in Firebug, look at params "f" and "q"
    8) Check some combinaison of select and input filters
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 3e9989568e171ebcfc73df80c49556e0b663a8ae)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit a3fe896ebf719caa465660374e35ec78003ab210
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Tue Mar 12 11:11:45 2019 +0000

    Bug 19747: Add link to article requests help page
    
    Newer manuals contain information about article requests.
    This patch adds the link to the article request section
    in the manual.
    
    To test:
    - Activate ArticleRequests system preference
    - Go to Circulation > Article requests
    - Click on Help
    - Verify that you end up in the proper section of the manual
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 64740260e51b4249dbc99d151dadfb173cde5298)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Acquisition.pm                                    |    1 -
 Koha/Acquisition/Invoice/Adjustment.pm               |   15 +++++++++++++++
 Koha/Manual.pm                                       |    1 +
 acqui/ordered.pl                                     |    2 +-
 acqui/spent.pl                                       |    2 +-
 .../intranet-tmpl/prog/en/modules/acqui/ordered.tt   |    6 +++++-
 .../intranet-tmpl/prog/en/modules/acqui/spent.tt     |   12 ++++++++++--
 .../prog/en/modules/catalogue/itemsearch.tt          |   18 ++++++++----------
 misc/cronjobs/overdue_notices.pl                     |    2 ++
 opac/opac-export.pl                                  |    7 +++++++
 .../Koha/Acquisition/Invoice/Adjustments.t           |   10 +++++++++-
 11 files changed, 59 insertions(+), 17 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Mon Apr 15 14:43:28 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Mon, 15 Apr 2019 12:43:28 +0000
Subject: [koha-commits] main Koha release repository branch 18.11.x updated.
	v18.11.04-66-g975505d
Message-ID: <E1hG0xM-00036I-AM@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  975505deee608414ecb894995161a64505eb3926 (commit)
      from  746b3930d5556d14d4fcc6a64612561edf8fef96 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 975505deee608414ecb894995161a64505eb3926
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue Apr 9 16:06:27 2019 +0000

    Bug 22626: 'Filter paid transactions' broken on Transactions tab in staff
    
    This patch changes a parameter in the function which filters the
    DataTable of transactions. The addition of more columns to the table
    changed the index of the column which is being filtered.
    
    To test, apply the patch and locate a patron who has multiple fines or
    charges, some of them paid. Go to Accounting -> Transactions. Test the
    "Filter paid transactions" link. Table rows which show "0.00" in the
    "Oustanding" column should be hidden.
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 9c0197a8d1b1a29f28de4b91e6605ae0a1088235)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Mon Apr 15 14:47:21 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Mon, 15 Apr 2019 12:47:21 +0000
Subject: [koha-commits] main Koha release repository branch 18.11.x updated.
	v18.11.04-68-g6dd197f
Message-ID: <E1hG117-0003C1-5O@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  6dd197f8be6bb8e2a5170763233b725f0d52eeaa (commit)
       via  ac5c68a9c96fb66989b11cda6ec1d41359f41a32 (commit)
      from  975505deee608414ecb894995161a64505eb3926 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 6dd197f8be6bb8e2a5170763233b725f0d52eeaa
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Apr 11 12:30:50 2019 +0000

    Bug 22680: Compiled CSS
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit d498c2563d76c05a1e819d63d8b56f732c3a7768)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit ac5c68a9c96fb66989b11cda6ec1d41359f41a32
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Wed Apr 10 17:55:22 2019 +0000

    Bug 22680: OPAC language footer not positioned correctly
    
    This patch modifies the OPAC CSS so that the language-selection footer
    is positioned correctly.
    
    To test, apply the patch and rebuild the OPAC CSS.
    
    - Enable one or more translations in the OPAC
    - View a page in the OPAC which can display in your browser without a
      vertical scrollbar (for instance, the OPAC main page with no news
      items or OpacMainUserBlock).
      - The language-selection footer should appear at the bottom of the
        screen. At smaller browser heights the footer should scroll
        offscreen.
      - Test with content in the opaccredits system preference, and with
        OpacKohaUrl enabled. The footer should still be positioned
        correctly.
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit d8a196cc9decd19a5401907adc64c7dee80a0c55)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 koha-tmpl/opac-tmpl/bootstrap/css/opac.css      |    2 +-
 koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss |   12 +++++++-----
 2 files changed, 8 insertions(+), 6 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Mon Apr 15 19:01:23 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Mon, 15 Apr 2019 17:01:23 +0000
Subject: [koha-commits] main Koha release repository branch 18.05.x updated.
	v18.05.11-19-ga86dff7
Message-ID: <E1hG4yx-0002tY-TC@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  a86dff79241710afff8cb68bb8174129c30b31d5 (commit)
      from  c8eee1b25761c5f3867fffc48c2e03ceab56e4ce (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a86dff79241710afff8cb68bb8174129c30b31d5
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Mon Apr 1 12:16:51 2019 +0100

    Bug 22611: Correction for call to get create_item in EDI.pm
    
    There was a typo in the addition of a call to
    effective_create_items causing processing to abort after adding
    a single copy.
    
    This patch reverts to using the C4::Context call as used for the
    first copy created, the intended call to effective_create_items
    is a wrapper around that as the field in the basket is guaranteed
    to be null (its not set when we call AddBasket). Being consistent
    and explicit in what we call should guard against future changes
    in dependencies exposing the logic flaw
    
    Added some comments to make logical flow of code clearer
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit f6bc67e851722451a970d085f51fb11fb03e21b3)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 4a2e88549505afbf28c2e0236f81012789262496)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/EDI.pm |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Mon Apr 15 19:08:46 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Mon, 15 Apr 2019 17:08:46 +0000
Subject: [koha-commits] main Koha release repository branch 18.05.x updated.
	v18.05.11-20-g672357a
Message-ID: <E1hG566-000384-93@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  672357a62a7b99393221b7f1ef437669c7605944 (commit)
      from  a86dff79241710afff8cb68bb8174129c30b31d5 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 672357a62a7b99393221b7f1ef437669c7605944
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue Mar 26 14:11:28 2019 +0000

    Bug 22575: Item type administration uses invalid error class for dialog
    
    This patch modifies the item types administration script so that it
    passes a valid message type to the template, where the type is used as a
    CSS class. "Error" is a nonexistent dialog class. It should be "alert."
    
    To test, apply the patch and go to Administration -> Item types.
    
     - Try to delete an item type which is in use. The style of the error
       dialog should be correct.
     - Try to add an item type using a code which already exists. The error
       should look correct.
    
    Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
    Signed-off-by: Bin Wen <bin.wen at inlibro.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 40503c8fa86e6c4480ec8ca59e28f0c6f394502d)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 7f81521067d5fcca8ba399a280515ce8942c7284)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 admin/itemtypes.pl |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Mon Apr 15 19:32:53 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Mon, 15 Apr 2019 17:32:53 +0000
Subject: [koha-commits] main Koha release repository branch 18.05.x updated.
	v18.05.11-21-ge7e66d4
Message-ID: <E1hG5TR-0003eu-MF@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  e7e66d4938427dd2e7d2be6f24c17bbb16bf7518 (commit)
      from  672357a62a7b99393221b7f1ef437669c7605944 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit e7e66d4938427dd2e7d2be6f24c17bbb16bf7518
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Tue Apr 2 09:57:35 2019 +0200

    Bug 22620: OPAC description for CCODE in opac-reserve.tt
    
    Bug 20450 added CCODE to opac-reserve.tt using AuthorisedValues TT plugin.
    
    This patch changes the plugin call so that it requests OPAC description.
    
    Test plan :
    1) Define a CCODE with staff and OPAC descriptions
    2) Apply this collection on an item
    3) At OPAC, place an hold on this item
    4) Verify the collection display correctly OPAC description and not staff description
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 05e49e6be98723f67ec85a5843fad1fc9787925f)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 8a501d6e6368d7e72e349bf9909d62acfff6dd49)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Mon Apr 15 19:40:14 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Mon, 15 Apr 2019 17:40:14 +0000
Subject: [koha-commits] main Koha release repository branch 18.05.x updated.
	v18.05.11-22-g592ce8b
Message-ID: <E1hG5aY-0003nh-Fd@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  592ce8b80b24dfe302a6263505eee9798a4f8a3c (commit)
      from  e7e66d4938427dd2e7d2be6f24c17bbb16bf7518 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 592ce8b80b24dfe302a6263505eee9798a4f8a3c
Author: Lucas Gass <lucas at bywatersolutions.com>
Date:   Mon Apr 15 17:20:29 2019 +0000

    Bug 22620: RMaint Follow-up reverting bad commit
    
    This reverts commit e7e66d4938427dd2e7d2be6f24c17bbb16bf7518.
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt |    7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Mon Apr 15 19:45:36 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Mon, 15 Apr 2019 17:45:36 +0000
Subject: [koha-commits] main Koha release repository branch 18.05.x updated.
	v18.05.11-23-g15badc6
Message-ID: <E1hG5fk-0003wp-IP@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  15badc6ad43dcb0be8bd290c84fd5550603f91ce (commit)
      from  592ce8b80b24dfe302a6263505eee9798a4f8a3c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 15badc6ad43dcb0be8bd290c84fd5550603f91ce
Author: Bj?rn Nyl?n <bjorn.nylen at ub.lu.se>
Date:   Thu Mar 28 10:28:29 2019 +0100

    Bug 10345: Increment copy number when adding multiple copies.
    
    To test:
    1. Add multiple copies of an item with data in the 'Copy number' field. Note that tha data will be identical for all items.
    2. Apply patch.
    3. Add multiple copies of an item with a positive integer (ie. only digits) in the 'Copy number' field. Note that the copy number is incremented for each item.
    4. Add multiple copies of an item with some other type of data in the 'Copy number' field. Note that the copy number field remains unchanged for the added items.
    
    Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 0e0a3173859d4374087e99e1a7cd929c8da61c76)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 625265be742d27fb27e6b501df1e38e65ad1a878)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 cataloguing/additem.pl |    8 ++++++++
 1 file changed, 8 insertions(+)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Mon Apr 15 19:51:04 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Mon, 15 Apr 2019 17:51:04 +0000
Subject: [koha-commits] main Koha release repository branch 18.05.x updated.
	v18.05.11-24-g6765211
Message-ID: <E1hG5l2-0004Cy-1I@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  676521157970f50914ccb1ea47122ac2ce9d916d (commit)
      from  15badc6ad43dcb0be8bd290c84fd5550603f91ce (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 676521157970f50914ccb1ea47122ac2ce9d916d
Author: Hayley Mapley <hayleymapley at catalyst.net.nz>
Date:   Thu Mar 14 03:47:59 2019 +0000

    Bug 12441: Search.pl conditional checks and displays using same syspref
    
    Script search.pl checks OPACdefaultSortField and OPACdefaultSortOrder, but
    shows defaultSortField and defaultSortOrder when using Advanced Search
    in the staff client.
    
    Test plan:
    Apply the patch and then check that the Advanced Search uses
    defaultSortOrder and defaultSortField sysprefs instead of the OPAC
    sysprefs in the conditional. Check that sort behaviour in Advanced
    Search still functions as expected. (It should do - this doesn't change
    what displays, just improves consistency).
    
    Sponsored-by: Catalyst IT
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit c786e4de2369de34ce26610309cbce53534446d3)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 8a2e6473d7c974a5a0cdccc49be7086789bc6c0e)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 catalogue/search.pl |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Mon Apr 15 20:02:41 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Mon, 15 Apr 2019 18:02:41 +0000
Subject: [koha-commits] main Koha release repository branch 18.05.x updated.
	v18.05.11-25-g625c220
Message-ID: <E1hG5wH-0004Ws-AP@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  625c2201f03ba0084005a3d230dca6460eadfa3b (commit)
      from  676521157970f50914ccb1ea47122ac2ce9d916d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 625c2201f03ba0084005a3d230dca6460eadfa3b
Author: Hayley Mapley <hayleymapley at catalyst.net.nz>
Date:   Thu Mar 7 02:50:12 2019 +0000

    Bug 21003: Removed warning and changed wording on add_items-step2.tt
    
    When editing an item in a Course Reserve, the page displayed is the same
    that is displayed when adding an item to a Course Reserve. This patch
    removes the warning 'This course already has this item on reserve' when
    the item is being edited, as well as changes the title, breadcrumbs, and
    header of the div. This patch also Changes the header of the div to say
    'Edit 'book_name' in 'course_name'' instead of 'Add 'book_name' to
    'course_name'' when adding items to a course reserve if the item is
    already present.
    
    To test:
    1) Create a new course in Course Reserves (you will need Course
        Reserves enabled in syspref)
    2) Add an item by clicking the Add reserves button
    3) Click the edit button on the right hand side of the item listing
    under the Reserves heading
    4) Observe that the warning 'The course already has this item on reserve' appears, and that the title, breadcrumbs and
    header of the div all say Add/Reserve
    5) Apply the patch
    6) Repeat step 3 and observe that the title, breadcrumbs and header of
    the div now say Edit
    7) Also verify that when adding a reserve with a barcode that does not
    yet exist in the course reserves that the warning 'The course already...' is not displayed and that the header of the div says Add
    8) Finally verify that when adding a reserve with a barcode that DOES
    exist in the course reserves that the warning 'The course already...' IS
    displayed and the header of the div says Edit
    9) Sign off!
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 3eee6f3091fcb621152af7f4db6441c98cb74558)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 7c39ad305da2c337743fc5122c5a7b5220dea98f)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 course_reserves/add_items.pl                             |    2 ++
 .../prog/en/modules/course_reserves/add_items-step2.tt   |   14 +++++++++-----
 .../prog/en/modules/course_reserves/course-details.tt    |    2 +-
 3 files changed, 12 insertions(+), 6 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Mon Apr 15 20:05:11 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Mon, 15 Apr 2019 18:05:11 +0000
Subject: [koha-commits] main Koha release repository branch 18.05.x updated.
	v18.05.11-26-g4250579
Message-ID: <E1hG5yh-0004dq-Rj@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  4250579e3f6a7c7e941376b31d48a854f0ad7c43 (commit)
      from  625c2201f03ba0084005a3d230dca6460eadfa3b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4250579e3f6a7c7e941376b31d48a854f0ad7c43
Author: Hayley Mapley <hayleymapley at catalyst.net.nz>
Date:   Thu Mar 7 20:28:48 2019 +0000

    Bug 21003: Made Edit keywords more consistent in add_items-step2.tt
    
    When adding a course reserve with a barcode that already exists, the
    title, breadcrumbs, and legend of the form all specify that the user is
    editing, and not adding, the book.
    
    Test plan:
    Same as comment 1
    
    Signed-off-by: Devinim <kohadevinim at devinim.com.tr>
    Signed-off-by: Bin Wen <bin.wen at inlibro.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 41e0ff7cd6240c2c9ba2d1bec816b191ef091eb1)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit df88d3c87a11feb17b7949d2a3567220a07bc196)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 .../prog/en/modules/course_reserves/add_items-step2.tt             |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Mon Apr 15 20:17:39 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Mon, 15 Apr 2019 18:17:39 +0000
Subject: [koha-commits] main Koha release repository branch 18.11.x updated.
	v18.11.04-77-g9304cea
Message-ID: <E1hG6Al-00059F-Uy@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  9304cea6f04baab588a7de24a06dc14994b46405 (commit)
       via  f7a6adc183ad8829c9e9d391ee918aa1deb218fe (commit)
       via  039967f1e1f60b357ca333d92abcdf47ceca2b4a (commit)
       via  b1628abb3e3262f0eb712236f44991b7bb1799a9 (commit)
       via  6f1738121355fed39b7c9440e3ed47a05788987e (commit)
       via  ac5c0700fcab5e74befef6a2d5f400573d83411b (commit)
       via  764260ded4f350904c548422defb74d32581f65e (commit)
       via  781821b8aec54a5532c1a2da2e39df764f0bbb5e (commit)
       via  99bc0ba719b2e23eb5b89f4ec8fc033461576109 (commit)
      from  6dd197f8be6bb8e2a5170763233b725f0d52eeaa (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 9304cea6f04baab588a7de24a06dc14994b46405
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Mon Apr 15 18:55:21 2019 +0100

    Bug 22121: Display 'Price paid' on ILL requests according to CurrencyFormat pref
    
    To test:
    - Install BLDSS backend
      see: https://wiki.koha-community.org/wiki/ILL_backends
      - Add a new BLDSS ILL request
      - Edit ILL request
      - Fill in Price paid field
      - Verify Price paid is formatted correctly on 'Manage ILL request'
        page
    
    Signed-off-by: Ethan Amohia <ethan.amohia at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (reimplimentation of commit 1493c42e7bae5bffab430072587b7aa0527f6fc7 for 18.11.x series)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit f7a6adc183ad8829c9e9d391ee918aa1deb218fe
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Mar 7 09:14:25 2019 -0300

    Bug 22472: Make column_exists early return if the table does not exist
    
    On the way we move TableExists to C4::Installer, where it belongs to.
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 7208ac6196a8619dbb0cca3b6f01480f4c46cab1)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 039967f1e1f60b357ca333d92abcdf47ceca2b4a
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Mar 7 09:14:06 2019 -0300

    Bug 22472: Add tests
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 19b9aacfbae616f7198cd93ebdbd97115d204c5b)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit b1628abb3e3262f0eb712236f44991b7bb1799a9
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Thu Apr 4 00:56:43 2019 +0000

    Bug 21659: Change link to basket group edit page
    
    I have taken another look at other links like the one
    from acq order search and changed the link to not lead
    to the vendor's basket group page but to the edit page
    of the invidividual basket group.
    
    To test:
    - Same as first patch, verify links now lead
      to the basket grou edit page
    
    https://bugs.koha-community.org/show_bug.cgi?id=21650
    
    Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos at inLibro.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 9cbc5f2aa072ec41a70fd1fa1de4f684fcd695e9)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 6f1738121355fed39b7c9440e3ed47a05788987e
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Mon Mar 11 16:24:16 2019 +0000

    Bug 21659: Fix links to basket groups from order receive page
    
    Fixes a problem with the template variables on the order
    receive page, so that the links to basket groups work
    correctly again.
    
    To test:
    - Create some orders with and without basket groups
    - Receive shipment
    - Verify that the basket group links for pending orders work right
    - Receive an order line
    - Verify that the basket group links for received orders work right
    
    Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos at inLibro.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 3db5feb900d3e6a6400767c771afe78bab0fa880)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit ac5c0700fcab5e74befef6a2d5f400573d83411b
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Wed Apr 3 22:35:38 2019 +0200

    Bug 22634: Standardize table creation for stockrotation* tables in kohastructure.sql
    
    The existing pattern is:
    DROP TABLE IF EXISTS ...
    CRATE TABLE
    
    Stockrotation was using:
    CREATE TABLE IF NOT EXISTS ...
    which would not recreate the table in a database it's already
    existing in possibly causing mismatches in table structure.
    
    To test:
    - Drop your database
    - Run through the web installer
    - Make sure there are no Database/SQL errors
    - Makse sure the 4 stockrotation tables have been created
    
    Signed-off-by: Fr?d?ric Demians <f.demians at tamil.fr>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit fbdb2b2be009140be6f9b5b84c765741bc828a3c)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 764260ded4f350904c548422defb74d32581f65e
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Mon Apr 1 19:15:18 2019 +0000

    Bug 22624: Show OPAC description for authorised values in OPAC
    
    Patch adds the IS_OPAC parameter to a few GetByCode calls in
    OPAC files.
    
    To test:
    - Add different OPAC and intranet descriptions to some authorised
      value categories:
      - TERM
      - DEPARTMENT
      - LOC
      - CCODE
    - Create a new course using the values and adding items to it
    - Check the course reserves overview and detail pages in OPAC
    - Verify Department, term, location, and collection show
      the OPAC description if existing
    - Create a subscription, make sure a default location is selected
    - Check the OPAC detail page, subscription tab for this subsription
      in the OPAC
    - Verify the location of the subscription displays correctly
    
    Signed-off-by: Mika?l Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 3323a428eaf662a0ba1a31b2cb56002a7372461a)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 781821b8aec54a5532c1a2da2e39df764f0bbb5e
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Thu Apr 4 18:27:28 2019 +0000

    Bug 13629: SingleBranchMode removes both library and availability search from advanced search
    
    This patch modifies the OPAC advanced search form so that it is possible
    to limit searches to available items even if there is only one library.
    
    To test, apply the patch and go to the advanced search page in the OPAC.
    
     - With only one library configured: There should be a section labeled
       "Availability" with just the "only available" checkbox.
    
     - With multiple libraries: The section should be labeled "Location and
       availability" and should have the library dropdown and the
       availability checkbox.
    
    Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 7acb5394e1f62728c90a1d18e988c23a3e2862d2)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 99bc0ba719b2e23eb5b89f4ec8fc033461576109
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Thu Apr 4 14:05:21 2019 +0000

    Bug 14358: Changing the module refreshes the page and resets library choice
    
    This patch makes an incremental change towards fixing Bug 14358: The
    "New notice" button is converted to a dropdown button which asks the
    user to select a module to start with.
    
    To test, apply the patch and go to Tools -> Notices. Test the "New
    notice" button and confirm that module selections are reflected in the
    notice add form you are shown.
    
    Signed-off-by: Mika?l Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit edf173e6ef1fa6de6e07f41c229799733456901a)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Installer.pm                                    |   16 +++++++++++-
 installer/data/mysql/kohastructure.sql             |    9 ++++---
 installer/data/mysql/updatedatabase.pl             |   15 -----------
 .../intranet-tmpl/prog/en/modules/acqui/parcel.tt  |    4 +--
 .../prog/en/modules/ill/ill-requests.tt            |    7 +++---
 .../intranet-tmpl/prog/en/modules/tools/letter.tt  |   26 +++++++++++++++-----
 .../bootstrap/en/modules/opac-advsearch.tt         |   17 +++++++++++--
 .../bootstrap/en/modules/opac-course-details.tt    |    8 +++---
 .../bootstrap/en/modules/opac-course-reserves.tt   |    2 +-
 .../opac-tmpl/bootstrap/en/modules/opac-detail.tt  |    2 +-
 t/db_dependent/Installer.t                         |    8 ++++--
 11 files changed, 74 insertions(+), 40 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Mon Apr 15 20:28:31 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Mon, 15 Apr 2019 18:28:31 +0000
Subject: [koha-commits] main Koha release repository branch 18.05.x updated.
	v18.05.11-28-g147d67c
Message-ID: <E1hG6LH-0005dV-FM@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  147d67cebfa6a67b0a783fda03be588d08910a7c (commit)
       via  96a700c3dd0d4008c6c0250ac24c8c0c2e8b9dee (commit)
      from  4250579e3f6a7c7e941376b31d48a854f0ad7c43 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 147d67cebfa6a67b0a783fda03be588d08910a7c
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Apr 5 15:13:36 2019 -0300

    Bug 22068: (QA follow-up) Return meaningful error codes
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit e98dacf9f1f8464f0db394da6bc1152f96713597)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 912a97f8b49b89d03ed524bed2072db0a50c4527)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit 96a700c3dd0d4008c6c0250ac24c8c0c2e8b9dee
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Feb 14 17:03:17 2019 -0300

    Bug 22068: Prevent patrons to cancel article request they did not create
    
    opac-article-request-cancel.pl doesn't check that the article request to
    be cancelled actually belongs to the logged-in borrower. This results in
    any logged-in user being able to cancel any article request just by
    changing the id in the URL.
    
    Test plan:
    - Login with Patron P1, create an article request
    - Cancel it
    - Create another one
    - Copy the cancellation link (must be /cgi-bin/koha/opac-article-request-cancel.pl?id=X)
    - Login with Patron P2
    - Hit the cancellation link
    => Without this patch the article request is cancelled
    => With this patch applied there is a 404 redirection
    
    Note that the 404 will also appears when the article request id does not
    exist.
    
    Signed-off-by: Ere Maijala <ere.maijala at helsinki.fi>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 0b931d5de3c4fe9fa2b4823d9b8727b28a46aa7c)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit dc32211a8ea12e67453e5af9edaac0a73b52e2de)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 opac/opac-article-request-cancel.pl |   13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Tue Apr 16 15:40:04 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Tue, 16 Apr 2019 13:40:04 +0000
Subject: [koha-commits] main Koha release repository branch master updated.
	v18.11.00-1154-gfc6b7e5
Message-ID: <E1hGOJg-00057w-Ic@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  fc6b7e5c3e101e0c5935f34c45b72cf3fd4f1bb7 (commit)
       via  8e77287b9b2453fc29980d57154030c52cc62a07 (commit)
       via  a8e95a189f8842797395469680f686fba16fdca3 (commit)
       via  8465b60a8e63ce53bf8225616fffe53b89e8c7b4 (commit)
       via  37970eead1d265b6123f370afd87ac189d4e5e51 (commit)
       via  b74be6724b4b25c73b1e6f22d0ba270b50af755c (commit)
       via  6d6aa48f6adbb8c60f44dde6c6bb8fbf9afdbf8b (commit)
       via  2d7eba5be3f99d33533de4f32a88cca4de94b755 (commit)
       via  44a39929afc60ddda3182a93197ced098044a12d (commit)
       via  9df6a7d14f3dd869c00e514d7c3c45238aaaccc0 (commit)
       via  d4f133b0c03a0ef71ba689cea9abbea0a5149b80 (commit)
       via  3a3ffbc54b8dec8ee63332417fe2732ee93f3034 (commit)
       via  0be8fd212067ebd4b36e00b4d139761aa0e021c3 (commit)
       via  003b70b697f9c57da8bfb0aca1223c867a07ac97 (commit)
       via  a131ffca088a8bf6a687cd57a7162c8511c88124 (commit)
       via  6a58da7da2a3f72825d8b610961961a5f65f1af3 (commit)
       via  34c835ed141a3b4758ad77e5b72f30e83d57024f (commit)
       via  118f685dbf1519077ece65a47f83bff179efbf9b (commit)
       via  1a2572915b4bf4a11b3a65c3a65e506610263a03 (commit)
       via  545a3a1295b908ac79f8fd379374f5776d5b455d (commit)
       via  3e7b24e023c7c88eb9b1a30308a537de9dcd8682 (commit)
       via  a48d1a43df24a47f1d31cd437a54961934d50230 (commit)
       via  ae18c4bb031a194302ced37f4b376c7439f77c99 (commit)
       via  111068485d455d2020d68a69d29a562547e345c6 (commit)
       via  2c461fc508d6161c3ab60b523bd724eef20870b9 (commit)
       via  f1c150c98fb60ea75eae7d3b55adbcb7620b7519 (commit)
       via  be3c2abbdc3410ea0cd7e9aa908329d9b46d8c14 (commit)
       via  4d3461a671f8ad95917aab9ac193cd69fe6c1691 (commit)
       via  ba14e9ca7d40af664f7079c6a9f85a85e88fca9a (commit)
       via  8cb24d65849aa881a0e6eb74271ca2d9c7ea455c (commit)
       via  d5d4501290704b9b3a0893a4a3df0a356abe445b (commit)
       via  5ed171a45c46f63b18266ad3a3d0a978719ca285 (commit)
       via  230905e1d56a11cf5619f95c95920eb09803900c (commit)
       via  48787acc6f725686583bb05f45888acf3e1231d0 (commit)
      from  7e218b81e6f7e4cf8bb8be3aef547cd1c1aac573 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit fc6b7e5c3e101e0c5935f34c45b72cf3fd4f1bb7
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Tue Apr 16 13:14:17 2019 +0000

    Bug 14457: DBRev 18.12.00.047
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 8e77287b9b2453fc29980d57154030c52cc62a07
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Wed Apr 3 21:20:40 2019 +0000

    Bug 14457: (QA follow-up) Fix POD
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit a8e95a189f8842797395469680f686fba16fdca3
Author: Bj?rn Nyl?n <bjorn.nylen at ub.lu.se>
Date:   Wed Mar 13 12:28:55 2019 +0100

    Bug 14457: (QA follow-up) Fix QA script complaints and amend system preference text
    
    Pod coverage for 'NAME'.
    Moved sysprefs in order and moved semicolon to last line.
    Replaced tab indentation with spaces.
    Added "Swedish service for spellchecking" to the syspref description.
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 8465b60a8e63ce53bf8225616fffe53b89e8c7b4
Author: Chris Cormack <chrisc at catalyst.net.nz>
Date:   Thu Sep 29 21:47:52 2016 +0000

    Bug 14457: (follow-up) Add syspref for Libris API URL
    
    Added another syspref for the url of the Libris API
    Added sysprefs to syspref.sql
    
    Please test the 2 patches together
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 37970eead1d265b6123f370afd87ac189d4e5e51
Author: Eivin Giske Skaaren <eskaaren at yahoo.no>
Date:   Mon Jul 6 21:46:49 2015 +0000

    Bug 14457: Integrate LIBRIS spellchecking
    
    This patch makes it possible to configure LIBRIS spellchecker as a
    "did you mean" feature. When searching for a word or phrase and misspelling
    the query will be sent to LIBRIS and if they have a suggestion it will
    be shown in the yellow did you mean box in the results page.
    
    The API is not very quick so this type of implementation was chosen to not
    disrupt the real-time feeling of the search.
    
    To test:
    
    1. Apply the patch.
    2. Go to http://api.libris.kb.se/bibspell/, enter the koha servers IP and click
    on the "Generera nyckel" button.
    3. Under "Nyckel" you can copy the value that looks like this: E47B44829E265607274B677BC17B8D78,
    and enter it into the LibrisKey syspref (cgi-bin/koha/admin/preferences.pl?tab=searching).
    4. In cgi-bin/koha/admin/didyoumean.pl check the box for using the LIBRIS API. It is only implemented for OPAC.
    5. Perform some searches:
    tset - Did you mean should suggest: test
    jeg ?r p? smester - suggestion: jag ?r p? semester
    dantes inferna - suggestion: dantes inferno
    
    Restored opac-search.pl
    
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    
    Seems to work, of course I can't tell if it is giving me accurate
    suggestions :)
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit b74be6724b4b25c73b1e6f22d0ba270b50af755c
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Thu Mar 28 08:53:46 2019 +0000

    Bug 22588: (follow-up) Simplify getting accounts even more
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 6d6aa48f6adbb8c60f44dde6c6bb8fbf9afdbf8b
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Wed Mar 27 08:27:13 2019 +0000

    Bug 22588: Simplify getting fines information in opac and selfcheckout
    
    Test plan:
    0) Have patron with some fines and credits
    1) Go to opac and log in
    2) Go to 'your summary' page and confirm it shows the right amount and
    description for both, credit and debit
    3) Go to 'your fines' page and confirm it show right information
    4) Go to self checkout page and confirm the fines are right here
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 2d7eba5be3f99d33533de4f32a88cca4de94b755
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue Mar 26 16:34:34 2019 +0000

    Bug 22698: Fix incorrect button classes
    
    This patch builds on Bug 22023 in making further corrections to toolbar
    button classes.
    
    To test, apply the patch and view the following pages to confirm that
    toolbar buttons are consistent:
    
    - Acquisitions -> Vendor -> View basket.
    - Administration -> Additional fields -> Select a table.
    - Administration -> Audio alerts.
    - Catalog -> Advanced search -> More/fewer options link
    - Cataloging -> Edit record -> Advanced editor -> Advanced search.
    - Cataloging -> Edit record -> Advanced editor -> Macros.
    - Cataloging -> Edit record -> MARC21 008 value builder.
    - Cataloging -> Search results.
    - Circulation -> Checkout notes.
    - Circulation: Sticky due date clear button, view restrictions, override
       restrictions temporarily, add message, delete message
    - Course reserves: Toolbar buttons on that page and the course reserve
       detail page.
    - ILL requests -> View ILL requests. The "New ILL request" and "List
       requests" button.
    - Lists and Lists -> View list.
    - Patrons -> Search -> Merge patrons.
    - Patrons -> View patron -> "Edit" button on patron image (patronimages
       must be enabled).
    - Patrons -> View patron -> "More" menu -> Manage API keys.
    - Patrons -> View patron -> "More" menu -> Set permissions.
    - Patrons -> View patron -> Delete circulation message link.
    - Patrons -> View patron -> Edit patron.
    - Patrons -> View patron -> Housebound.
    - Reports -> Dictionary.
    - Serials -> Numbering patterns.
    - Serials -> Subscription -> Receive.
    - Tools -> Labels -> Manage -> Label batches: Export selected.
    - Tools -> Patron card creator -> Manage -> Card batches -> Edit batch.
    - Tools -> Patron card creator. The "New" and "Manage" buttons.
    - Tools -> Patron clubs.
    - Tools -> Quote editor -> Import quotes.
    - Tools -> Rotating collections. Toolbar buttons on that page and the
       collection view page.
    - Tools -> Tags.
    - Tools -> Upload local cover image.
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 44a39929afc60ddda3182a93197ced098044a12d
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Thu Apr 4 01:36:47 2019 +0000

    Bug 22154: Fix search for Braille from Advanced search page
    
    When you do an advanced search and choose the Format subtype
    Braille, it looks for l-format:fk, but that is not the right
    code for Braille.
    
    fk does not exist. It should be fb for Tactile material/Braille
    OR tc for Text/Braille
    
    To test:
    0) Catalog 2 records, one with 007 tc and another with fb
       Use value builder to verify both are for Braille.
    1) In Administration > System preferences, make sure 'Subtypes'
       is checked in either OpacAdvSearchMoreOptions or OpacAdvSearchOptions
    2) Go to Advanced search
    3) If necessary, click on 'More options'
    4) In the 'Subtype limits' section, choose 'Braille' from the 'Format'
       drop-down menu
    5) Click on 'Search'
    6) Verify both records were found
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 9df6a7d14f3dd869c00e514d7c3c45238aaaccc0
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Fri Apr 12 11:51:52 2019 +0200

    Bug 21975: (follow-up) avoid undef in eq
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit d4f133b0c03a0ef71ba689cea9abbea0a5149b80
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Fri Apr 12 11:42:39 2019 +0200

    Bug 21975: (follow-up) get item datas from previous SQL query
    
    Forced by removal of C4::Items::GetItem from Bug 21206
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 3a3ffbc54b8dec8ee63332417fe2732ee93f3034
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Fri Dec 7 16:05:52 2018 +0100

    Bug 21975: Avoid unnecessary substitutions in automatic item modification by age
    
    Automatic item modification by age cronjob is based on rules with conditions and substitutions.
    When substitution value is equal to actual item value, the code should not call C4::Items::ModItem. It adds unnecessary action log and entry in zebraqueue.
    With a rule than can impact all catalogue you can explode your database with action logs.
    
    Test plan :
    1) Run prove t/db_dependent/Items/AutomaticItemModificationByAge.t
    2) Define a item modification by age with no condition
    3) Run several times misc/cronjobs/automatic_item_modification_by_age.pl
    4) Check it creates only one entry in action_logs and zebraqueue
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 0be8fd212067ebd4b36e00b4d139761aa0e021c3
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Fri Dec 7 15:21:48 2018 +0100

    Bug 21975: add Unit Test
    
    Added missing transaction rollback
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 003b70b697f9c57da8bfb0aca1223c867a07ac97
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Fri Dec 7 15:58:54 2018 +0100

    Bug 21975: get item field in substitutions
    
    substitutions field stores the item field with 'items.' prefix.
    Looks like call of C4::Items::ModItem() works but it will not if ORM object is used in the futur.
    So I prefer fix it now and it is needed for main patch.
    
    Test plan :
    Run t/db_dependent/Items/AutomaticItemModificationByAge.t
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit a131ffca088a8bf6a687cd57a7162c8511c88124
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Tue Apr 16 12:12:11 2019 +0000

    Bug 22695: DBRev 18.12.00.046
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 6a58da7da2a3f72825d8b610961961a5f65f1af3
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Fri Apr 12 12:52:52 2019 +0000

    Bug 22695: Remove non-XSLT search results view from the staff client
    
    This patch removes the option to select non-XSLT search results in the
    staff client. The patch removes the markup from the template, updates
    the system preference options, and modifies Search.pm so that OPAC and
    staff client results XSLT functions are not tied together.
    
    To test, apply the patch and set the XSLTResultsDisplay to a blank
    value. Run the database update. The value of the XSLTResultsDisplay
    system preference should now be "default."
    
    Perform a catalog search in the staff client. The results should be
    shown using the XSLT view.
    
    Test that OPAC search results respect the OPACXSLTResultsDisplay
    preference when enabled and disabled.
    
    Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
    Signed-off-by: Bin Wen <bin.wen at inlibro.com>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 34c835ed141a3b4758ad77e5b72f30e83d57024f
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Fri Apr 12 11:04:06 2019 +0000

    Bug 18011: Enrollment period date on patron category can be set in the past without any error/warning messages
    
    This patch modifies the patron category edit form so that the enrollment
    period datepicker widget cannot be used to select a date in the past.
    
    The <input> element had a "datepicker" class, which triggers a default
    datepicker configuration. This was overriding the configuration in the
    page-specific JavaScript file.
    
    To test, apply the patch and go to Administration -> Patron categories.
    
    Click the "Enrollment period -> Until date" field and verify that dates
    before today are disabled.
    
    Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 118f685dbf1519077ece65a47f83bff179efbf9b
Author: Ere Maijala <ere.maijala at helsinki.fi>
Date:   Thu Mar 7 16:35:30 2019 +0200

    Bug 22474: Clone field config before adding fields to it
    
    Test plain:
    
    1. Reindex both authorities and biblios with the -d flag to recreate the index, e.g. "perl misc/search_tools/rebuild_elastic_search.pl -v -d"
    2. Check that authorities only contains authority-specific fields in Elasticsearch e.g. by fetching  http://localhost:9200/koha_dev_authorities/_mappings
    3. Reindex both without the -d flag and verify it works, e.g. "perl misc/search_tools/rebuild_elastic_search.pl -v"
    
    Signed-off-by: Bj?rn Nyl?n <bjorn.nylen at ub.lu.se>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 1a2572915b4bf4a11b3a65c3a65e506610263a03
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Sun Apr 7 18:23:32 2019 +0000

    Bug 22090: Add missing information to cash register CSV file
    
    Some information was missing from the CSV export file
    of the Cash register report: manager surname, patron surname
    and payment notes.
    
    Also pretties up the column headers a bit and makes the
    sequence between GUI and CSV export match.
    
    To test:
    - Make sure you have some fines and fees and payments in
      your system
    - Make a search with the Cash register report
    - Export results as CSV
    - Proof read hader line and make sure contents match headings
    - Verify first name and surname are shown for manager and patron
    - Verify notes show up
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 545a3a1295b908ac79f8fd379374f5776d5b455d
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Tue Apr 16 11:52:46 2019 +0000

    Bug 22069: (follow-up) fix patorns type for patrons
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 3e7b24e023c7c88eb9b1a30308a537de9dcd8682
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Sun Apr 7 17:51:13 2019 +0000

    Bug 22069: Make log viewer find item renewals
    
    Without this patch renewals for checkouts wouldn't
    show in the log viewer. The log viewre was using
    RENEW, which we use for patrons, but for issue
    RENEWAL is used.
    
    The patch adds RENEWAL to the search params, when
    Renew was selected in the form, so both terms are
    included in the query.
    
    To test:
    - Make sure you have RenewalLog turned on
    - Make a patron renewal
    - Check something out and renew it
    - Go to Tools > Log viewer and test different
      searches
      - Modules All - Actions All
      - Modules All - Actions Renew
      - Modules Circulation - Actions Renew
      ...
    - Make sure results show as expected
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit a48d1a43df24a47f1d31cd437a54961934d50230
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Thu Apr 11 17:15:51 2019 -0300

    Bug 22688: (QA follow-up) Use search_params as all() does
    
    It looks like selected would be passed all the way down to
    Koha::Libraries->search and this would fail all the time.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit ae18c4bb031a194302ced37f4b376c7439f77c99
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Apr 11 09:52:29 2019 -0400

    Bug 22688: TT plugin for pickup locations code wrong
    
    Test Plan:
    1) Apply this patch
    2) prove t/db_dependent/Koha/Libraries.t
    
    Signed-off-by: Agust?n Moyano <agustinmoyano at theke.io>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 111068485d455d2020d68a69d29a562547e345c6
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Thu Apr 11 17:14:05 2019 -0300

    Bug 22688: (follow-up) Unit tests
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 2c461fc508d6161c3ab60b523bd724eef20870b9
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Apr 11 10:13:58 2019 -0400

    Bug 22688: Unit tests
    
    Signed-off-by: Agust?n Moyano <agustinmoyano at theke.io>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit f1c150c98fb60ea75eae7d3b55adbcb7620b7519
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Tue Feb 26 13:54:28 2019 +0000

    Bug 22451: Use Asset everywhere
    
    Test plan:
    Use installer and onboaarding tool, make sure the js and css files are
    loaded
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit be3c2abbdc3410ea0cd7e9aa908329d9b46d8c14
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Tue Feb 26 13:43:21 2019 +0000

    Bug 22451: Update test
    
    Test plan:
    prove t/db_dependent/Koha/Template/Plugin/Asset.t
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 4d3461a671f8ad95917aab9ac193cd69fe6c1691
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Tue Feb 26 13:30:20 2019 +0000

    Bug 22451: Make Asset plugin use Koha::version instead of version from db
    
    Test plan:
    Apply the patch a try to use Koha, css and js files should be used
    normally
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit ba14e9ca7d40af664f7079c6a9f85a85e88fca9a
Author: Lyon3 Team <koha at univ-lyon3.fr>
Date:   Thu Apr 11 10:48:42 2019 +0200

    Bug 22652: Editing Course reserves is broken
    
    To test:
    1. Create a course reserve or go on an existing one
    2. Add items and add a change for the holdingbranch
    3. On the list of items in this course reserve
    (course_reserves/course-details.pl?course_id=xx), click on "edit" at the
    end of a row :
    
    Without the patch, you can't see the holdingbranch you have choose for
    this item, but you see "LEAVE UNCHANGED"
    
    With the patch, you can see the holdingbranch you have choose when
    adding this item in the course
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Mika?l Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 8cb24d65849aa881a0e6eb74271ca2d9c7ea455c
Author: Olivier Crouzet <kohateam at univ-lyon3.fr>
Date:   Mon Mar 11 15:00:23 2019 +0100

    Bug 20830: Make sure a fund is selected when ordering from a stage file
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit d5d4501290704b9b3a0893a4a3df0a356abe445b
Author: Christopher Brannon <cbrannon at cdalibrary.org>
Date:   Wed Dec 5 20:33:25 2018 +0000

    Bug 21346: Remove inline onclicks per comment 42
    
    To test:
    1)  Apply patch.
    2)  Check that there is no changed behavior with buttons or checkboxes.
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 5ed171a45c46f63b18266ad3a3d0a978719ca285
Author: Christopher Brannon <cbrannon at cdalibrary.org>
Date:   Sun Nov 4 03:47:30 2018 +0000

    Bug 21346: Convert dialogs to modals.
    
    This addresses most of the transfer dialogs.  There are some dialogs
    that I have not converted because I don't know what triggers them,
    therefore I cannot test them.
    
    The following scenarios have been addresses, and should be tested:
    
    FOR TRANSFERS
    
    1) Checkin with no issue, hold or transfer; not at home (AutomaticItemReturn set to Don't)
         * Should give 3 options - Yes, Yes with print, or No.
         * Yes and Yes with print should trigger a transfer back home.
         * No should do nothing.
         * Print should open a window for printing, with correct
         information.
         * All three options should close the modal.
    
         TO TEST:
         1) Set AutomaticItemREturn to Don't.
         2) Check in an item with no issues, holds or transfers set, at a
         location other than the owning library.
         3) Test conditions above.
    
    2) Checkin with no issue, hold or transfer; not at home (AutomaticItemReturn set to Do)
        * Should give 2 options - Print or OK.
        * Should automatically set transfer.
        * Print should open a window for printing, with correct information.
        * Both buttons should close modal.
    
        TO TEST:
        1) Set AutomaticItemReturn to Do.
        2) Check in an item with no issues, holds or transfers set, at a
        location other than the owning library.
        3) Test conditions above.
    
    3) Checkin with no issues or holds, but transfer already set
        * Should give 3 options - OK, Print or Cancel.
        * OK and print should not touch existing transfer.
        * Cancel should remove the exisiting transfer.
        * Print should open a window for printing, with correct information.
        * All three options should close the modal.
    
        TO TEST:
        1) Check in an item following step 2 of either test above.
        2) Check in item again, while a transfer exists.
        3) Test conditions above.
    
    WRONG BRANCH
    
    4) If AllowReturnToBranch is not set "to any library", and the item is not checked in at the appropriate branch, the wrong-branch-modal pops up:
        * Should give 1 option - OK.
        * Should not check anything in or initiate a transfer.
        * OK should close the modal.
    
        TO TEST:
        1) Set AllowReturnToBranch to "only the library the item is from".
        You can test the other settings, as long as you pay attention to
        where you are checking the item in at.
        2) Check in an item at a branch other than the owning library.
        3) Test conditions above.
    
    Signed-off-by: Lisette <lisetteslatah at gmail.com>
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 230905e1d56a11cf5619f95c95920eb09803900c
Author: Christopher Brannon <cbrannon at cdalibrary.org>
Date:   Thu Nov 1 21:08:19 2018 +0000

    Bug 21346: Remove double dialog
    
    To Test:
    1) Place a hold on an item for pickup at another branch.
    2) Check in item to trigger hold and transfer.
    3) Check in item again without changing location.  Note modal AND old
    dialog behind modal.
    4) Apply patch.
    5) Check in item again without changing location.  Note modal without
    the old dialog.
    
    Signed-off-by: Lisette <lisetteslatah at gmail.com>
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 48787acc6f725686583bb05f45888acf3e1231d0
Author: Christopher Brannon <cbrannon at cdalibrary.org>
Date:   Thu Nov 1 20:21:08 2018 +0000

    Bug 21346: Streamline logic in holds and transfers
    
    1) Replaced comparison with string to make testing branch easier.
    2) Replaced useless 0 values with undef.
    
    Does not change any behavior, only simplifies code.
    
    Signed-off-by: Lisette <lisetteslatah at gmail.com>
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Installer/PerlDependencies.pm                   |    2 +-
 C4/Items.pm                                        |    8 +-
 C4/Search.pm                                       |   12 +-
 Koha.pm                                            |    2 +-
 Koha/SearchEngine/Elasticsearch.pm                 |   21 +-
 Koha/SuggestionEngine/Plugin/LibrisSpellcheck.pm   |  100 +++++++++
 Koha/Template/Plugin/Asset.pm                      |    4 +-
 Koha/Template/Plugin/Branches.pm                   |    9 +-
 circ/returns.pl                                    |   10 +-
 installer/data/mysql/sysprefs.sql                  |    2 +
 installer/data/mysql/updatedatabase.pl             |   19 ++
 .../intranet-tmpl/prog/en/includes/circ-menu.inc   |    4 +-
 .../csv_headers/reports/cash_register_stats.tt     |    2 +-
 .../intranet-tmpl/prog/en/includes/ill-toolbar.inc |    8 +-
 .../prog/en/includes/installer-doc-head-close.inc  |    8 +-
 .../prog/en/includes/installer-intranet-bottom.inc |   11 +-
 .../prog/en/includes/patroncards-toolbar.inc       |    4 +-
 .../prog/en/includes/quotes-upload-toolbar.inc     |    6 +-
 .../en/includes/rotating-collections-toolbar.inc   |    8 +-
 .../intranet-tmpl/prog/en/includes/select2.inc     |    2 +-
 .../prog/en/includes/virtualshelves-toolbar.inc    |    4 +-
 .../prog/en/modules/acqui/addorderiso2709.tt       |   14 ++
 .../intranet-tmpl/prog/en/modules/acqui/basket.tt  |    4 +-
 .../prog/en/modules/admin/additional-fields.tt     |    2 +-
 .../prog/en/modules/admin/audio_alerts.tt          |    2 +-
 .../prog/en/modules/admin/categories.tt            |    2 +-
 .../prog/en/modules/admin/didyoumean.tt            |    2 +
 .../en/modules/admin/preferences/searching.pref    |   10 +
 .../en/modules/admin/preferences/staff_client.pref |    4 +-
 .../prog/en/modules/catalogue/advsearch.tt         |    8 +-
 .../prog/en/modules/catalogue/results.tt           |   39 ----
 .../prog/en/modules/cataloguing/addbooks.tt        |    2 +-
 .../prog/en/modules/cataloguing/editor.tt          |    8 +-
 .../cataloguing/value_builder/marc21_field_008.tt  |    4 +-
 .../prog/en/modules/circ/checkout-notes.tt         |    4 +-
 .../prog/en/modules/circ/circulation.tt            |   10 +-
 .../intranet-tmpl/prog/en/modules/circ/returns.tt  |  213 +++++++++++++-------
 .../intranet-tmpl/prog/en/modules/clubs/clubs.tt   |    6 +-
 .../en/modules/course_reserves/add_items-step2.tt  |    2 +-
 .../en/modules/course_reserves/course-details.tt   |    8 +-
 .../en/modules/course_reserves/course-reserves.tt  |    2 +-
 .../prog/en/modules/ill/ill-requests.tt            |   16 +-
 .../prog/en/modules/labels/label-manage.tt         |    2 +-
 .../prog/en/modules/members/apikeys.tt             |    2 +-
 .../prog/en/modules/members/housebound.tt          |    4 +-
 .../prog/en/modules/members/member-flags.tt        |    4 +-
 .../prog/en/modules/members/memberentrygen.tt      |    2 +-
 .../prog/en/modules/members/merge-patrons.tt       |    2 +-
 .../prog/en/modules/members/moremember.tt          |    4 +-
 .../prog/en/modules/onboarding/onboardingstep3.tt  |    4 +-
 .../prog/en/modules/patroncards/edit-batch.tt      |   14 +-
 .../prog/en/modules/reports/cash_register_stats.tt |    2 +-
 .../prog/en/modules/reports/dictionary.tt          |    2 +-
 .../prog/en/modules/serials/serials-edit.tt        |    4 +-
 .../modules/serials/subscription-numberpatterns.tt |    6 +-
 .../intranet-tmpl/prog/en/modules/tags/review.tt   |    4 +-
 .../prog/en/modules/tools/upload-images.tt         |    2 +-
 .../intranet-tmpl/prog/en/modules/tools/viewlog.tt |    1 +
 .../bootstrap/en/includes/account-table.inc        |    8 +-
 .../bootstrap/en/modules/opac-advsearch.tt         |    2 +-
 .../opac-tmpl/bootstrap/en/modules/opac-reserve.tt |    2 +-
 .../opac-tmpl/bootstrap/en/modules/opac-user.tt    |   25 +--
 opac/opac-account.pl                               |   27 +--
 opac/opac-user.pl                                  |   11 -
 opac/sco/sco-main.pl                               |   29 +--
 reports/cash_register_stats.pl                     |    6 +-
 .../Items/AutomaticItemModificationByAge.t         |   12 +-
 t/db_dependent/Koha/Template/Plugin/Asset.t        |    7 +-
 t/db_dependent/Template/Plugin/Branches.t          |  185 +++++++++++------
 tools/viewlog.pl                                   |    3 +
 70 files changed, 591 insertions(+), 393 deletions(-)
 create mode 100644 Koha/SuggestionEngine/Plugin/LibrisSpellcheck.pm


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Tue Apr 16 16:02:52 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Tue, 16 Apr 2019 14:02:52 +0000
Subject: [koha-commits] main Koha release repository branch 18.11.x updated.
	v18.11.04-88-g383349f
Message-ID: <E1hGOfk-0005s3-JK@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  383349f83fb9362a6f875cc11a9efbb5caed2956 (commit)
       via  a5cc927a6afd7f8da86c2781c6ed46576d1338aa (commit)
       via  fab9d81a38bb5abdf5b9d6fe8e52a0178ee131d3 (commit)
       via  0c1a0e0898b4b4ac298e6003dd09efe727de9810 (commit)
       via  7c3683ed2fbf49c7922edbe9819276aacd5a6bb3 (commit)
       via  117a9fc0903fe57202326604f689c17adfabc0e4 (commit)
       via  634400f05c625a0724172c82004fc6209717bde1 (commit)
       via  969ad3ece8c55563391f39280ddade70c74233cd (commit)
       via  4a1986b6b102304ab0cce24e32a334f11d9556df (commit)
       via  f7f13511d6a74359d65d7cc2348a73eb18da6044 (commit)
       via  5236b45a055e90f21ae634acf5b07831ba8f02b8 (commit)
      from  9304cea6f04baab588a7de24a06dc14994b46405 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 383349f83fb9362a6f875cc11a9efbb5caed2956
Author: Liz Rea <wizzyrea at gmail.com>
Date:   Tue Apr 9 17:49:00 2019 +0000

    Bug 18387: (QA Follow up) adding specificity to error template.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 8c038b9eab64d16c08a66218ab5bc631ce6a0b09)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit a5cc927a6afd7f8da86c2781c6ed46576d1338aa
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon Jul 9 13:30:38 2018 +0000

    Bug 18387: Allow sco-user to access errors templates
    
    To test:
     1 - Enable AuthoSelfCheck prefs
     2 - In opacuserjs or scouserjs add a fetch of an unreachable resources
     3 - Visit the SCO
     4 - Sign in as a patron then click 'finish'
     5 - Say 'yes' to receipt
     6 - Note you are directed to log in
     7 - Apply patch
     8 - Restart all the things
     9 - Repeat 4 & 5
    10 - Sucess, receipt prints
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 2ecca43004685408d999e2b0a765c55a32c404c5)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit fab9d81a38bb5abdf5b9d6fe8e52a0178ee131d3
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Wed Apr 10 20:42:22 2019 +0000

    Bug 22501: Add raw filter to course reserves summary page
    
    Fixes another place where the public note is shown:
    - Course reserves module start/summary page
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 0f02c37aab5e2b2cbffbc2fb84e16b5355a33bcf)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 0c1a0e0898b4b4ac298e6003dd09efe727de9810
Author: Liz Rea <wizzyrea at gmail.com>
Date:   Tue Apr 9 17:56:43 2019 +0000

    Bug 22501: (QA follow-up) use $raw for the note in the intranet
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 8c7bc8946b4d100da841916b4fe5fa12c2505fb5)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 7c3683ed2fbf49c7922edbe9819276aacd5a6bb3
Author: Lucas Gass <lucas at bywatersolutions.com>
Date:   Tue Mar 26 17:41:36 2019 +0000

    Bug 22501: OPAC course reserves notes should allow html links
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 79f1008c7ed97117c248c6aead8742bc64dd0353)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 117a9fc0903fe57202326604f689c17adfabc0e4
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Mon Apr 8 18:04:14 2019 +0100

    Bug 22642: Corrections to updatedatebase for bug 12395
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 8b3f1cb151787d742886a328225ceb07d202f2f5)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 634400f05c625a0724172c82004fc6209717bde1
Author: Hayley Mapley <hayleymapley at catalyst.net.nz>
Date:   Thu Mar 14 04:14:57 2019 +0000

    Bug 19497: Removed title (tooltip) from Edit button in items_search_fields.tt
    
    This patch removes the tooltip that appears when hovering over the Edit button
    of Item Search Fields in the staff client. This was done for consistency reasons,
    including that this tooltip is not translated and tooltips do not appear to be
    on the majority of buttons in the staff client.
    
    Test plan:
    1) In Home->Administration->Item search fields create a new search field
    if you haven't got any already
    2) Observe the tooltip that appears when hovering over the Edit button in
    the Item serach fields table.
    3) Apply the patch and observe that the tool tip no longer appears.
    
    Sponsored-by: Catalyst IT
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 968c888e1579ab28ec165819a011612d8b8f5570)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 969ad3ece8c55563391f39280ddade70c74233cd
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Apr 11 13:39:10 2019 +0000

    Bug 19670: DBRev 18.11.05.002
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit f7869ad48b8f2f86f2b912aad1c3dcbd1a5679c1)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 4a1986b6b102304ab0cce24e32a334f11d9556df
Author: Ere Maijala <ere.maijala at helsinki.fi>
Date:   Thu Mar 14 14:33:18 2019 +0200

    Bug 19670: Change Collation of marc_field to allow mixed case mappings
    
    Test plan:
    1. Apply patch and update database
    2. Verify that you can add a search field mapping for both 100a and 100A.
    3. Verify that the above also works with a newly-created database.
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit a5f3d405f56202beb4426da52f3bf4019f26484b)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit f7f13511d6a74359d65d7cc2348a73eb18da6044
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Wed Mar 6 19:02:50 2019 +0000

    Bug 22444: currencies_manage permission doesn't provide link to manage currencies when selected alone
    
    This patch modifies the acquisitions sidebar menu so that it checks
    properly for the currencies_manage permission.
    
    This patch also removes the menu link directly to the administration
    home page. Since we're removing the check on the general
    "CAN_user_parameters" permission it doesn't make sense to assume the
    page is accessible.
    
    To test, apply the patch and modifiy a staff user so that they have no
    "parameters" permissions but do have "currencies_manage" permission.
    
    Go to the Acquisitions home page. There should be a link to currencies
    management in the sidebar menu.
    
    Perform the same test with a user who has "parameters" permissions but
    not "currencies_manage" permission. There should be no link to
    currencies in the acquisitions sidebar menu. The user should have access
    to the administrative home page.
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 761b410f99cbbfff8e353c538fde2b6816408795)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 5236b45a055e90f21ae634acf5b07831ba8f02b8
Author: Maryse Simard <maryse.simard at inlibro.com>
Date:   Thu Feb 7 08:24:03 2019 -0500

    Bug 21263: Pickup library not set correctly when using Default holds policy
    
    In the case of a specific item hold, it can only be fulfilled if the pickup library
    matches the hold fulfillment policy. Therefore, if OPACAllowUserToChooseBranch is
    set to don't allow, the pickup library should correspond to the policy.
    
    In case of hold that does not specify an item, the homebranch or holdingbranch
    can't be determined at this time, so the pickup library still defaults to the
    homebranch of the borrower. Same if there is no policy or it states 'any'.
    
    To test:
    - Make sure OPACAllowUserToChooseBranch is set to don't allow
    - Make sure you have two branches A and B
    - Have one item whose homebranch is B
    - Have one user whose homebranch is A
    - Make sure the circulation rules allow the user to reserve the item's item type
    
    1. Go to Administration > Circulation and fines rules
    2. Create a Default holds policy by item type for that item type
        - Item type = item's item type
        - Hold policy = From any library
        - Hold pickup library match = item's home library
        - Return policy = item returns home
    3. Go to the OPAC and log in with the user's credentials
    4. Search for the item
    5. Click on "Place hold"
    6. Select a specific item and confirm hold
    7. In the user's file on the OPAC and check the reservation's pickup library. It should be the item's homebranch
    
    You can then repeat the steps for 'item's holding library' or 'any library' as
    the Hold pickup library match. It should also work the same way if there is no
    'Default holds policy by item type' for this item type but a 'Default checkout,
    hold and return policy' set.
    
    Finally, check that placing a hold without selecting a specific item still
    defaults the pickup library to the borrower's homebranch.
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 275dee5f9b9a26b3490bf3646c71c78a2d8647eb)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Auth.pm                                            |    2 +-
 Koha.pm                                               |    2 +-
 installer/data/mysql/kohastructure.sql                |    2 +-
 installer/data/mysql/updatedatabase.pl                |   17 ++++++++++++++++-
 .../prog/en/includes/acquisitions-menu.inc            |    3 +--
 .../prog/en/modules/admin/items_search_fields.tt      |    2 +-
 .../prog/en/modules/course_reserves/course-details.tt |    2 +-
 .../en/modules/course_reserves/course-reserves.tt     |    4 ++--
 .../bootstrap/en/modules/opac-course-reserves.tt      |    2 +-
 opac/opac-reserve.pl                                  |   14 ++++++++++++++
 10 files changed, 39 insertions(+), 11 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Tue Apr 16 23:21:17 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Tue, 16 Apr 2019 21:21:17 +0000
Subject: [koha-commits] main Koha release repository branch 18.05.x updated.
	v18.05.11-29-geda7dac
Message-ID: <E1hGVW1-0005zw-Au@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  eda7dacae3647f5f30880bad1ec3eef159011788 (commit)
      from  147d67cebfa6a67b0a783fda03be588d08910a7c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit eda7dacae3647f5f30880bad1ec3eef159011788
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Thu Mar 14 13:15:01 2019 +0000

    Bug 21013: Missing itemtype for checkut makes patron summary print explode
    
    This patch moves retrieval of the item type description from the script
    to the template using the ItemTypes template plugin.
    
    To test, apply the patch and locate an item which is checked out to
    someone. Modify the database record for that item to remove the item
    type (items.itype).
    
    View the print summary for the patron who has that item checked out. The
    page should display correctly. Checked-out items which have an item type
    should show that item type description correctly.
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit ea7245631ebfb16d4921a6cf7b4b46799a241ff9)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 1247af85216fc0664de8c667d282aa9c7e605f35)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt |    3 ++-
 members/summary-print.pl                                            |    3 ---
 2 files changed, 2 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Tue Apr 16 23:54:04 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Tue, 16 Apr 2019 21:54:04 +0000
Subject: [koha-commits] main Koha release repository branch 18.05.x updated.
	v18.05.11-30-gc14c725
Message-ID: <E1hGW1k-0006oK-VD@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  c14c725a5333e98fd4a4276c62047923d06f8c4f (commit)
      from  eda7dacae3647f5f30880bad1ec3eef159011788 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c14c725a5333e98fd4a4276c62047923d06f8c4f
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Sun Apr 7 16:25:28 2019 +0000

    Bug 22075: Fix encoding problem with RIS export in OPAC
    
    When exporting a record with diacritics in RIS
    format from the detail page in OPAC the encoding
    is not correct and the diacritics appear broken.
    
    This patch fixes it.
    
    To test:
    - Find or create a record with some special
      chars in your OPAC
    - Go to the detail page
    - Save as > RIS
    - Verify the diacritics are broken in an editor
    - Apply patch
    - Repeat and verify everything now displays correctly
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit bfeac6486516f185d9882d294d5000ab773c7dd5)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit ad2a3c5e8034d82edda187aa113029eb4f07b4bb)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 opac/opac-export.pl |    7 +++++++
 1 file changed, 7 insertions(+)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Tue Apr 16 23:59:34 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Tue, 16 Apr 2019 21:59:34 +0000
Subject: [koha-commits] main Koha release repository branch 18.05.x updated.
	v18.05.11-31-g2fea06f
Message-ID: <E1hGW74-0006ya-SP@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  2fea06f7d9523ab0f23c6a0c8a93a7cffb48bc40 (commit)
      from  c14c725a5333e98fd4a4276c62047923d06f8c4f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 2fea06f7d9523ab0f23c6a0c8a93a7cffb48bc40
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Feb 27 12:45:47 2019 -0500

    Bug 20937: Truncate items for print notices when user has an email
    
    To test:
     1 - Set PrintNoticesMaxLines to 1
     2 - Checkout 2 (or more) items to a patron and make them overdue to trigger a
    notice
     3 - Make sure the patron has an email
     4 - Make sure the notice you are sending is set to 'print' as the type
     5 - Run overdue_notices.pl without the 'nomail' option
     6 - Find the message and note all items have been added
     7 - Apply patch
     8 - Clear the message queue
     9 - Re-run overdue_notices.pl
    10 - Confirm the message now has only 1 item.
    11 - Set PrintNoticesMaxLines to 0
    12 - Clear the message queue
    13 - Re-run overdue_notices.pl
    14 - Confirm the message has 2 items as expected
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 083f789b9548ec70d86dc48911df1bc9febda619)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 746b3930d5556d14d4fcc6a64612561edf8fef96)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 misc/cronjobs/overdue_notices.pl |    2 ++
 1 file changed, 2 insertions(+)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Wed Apr 17 14:43:37 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Wed, 17 Apr 2019 12:43:37 +0000
Subject: [koha-commits] main Koha release repository branch master updated.
	v18.11.00-1203-gec6b3d1
Message-ID: <E1hGjub-000142-GB@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  ec6b3d18348189461b3d7587cb055394962255b6 (commit)
       via  92b329b22393ec802cabc2e048d7eebfecdcf9cf (commit)
       via  4c01891613f68d5eecc9d971717d2a439be041bb (commit)
       via  8f8367c728112178d4831a9776c55d58eb7ef22b (commit)
       via  a2b057758d83c3530c38ced02921c82185f3251f (commit)
       via  313ad660e7ae28fb3f9036839b2cb773494c4af0 (commit)
       via  374527c1cb34788dc29eed2ef7a4fa52c7989052 (commit)
       via  5ed025a73f6c7c8d7ab859a2bad97a60e8c3986d (commit)
       via  79ebbffd26b04222831f3b734c4f44d69d199a0b (commit)
       via  cd082782d1b42765d2ef1094a7e52f792ae75980 (commit)
       via  9ebdfb1ed1ff1c7a110dc7a7718bb17cd231f66f (commit)
       via  0393f053b08b316f4da174559b6f44f5a8b20e3b (commit)
       via  4605d76a73f9b13ba3b0259e3f480fb396051309 (commit)
       via  693bbc76e736f048c4c16e7a5664f3494db287c0 (commit)
       via  21e9b55c2c9c2b72b9901233ea9263b5f5edfa5f (commit)
       via  2a59d22b894aa4d932d021eddf64b2a24c1b8e0c (commit)
       via  78d35a2e44a3eeb303bdc81c66645d5d0412f54d (commit)
       via  e0f83eb4b68a53f8de87c82a2e48628c71e20f88 (commit)
       via  b31d314613994da218740b735139af70f009fca8 (commit)
       via  3f7e19ea7a054d55ccd0b8d74339cf6644bebfd0 (commit)
       via  8153c73c6b3a8a8855091004e6a586d8b2de0e9d (commit)
       via  47111d993dd6308365732ad63e5cdc90823151ee (commit)
       via  fb192699859aa124a827ceac27a9b1776d9629b3 (commit)
       via  81d3e415a9d87c7b6253a7ddb84efb6432715145 (commit)
       via  47df429cc6b4a643e678391e95ec475dbe4b89c1 (commit)
       via  6f9341a7f79fd913669ee870a7f243f74d52498f (commit)
       via  d86f17e6b86fe2c94a6b27488f06598122cd120d (commit)
       via  5e1894c94813f10efa0c0d0454958ce19b890742 (commit)
       via  af84af7cb7cd7ade4054ad155963db4d1ecd6272 (commit)
       via  23db9b1d67ee9bf1927bfd7f11da46886d51999b (commit)
       via  2ca2585b1c5b61024351c32d84e605f61d04a418 (commit)
       via  f7f5f167e5736a1e40b59058fb4a99f96daaea42 (commit)
       via  0611621ed082a2463b8a15d61273b5720c9db31c (commit)
       via  71f17b35ee8023967e671ca9203d5d5b62aa2931 (commit)
       via  37460d924eef0383e55ef8078944354a9d500e9a (commit)
       via  3b62cbb17bc062c2bb4801eb30460b5f82a171c0 (commit)
       via  4b3eb99ad6cd9fc8e9bac6627c38bd16600aa38a (commit)
       via  b107d5029ed25cc26d16edb5c571ace749b46ccb (commit)
       via  e37dd514ad08f390a884752d84e457fa74bf208f (commit)
       via  03deaadd31cfcb282c1210456a9429a8e41669a4 (commit)
       via  93d130f357f77e5e8f8756642f422a2b12164d04 (commit)
       via  fa64402384fa198ecafa5c54abc5a83b8ce42de3 (commit)
       via  2a9b9a526bb3e1c73e09cbee499a2debcab74ee5 (commit)
       via  f3afec0587f4baeff580e153ea592020d4d36be3 (commit)
       via  4177d2e32942b16e65748852df881541406297bd (commit)
       via  f6e143c73c9ba7f6b1daf76d592dc7a56e8694bb (commit)
       via  a3a3bf2dda3219b3385b587585985c51f6cc8498 (commit)
       via  4779cf845077ffd7f564b63b22f72ba99aa812ff (commit)
       via  9f34d208d08fc89d2d0b4d3718fc43e3f32ff055 (commit)
      from  fc6b7e5c3e101e0c5935f34c45b72cf3fd4f1bb7 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit ec6b3d18348189461b3d7587cb055394962255b6
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Apr 17 12:22:45 2019 +0000

    Bug 20128: DBRev 18.12.00.054
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 92b329b22393ec802cabc2e048d7eebfecdcf9cf
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Wed Apr 10 21:38:57 2019 +0000

    Bug 20128: Add new permission for new installations
    
    Change was missing from userpermissions.sql
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 4c01891613f68d5eecc9d971717d2a439be041bb
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Thu Mar 21 10:16:34 2019 +0000

    Bug 20128: (QA follow-up) Corrections to haspermission
    
    The haspermission routine wrongly assumed that get_user_subpermissions
    would return a list of all subpermissions if the user had the top level
    permission, but instead if just returns 1.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 8f8367c728112178d4831a9776c55d58eb7ef22b
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Mar 13 05:23:21 2019 +0000

    Bug 20128: Problem when checking individual perms where borrower has top level
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit a2b057758d83c3530c38ced02921c82185f3251f
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Mar 6 12:21:38 2019 -0500

    Bug 20128: Add permission for advanced cataloging editor
    
    To test:
    1 - Have a borrower with edit_catalogue permission and one with
    editcatalogue top level
    2 - Confirm they can both access the advanced editor from the
    'Cataloguing' home page or from the basic editor
    3 - Apply patch
    4 - Update database
    5 - Confirm borrower with 'edit_catalogue' has 'advanced_editor'
    permission
    6 - Confirm borrowers can access advanced editor as above
    7 - Remove 'advanced_editor' permission from borrower
    8 - Ensure they cannot access the advanced editor
    9 - Ensure links to 'Edit record' from search results go to basic editor
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 313ad660e7ae28fb3f9036839b2cb773494c4af0
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Apr 17 12:17:35 2019 +0000

    Bug 17171: DBRev 18.12.00.053
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 374527c1cb34788dc29eed2ef7a4fa52c7989052
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Wed Apr 10 22:43:53 2019 +0000

    Bug 17171: (QA follow-up) Remove cardnumber template variable
    
    The INCLUDE already takes care of displaying the cardnumber, the
    extra variable is not needed.
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 5ed025a73f6c7c8d7ab859a2bad97a60e8c3986d
Author: Liz Rea <wizzyrea at gmail.com>
Date:   Mon Apr 1 19:38:17 2019 +0000

    Bug 17171: (QA follow-up) Using patron-title.inc for names
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 79ebbffd26b04222831f3b734c4f44d69d199a0b
Author: Kyle M Hall <kyle at bywatetsolutions.com>
Date:   Tue Mar 27 10:11:27 2018 -0400

    Bug 17171: (QA follow-up) Add message to batch checkout template
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit cd082782d1b42765d2ef1094a7e52f792ae75980
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Sun Jun 11 09:10:17 2017 +0000

    Bug 17171: Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation
    
    Some libraries don't want to force the librarians to manually confirm
    each checkout when the item is checked out to another. Instead, they
    would prefer to be alerted after the fact.
    
    Test Plan:
    1) Apply this patch
    2) Run updatedatabase.pl
    3) Enable the new syspref AutoReturnCheckedOutItems
    4) Check an item out to a patron
    5) Check the same item out to another patron
    6) Note you are not prompted to confirm the checkout,
       but are instead alerted that is had been checked out to another patron!
    
    Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org>
    Signed-off-by: BWS Sandboxes <ByWaterSandboxes at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 9ebdfb1ed1ff1c7a110dc7a7718bb17cd231f66f
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Wed Apr 10 01:15:30 2019 +0200

    Bug 22580: Remove deprecated delete_expired_opac_registrations.pl cronjob
    
    Removes the deprecated script and changes the hint on the
    PatronSelfRegistrationExpireTemporaryAccountsDelay sytem preference.
    
    To test:
    - Make sure the script misc/cronjobs/delete_expired_opac_registrations.pl
      was deleted
    - Make sure the hint on the PatronSelfRegistrationExpireTemporaryAccountsDelay
      system preference is correct
    - Make sure there are no other reference to the removed script
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 0393f053b08b316f4da174559b6f44f5a8b20e3b
Author: Agustin Moyano <agustinmoyano at theke.io>
Date:   Wed Mar 20 00:16:05 2019 -0300

    Bug 22538: Add a noticeable alert about waiting holds
    
    In SCO, bug 21772 introduced holds information, but it lacked the
    capability to attract atention when any of those holds was in waiting
    status. Because SCO and opac-user uses the same include file for holds
    table, this bug applies to both modules.
    
    To test:
    1) Have a patron with holds in waiting status and pending status.
    2) Enable SCO module.
    3) Holds tab label contains holds count, but doesn't inform that there
       is something that requires attention.
    5) Holds tab content has no visual aid to recognize without reading
       effort which holds are in waiting status.
    6) Apply this patch
       => SUCCESS: Holds tab label has a visual aid to indicate that
          something requires attention, and in
          holds table it's easy to recognize waiting holds without reading
          effort.
    7) Sign off
    
    Sponsored-by: Theke Solutions
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 4605d76a73f9b13ba3b0259e3f480fb396051309
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Wed Mar 6 19:59:53 2019 +0000

    Bug 3766: Cities/Towns only on one address
    
    This patch ties the alternate address and alternate contact address
    fields in the patron entry form to the cities and towns data. This
    provides a dropdown of predefined city data to these address fields.
    
    To test, apply the patch and edit a patron record.
    
    Test city selection for all three address fields: Main address,
    alternate address, and alternate contact. Confirm that city selection
    works correctly and that your changes are saved correctly.
    
    Perform these tests with all AddressFormat options: French, German, and
    US.
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 693bbc76e736f048c4c16e7a5664f3494db287c0
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue Mar 26 13:51:47 2019 +0000

    Bug 11969: Show patrons star rating on their reading history
    
    This patch adds display of a user's ratings to their reading history in
    the OPAC.
    
    Also changed: Removed obsolete "border" attribute from the template, and
    removed obsolete JavaScript include from opac-results.tt
    
    To test, apply the patch and rebuild the OPAC CSS. OpacStarRatings
    should be set to all (results and details).
    
     - Log in to the OPAC as a user with a reading history and titles in
       that history which have ratings.
     - Under the "your reading history" tab, your ratings should show under
       rated titles with the date of the rating.
     - Test also with OpacStarRatings set to a value other than "all."
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
    Star ratings are displayed in Reading History with OpacStarRatings
    enabled, and are not displayed when OpacStarRatings is disabled, as
    expected.
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 21e9b55c2c9c2b72b9901233ea9263b5f5edfa5f
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Apr 17 11:42:05 2019 +0000

    Bug 22311: DBRev 18.12.00.052
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 2a59d22b894aa4d932d021eddf64b2a24c1b8e0c
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Fri Feb 22 08:00:33 2019 -0500

    Bug 22311: Add a SysPref to allow adding content to the #moresearches div in the opac
    
    The idea of this development would be to match the syspref 'OPACSearchForTitleIn' but
    for populating the search headers (#moresearches) on the opac page to allow staff to
    easily add links without jQuery.
    
    Test Plan:
    1) Apply this patch
    2) Run updatedatabase.pl
    3) Update the new OpacMoreSearches system preference to include the following line:
        <li><a href="https://duckduckgo.com/">Duck Duck Go</a></li>
    4) Browse to the OPAC
    5) Note your new link displays in the "moresearches" area of the OPAC.
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 78d35a2e44a3eeb303bdc81c66645d5d0412f54d
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Mon Apr 8 10:47:03 2019 +0000

    Bug 22372: (QA follow-up) Change 'Available location' to 'Shelving location'
    
    Make terminology more consistent with other places in Koha.
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit e0f83eb4b68a53f8de87c82a2e48628c71e20f88
Author: Matthias Meusburger <matthias.meusburger at biblibre.com>
Date:   Tue Feb 12 15:33:33 2019 +0100

    Bug 22372: Add available location to Holds awaiting pickup
    
    Test plan:
     - Go to Circulation, Holds awaiting pickup (circ/waitingreserves.pl)
     - Note the additional column for available location.
    
    Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos at inLibro.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit b31d314613994da218740b735139af70f009fca8
Author: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Date:   Wed Nov 28 13:14:21 2018 -0300

    Bug 21899: Update MARC21 frameworks to Update 27 (November 2018)
    
    This bug updates MARC21 english frameworks to Update 27
    
    Bibliographic
    -------------
     * New fields 251, 341 and 532 with corresponding subfields
     * New subfields 041$p, 041$q and 041$r
     * Renamed subfield 041$j
    
    Authorities
    -----------
     * New subfield 055$2
    
    To test:
    1) Remove all your frameworks
    2) Check mandatory bibliographic and authority files load without problem
    3) Check new fields/subfields
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 3f7e19ea7a054d55ccd0b8d74339cf6644bebfd0
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Mon Apr 8 06:03:42 2019 +0000

    Bug 22656: Fix charts in reports
    
    This reverts a change on Create chart button in report toolbar made by
    bug 22023
    
    1) Confirm the bug
        a) Create some SQL report
        b) Run it and click on "Show chart settings" button
        c) There is no modal  or other way to actually draw the chart
    
    2) Apply the patch
    3) Go through 1) again - the modal and chart should work
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 8153c73c6b3a8a8855091004e6a586d8b2de0e9d
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Apr 17 11:21:07 2019 +0000

    Bug 21943: Compiled CSS
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 47111d993dd6308365732ad63e5cdc90823151ee
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Mon Mar 11 13:41:49 2019 +0000

    Bug 21943: (follow-up) Fix float error with sidebar menu
    
    This patch makes a minor change to the staff client CSS to fix a float
    clearing problem when the <main> element contains only a floated element
    like <fieldset>. It is a global change, but shouldn't cause unwanted
    effects because a non-clearing <main> isn't used in any
    float-dependent layouts.
    
    To test, apply the patch and regenerate the staff client CSS. View the
    place hold screen and confirm that the sidebar menu looks correct at
    narrower browser widths.
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit fb192699859aa124a827ceac27a9b1776d9629b3
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue Dec 4 16:27:00 2018 +0000

    Bug 21943: Clean up holds template
    
    This patch makes a few markup corrections to the holds template in the
    staff client: Replace some YUI markup with Bootstrap; Replace invalid
    "alt" attributes with "title."
    
    To test, apply the patch and test the process of placing a hold, both
    single and multiple holds. At each step of the process the page should
    look correct and adjust well at various browser widths.
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 81d3e415a9d87c7b6253a7ddb84efb6432715145
Author: Liz Rea <wizzyrea at gmail.com>
Date:   Fri Mar 29 16:31:14 2019 +0000

    Bug 22616: Updating error text messages
    
    To test:
    
    Apply this patch
    Go to a borrower that doesn't exist, check that the error message is
    displayed and looks correct. (i.e. http://127.0.0.1:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=9999999999999999)
    Go to an item, subscription, biblio that don't exist, check that the
    error message is correct and the links work
    Go to a borrower that the logged in user doesn't have permission to see, check that the error message is correct and the links work.
    
    Signed-off-by: Bin Wen <bin.wen at inlibro.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 47df429cc6b4a643e678391e95ec475dbe4b89c1
Author: Liz Rea <wizzyrea at gmail.com>
Date:   Thu Mar 21 17:59:59 2019 +0000

    Bug 22576: OPAC password text refresh
    
    To test:
    
    Create a patron with a username and password
    Make sure that password resets on OPAC are allowed in your system
    preferences (OpacPasswordChange -> Allow)
    Log into the OPAC with this patron
    Click the "Change password" tab
    Change the password - notice that the button to submit the changes says
    "Submit Changes" and also that the success page says "Return to my
    record"
    Apply this patch
    Reset the password again, noticing that the button to submit the new
    password says "Change password" and the success page says "Return to my
    account"
    
    Signed-off-by: Marie-Luce Laflamme <marie-luce.laflamme at inlibro.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 6f9341a7f79fd913669ee870a7f243f74d52498f
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Apr 17 11:15:22 2019 +0000

    Bug 21336: DBRev 18.12.00.051
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit d86f17e6b86fe2c94a6b27488f06598122cd120d
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Thu Apr 4 09:42:38 2019 +0100

    Bug 21336: (QA follow-up) Add tests for administrative lockout
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 5e1894c94813f10efa0c0d0454958ce19b890742
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Mar 29 08:30:06 2019 +0000

    Bug 21336: (QA follow-up) Add column_exists in db revision
    
    As requested by Josef on comment70.
    
    Test plan:
    Run db revision twice. No warnings.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit af84af7cb7cd7ade4054ad155963db4d1ecd6272
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Mon Dec 17 09:15:29 2018 +0100

    Bug 21336: (follow-up) Handle strict SQL mode in _anonymize_column
    
    When a field is not nullable we should pass empty string, zero or today
    to a char, numeric or date column.
    The mandatory parameter does not refer to a database constraint but a Koha
    preference. Only for strings we generate a random value.
    
    Test plan:
    Enable strict_sql_modes.
    Run t/db_dependent/Koha/Patrons.t again.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 23db9b1d67ee9bf1927bfd7f11da46886d51999b
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Oct 26 12:21:13 2018 +0200

    Bug 21336: (follow-up) Fix last line after PatronRemovalDelay in pref file
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 2ca2585b1c5b61024351c32d84e605f61d04a418
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Wed Sep 12 14:25:26 2018 +0200

    Bug 21336: Adjust cleanup_database.pl
    
    Add the new Patron routines to this cron job. Actions are performed only if
    preferences are set.
    
    Note: No specific command line flags for these actions are added here
    (and probably not needed too). So no crontab changes too.
    
    Test plan:
    Add a new patron.
    Enable GDPR_Policy and refuse consent on OPAC for this patron.
    Set only the first delay to zero (0) for immediate action.
    Run cleanup_database.pl --logs (or any other flag) for the first time.
    Check lock and expiration.
    Set the second delay to zero (0) for immediate action.
    Run cleanup_database.pl --logs for the second time. Check anonymization.
    Set the third delay to zero (0) for immediate action.
    Run cleanup_database.pl --logs for the third time. Check removal.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Amended: Added the warn $@ line in cleanup_database.pl
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit f7f5f167e5736a1e40b59058fb4a99f96daaea42
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Wed Sep 12 14:25:26 2018 +0200

    Bug 21336: Search, lock and anonymize methods
    
    Add Koha::Patron->lock and anonymize.
    Add Koha::Patrons methods search_unsubscribed, search_anonymize_candidates
    and search_anonymized. And wrappers for lock and anonymize.
    Add unit tests.
    
    Test plan:
    Run t/db_dependent/Koha/Patrons.t
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 0611621ed082a2463b8a15d61273b5720c9db31c
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Wed Oct 3 15:36:46 2018 +0200

    Bug 21336: Introduce administrative lockout
    
    As a preparation for Koha::Patron->lock, we add the concept of administrative
    lockout. The account is locked just as it would have been by too much
    failed login attempts.
    This is handled by a negative value in borrowers.login_attempts.
    
    Test plan:
    Run t/db_dependent/Auth.t
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 71f17b35ee8023967e671ca9203d5d5b62aa2931
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Mon Oct 1 14:46:15 2018 +0200

    Bug 21336: Do not increase login_attempts after locking
    
    If an account has been locked, there is no use to keep increasing this
    number. It is not true too; after the pref number has been reached,
    we can not really speak of login attempts anymore. The credentials are
    just ignored.
    
    Adding a dbrev to put existing values in line. And a simple test in
    Auth.t to confirm that login_attempts stop increasing.
    
    Note: It feels safe to keep the '>=' condition in account_locked. But it
    could obviously be changed to '=='. (Added a test for that.)
    
    Note: Adding a mock_preference in Auth.t too for GDPR_Policy. Since not all
    tests will pass when the pref is enabled (though disabled by default).
    
    Test plan:
    Run dbrev with updatedatabase.pl.
    Run t/db_dependent/Koha/Patrons.t
    Run t/db_dependent/Auth.t
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 37460d924eef0383e55ef8078944354a9d500e9a
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Thu Sep 20 12:48:10 2018 +0200

    Bug 21336: Database update for new prefs
    
    This patch adds three new prefs:
    - UnsubscribeReflectionDelay
    - PatronAnonymizeDelay
    - PatronRemovalDelay
    
    Test plan:
    Run upgrade.
    Check patrons pref page. Look under Privacy.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 3b62cbb17bc062c2bb4801eb30460b5f82a171c0
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Wed Sep 19 16:56:16 2018 +0200

    Bug 21336: Database revision for borrowers.flgAnonymized
    
    This new flag should speak for itself ;)
    
    Test plan:
    Run installer or updatedatabase.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 4b3eb99ad6cd9fc8e9bac6627c38bd16600aa38a
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue Apr 16 16:34:13 2019 +0000

    Bug 22716: Use gender-neutral pronouns in system preference descriptions
    
    This patch makes a few corrections to the .pref files which provide
    descriptions for system preferences. Language like "him or her" is
    replaced with "they/them" pronouns.
    
    To test, apply the patch and check the following preferences:
    
     - OPACFineNoRenewalsBlockAutoRenew
     - ExpireReservesMaxPickUpDelayCharge
     - PatronSelfRegistrationVerifyByEmail
    
    Signed-off-by: Lisette <lisettes at latahlibrary.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit b107d5029ed25cc26d16edb5c571ace749b46ccb
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Apr 17 10:31:03 2019 +0000

    Bug 22274: Compiled CSS
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit e37dd514ad08f390a884752d84e457fa74bf208f
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Thu Apr 11 15:12:30 2019 +0000

    Bug 22274: (follow-up) Use one CSS file for SCO and SCI
    
    This patch makes the self-checkin CSS created in Bug 22638 the CSS for
    self-checkout as well. The interfaces have the same requirements.
    
    This patch also replaces some old image-based icons with Font Awesome
    icons.
    
    To test, apply the patch and rebuild the OPAC CSS. Clear your browser
    cache if necessary.
    
     - Enable both self checkout (WebBasedSelfCheck) and self checkin
       (SelfCheckInModule).
     - Test both interfaces, confirming that the style is consistent for
       each and looks correct.
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 03deaadd31cfcb282c1210456a9429a8e41669a4
Author: Claire Gravely <claire.gravely at bsz-bw.de>
Date:   Wed Apr 3 13:01:21 2019 +0000

    Bug 22274: Self-checkout/checkin pages not covered by OPAC CSS changes
    
    This patch updates the Self-checkout pages to match the new OPAC style.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 93d130f357f77e5e8f8756642f422a2b12164d04
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Thu Apr 11 13:50:12 2019 +0000

    Bug 22638: (follow-up) Convert SCI CSS to SCSS
    
    This patch makes a number of follow-up changes, including:
    
     - Covert remaining icons to Font Awesome
     - Convert CSS to SCSS
     - Move SCSS which is common to both the OPAC and SCI into separate
       files to be including in each during compilation.
     - Make minor correction to opac.scss to fix SCSS build warning
    
    To test, apply the patch and rebuild the OPAC CSS. Clear your browser
    cache if necessary.
    
    - Enable the self checkin module using using the SelfCheckInModule
      system preference.
    - Open the self checkin interface and test the checkin process.
      Everything should look correct.
      - After submitting barcodes for checkin, the "Finish" button should
        show a Font Awesome icon instead of an image icon.
    - Enable multiple translations and set the OpacLangSelectorMode
      preference to show the language menu in the footer.
    - Confirm that the language menu looks correct.
    - View the regular OPAC to make sure the changes to opac.scss didn't
      result in unintended changes to the interface.
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit fa64402384fa198ecafa5c54abc5a83b8ce42de3
Author: Claire Gravely <claire.gravely at bsz-bw.de>
Date:   Thu Apr 4 07:27:45 2019 +0000

    Bug 22638: Self checkin CSS update
    
    This patch updates the Self-Checkin CSS to match tne new OPAC design.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 2a9b9a526bb3e1c73e09cbee499a2debcab74ee5
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Sun Apr 14 03:13:01 2019 +0000

    Bug 21172: Remove obsolete framework parameter from GetMarcFromKohaField
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit f3afec0587f4baeff580e153ea592020d4d36be3
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Aug 7 17:06:41 2018 -0300

    Bug 21172: Remove warning from addbiblio.pl
    
    Argument "01e" isn't numeric in numeric ne (!=) at
    /home/vagrant/kohaclone/cataloguing/addbiblio.pl line 507.
    
    A tagfield can be 01e and so raise a warning is compared with == or !=
    
    This patch also fixes few inconsistencies:
    - tagfield for items.itemnumber must be retrieved with GetMarcFromKohaField
    (to support other marcflavours)
    - do not use $_
    - loop only once on $usedTagsLib
    
    Test plan:
    For devs only, read the code and confirm the changes make sense.
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 4177d2e32942b16e65748852df881541406297bd
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Apr 17 10:11:04 2019 +0000

    Bug 22044: DBRev 18.12.00.048
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit f6e143c73c9ba7f6b1daf76d592dc7a56e8694bb
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Sun Apr 14 04:26:29 2019 +0000

    Bug 22044: Fix sysprefs.sql description to use circ column description
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit a3a3bf2dda3219b3385b587585985c51f6cc8498
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon Apr 15 13:32:12 2019 +0000

    Bug 22044: Correct syspref name
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 4779cf845077ffd7f564b63b22f72ba99aa812ff
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Dec 21 19:19:05 2018 +0000

    Bug 22044: Set default and add NoRenewalBeforePrecision preference for new/affected installs
    
    I am not sure the correct answer - for upgraded installs the pref was
    set to date, which changed behaviour
    
    For new installs the pref was unset, behaved as if 'exact_time' so we
    shouldn't change behaviour?
    
    If the perceived default is date then the code should be changed, or
    this shouldn't be a pref at all?
    
    To test:
    1 - Have a new system missing this pref
    2 - Note when searchign the pref in staff client if appears as 'date'
    3 - Check the db to confirm value is 'NULL'
    4 - Apply patch and run update
    5 - Pref is now set to 'exact_time'
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 9f34d208d08fc89d2d0b4d3718fc43e3f32ff055
Author: Lucas Gass <lucas at bywatersolutions.com>
Date:   Fri Apr 12 23:04:06 2019 +0000

    Bug 22702: circulation note on patron page should allow for HTML tags
    
    Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>
    Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Auth.pm                                         |    4 +-
 C4/Circulation.pm                                  |    4 +
 Koha.pm                                            |    2 +-
 Koha/Patron.pm                                     |   90 +++++-
 Koha/Patrons.pm                                    |  136 +++++++-
 Koha/Schema/Result/Borrower.pm                     |   18 +-
 Koha/Schema/Result/Deletedborrower.pm              |   18 +-
 cataloguing/addbiblio.pl                           |   19 +-
 cataloguing/editor.pl                              |    7 +-
 .../marc21/mandatory/authorities_normal_marc21.sql |    3 +-
 .../marc21/mandatory/marc21_framework_DEFAULT.sql  |   29 +-
 installer/data/mysql/kohastructure.sql             |    2 +
 installer/data/mysql/sysprefs.sql                  |    6 +
 installer/data/mysql/updatedatabase.pl             |   78 +++++
 installer/data/mysql/userpermissions.sql           |    1 +
 .../intranet-tmpl/prog/css/src/staff-global.scss   |    6 +
 koha-tmpl/intranet-tmpl/prog/css/staff-global.css  |    2 +-
 .../prog/en/includes/blocking_errors.inc           |   12 +-
 .../en/includes/member-alt-address-style-de.inc    |   39 ++-
 .../en/includes/member-alt-address-style-fr.inc    |   14 +
 .../en/includes/member-alt-address-style-us.inc    |   18 +-
 .../en/includes/member-alt-contact-style-de.inc    |   16 +-
 .../en/includes/member-alt-contact-style-fr.inc    |   20 +-
 .../en/includes/member-alt-contact-style-us.inc    |   20 +-
 .../en/includes/member-main-address-style-de.inc   |    2 +-
 .../en/includes/member-main-address-style-fr.inc   |   20 +-
 .../en/includes/member-main-address-style-us.inc   |    2 +-
 .../intranet-tmpl/prog/en/includes/permissions.inc |    5 +
 .../prog/en/includes/reports-toolbar.inc           |    3 +-
 .../prog/en/includes/waiting_holds.inc             |    3 +
 .../en/modules/admin/preferences/circulation.pref  |   10 +-
 .../prog/en/modules/admin/preferences/opac.pref    |    9 +-
 .../prog/en/modules/admin/preferences/patrons.pref |    8 +
 .../prog/en/modules/cataloguing/addbiblio.tt       |    2 +-
 .../prog/en/modules/cataloguing/addbooks.tt        |    2 +-
 .../prog/en/modules/circ/circulation.tt            |    8 +-
 .../en/modules/circ/circulation_batch_checkouts.tt |    3 +
 .../prog/en/modules/members/memberentrygen.tt      |    9 +-
 .../prog/en/modules/members/moremember.tt          |    2 +-
 .../prog/en/modules/reserve/request.tt             |   39 ++-
 koha-tmpl/intranet-tmpl/prog/js/members.js         |   15 +-
 koha-tmpl/opac-tmpl/bootstrap/css/opac.css         |    2 +-
 koha-tmpl/opac-tmpl/bootstrap/css/sci.css          |  208 ------------
 koha-tmpl/opac-tmpl/bootstrap/css/sco.css          |  213 +-----------
 koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss |  196 +++++++++++
 koha-tmpl/opac-tmpl/bootstrap/css/src/_fonts.scss  |   35 ++
 koha-tmpl/opac-tmpl/bootstrap/css/src/_mixins.scss |    6 +-
 koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss    |  210 +-----------
 koha-tmpl/opac-tmpl/bootstrap/css/src/sco.scss     |  340 ++++++++++++++++++++
 .../bootstrap/en/includes/holds-table.inc          |    1 +
 .../bootstrap/en/includes/masthead-sco.inc         |    4 +-
 .../opac-tmpl/bootstrap/en/includes/masthead.inc   |    1 +
 .../opac-tmpl/bootstrap/en/modules/opac-passwd.tt  |    4 +-
 .../bootstrap/en/modules/opac-readingrecord.tt     |   26 +-
 .../opac-tmpl/bootstrap/en/modules/opac-results.tt |    1 -
 .../opac-tmpl/bootstrap/en/modules/sci/sci-main.tt |   10 +-
 .../opac-tmpl/bootstrap/en/modules/sco/sco-main.tt |   30 +-
 misc/cronjobs/cleanup_database.pl                  |    8 +
 misc/cronjobs/delete_expired_opac_registrations.pl |   71 ----
 opac/opac-readingrecord.pl                         |    9 +-
 opac/sco/sco-main.pl                               |    6 +
 t/db_dependent/Auth.t                              |   49 ++-
 t/db_dependent/Auth/haspermission.t                |   21 +-
 t/db_dependent/Circulation.t                       |   62 +++-
 t/db_dependent/Koha/Patrons.t                      |  173 +++++++++-
 65 files changed, 1561 insertions(+), 831 deletions(-)
 delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/css/sci.css
 create mode 100644 koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss
 create mode 100644 koha-tmpl/opac-tmpl/bootstrap/css/src/_fonts.scss
 create mode 100644 koha-tmpl/opac-tmpl/bootstrap/css/src/sco.scss
 delete mode 100755 misc/cronjobs/delete_expired_opac_registrations.pl


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Wed Apr 17 19:38:40 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Wed, 17 Apr 2019 17:38:40 +0000
Subject: [koha-commits] main Koha release repository branch master updated.
	v18.11.00-1214-g75cdd63
Message-ID: <E1hGoW7-0002OP-UJ@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  75cdd63608596b02729d83f369eee8699eacb524 (commit)
       via  fa922322037ab1ce476aaa65984c66ef78bd3b9e (commit)
       via  37606f8b44ae1d680a32e83458df5601b94efb33 (commit)
       via  855ecd9f6ed57c643c983d738816fb3dfa1fbdef (commit)
       via  a6ba3bcc0d63784296d73a292780a994c2d09070 (commit)
       via  7c3ffa816b7e323d31b2fdac03198021a16fd4e3 (commit)
       via  5cad2946ae3ec52daf425118ffb35787160da417 (commit)
       via  dc62187ebff139fe93ac1c404105ac4abf2741b5 (commit)
       via  c12433a336ad20de1a53239b7aebf121e6a49878 (commit)
       via  3004bbb6f7430524aaca6c62c584f2b0b16ad89d (commit)
       via  97a680cc24b96e11e71da2e6fcc2bf6a239c7a00 (commit)
      from  ec6b3d18348189461b3d7587cb055394962255b6 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 75cdd63608596b02729d83f369eee8699eacb524
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Apr 17 17:01:10 2019 +0000

    Bug 22521: DBRev 18.12.00.055
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit fa922322037ab1ce476aaa65984c66ef78bd3b9e
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Apr 11 15:11:45 2019 -0400

    Bug 22521: (QA follow-up) Update number of tests in Circulation.t
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 37606f8b44ae1d680a32e83458df5601b94efb33
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Fri Apr 12 09:36:22 2019 +0100

    Bug 22521: (QA follow-up) remove FFOR from display
    
    A rebase re-introduced the FFOR accounttype in the display list.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 855ecd9f6ed57c643c983d738816fb3dfa1fbdef
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Fri Mar 29 10:04:46 2019 +0000

    Bug 22521: (QA follow-up) Update 'Offsets' test
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit a6ba3bcc0d63784296d73a292780a994c2d09070
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Wed Mar 27 11:39:30 2019 +0000

    Bug 22521: (QA follow-up) Corrections to tests
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 7c3ffa816b7e323d31b2fdac03198021a16fd4e3
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Fri Mar 22 11:46:36 2019 +0000

    Bug 22521: Update existing accounttypes
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 5cad2946ae3ec52daf425118ffb35787160da417
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Fri Mar 29 14:31:22 2019 +0000

    Bug 22521: Update UI to use accountlines.status
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit dc62187ebff139fe93ac1c404105ac4abf2741b5
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Fri Mar 29 14:31:06 2019 +0000

    Bug 22521: Update fines handling to use accountline.status
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit c12433a336ad20de1a53239b7aebf121e6a49878
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Tue Mar 19 14:24:35 2019 +0000

    Bug 22521: Increase varchar size for accounttype
    
    accountlines.accounttype is currently a short varchar(5) field for to
    store accounttype codes. Koha is moving towards more descriptive codes
    which require a larger capacity varchar(16).
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 3004bbb6f7430524aaca6c62c584f2b0b16ad89d
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Tue Apr 9 13:47:35 2019 -0300

    Bug 22547: (QA follow-up) Warn in debug mode
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 97a680cc24b96e11e71da2e6fcc2bf6a239c7a00
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Wed Mar 20 11:46:38 2019 +0000

    Bug 22547: Add tests for C4::Overdues->UpdateFine
    
    Add tests for UpdateFine, in particular testing the functionality of
    MaxFine.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm                                  |    7 +-
 C4/Overdues.pm                                     |   59 +++----
 Koha.pm                                            |    2 +-
 Koha/Account.pm                                    |    7 +-
 Koha/Account/Line.pm                               |   32 ++--
 Koha/Schema/Result/Accountline.pm                  |    8 +-
 circ/branchoverdues.pl                             |    6 +-
 installer/data/mysql/account_offset_types.sql      |    6 +-
 installer/data/mysql/kohastructure.sql             |    2 +-
 installer/data/mysql/updatedatabase.pl             |   73 ++++++++
 .../intranet-tmpl/prog/en/includes/accounts.inc    |   53 +++---
 .../prog/en/modules/members/maninvoice.tt          |    2 +-
 .../prog/en/modules/members/moremember-print.tt    |    2 +-
 .../bootstrap/en/includes/account-table.inc        |   13 +-
 .../opac-tmpl/bootstrap/en/modules/opac-account.tt |    1 +
 misc/cronjobs/staticfines.pl                       |    4 +-
 opac/opac-user.pl                                  |    2 +-
 t/db_dependent/Circulation.t                       |   42 +++--
 t/db_dependent/Koha/Account/Lines.t                |   59 ++++---
 t/db_dependent/Koha/Account/Offsets.t              |    8 +-
 t/db_dependent/Overdues.t                          |  186 +++++++++++++++++++-
 21 files changed, 432 insertions(+), 142 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Thu Apr 18 00:30:40 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Wed, 17 Apr 2019 22:30:40 +0000
Subject: [koha-commits] main Koha release repository branch 18.05.x updated.
	v18.05.11-32-ga1af304
Message-ID: <E1hGt4i-0005Ic-5f@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  a1af304aa0793f31c169dab13888f86486154e18 (commit)
      from  2fea06f7d9523ab0f23c6a0c8a93a7cffb48bc40 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a1af304aa0793f31c169dab13888f86486154e18
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Thu Apr 4 14:05:21 2019 +0000

    Bug 14358: Changing the module refreshes the page and resets library choice
    
    This patch makes an incremental change towards fixing Bug 14358: The
    "New notice" button is converted to a dropdown button which asks the
    user to select a module to start with.
    
    To test, apply the patch and go to Tools -> Notices. Test the "New
    notice" button and confirm that module selections are reflected in the
    notice add form you are shown.
    
    Signed-off-by: Mika?l Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit edf173e6ef1fa6de6e07f41c229799733456901a)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 99bc0ba719b2e23eb5b89f4ec8fc033461576109)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 .../intranet-tmpl/prog/en/modules/tools/letter.tt  |   26 +++++++++++++++-----
 1 file changed, 20 insertions(+), 6 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Thu Apr 18 00:42:50 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Wed, 17 Apr 2019 22:42:50 +0000
Subject: [koha-commits] main Koha release repository branch 18.05.x updated.
	v18.05.11-33-g14cfc4e
Message-ID: <E1hGtGU-0005hu-DC@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  14cfc4e7c558033299e1b719dc648c5649024304 (commit)
      from  a1af304aa0793f31c169dab13888f86486154e18 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 14cfc4e7c558033299e1b719dc648c5649024304
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Thu Apr 4 18:27:28 2019 +0000

    Bug 13629: SingleBranchMode removes both library and availability search from advanced search
    
    This patch modifies the OPAC advanced search form so that it is possible
    to limit searches to available items even if there is only one library.
    
    To test, apply the patch and go to the advanced search page in the OPAC.
    
     - With only one library configured: There should be a section labeled
       "Availability" with just the "only available" checkbox.
    
     - With multiple libraries: The section should be labeled "Location and
       availability" and should have the library dropdown and the
       availability checkbox.
    
    Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 7acb5394e1f62728c90a1d18e988c23a3e2862d2)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 781821b8aec54a5532c1a2da2e39df764f0bbb5e)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 .../opac-tmpl/bootstrap/en/modules/opac-advsearch.tt  |   17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Thu Apr 18 00:57:21 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Wed, 17 Apr 2019 22:57:21 +0000
Subject: [koha-commits] main Koha release repository branch 18.05.x updated.
	v18.05.11-34-g531ee47
Message-ID: <E1hGtUX-00069N-88@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  531ee472234942f1c63ab10745551af8e3eddbf8 (commit)
      from  14cfc4e7c558033299e1b719dc648c5649024304 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 531ee472234942f1c63ab10745551af8e3eddbf8
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Mon Apr 1 19:15:18 2019 +0000

    Bug 22624: Show OPAC description for authorised values in OPAC
    
    Patch adds the IS_OPAC parameter to a few GetByCode calls in
    OPAC files.
    
    To test:
    - Add different OPAC and intranet descriptions to some authorised
      value categories:
      - TERM
      - DEPARTMENT
      - LOC
      - CCODE
    - Create a new course using the values and adding items to it
    - Check the course reserves overview and detail pages in OPAC
    - Verify Department, term, location, and collection show
      the OPAC description if existing
    - Create a subscription, make sure a default location is selected
    - Check the OPAC detail page, subscription tab for this subsription
      in the OPAC
    - Verify the location of the subscription displays correctly
    
    Signed-off-by: Mika?l Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 3323a428eaf662a0ba1a31b2cb56002a7372461a)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 764260ded4f350904c548422defb74d32581f65e)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 .../bootstrap/en/modules/opac-course-details.tt    |   22 ++++++++++----------
 .../bootstrap/en/modules/opac-course-reserves.tt   |   10 ++++-----
 .../opac-tmpl/bootstrap/en/modules/opac-detail.tt  |   10 ++++-----
 3 files changed, 21 insertions(+), 21 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Thu Apr 18 12:08:52 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Thu, 18 Apr 2019 10:08:52 +0000
Subject: [koha-commits] main Koha release repository branch master updated.
	v18.11.00-1216-g2d54c95
Message-ID: <E1hH3yO-0002Na-OS@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  2d54c95e902c9111eb812d1b48dc0bb8df824f75 (commit)
       via  da8ca6c865e65bfe0d078e39324951ab1f7ed838 (commit)
      from  75cdd63608596b02729d83f369eee8699eacb524 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 2d54c95e902c9111eb812d1b48dc0bb8df824f75
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Wed Apr 17 14:34:24 2019 -0300

    Bug 21336: Add borrowers.flgAnonymized in an explicit position
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit da8ca6c865e65bfe0d078e39324951ab1f7ed838
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Wed Apr 17 14:31:27 2019 -0300

    Bug 21336: Fix the API
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/REST/V1/Patrons.pm                |    2 ++
 Koha/Schema/Result/Borrower.pm         |    3 ++-
 api/v1/swagger/definitions/patron.json |    5 +++++
 installer/data/mysql/updatedatabase.pl |   15 +++++++++++++--
 t/db_dependent/api/v1/patrons.t        |    3 +++
 5 files changed, 25 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Thu Apr 18 14:21:57 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Thu, 18 Apr 2019 12:21:57 +0000
Subject: [koha-commits] main Koha release repository branch master updated.
	v18.11.00-1244-g6b61049
Message-ID: <E1hH63B-0006Ts-D5@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  6b610497ffba5008f4e2541dc6cb07727ac5a63a (commit)
       via  bc1a21ec65377c8e7b331b89b45ebcddf9a7e4c7 (commit)
       via  f88923c05a303fc0d458055b1d27a17a775f07d1 (commit)
       via  9d80f9dc6b7d87bdf2e1536647a0bc8530465bd7 (commit)
       via  03c03ed8cdb94cda4cfd661e3b04f97cb36d8dc4 (commit)
       via  0bb1e01a0c553c18953be9799329128700e2d42b (commit)
       via  729987f40d442fd20c331e7ceec32f2e24486a5a (commit)
       via  8bf043b94d73724244429adfae249d87ca5c8b9c (commit)
       via  6f1459e2cea0b3ea2d14a649bda813cd9dee84ab (commit)
       via  752eba6cfeee809e74cc24bcfa4d95b14e7b9b68 (commit)
       via  5867683fe9aa91d9284d3554cebff9bbec2fa117 (commit)
       via  bc3f6a6aac993040e2cf57999bbbebeb1eb5ec9a (commit)
       via  f8bd40c1a619f530d5d8abc7e82b50b82a7d8db6 (commit)
       via  1758c8bc5da3c7d54f7537c80027dae0c369d847 (commit)
       via  8011f226975fa4f38586d7e0f2e4ce747bdced2b (commit)
       via  d6e1c6ffe639c08be9876c9e6f2f3551b3a82cb0 (commit)
       via  cb83128f62f258ad4bf97896b44fbf0ca65f7b35 (commit)
       via  0c95e22afe13349b60d134217fce6718bfa9727f (commit)
       via  cc501af15082f3da329d0557b337dce944626511 (commit)
       via  c90329fbe5c65c25908001383f24009811104240 (commit)
       via  074233b9d3732f0282df598a1742a37c8859f24a (commit)
       via  e600ae6c4b125ee40ce80346ce15f954a1fa424d (commit)
       via  d9cefbdd19c35ae83d0ffa59ca99aaf4bc775cac (commit)
       via  e8011cadddeedd594ba7fbbf90a49ce1822afa18 (commit)
       via  086a0007d2d484ecbd6ae6d60317ed4f0d3434b1 (commit)
       via  c9fa30a55b585b3351ece9c3f789fd18d9807fac (commit)
       via  4e40784f99f883a4f2634ed938764221d818096c (commit)
       via  d482c7b27257f5a63425633a17efed0747c317a1 (commit)
      from  2d54c95e902c9111eb812d1b48dc0bb8df824f75 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 6b610497ffba5008f4e2541dc6cb07727ac5a63a
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Wed Dec 19 00:19:07 2018 +0100

    Bug 21545: Translate new ACCOUNT_PAYMENT and ACCOUNT_WRITEOFF notices to German
    
    To test:
    - Apply patch
    - Run the German web installer
    - Verify the sample notices installs without error
    - Verify it looks 'German' in the GUI :)
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit bc1a21ec65377c8e7b331b89b45ebcddf9a7e4c7
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Wed Dec 19 00:06:55 2018 +0100

    Bug 21545: Translate 'Stock rotation slip'
    
    Throwing in some capitalization fixes for the English
    version of the notice as well.
    
    To test:
    - Verify the changes make sense and the SQL is still valid
      and executes
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit f88923c05a303fc0d458055b1d27a17a775f07d1
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Tue Jan 8 10:40:21 2019 -0500

    Bug 19619: Add support for SIP2 field CM ( Hold Pickup Date ) to Koha
    
    The CM field was all set up for implementation, but never completed.
    We should fully implement the CM ( Hold Pickup Date ), which according
    to the SIP2 protocol specification is "The date that the hold expires".
    
    Test Plan:
    1) Set up a waiting hold for an item
    2) Using the sip cli emulator, send an item information request for that item
    3) Note the CM field does not show up
    4) Apply this patch
    5) Restart all the things!
    6) Repeat the item information request
    7) Note the CM field is now transmitted!
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 9d80f9dc6b7d87bdf2e1536647a0bc8530465bd7
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Apr 18 11:54:07 2019 +0000

    Bug 15253: (follow-up) Fix qa complaints
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 03c03ed8cdb94cda4cfd661e3b04f97cb36d8dc4
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Tue May 1 11:47:12 2018 +0000

    Bug 15253: Add Koha::Logger based logging for SIP2
    
    Now that we have Koha::Logger, we should use it in our SIP server. This
    has the potential to make debugging SIP issue much easier. We should add
    the userid for the sipuser to the namespace so we can allow for separate
    files per sip user if wanted.
    
    Also modifies the log4perl.conf to lazy-open filehandles to log files,
    so the same config can be used with log-files needing different
    permissions.
    
    Test Plan:
    1) Apply this patch set
    2) Update the modififed log4perl.conf to your system
    3) Restart your sip server
    4) Tail your sip2.log, run some queries
    5) Note you still get the same output messages as before, with the
       addition of the ip address and username ( if available )
       prefixing the message.
    
    Based on original patches by Kyle Hall and additions by Olli-Antti
    Kivilahti.
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 0bb1e01a0c553c18953be9799329128700e2d42b
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Sat Apr 6 11:25:01 2019 +0000

    Bug 22645: Add 'ISSN' sarch option to OPAC simple search pull down
    
    To test:
    - Apply patch
    - Verify that the ISSN option shows up in the pull down
      for the simple search on top of the OPAC
    - Search for an ISSN with the new search option
    - Verify the correct search result shows
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 729987f40d442fd20c331e7ceec32f2e24486a5a
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Thu Apr 11 18:49:13 2019 +0000

    Bug 22175: (follow-up) Identify columns to exclude from export
    
    Bug 21216 added a way to designate DataTables columns to include in
    export operations (Copy, CSV, print, etc). However, this solution did
    not take hidden columns into account. This patch revises the global
    columns configuration settings so that exports will include only visible
    columns and will exclude columns with a "noExport" class on the <th>.
    
    To test, apply the patch and clear your browser cache if necessary.
    
     - Go to Tools -> Stock rotation
     - In the table of rotas, hide some columns in the table and verify that
       export operations include only your visible selections, excluding the
       last column with buttons.
     - Choose a rota and select Manage -> Items. Test that this table works
       in the same way.
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 8bf043b94d73724244429adfae249d87ca5c8b9c
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Fri Jan 25 14:02:01 2019 +0000

    Bug 22175: Make stock rotation table sortable
    
    This patch adds sorting and column configuration to the stock
    rotation tables, both rotas and items. No new defaults for the table are
    defined.
    
    To test, apply the patch and clear your browser cache if necessary.
    
     - Go to Tools -> Stock rotation.
       - In the table of rotas test that sorting works correctly.
       - Test that the "Column visibility" button works to show and hide
         columns. The "actions" column should be excluded.
       - Test that export options (Excel, CSV, etc) exclude the "actions"
         column.
       - Choose a rota with multiple items on it and select manage ->
         items. Repeat the above DataTables functionality tests.
    
     - Go to Administration -> Columns settings and edit the default
       configuration of the stock rotation tables. Confirm that these
       changes are reflected in the corresponding tables.
    
    Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos at inLibro.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 6f1459e2cea0b3ea2d14a649bda813cd9dee84ab
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Apr 18 10:51:21 2019 +0000

    Bug 22532: DBRev 18.12.00.059
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 752eba6cfeee809e74cc24bcfa4d95b14e7b9b68
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Mon Mar 18 16:48:51 2019 +0000

    Bug 22532: Database update
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 5867683fe9aa91d9284d3554cebff9bbec2fa117
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Mon Mar 18 16:46:00 2019 +0000

    Bug 22532: Remove Z39.50 random
    
    Test plan:
    Try to search, preview and import authority from Z39.50, everything
    should work as expected
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit bc3f6a6aac993040e2cf57999bbbebeb1eb5ec9a
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Apr 18 10:32:32 2019 +0000

    Bug 22521: (RM follow-up) Adjust tests to use new accounttype
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit f8bd40c1a619f530d5d8abc7e82b50b82a7d8db6
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Apr 18 10:08:58 2019 +0000

    Bug 22318: DBRev 18.12.00.058
    
    This includes DBRev 18.12.00.057 for bug 13795
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 1758c8bc5da3c7d54f7537c80027dae0c369d847
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Mon Apr 8 10:28:38 2019 +0100

    Bug 22318: (QA follow-up) Correct name of atomicupdate
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 8011f226975fa4f38586d7e0f2e4ce747bdced2b
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue Mar 19 13:39:39 2019 +0000

    Bug 22318: (follow-up) Add new options to new table filter form
    
    This patch adds the new language/location options to the form for
    filtering entries in the table of news items. Since this markup is
    duplicated twice in the template, its contents have been moved to a
    BLOCK.
    
    To test, apply the patch and go to Tools -> News. At the top of the
    table of news items the "Display location" form should show all options
    including OpacNavRight for all your enabled languages.
    
    Confirm that location/language selection still works correctly upon
    adding and editing news items.
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit d6e1c6ffe639c08be9876c9e6f2f3551b3a82cb0
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Thu Feb 14 15:49:25 2019 +0000

    Bug 22318: Example implementation: OpacNavRight system preference
    
    This patch implements a Koha news system replacement of the OpacNavRight
    system preference. The changes to koha-news.tt enable the selection of
    "OpacNavRight" as a location for the content. opac-main.pl is modified
    to ensure that the user's selected language is passed to the template
    for use by the KohaNews plugin.
    
    The database update process takes the contents of Koha's OpacNavRight
    system preference and adds it to the Koha news system. The OpacNavRight
    system preference is then removed from the database.
    
    When the new entry is added to Koha news, the language is set based on
    the top selected language in the "opaclanguages" preference. The entry
    is added to "All libraries" without an author, title, or expiration
    date.
    
    Note that this patch doesn't change the way OPAC news is displayed. I
    think it's best to keep existing markup and code for that since it
    handles details like branch selection and RSS.
    
    To test, apply the patch and run the database update.
    
     - In the staff client go to Tools -> News and confirm that there is now
       an entry with the location "OpacNavRight_en" (assuming an "en"
       English interface).
     - Confirm that the previous contents of OpacNavRight were added
       correctly.
     - Go to Administration -> System preferences -> OPAC and verify that
       the OpacNavRight preference has been removed.
     - In the OPAC, confirm that the correct content is displayed in the
       region previously defined in the OpacNavRight system preference.
     - Test that the language and library-specific nature of news items is
       reflected in the behavior of this content area:
       - Define different text based on language and location. Confirm that
         switching translations and logging in to the OPAC both trigger the
         correct display of different content.
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit cb83128f62f258ad4bf97896b44fbf0ca65f7b35
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Thu Feb 14 15:46:24 2019 +0000

    Bug 22318: Extend Koha news feature to include other content areas
    
    This patch lays the groundwork for using the Koha news tool to replace
    OPAC system preferences which embed HTML content in the Koha interface.
    This will allow multiple translations of these content blocks to be
    created.
    
    This adds a new template plugin, KohaNews. It has a single subroutine,
    get(), which takes three parameters:
    
     - "location" -- the area of the template where the content will appear.
       This will correspond to the system preference it replaces:
       OpacMainUserBlock, OpacNavRight, etc.
     - "lang" -- the user's currently-selected language.
     - "library" -- the user's home library (if they are logged in)
    
    A new "koha_news_block" block is added to the OPAC templates'
    html_helpers include. The content area is activated in the template
    using this syntax:
    
    [% PROCESS koha_news_block news => KohaNews.get( location =>
    "OpacNavRight", lang => news_lang, library => branchcode ) %]
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 0c95e22afe13349b60d134217fce6718bfa9727f
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Wed Apr 10 00:33:48 2019 +0200

    Bug 6730: Rename 'basket' filter to 'basket name' on receive page
    
    This way it's clear that you can search for the name here, but
    not for the number. It also matches the labelling of the
    other filter: Basket group name below.
    
    To test:
    - Receive shipment
    - Enter invoice number and go to receive page
    - Look at the filters on the left
    - Confirm the changed label and that basket name is searched
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit cc501af15082f3da329d0557b337dce944626511
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Wed Mar 20 15:29:32 2019 +0000

    Bug 13795: Remove occurences of unused columns in code
    
    These patch removes these two columns from backfill_statstics script
    and from columns.def - this file is used to create description in guided
    reports
    
    Test plan:
    1. Run installer/data/mysql/backfull_statistics.pl
    --> without this patch, there are associatedborrower and usercode errors
    reported
    --> with patch, these two columns are not reported
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit c90329fbe5c65c25908001383f24009811104240
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Wed Mar 20 15:26:38 2019 +0000

    Bug 13795: Make database update idempotent
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 074233b9d3732f0282df598a1742a37c8859f24a
Author: Nicole <nicole at bywatersolutions.com>
Date:   Tue Feb 2 09:33:46 2016 -0500

    Bug 13795: Delete unused columns from statistics table
    
    The following 2 fields are never used in the statistics table:
    
    associatedborrower
    usercode
    
    This patch removes them.
    
    To test:
    
    * check the database and make sure columns are gone
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit e600ae6c4b125ee40ce80346ce15f954a1fa424d
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Dec 5 21:05:32 2018 +0000

    Bug 21957: Add a flag to ModBiblio to avoid linking auths if called from linker
    
    To test:
    1 - prove -v t/db_dependent/Biblio.t
    2 - Set BiblioAddsAuthoorities and AutoCreateAuthorities
    3 - Modify a biblio to add a heading with no existing auth record
    4 - Ensure the record was created on saving
    5 - Ensure that editing works as normal otherwise
    6 - Run link_bibs_to_authorities
    7 - Ensure results are as expected
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit d9cefbdd19c35ae83d0ffa59ca99aaf4bc775cac
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Apr 18 10:00:48 2019 +0000

    Bug 8701: DBRev 18.12.00.056
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit e8011cadddeedd594ba7fbbf90a49ce1822afa18
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Sat Mar 16 13:19:11 2019 +0100

    Bug 8701: Remove links to OpacHiddenItems.txt in favor of wiki page
    
    Removes the OpacHiddenItems.txt file from Koha as this is not
    accessible for most people and replaces it with links to the wiki
    page like it's already done from the system preference editor.
    
    For reporting and the initial patch
    Thanks-to: Jane Sandberg <sandbej at linnbenton.edu>
    
    To test:
    - Changes are invisible from the GUI
    - Apply patch and run database update
    - SELECT * FROM systempreferences WHERE variable = "OpacHiddenItems";
    - Verify the description has the wiki link
    - Verify that docs/opac/OpacHiddenItems.txt has been removed
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 086a0007d2d484ecbd6ae6d60317ed4f0d3434b1
Author: Kris Sinnaeve <kris.sinnaeve at etf.edu>
Date:   Tue Apr 16 21:37:17 2019 +0000

    Bug 22139: Fields of ACCTDETAILS email not populating
    
    To test:
    * Make sure AutoEmailOpacUser is set to "send"
    * Create a new patron with a username and password, and an email address
    * In Kohadevbox, check the mail (usually you can type "mail" and go down
    to the last message) - these do not go into the message queue and they
    are processed immediately.
    notice that the email does not have
    <<borrowers.title>> <<borrowers.firstname>> <<borrowers.surname>>
    
    Apply this patch, restart the things, retest as above.
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit c9fa30a55b585b3351ece9c3f789fd18d9807fac
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Wed Apr 10 14:39:40 2019 +0100

    Bug 22461: Clarify and correct the hash reduction
    
    There were a couple of bugs in the previous patch which meant it wasn't
    working as intended. This patch corrects those bugs and simplifies the
    code a little along the way.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 4e40784f99f883a4f2634ed938764221d818096c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Mar 21 14:05:49 2019 -0300

    Bug 22461: Filter ldap mapping before inserting patron's info
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit d482c7b27257f5a63425633a17efed0747c317a1
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Mar 15 20:16:41 2019 -0300

    Bug 22461: Fix LDAP user replication
    
    From bug 20287:
    -        $borrowernumber = C4::Members::AddMember(%borrower) or die "AddMember failed";
    +        Koha::Patron->new( \%borrower )->store;
             C4::Members::Messaging::SetMessagingPreferencesFromDefaults( { borrowernumber => $borrowernumber, categorycode => $borrower{'categorycode'} } );
    
    $borrowernumber is not updated with the value of the newly created patron
    
    This patch restores the previous behavior (as well as the die)
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Auth_with_ldap.pm                               |    9 +-
 C4/Biblio.pm                                       |   12 +--
 C4/Breeding.pm                                     |   66 ++++++---------
 C4/ImportBatch.pm                                  |   18 ++--
 C4/SIP/ILS.pm                                      |    2 +-
 C4/SIP/ILS/Item.pm                                 |   11 ++-
 C4/SIP/ILS/Patron.pm                               |    2 +-
 C4/SIP/ILS/Transaction/Checkout.pm                 |    2 +-
 C4/SIP/ILS/Transaction/RenewAll.pm                 |    2 +-
 C4/SIP/SIPServer.pm                                |   88 +++++++++++++++++++-
 C4/SIP/Sip.pm                                      |   20 ++++-
 C4/SIP/Sip/Configuration.pm                        |    4 +-
 C4/SIP/Sip/MsgType.pm                              |    1 -
 C4/SIP/Trapper.pm                                  |   22 +++++
 Koha.pm                                            |    2 +-
 Koha/Logger.pm                                     |    7 +-
 Koha/Schema/Result/ImportRecord.pm                 |   12 +--
 Koha/Schema/Result/Statistic.pm                    |   19 +----
 Koha/Template/Plugin/KohaNews.pm                   |   73 ++++++++++++++++
 admin/columns_settings.yml                         |   35 ++++++++
 cataloguing/z3950_auth_search.pl                   |    1 -
 docs/opac/OpacHiddenItems.txt                      |   12 ---
 etc/log4perl.conf                                  |   16 ++++
 installer/data/mysql/backfill_statistics.pl        |    2 -
 .../data/mysql/de-DE/mandatory/sample_notices.sql  |    8 +-
 .../data/mysql/en/mandatory/sample_notices.sql     |    2 +-
 .../data/mysql/es-ES/mandatory/sample_notices.sql  |    2 +-
 .../mysql/fr-FR/1-Obligatoire/sample_notices.sql   |    2 +-
 installer/data/mysql/kohastructure.sql             |    5 --
 .../mysql/nb-NO/1-Obligatorisk/sample_notices.sql  |    2 +-
 .../data/mysql/pl-PL/mandatory/sample_notices.sql  |    2 +-
 .../data/mysql/ru-RU/mandatory/sample_notices.sql  |    2 +-
 .../data/mysql/ru-RU/optional/sample_notices.sql   |    2 -
 installer/data/mysql/sysprefs.sql                  |    3 +-
 .../data/mysql/uk-UA/mandatory/sample_notices.sql  |    2 +-
 installer/data/mysql/updatedatabase.pl             |   50 +++++++++++
 koha-tmpl/intranet-tmpl/prog/en/columns.def        |    1 -
 .../prog/en/includes/columns_settings.inc          |    2 +-
 .../intranet-tmpl/prog/en/modules/acqui/parcel.tt  |    2 +-
 .../prog/en/modules/admin/preferences/opac.pref    |    6 --
 .../prog/en/modules/tools/koha-news.tt             |   87 +++++++++----------
 .../prog/en/modules/tools/stockrotation.tt         |   42 ++++------
 .../intranet-tmpl/prog/js/pages/stockrotation.js   |   21 +++++
 .../bootstrap/en/includes/html_helpers.inc         |   13 +++
 .../opac-tmpl/bootstrap/en/includes/masthead.inc   |    5 ++
 .../opac-tmpl/bootstrap/en/modules/opac-main.tt    |    7 +-
 members/memberentry.pl                             |    1 +
 misc/link_bibs_to_authorities.pl                   |    3 +-
 opac/opac-main.pl                                  |    1 +
 t/db_dependent/Biblio.t                            |   19 ++++-
 t/db_dependent/Koha/Account.t                      |   48 +++++------
 51 files changed, 533 insertions(+), 245 deletions(-)
 create mode 100644 C4/SIP/Trapper.pm
 create mode 100644 Koha/Template/Plugin/KohaNews.pm
 delete mode 100644 docs/opac/OpacHiddenItems.txt


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Thu Apr 18 20:16:27 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Thu, 18 Apr 2019 18:16:27 +0000
Subject: [koha-commits] main Koha release repository branch master updated.
	v18.11.00-1246-g296e0ce
Message-ID: <E1hHBaF-0001Q3-Kl@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  296e0ce224debc9e1541683220df2306e166963f (commit)
       via  97faa17d710ed9e26f23e53a6dfbbd3ba79a3589 (commit)
      from  6b610497ffba5008f4e2541dc6cb07727ac5a63a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 296e0ce224debc9e1541683220df2306e166963f
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Apr 18 17:57:51 2019 +0000

    Revert "Bug 15253: Add Koha::Logger based logging for SIP2"
    
    This reverts commit 03c03ed8cdb94cda4cfd661e3b04f97cb36d8dc4.
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 97faa17d710ed9e26f23e53a6dfbbd3ba79a3589
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Apr 18 17:57:41 2019 +0000

    Revert "Bug 15253: (follow-up) Fix qa complaints"
    
    This reverts commit 9d80f9dc6b7d87bdf2e1536647a0bc8530465bd7.
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/SIP/ILS.pm                      |    2 +-
 C4/SIP/ILS/Item.pm                 |    2 +-
 C4/SIP/ILS/Patron.pm               |    2 +-
 C4/SIP/ILS/Transaction/Checkout.pm |    2 +-
 C4/SIP/ILS/Transaction/RenewAll.pm |    2 +-
 C4/SIP/SIPServer.pm                |   88 +-----------------------------------
 C4/SIP/Sip.pm                      |   20 ++------
 C4/SIP/Sip/Configuration.pm        |    4 +-
 C4/SIP/Sip/MsgType.pm              |    1 +
 C4/SIP/Trapper.pm                  |   22 ---------
 Koha/Logger.pm                     |    7 +--
 etc/log4perl.conf                  |   16 -------
 12 files changed, 13 insertions(+), 155 deletions(-)
 delete mode 100644 C4/SIP/Trapper.pm


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Fri Apr 19 17:11:04 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Fri, 19 Apr 2019 15:11:04 +0000
Subject: [koha-commits] main Koha release repository branch master updated.
	v18.11.00-1269-g3d84015
Message-ID: <E1hHVAO-000812-Om@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  3d840153d1e9736f126b04b96eea4367d096996b (commit)
       via  7b7a2767c826abcb507a5fe2466ecbdcea6f9d2c (commit)
       via  99cd771b09a6462381001ab98f7d833ca247c439 (commit)
       via  d8dfb61a9099cd9c07b22bf1d5a4cc2a834f2fc6 (commit)
       via  b3de8738b7f8db23c99b588a11da2225bd67106c (commit)
       via  5e20e438e80465fcd6f1c2af5e6138a639dec5f3 (commit)
       via  646e9fe3009b38694bc109611506932a3008932b (commit)
       via  38d68299ce7405823c50a6a41ac0f5d18b0b9044 (commit)
       via  0bbebced9dd463444cb1d91a60bcf4323e5a721e (commit)
       via  f751423d155d25b1ba80b4c429191389b46b6bcb (commit)
       via  ac6dc3b2c12cf16464e8676f4e2da6ec99e34e70 (commit)
       via  b969ccbf97c218da2bf6e22ab7773baf36c4fa71 (commit)
       via  31ace6a9347a8260532f6cc50d55fc36f87f1b44 (commit)
       via  7262bc066784247b12ce7f25c390498086e1d72b (commit)
       via  170085397b23d9b688628a56039f5e485fade6a5 (commit)
       via  4f14f7c7af13a7ee29c68302bad1ff8ac12c7fdf (commit)
       via  b038195735d2e9e64598cf12485aff3c4eeb1948 (commit)
       via  44e1cb20649b8b03a0f1036a05b0b7cf5e42c3e1 (commit)
       via  a488c9f4512eafa3d742b3e8204c2ca8cc850987 (commit)
       via  7a603d98d14527509fd38eb29ceb360ba0030904 (commit)
       via  8adb2f8003e25f6fe8cc78506a823a618a837fa1 (commit)
       via  c54c12f53d75598f2b014fb03c14aa2b1d7bb7c5 (commit)
       via  87026c6cad4bd65d7ed643ece830462f0ee95639 (commit)
      from  296e0ce224debc9e1541683220df2306e166963f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 3d840153d1e9736f126b04b96eea4367d096996b
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Apr 19 14:51:08 2019 +0000

    Bug 22564: DBRev 18.12.00.060
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 7b7a2767c826abcb507a5fe2466ecbdcea6f9d2c
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Apr 19 09:53:53 2019 +0000

    Bug 22564: (QA follow-up) Correct copy-paste message
    
    We should be replacing Rep here ;)
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 99cd771b09a6462381001ab98f7d833ca247c439
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Fri Mar 29 13:35:27 2019 +0000

    Bug 22564: Add UI handling for 'Replaced'
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit d8dfb61a9099cd9c07b22bf1d5a4cc2a834f2fc6
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Fri Mar 29 12:20:26 2019 +0000

    Bug 22564: Add database update 'just in case'
    
    With the introduction of the 'status' field it's a clear oportunity to
    convert any last remaining instances of 'Rep' to 'L' + 'REPLACED'.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit b3de8738b7f8db23c99b588a11da2225bd67106c
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Fri Mar 22 15:49:13 2019 +0000

    Bug 22564: Remove references to 'Rep' accounttype
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 5e20e438e80465fcd6f1c2af5e6138a639dec5f3
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date:   Wed Mar 6 14:07:50 2019 +0000

    Bug 22464: Pass forward parameters
    
    This patch ensures that parameters that are present are passed forward
    when accepting the copyright notice.
    
    Test plan:
    
    - Clone the latest version of the FreeForm backend from:
      https://github.com/PTFS-Europe/koha-ill-freeform
    - Ensure the ILLModuleCopyrightClearance syspref is populated
    - Create an OpenURL in order to pre-populate the FreeForm form, a suitable URL would be:
    
    <your_koha_instance>/cgi-bin/koha/opac-illrequests.pl?openurl=true&backend=FreeForm&method=create&opac=1&atitle=Theater%20careers.%20%5Belectronic%20resource%5D%20%3A%20a%20realistic%20guide.&aulast=Donahue%2C%20Tim&date=2012&genre=article&isbn=978123123123&issn=1234-5678&issue=34&pages=12-34&sid=EBSCO%3AAthlone%20Institute%20of%20Technology%3Aait.101326&title=article%20title%20here&volume=12
    
    - Log in
    - Accept the copyright notice
    => TEST: Observe that the FreeForm form is pre-filled with the metadata
    supplied in the OpenURL
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 646e9fe3009b38694bc109611506932a3008932b
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Wed Nov 7 17:18:00 2018 +0000

    Bug 21783: Reindent admin/columns_settings.tt
    
    This patch reindents admin/columns_settings.tt to use four spaces
    instead of two for indentation, following coding guidelines.
    
    To test, apply the patch and compare the file to master using the -w
    flag to ignore whitespace. The only changes should appear where lines
    were added during indentation.
    
    Go to Admin -> Columns settings and confirm that everything works
    correctly.
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 38d68299ce7405823c50a6a41ac0f5d18b0b9044
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Thu Apr 11 10:32:52 2019 +0100

    Bug 22687: Typo correction for Portuguese manual link
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 0bbebced9dd463444cb1d91a60bcf4323e5a721e
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon Apr 17 11:20:25 2017 -0400

    Bug 16149: Generate and send custom notices based on report output
    
    Ths patch add an EmailReport function to C4::Reports::Guided
    
    It accepts a notice (module, code, branch) and a report and attempts to
    email notices to patron, generating content using report content.
    
    Notice must be in template toolkit syntax, only columns in report are
    available for notice.
    
    To test:
    1 - Specify various options
    2 - Ensure errors are returned if options are incomplete or incorrect
    3 - Pass a report containing 'from' and 'email' and 'borrowernumber'
    columns and ensure message queue populated as expected
    
    Signed-off-by: Jessica Ofsa <jofsa at vt.edu>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit f751423d155d25b1ba80b4c429191389b46b6bcb
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri May 12 17:13:07 2017 -0400

    Bug 16149: Unit tests
    
    To test:
    prove -v t/db_dependent/Reports/Guided.t
    
    Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
    
    Signed-off-by: Jessica Ofsa <jofsa at vt.edu>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit ac6dc3b2c12cf16464e8676f4e2da6ec99e34e70
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Sat Apr 6 12:42:39 2019 +0000

    Bug 22649: Add itemtype to item search results and CSV file
    
    The itemtype can be searched for in the item search form, but
    it is not displayed in the result list.
    This patch adds the itemtype to the display and the CSV export
    file.
    
    To test:
    - Try different item searches
    - Verify that the itemtype now shows in the result list
    - Export to CSV
    - Verify that the itemtype shows there correctly as well
    
    Signed-off-by: Axel Amghar <axel.amghar at gmail.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit b969ccbf97c218da2bf6e22ab7773baf36c4fa71
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Tue Mar 12 11:19:35 2019 +0000

    Bug 22174: Add link to help page for API key management
    
    Makes the help link on the API key management page point
    to the proper section in the Koha manual.
    
    To test:
    - Activate RESTOAuth2ClientCredentials system preference
    - Go to any patron account
    - Go to More > Manage API keys
    - Click on the Help link in top right corner
    - Verify that the right section of the Koha manual displays
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 31ace6a9347a8260532f6cc50d55fc36f87f1b44
Author: Fr?d?ric Demians <f.demians at tamil.fr>
Date:   Mon Dec 3 18:02:03 2018 +0100

    Bug 21937: Syspref autoBarcode annual doesn't increment properly barcode
    
    This patch fix the barcode annual builder. The test should pass.
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 7262bc066784247b12ce7f25c390498086e1d72b
Author: Fr?d?ric Demians <f.demians at tamil.fr>
Date:   Mon Dec 3 18:27:08 2018 +0100

    Bug 21937: Add test to show autoBarcode annual increment bug
    
    This patch show the issue. If the DB contains a barcode (not auto attributed
    by Koha) which begin with the year used to generate automatically a new one,
    there may be a 'collision'.
    
    prove -v t/db_dependent/Barcodes_ValueBuilder.t
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 170085397b23d9b688628a56039f5e485fade6a5
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Tue Dec 27 17:07:20 2016 +0000

    Bug 15505: Mark Hold Items 'On hold' instead of 'Available'
    
    This patch adds a 'pending hold' column to C4::Items:GetItemsInfo to
    allow for displaying status of an item when it has been selected for a
    hold by the holdsqueue and AllowItemsOnHoldCheckout is set to 'Don't
    allow'
    
    To test:
    00 - Set AllowItemsOnHoldCheckout to 'Allow'
    01 - Place a hold on an item
    02 - Build the holdsqueue (kohadevbox example below)
          sudo koha-shell kohadev
          perl misc/cronjobs/holds/build_holds_queue.pl
    03 - Search for the item on the OPAC
    04 - Note item shows as 'Available' in results and details
    05 - Toggle AllowItemsOnHOldCheckout to 'Don't allow'
    06 - Repeat search, note there is no change
    06 - Apply Patch
    07 - Search for the item on the OPAC
    08 - Note that item now shows as 'Pending hold'
    09 - Toggle AllowItemsOnHoldCheckout to Allow
    10 - Note item shows as available
    11 - prove -v t/db_dependent/Items.t
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 4f14f7c7af13a7ee29c68302bad1ff8ac12c7fdf
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Mon Mar 11 13:18:06 2019 +0000

    Bug 21307: (follow-up) QA fixes
    
    This patch corrects a couple of issues discovered by QA: Removed markup
    copy-and-paste error; Add some CSS to help the responsive behavior of
    the advanced editor controls at smaller browser widths.
    
    To test, apply the patch and open the advanced MARC editor. Test the
    appearance of the page at various browser widths. At narrower widths the
    status bar and search fields should behave well.
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit b038195735d2e9e64598cf12485aff3c4eeb1948
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue Mar 5 14:53:18 2019 +0000

    Bug 21307: (follow-up) Change the way Codemirror height is calculated
    
    This follow-up changes the way the height of the Codemirror editor is
    calculated. Using offset() instead of position() returns the correct
    values with the changed markup.
    
    To test, apply the patch and load the advanced MARC editor. The "status
    bar" should display correctly a the bottom of the editor and there
    should be no double scrollbar.
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 44e1cb20649b8b03a0f1036a05b0b7cf5e42c3e1
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Mon Mar 11 14:25:27 2019 +0000

    Bug 21307: Switch two-column templates to Bootstrap grid: Cataloging
    
    This patch modifies two cataloging templates to use the Bootstrap grid
    instead of YUI.
    
    To test, apply the patch and view the following pages, confirming that
    they look correct at various browser widths:
    
     - Cataloging -> Edit record using the advanced editor
     - Cataloging -> Edit items
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit a488c9f4512eafa3d742b3e8204c2ca8cc850987
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Wed Mar 27 13:16:34 2019 +0000

    Bug 22584: Add YAML support for Codemirror
    
    This patch adds the dependencies required to provide YAML syntax
    highlighting in CodeMirror text areas. The OpacHiddenItems system
    preference configuration is updated to use a "text/x-yaml" CodeMirror
    syntax.
    
    To test, apply the patch and go to Administration -> System preferences
    -> OPAC.
    
    Expand the OpacHiddenItems preference and test that YAML-formatted text
    entry has the correct syntax highlighting.
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    https://bugs.koha-community.org/show_bug.cgi?id=2700
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 7a603d98d14527509fd38eb29ceb360ba0030904
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Fri Apr 12 14:32:46 2019 +0000

    Bug 22697: Reindent catalogue/result.tt
    
    This patch reindents the template for staff client catalogue search
    results. The only non-whitespace changes are comments to help identify
    closing tags and template directives.
    
    To test, apply the patch and perform a catalog search in the staff
    client. The results should look correct.
    
    The diff using the '-w' flag to ignore whitespace should
    highlight only moved lines and added comments.
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    https://bugs.koha-community.org/show_bug.cgi?id=22679
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 8adb2f8003e25f6fe8cc78506a823a618a837fa1
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date:   Tue Feb 19 01:36:14 2019 +0000

    Bug 22365: Removing warn when accessing Log Viewer
    
    To test:
    Go to Tools -> Log Viewer and confirm the warn no longer shows after
    applying the patch.
    
    Sponsored-by: Catalyst IT
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit c54c12f53d75598f2b014fb03c14aa2b1d7bb7c5
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue Dec 4 15:32:17 2018 +0000

    Bug 21942: Clean up cataloging merge template
    
    This patch makes a few minor markup corrections to the cataloging merge
    template:
    
     - Remove invalid "type" attributes from <style> and <script>
     - Add missing closing </span>
     - Remove obsolete YUI grid markup
    
    To test, apply the patch and test the process of merging records in
    Cataloging. Everything should look correct and work correctly.
    Validating the HTML source should return no errors stemming from the
    template.
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 87026c6cad4bd65d7ed643ece830462f0ee95639
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Fri Feb 22 13:26:01 2019 +0000

    Bug 21308: Results from order search do not show the search parameters
    
    This patch modifies the orders search results page so that the search
    form appears in the sidebar. This allows the user to view and re-use
    their search parameters.
    
    This patch also moves the "no search results" message to the top of the
    page in a message box.
    
    To test, apply the patch and go to Acquisitions -> Orders search.
    
     - Perform a search which will return results. In the sidebar you should
       see the full orders search form with your search parameters in the
       form fields.
    
     - Perform a search which will return no results. You should see the
       "Your search returned no results." message in a standard message
       dialog.
    
    Signed-off-by: Bin Wen <bin.wen at inlibro.com>
    
    Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Barcodes/ValueBuilder.pm                        |    2 +-
 C4/Circulation.pm                                  |    2 +-
 C4/Items.pm                                        |    3 +
 C4/Reports/Guided.pm                               |   97 ++
 C4/XSLT.pm                                         |    7 +-
 Koha.pm                                            |    2 +-
 Koha/Account.pm                                    |    2 +-
 Koha/Illrequest.pm                                 |    1 +
 Koha/Manual.pm                                     |    3 +-
 catalogue/itemsearch.pl                            |    2 +-
 installer/data/mysql/updatedatabase.pl             |   18 +
 koha-tmpl/intranet-tmpl/lib/codemirror/yaml.js     |  121 +++
 koha-tmpl/intranet-tmpl/lib/codemirror/yaml.min.js |    1 +
 koha-tmpl/intranet-tmpl/prog/css/cateditor.css     |   14 +-
 .../intranet-tmpl/prog/en/includes/accounts.inc    |    1 +
 .../en/includes/catalogue/itemsearch_item.csv.inc  |    3 +-
 .../en/includes/catalogue/itemsearch_item.json.inc |    2 +
 .../prog/en/includes/cateditor-ui.inc              |    2 +-
 .../includes/csv_headers/catalogue/itemsearch.tt   |    2 +-
 .../prog/en/includes/filter-orders.inc             |    2 +-
 .../prog/en/modules/acqui/histsearch.tt            |   53 +-
 .../prog/en/modules/admin/columns_settings.tt      |  383 +++----
 .../prog/en/modules/admin/preferences.tt           |    1 +
 .../en/modules/admin/preferences/cataloguing.pref  |    4 +-
 .../en/modules/admin/preferences/circulation.pref  |    2 +-
 .../prog/en/modules/admin/preferences/opac.pref    |    1 +
 .../prog/en/modules/catalogue/itemsearch.tt        |    7 +
 .../prog/en/modules/catalogue/results.tt           | 1067 ++++++++++----------
 .../prog/en/modules/cataloguing/additem.tt         |   34 +-
 .../prog/en/modules/cataloguing/editor.tt          |   52 +-
 .../prog/en/modules/cataloguing/merge.tt           |    6 +-
 .../bootstrap/en/includes/account-table.inc        |    1 +
 .../bootstrap/en/includes/item-status.inc          |    5 +
 .../bootstrap/en/modules/opac-illrequests.tt       |    3 +-
 .../bootstrap/en/xslt/MARC21slim2OPACResults.xsl   |    6 +
 misc/cronjobs/patron_emailer.pl                    |  175 ++++
 t/db_dependent/Barcodes_ValueBuilder.t             |    6 +
 t/db_dependent/Items.t                             |   15 +-
 t/db_dependent/Reports/Guided.t                    |   55 +-
 tools/viewlog.pl                                   |    2 +-
 40 files changed, 1378 insertions(+), 787 deletions(-)
 create mode 100644 koha-tmpl/intranet-tmpl/lib/codemirror/yaml.js
 create mode 100644 koha-tmpl/intranet-tmpl/lib/codemirror/yaml.min.js
 create mode 100755 misc/cronjobs/patron_emailer.pl


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Fri Apr 19 18:28:59 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Fri, 19 Apr 2019 16:28:59 +0000
Subject: [koha-commits] main Koha release repository branch 18.05.x updated.
	v18.05.11-36-gaf21725
Message-ID: <E1hHWNn-0001dv-PB@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  af21725edaf4342bbf6a8883f08426b41fc6f09b (commit)
       via  bf09bf5826c4bb8ad2d77456b843c321b3bffe37 (commit)
      from  531ee472234942f1c63ab10745551af8e3eddbf8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit af21725edaf4342bbf6a8883f08426b41fc6f09b
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Thu Apr 4 00:56:43 2019 +0000

    Bug 21659: Change link to basket group edit page
    
    I have taken another look at other links like the one
    from acq order search and changed the link to not lead
    to the vendor's basket group page but to the edit page
    of the invidividual basket group.
    
    To test:
    - Same as first patch, verify links now lead
      to the basket grou edit page
    
    https://bugs.koha-community.org/show_bug.cgi?id=21650
    
    Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos at inLibro.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 9cbc5f2aa072ec41a70fd1fa1de4f684fcd695e9)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit b1628abb3e3262f0eb712236f44991b7bb1799a9)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit bf09bf5826c4bb8ad2d77456b843c321b3bffe37
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Mon Mar 11 16:24:16 2019 +0000

    Bug 21659: Fix links to basket groups from order receive page
    
    Fixes a problem with the template variables on the order
    receive page, so that the links to basket groups work
    correctly again.
    
    To test:
    - Create some orders with and without basket groups
    - Receive shipment
    - Verify that the basket group links for pending orders work right
    - Receive an order line
    - Verify that the basket group links for received orders work right
    
    Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos at inLibro.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 3db5feb900d3e6a6400767c771afe78bab0fa880)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 6f1738121355fed39b7c9440e3ed47a05788987e)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Fri Apr 19 18:46:06 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Fri, 19 Apr 2019 16:46:06 +0000
Subject: [koha-commits] main Koha release repository branch 18.05.x updated.
	v18.05.11-37-gb48a2b3
Message-ID: <E1hHWeM-000207-2Q@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  b48a2b38fec71f823e6ae99338217d837f329653 (commit)
      from  af21725edaf4342bbf6a8883f08426b41fc6f09b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit b48a2b38fec71f823e6ae99338217d837f329653
Author: Maryse Simard <maryse.simard at inlibro.com>
Date:   Thu Feb 7 08:24:03 2019 -0500

    Bug 21263: Pickup library not set correctly when using Default holds policy
    
    In the case of a specific item hold, it can only be fulfilled if the pickup library
    matches the hold fulfillment policy. Therefore, if OPACAllowUserToChooseBranch is
    set to don't allow, the pickup library should correspond to the policy.
    
    In case of hold that does not specify an item, the homebranch or holdingbranch
    can't be determined at this time, so the pickup library still defaults to the
    homebranch of the borrower. Same if there is no policy or it states 'any'.
    
    To test:
    - Make sure OPACAllowUserToChooseBranch is set to don't allow
    - Make sure you have two branches A and B
    - Have one item whose homebranch is B
    - Have one user whose homebranch is A
    - Make sure the circulation rules allow the user to reserve the item's item type
    
    1. Go to Administration > Circulation and fines rules
    2. Create a Default holds policy by item type for that item type
        - Item type = item's item type
        - Hold policy = From any library
        - Hold pickup library match = item's home library
        - Return policy = item returns home
    3. Go to the OPAC and log in with the user's credentials
    4. Search for the item
    5. Click on "Place hold"
    6. Select a specific item and confirm hold
    7. In the user's file on the OPAC and check the reservation's pickup library. It should be the item's homebranch
    
    You can then repeat the steps for 'item's holding library' or 'any library' as
    the Hold pickup library match. It should also work the same way if there is no
    'Default holds policy by item type' for this item type but a 'Default checkout,
    hold and return policy' set.
    
    Finally, check that placing a hold without selecting a specific item still
    defaults the pickup library to the borrower's homebranch.
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 275dee5f9b9a26b3490bf3646c71c78a2d8647eb)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 5236b45a055e90f21ae634acf5b07831ba8f02b8)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 opac/opac-reserve.pl |   14 ++++++++++++++
 1 file changed, 14 insertions(+)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Fri Apr 19 18:57:34 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Fri, 19 Apr 2019 16:57:34 +0000
Subject: [koha-commits] main Koha release repository branch 18.05.x updated.
	v18.05.11-38-g483a2b2
Message-ID: <E1hHWpS-0002HR-QE@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  483a2b2c7a3471f619ea0798a81fa715e604ba6a (commit)
      from  b48a2b38fec71f823e6ae99338217d837f329653 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 483a2b2c7a3471f619ea0798a81fa715e604ba6a
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Wed Mar 6 19:02:50 2019 +0000

    Bug 22444: currencies_manage permission doesn't provide link to manage currencies when selected alone
    
    This patch modifies the acquisitions sidebar menu so that it checks
    properly for the currencies_manage permission.
    
    This patch also removes the menu link directly to the administration
    home page. Since we're removing the check on the general
    "CAN_user_parameters" permission it doesn't make sense to assume the
    page is accessible.
    
    To test, apply the patch and modifiy a staff user so that they have no
    "parameters" permissions but do have "currencies_manage" permission.
    
    Go to the Acquisitions home page. There should be a link to currencies
    management in the sidebar menu.
    
    Perform the same test with a user who has "parameters" permissions but
    not "currencies_manage" permission. There should be no link to
    currencies in the acquisitions sidebar menu. The user should have access
    to the administrative home page.
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 761b410f99cbbfff8e353c538fde2b6816408795)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit f7f13511d6a74359d65d7cc2348a73eb18da6044)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-menu.inc |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Mon Apr 22 17:14:18 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Mon, 22 Apr 2019 15:14:18 +0000
Subject: [koha-commits] main Koha release repository branch 18.05.x updated.
	v18.05.11-39-ga0b6a89
Message-ID: <E1hIaeA-00075Z-Ac@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  a0b6a894fec0d2a3a804f86e9fdd076137b8c26e (commit)
      from  483a2b2c7a3471f619ea0798a81fa715e604ba6a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a0b6a894fec0d2a3a804f86e9fdd076137b8c26e
Author: Hayley Mapley <hayleymapley at catalyst.net.nz>
Date:   Thu Mar 14 04:14:57 2019 +0000

    Bug 19497: Removed title (tooltip) from Edit button in items_search_fields.tt
    
    This patch removes the tooltip that appears when hovering over the Edit button
    of Item Search Fields in the staff client. This was done for consistency reasons,
    including that this tooltip is not translated and tooltips do not appear to be
    on the majority of buttons in the staff client.
    
    Test plan:
    1) In Home->Administration->Item search fields create a new search field
    if you haven't got any already
    2) Observe the tooltip that appears when hovering over the Edit button in
    the Item serach fields table.
    3) Apply the patch and observe that the tool tip no longer appears.
    
    Sponsored-by: Catalyst IT
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 968c888e1579ab28ec165819a011612d8b8f5570)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 634400f05c625a0724172c82004fc6209717bde1)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 .../intranet-tmpl/prog/en/modules/admin/items_search_fields.tt     |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Tue Apr 23 15:41:16 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Tue, 23 Apr 2019 13:41:16 +0000
Subject: [koha-commits] main Koha release repository branch 18.05.x updated.
	v18.05.11-41-g8ffc1ba
Message-ID: <E1hIvfg-000221-7Q@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  8ffc1ba00cf21377f1ea476026a5df7a711adaae (commit)
       via  a058708d54d4bcf3ccee32494e0dddf8981a4967 (commit)
      from  a0b6a894fec0d2a3a804f86e9fdd076137b8c26e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 8ffc1ba00cf21377f1ea476026a5df7a711adaae
Author: Lucas Gass <lucas at bywatersolutions.com>
Date:   Tue Apr 23 12:37:54 2019 +0000

    Bug 22607: DBRev 18.05.11.001
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit a058708d54d4bcf3ccee32494e0dddf8981a4967
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Fri Mar 29 08:13:48 2019 +0000

    Bug 22607: Change default value in issues.renewals to '0'.
    
    This patch change renewals column of issues and old_issues tables.
    
    Now it is NOT NULL default 0. It does not make sense when number of
    renewals is undefined, it is always integer with value zero or more
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit cf95f0a7e6897d3dc4b90c92ffad19230379d7cb)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit fd22ef99fe0d78bce28d659323bd8401067f198b)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha.pm                                |    2 +-
 installer/data/mysql/kohastructure.sql |    4 ++--
 installer/data/mysql/updatedatabase.pl |   14 ++++++++++++++
 3 files changed, 17 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Tue Apr 23 16:57:31 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Tue, 23 Apr 2019 14:57:31 +0000
Subject: [koha-commits] main Koha release repository branch 18.05.x updated.
	v18.05.11-44-ga680472
Message-ID: <E1hIwrT-0004U2-2M@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  a6804721711904f1a95c18d6274d6d2c495431b7 (commit)
       via  ae481fde83f1811cc8204d552c37562e26e840c9 (commit)
       via  1260e16b67406a552b634443cd02721bb519f50e (commit)
      from  8ffc1ba00cf21377f1ea476026a5df7a711adaae (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a6804721711904f1a95c18d6274d6d2c495431b7
Author: Lucas Gass <lucas at bywatersolutions.com>
Date:   Tue Apr 23 13:53:51 2019 +0000

    Bug 19670: (RMaint follow-up)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit ae481fde83f1811cc8204d552c37562e26e840c9
Author: Lucas Gass <lucas at bywatersolutions.com>
Date:   Tue Apr 23 13:51:49 2019 +0000

    Bug 19670: DBRev 18.05.11.002
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit 1260e16b67406a552b634443cd02721bb519f50e
Author: Ere Maijala <ere.maijala at helsinki.fi>
Date:   Thu Mar 14 14:33:18 2019 +0200

    Bug 19670: Change Collation of marc_field to allow mixed case mappings
    
    Test plan:
    1. Apply patch and update database
    2. Verify that you can add a search field mapping for both 100a and 100A.
    3. Verify that the above also works with a newly-created database.
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit a5f3d405f56202beb4426da52f3bf4019f26484b)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 4a1986b6b102304ab0cce24e32a334f11d9556df)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha.pm                                |    2 +-
 installer/data/mysql/kohastructure.sql |    2 +-
 installer/data/mysql/updatedatabase.pl |   14 +++++++++++++-
 3 files changed, 15 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Wed Apr 24 10:09:21 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Wed, 24 Apr 2019 08:09:21 +0000
Subject: [koha-commits] main Koha release repository branch 17.11.x updated.
	v17.11.17-3-g1f80eac
Message-ID: <E1hJCy1-0002Cd-1N@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 17.11.x has been updated
       via  1f80eac9616f582012c591989d96643b2bc52b82 (commit)
       via  7ac6f7034b1997aa00a23238bc5a3abb257b7e73 (commit)
       via  d0590904723d79fda669a6ce8e0e44e0251046f6 (commit)
      from  a54244ace48b2f124d4183355e430faeb0e0e35b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 1f80eac9616f582012c591989d96643b2bc52b82
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Thu Mar 7 14:46:29 2019 +0100

    Bug 21832: add is_expired to ILS-DI example
    
    Test plan :
    1) Apply patch
    2) Enable ILS-DI
    3) Go to <opac URL>/cgi-bin/koha/ilsdi.pl?service=Describe&verb=GetPatronInfo
    4) Check you see is_expired in example response
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit c0df2d0e8612e1ca428f51462fcfb99fbc3f0009)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit fffb7b3c6a3762683920aa5448a6128944bf21e1)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit c15a41bcddcd052d3e8f79af35cb2c4118e567a8)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 7ac6f7034b1997aa00a23238bc5a3abb257b7e73
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Tue Feb 12 15:52:22 2019 +0100

    Bug 21832: add unit test
    
    Adds a check that is_expired exists in service GetPatronInfo.
    
    Test plan :
    Run : prove t/db_dependent/ILSDI_Services.t
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Amended patch: remove ref to bug number, we have git for that
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 20ce110f5c656f51bad262708d4b577568c1a52a)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 4e305856af7b713868206e385fb1abac7a79a9d8)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit 7037e350d6f005c5f66bdba40fcefea471618659)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit d0590904723d79fda669a6ce8e0e44e0251046f6
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Wed Nov 14 11:18:58 2018 +0100

    Bug 21832: Restore is_expired in ILS-DI GetPatronInfo service
    
    Since Bug 17578 removed C4::Member::GetMemberDetails, the information "is_expired" disappeared from ILS-DI service GetPatronInfo.
    
    I propose to restore in by adding the code that exisited in C4::Member::GetMemberDetails directly in C4::ILSDI::Services.
    
    Test plan :
    1) Enable ILS-DI webservice
    2) Choose a patron not expired
    3) Call web-service (replace X with patron's borrowernumber) :
       /cgi-bin/koha/ilsdi.pl?service=GetPatronInfo&patron_id=X
    4) You see : <is_expired>0</is_expired>
    5) Choose a patron expired
    6) Call web-service (replace X with patron's borrowernumber) :
       /cgi-bin/koha/ilsdi.pl?service=GetPatronInfo&patron_id=X
    7) You see : <is_expired>1</is_expired>
    
    Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 0748911eb26f2a35d8ba881dcb92e37a979fc9a9)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 531040897b2c02114fe51a6c8de338f8bb61c3cb)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit ec1145c148aefc5ea37a9dfbb5827da14e1d839d)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/ILSDI/Services.pm                              |    3 +++
 koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt |    1 +
 t/db_dependent/ILSDI_Services.t                   |    4 +++-
 3 files changed, 7 insertions(+), 1 deletion(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Wed Apr 24 13:58:15 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Wed, 24 Apr 2019 11:58:15 +0000
Subject: [koha-commits] main Koha release repository branch master updated.
	v18.11.00-1293-gbe0d338
Message-ID: <E1hJGXX-0006lr-2N@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  be0d338366589ef80b69f287d7dbfc059476e4b2 (commit)
       via  7d598d9130c3d171af1e1a6a0a168cea043c277d (commit)
       via  1d845a1b3765f9ca11e526a0ea78dd0947246f4d (commit)
       via  aa6c41db8dd60a0eb27560c515ffaab5f9371c42 (commit)
       via  e7e1f2faeea94d2568779f9e7bbdc100909561c3 (commit)
       via  cac5edd81d58a399b2254f378593fdb44a893826 (commit)
       via  097a6af3b03a90af8c42a4ea8139edca8c9eb616 (commit)
       via  40ed0baba7f1156ba63d2a8ee095b40db66e13c8 (commit)
       via  4a0fa82a5b3ed2f493c55c1b74bf3dac2738c47f (commit)
       via  95e074414758c84800281e410cabd258b1d4741d (commit)
       via  6416ead3cb5f992146822f7de6b242a814d1a1be (commit)
       via  0a22e3127d90c9d76734b223523e0635b18cb32d (commit)
       via  e3b68414373ee23418a6dc3ce10e859ae8fb66b8 (commit)
       via  0e762da67092e8bd04e37908e9e1419ea16f70e3 (commit)
       via  f76f93ecf191231036c96b17fceccf819247959f (commit)
       via  6fa21ef939785c1fd757a4755cd9b12ed09a18a0 (commit)
       via  f11bda813695e025a3e0f45463d7f710d82548af (commit)
       via  b639271a615aaf9dce0d6fc2fd0dc7e22e8cf74a (commit)
       via  6f4565ce686919ada0bc95ea26497ff80e4df250 (commit)
       via  b78bd2faec703bb7d7c750dbc1070ba2449f29a9 (commit)
       via  d8a759162cde8f373ea945a7e509102ec81878e0 (commit)
       via  d9ce1567937de5fe115ec8595db63b7cfe80d8d6 (commit)
       via  6d9839d800ac8334a902cba5917b878507f8ba18 (commit)
       via  22deca9445cb02320a04abb69febc9ef83d4d58f (commit)
      from  3d840153d1e9736f126b04b96eea4367d096996b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit be0d338366589ef80b69f287d7dbfc059476e4b2
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Mon Apr 22 18:50:15 2019 +0000

    Bug 22751: Switch two-column templates to Bootstrap grid: Patron details
    
    This patch updates the patron details page template to use the Bootstrap
    grid.
    
    To test, apply the patch and view the detail page for a patron in the
    staff client. Adjust the browser width and confirm that the page adapts
    to different sizes.
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 7d598d9130c3d171af1e1a6a0a168cea043c277d
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue Apr 23 15:41:50 2019 +0000

    Bug 21034: Re-indent circulation.tt
    
    This patch reindents the template for the checkout page, circulation.tt:
    
    - Trailing spaces removed
    - Indentation changed to a consistent 4 spaces
    - Markup indentation made more consistent
    
    To test, view the checkout page under various circumstances:
    
    - No card number submitted
    - Name submitted (patron search results)
    - Card number submitted
      - Restricted patron
      - Patron with circulation messages
      - On-site checkouts
      - Check all tabs: checkouts, relatives' checkouts holds, article
        requests, restrictions, clubs
    
    HTML validation before and after the patch should return the same
    results.
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 1d845a1b3765f9ca11e526a0ea78dd0947246f4d
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon Apr 22 12:47:40 2019 +0000

    Bug 22418: (follow-up) OPAC changes
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit aa6c41db8dd60a0eb27560c515ffaab5f9371c42
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon Apr 22 12:39:08 2019 +0000

    Bug 22418: Add magnifying glass to 655 results
    
    To test:
    1 - Have some 655 fields linked to authorities
    2 - Notice they have no magnifyiung glass
    3 - Apply patch
    4 - Note they have one now
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit e7e1f2faeea94d2568779f9e7bbdc100909561c3
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Wed Apr 10 00:02:09 2019 +0200

    Bug 22674: Change wording of payments in the GUI
    
    This changes the different versions of "Payment, thanks"
    to just read "Payment".
    
    To test:
    - Look at the Fines & Charges tables in
      - OPAC patron account > your fines
      - Staff patron account > Accounting > Transactions tab
      - Staff patron account > Accounting > Make a payment tab
    - Verify all tables display the descriptions correctly
    - Decide if you like this better than before
      Yes: sign-off
      No: comment on the bug please
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit cac5edd81d58a399b2254f378593fdb44a893826
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Wed Nov 7 18:55:57 2018 +0000

    Bug 21784: Clean up js_includes.inc
    
    This patch cleans up js_includes.inc by removing script "type"
    attributes which are now invalid HTML. The patch also removes "CDATA"
    markers from script blocks. They have been unnecessary since we stopped
    using an XHTML doctype.
    
    To test, apply the patch and look at various pages in the staff client
    to confirm that no JavaScript-driven interactions are broken.
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 097a6af3b03a90af8c42a4ea8139edca8c9eb616
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Apr 22 10:20:17 2019 -0300

    Bug 22696: Prefetch items too
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 40ed0baba7f1156ba63d2a8ee095b40db66e13c8
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Apr 19 11:29:49 2019 -0300

    Bug 22696: (follow-up) Use new relationship for prefetching
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 4a0fa82a5b3ed2f493c55c1b74bf3dac2738c47f
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Apr 12 15:22:30 2019 -0300

    Bug 22696: Simplify visibility logic in opac-ISBDdetail.pl
    
    This patch removes many DB queries and uses state-of-the-art Koha code
    to accomplish the same things it did before.
    
    To test:
    - Apply this patch
    - Open opac-ISBDdetail.pl for a known record
    => SUCCESS: No behaviour change.
    - Sign off :-D
    
    Signed-off-by: Bin Wen <bin.wen at inlibro.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 95e074414758c84800281e410cabd258b1d4741d
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Apr 22 10:08:41 2019 -0300

    Bug 22701: Make items prefetchable from Koha::Biblio
    
    This patch makes Koha::Biblio->items use _new_from_dbic instead of
    calling Koha::Items->search. This allows calling it with prefetch
    enabled for the items relationship. No noticeable behaviour change takes
    place besides this.
    
    To test:
    - Run:
      $ kshell
     k$ prove t/db_dependent/Koha/Biblio.t
    => SUCCESS: Tests pass!
    - Apply this patch
    - Run:
     k$ prove t/db_dependent/Koha/Biblio.t
    => SUCCESS: Tests still pass!
    - Sign off :-D
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 6416ead3cb5f992146822f7de6b242a814d1a1be
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Sat Apr 20 09:47:43 2019 -0300

    Bug 22701: Unit tests for Koha::Biblio->items
    
    This patch adds tests fr the current items() implementation. The idea is
    to verify no behaviour change takes place after we make it us
    _new_from_dbic instead of calling Koha::Items->search.
    
    To test:
    - Run:
      $ kshell
     k$ prove t/db_dependent/Koha/Biblio.t
    => SUCCESS: Tests pass!
    - Sign off :-D
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 0a22e3127d90c9d76734b223523e0635b18cb32d
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Tue Apr 23 15:49:28 2019 +0100

    Bug 22694: Add Koha::Patron::Category->override_hidden_items
    
    This patch introduces a method to determine for a given category if
    patrons belonging to it override OpacHiddenItems policies.
    
    To test:
    - Apply the patches
    - Run:
      $ kshell
     k$ prove t/db_dependent/Koha/Patron/Category.t
    => SUCCESS: Tests pass!
    - Sign off :-D
    
    Signed-off-by: Bin Wen <bin.wen at inlibro.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit e3b68414373ee23418a6dc3ce10e859ae8fb66b8
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Apr 12 10:42:30 2019 -0300

    Bug 22694: Unit tests
    
    Signed-off-by: Bin Wen <bin.wen at inlibro.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 0e762da67092e8bd04e37908e9e1419ea16f70e3
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Apr 12 13:46:04 2019 -0300

    Bug 22700: Make biblio_metadata prefetchable from Koha::Biblio
    
    This patch makes $biblio->metadata be prefetchable as the Coding
    guidelines require.
    
    A new has_one relationship is added in the Biblio schema, named as the
    accessor to also convey to proposed guidelines for readability.
    
    To test:
    - Apply this patch
    - Run:
      $ kshell
     k$ prove t/db_dependent/Koha/Biblio.t
    => SUCCESS: No regressions!
    - Sign off :-D
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit f76f93ecf191231036c96b17fceccf819247959f
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon Apr 22 15:05:51 2019 +0000

    Bug 22748: Pass userid to haspermission
    
    Signed-off-by: Agustin Moyano <agustinmoyano at theke.io>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 6fa21ef939785c1fd757a4755cd9b12ed09a18a0
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Tue Apr 23 07:38:14 2019 +0000

    Bug 22755: Fix pod in patron_emailer.pl
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit f11bda813695e025a3e0f45463d7f710d82548af
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Tue Apr 23 07:34:41 2019 +0000

    Bug 22755: Import Koha::Script into patron_emailer cronjob
    
    Test plan:
    Run patron_emailer.pl cronjob to ensure it is not broken after this
    patch
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit b639271a615aaf9dce0d6fc2fd0dc7e22e8cf74a
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Apr 22 12:02:02 2019 -0300

    Bug 22749: Make Koha::Item->hidden_in_opac respect hidelostitems
    
    This patch makes Koha::Item->hidden_in_opac take hidelostitems into
    account when performing the calculation.
    
    To test:
    - Apply the regression tests patch
    - Run:
      $ kshell
     k$ prove t/db_dependent/Koha/Item.t
    => FAIL: Tests fail because the code doesn't (yet) care about the
    syspref
    - Apply this patch
    - Run:
     k$ prove t/db_dependent/Koha/Item.t
    => SUCCESS: Tests pass!
    - Sign off :-D
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 6f4565ce686919ada0bc95ea26497ff80e4df250
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Apr 22 11:54:21 2019 -0300

    Bug 22749: Regression tests for Koha::Item->hidden_in_opac
    
    This patch introduces regression tests for Koha::Item->hidden_in_opac to
    verify it is not considering the hidelostitems syspref when determining
    if an item should be hidden (per policy) in the OPAC.
    
    To test:
    - Apply this patch
    - Run:
      $ kshell
     k$ prove t/db_dependent/Koha/Item.t
    => FAIL: Tests fail!
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit b78bd2faec703bb7d7c750dbc1070ba2449f29a9
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Apr 19 06:49:48 2019 +0000

    Bug 22735: Resolve internal server error on missing item type
    
    Trivial fix, similar to opac-detail, applied to ISBD and MARC detail.
    
    Test plan:
    Enable ArticleRequests pref.
    Make sure you have a biblio with no item type in 942c. (Perhaps you need to
    make 942c not mandatory temporarily and save a biblio record without this
    field being filled.)
    If you are logged in, log out.
    Go to MARC or ISBD detail page. No crash anymore?
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit d8a759162cde8f373ea945a7e509102ec81878e0
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Tue Apr 23 14:17:58 2019 +0000

    Bug 22679: Delete related CirculationRules when Removing IssuingRule
    
    Unfortunately, the tables here can't use a foreign key as one table uses null where the other uses
    '*' This patchset alters the delete method so delete related rules. It is somewhat of a workaround until
    all the columns in issuingrules are moved to circulation_rules
    
    To test:
    1 - Add some issuing rules in koha, making sure to set maxissueqty
    2 - Check the DB: SELECT * FROM circulation_rules;
    3 - note some circulation rules were created
    4 - Delete your rules via the staff interface
    5 - Check the DB, the circulation rules remain
    6 - Apply patch
    7 - Repeat
    8 - Huzzah! The rules delete!
    9 - Prove the tests, read the code
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit d9ce1567937de5fe115ec8595db63b7cfe80d8d6
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Tue Apr 23 16:18:51 2019 +0000

    Bug 22759: Fix wrong check of branch rule in C4::Circulation::TooMany
    
    The condition in TooMany applied branch limits only if the rule didn't have a branchcode, this was wrong
    
    To test:
     1 - Find a title in the catalog, add 8 items, all of a single itemtype, 4 for branch A, four for branch B
     2 - Remove any specific circ rules
     3 - Set a default circ rule for the itemtype used above, limiting the max issue quantity to 3
     4 - Find a patron and checkout the items from branch A
     5 - You should be allowed to checkout 3, but the fourth should trigger 'too many'
     6 - Now checkout the items from branch B, again you can checkout 3 and not four
     7 - Apply this patch
     8 - Assuming you have 6 items out now, try one from either branch, you should trigger 'too many' and have 6
     9 - Return two from branch B and one from branch A
    10 - Now you have three items issued total
    11 - An item from either branch should be refused now
    12 - Test with different values of 'CircControl' and confirm your expectations are met
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 6d9839d800ac8334a902cba5917b878507f8ba18
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Tue Apr 23 16:17:20 2019 +0000

    Bug 22759: Unit tests
    
    To test:
    1 - Apply only this patch
    2 - prove -v t/db_dependent/Circulation/TooMany.t
    3 - It fails
    4 - Apply second path
    5 - repeat
    6 - All green!
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 22deca9445cb02320a04abb69febc9ef83d4d58f
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Apr 18 16:35:03 2019 +0000

    Bug 22501: (follow-up) Use raw filter for course note on details page
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm                                  |    6 +-
 Koha/Biblio.pm                                     |   12 +-
 Koha/CirculationRules.pm                           |   15 +
 Koha/IssuingRule.pm                                |   23 +-
 Koha/Item.pm                                       |    4 +
 Koha/Patron/Category.pm                            |   19 +
 Koha/Schema/Result/Biblio.pm                       |    7 +
 admin/smart-rules.pl                               |    8 +-
 cataloguing/addbiblio.pl                           |    2 +-
 .../intranet-tmpl/prog/en/includes/accounts.inc    |    8 +-
 .../intranet-tmpl/prog/en/includes/js_includes.inc |   26 +-
 .../prog/en/modules/circ/circulation.tt            | 1759 ++++++++++----------
 .../prog/en/modules/members/moremember.tt          |   37 +-
 .../prog/en/xslt/MARC21slim2intranetDetail.xsl     |   13 +
 .../bootstrap/en/includes/account-table.inc        |    8 +-
 .../bootstrap/en/modules/opac-course-details.tt    |    2 +-
 .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl    |   12 +
 misc/cronjobs/patron_emailer.pl                    |    3 +-
 opac/opac-ISBDdetail.pl                            |   84 +-
 opac/opac-MARCdetail.pl                            |    5 +-
 t/db_dependent/Circulation/TooMany.t               |  196 ++-
 t/db_dependent/Koha/Biblio.t                       |   23 +-
 t/db_dependent/Koha/CirculationRules.t             |    9 +-
 t/db_dependent/Koha/IssuingRules.t                 |   41 +-
 t/db_dependent/Koha/Item.t                         |   15 +-
 t/db_dependent/Koha/Patron/Category.t              |   24 +-
 26 files changed, 1382 insertions(+), 979 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Thu Apr 25 14:08:54 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Thu, 25 Apr 2019 12:08:54 +0000
Subject: [koha-commits] main Koha release repository branch master updated.
	v18.11.00-1346-gbdc5cb0
Message-ID: <E1hJdBO-0006BX-FL@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  bdc5cb00accf0464d352a8197d2d8ff86a774a64 (commit)
       via  c5f4f560d29e86b5dbaa02470c21f3128b70a382 (commit)
       via  41f3c1a98ef281325c51c7d9852db199281a05cd (commit)
       via  b2e5cf36ea41b854fbe2688f545be875fbc1f197 (commit)
       via  a2b805a0df53be89884a64d890dfea4a5f13ac9c (commit)
       via  23a12cf4d81c6ebcdba02f15f0f6424d75e6ce55 (commit)
       via  62b6d94daaea5e113260e8888c522a2697b745f2 (commit)
       via  e7c05431f215064aa4d42df17023673cee27e414 (commit)
       via  f2581eac358b198c4b219ebcbd11eb3838f0e06d (commit)
       via  152e89b7113b82e590c30a127e5ced9422496cdf (commit)
       via  78a7d5aada4adb19943833f65beeac3ac3ff4eb9 (commit)
       via  90b8fb62eef4504b149b12593cf3518ad5575eed (commit)
       via  63d942d84fbefb65226e65b7b07c2116bd126a3e (commit)
       via  7dce351605e571c6bf6ae71b892f3b40fff2b3aa (commit)
       via  c5bef78457a8d4cd57c91dc0a54ddcf2963785d0 (commit)
       via  f0fd89fd9c2ce397e01ccc6d63d2da9efd2aeda9 (commit)
       via  de20398db303a1ee45b62f9aa51f124597ed0cd8 (commit)
       via  a6a2e29db85dd51f99a1b112947e449b26ad0a54 (commit)
       via  9fff49444368dffa9032feda071a1f70d429afc0 (commit)
       via  43e6b00f093e7641470afce92547fa41c5a08fe8 (commit)
       via  1e95b94ea0c2e0115227c6cbf90cfae5dd0c5feb (commit)
       via  69bd858712ece4811fbb7d8839c5c76cc749de3a (commit)
       via  58195734ee7bfe91c448db49b0eea0327654cf8e (commit)
       via  e0690dc84748f582553c7e45166d4fa8b174a266 (commit)
       via  1a25f1094d2d34163108b07b7486905cfbaac76f (commit)
       via  0db7b7a1c8e3c7d01971c93b311d2dc42d13c9cd (commit)
       via  4b97a67ae4b940cbac57f69cb47a7ae058980e6d (commit)
       via  951b857a970e02cc10bf1b5a31005e8eccc96eaf (commit)
       via  3255525b59fa0ecd728a3b5942db89a21ab52f43 (commit)
       via  eb8f5c86fe5f3e1e20bea73fa8b646cdc092513a (commit)
       via  aba8b130f8b96e5000e8a1eccecfb53d7b371c30 (commit)
       via  ed6228de83dc57e624c3b3dc30632775df972277 (commit)
       via  0047ede37e46a3334c9c47d7ebaed848907b6890 (commit)
       via  bdf0d85c1de9cbb37cc8a40b0b4a2e86633d3aaf (commit)
       via  2be0195895628ec491ee1f25368e60181c4f1eb2 (commit)
       via  ab2e7730387156841adc18b1659241f427bde7ef (commit)
       via  bf1100fbf1f3e7e6895d3f05da82c86313ad8e98 (commit)
       via  28e536892a609cd92c624ee4eca4d84cabba8893 (commit)
       via  ef5adaff5ac045000b90c4b2b121d8c2ce2d5c59 (commit)
       via  e2fa6d97ef45efb902086aa3a3d232137c054afa (commit)
       via  7be176cf1da5adb5f264bb9668667dfeb1d9a2ae (commit)
       via  18fd7538581a2993757ca6eb3601c0e7342e1432 (commit)
       via  41ef01098434aaa59b44368ac6b147b7d91939e1 (commit)
       via  482664cb804758b164161fe02df0813814fbd01b (commit)
       via  7021af687936054c2e7fb5ea8073ef54cf4784ba (commit)
       via  5854e5de7f0082b94c85006c267a72cade2c5687 (commit)
       via  49cab949b4d8bd1dac3a3c0f25a9f83b5f167beb (commit)
       via  c1949cda9b2847bc6ecf7e1dbc07990c4055b69a (commit)
       via  680dd7f340ef445820864045127da9c65b3be0e2 (commit)
       via  4e2c74fced685db861a78fc1aa151dd35ad0d5f2 (commit)
       via  40cf22ab5f9dbdcaa37f46977fe5386a6303a42e (commit)
       via  eb956eb4cf3d44f45ad54be58fe95d7355a2b8bf (commit)
       via  2f60cd8dd23662ad2878cb6d189679fde125290f (commit)
      from  be0d338366589ef80b69f287d7dbfc059476e4b2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit bdc5cb00accf0464d352a8197d2d8ff86a774a64
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Mar 21 06:43:13 2019 -0400

    Bug 22556: Add ability to quickly filter funds/budgets by library on the Acquisitions home page
    
    Some librarians would like to have a quick pulldown selector to filter budgets and funds by library on the acquisitions home page.
    
    Test Plan:
    1) Apply this patch
    2) Navigate to the Acquisitions home page
    3) Notice the new pulldown on the budgets table labeled "Filter by library"
    4) Select a library that has one or more budgets/funds
    5) Note only budgets/funds from that library now display!
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Bin Wen <bin.wen at inlibro.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit c5f4f560d29e86b5dbaa02470c21f3128b70a382
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Apr 25 11:39:11 2019 +0000

    Bug 14576: DBRev 18.12.00.064
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 41f3c1a98ef281325c51c7d9852db199281a05cd
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Tue Apr 23 12:02:32 2019 +0000

    Bug 14576: (follow-up) Add code highlighting to system preference UpdateItemLocationOnCheckin
    
    Test plan:
    1) Go to system preferences and find preference UpdateItemLocationOnCheckin
    2) Ensure the yaml code higlighting is used on textarea when editing
    this setting
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit b2e5cf36ea41b854fbe2688f545be875fbc1f197
Author: Liz Rea <wizzyrea at gmail.com>
Date:   Wed Mar 27 23:56:51 2019 +0000

    Bug 14576: (QA follow-up) Tidy up feature documentation
    
    To test:
    Apply this patch with all of the others
    run the updatedatabase, it should work
    install a new Koha, this pref should be installed and look fine in the
    interface.
    Check the syspref, make sure the text looks ok and makes sense.
    
    Bonus points:
    for checking to make sure PROC: _PERM_ appears in the new
    pereference if InProcessingToShelvingCart was set
    for checking to make sure _ALL_: CART appears in the new preferenec if ReturnToShelvingCart was previously set.
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit a2b805a0df53be89884a64d890dfea4a5f13ac9c
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Mar 27 11:36:47 2019 +0000

    Bug 14576: (follow-up) Using item objects, not hashrefs
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 23a12cf4d81c6ebcdba02f15f0f6424d75e6ce55
Author: Hayley Mapley <hayleymapley at catalyst.net.nz>
Date:   Wed Mar 27 12:16:20 2019 +1300

    Bug 14576: Replaced calls using deprecated method GetItem with Koha::Items->find
    
    Test plan:
    1) Apply all patches except this one
    2) Checkout out an item to a patron
    3) Check the item in - note that this will fail
    4) Apply this patch, and repeat steps 1-3, noting instead that the the
    check is instead successful
    5) Verify also that reserves act as expected
    5) Sign off
    
    Sponsored-by: Catalyst IT
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 62b6d94daaea5e113260e8888c522a2697b745f2
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Mar 20 15:46:26 2019 +0000

    Bug 14576: Rebase fixes Fix test Rebase code
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit e7c05431f215064aa4d42df17023673cee27e414
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Feb 20 18:45:44 2019 +0000

    Bug 14576: (follow-up) fix some typos and style
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit f2581eac358b198c4b219ebcbd11eb3838f0e06d
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Dec 12 13:30:11 2018 +0000

    Bug 14576: Update to use get_yaml_pref_hash
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 152e89b7113b82e590c30a127e5ced9422496cdf
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Oct 4 15:21:57 2017 +0000

    Bug 14576: Unit tests
    
    To test:
    1 - prove -v t/db_dependent/Circulation/Returns.t
    2 - prove -v t/db_dependent/Circulation/issue.t
    3 - prove -v t/db_dependent/UsageStats.t
    4 - All should pass
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 78a7d5aada4adb19943833f65beeac3ac3ff4eb9
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Oct 4 15:19:26 2017 +0000

    Bug 14576: Allow arbitrary automatic update of location on checkin
    
    This patch adds a new syspref "UpdateItemLocationOnCheckin" which
    accepts pairs of shelving locations.  On check-in the items location is
    compared ot the location on the left and, if it matches, is updated to
    the location on the left.
    
    This preference replaces ReturnToShelvingCart and
    InProcessingToShelvingCart preferences.  The update statement should
    insert values that replciate these functions.  Note existing
    functionality of all items in PROC location being returned to
    permanent_location is preserved by default.  Also, any items issued from
    CART location will be returned to their permanent location on issue (if
    it differs)
    
    Special values for this pref are:
    _ALL_ - used on left side only to affect all items
    _BLANK_ - used on either side to match on/set to blank (actual blanks
            will work, but this is an easier to read option)
    _PERM_ - used on right side only to return items to permanent location
    
    Test Plan:
    1) Apply this patch
    2) Run updatedatabase.pl
    3) Set the new system preference UpdateitemLocationOnCheckin
       to the following (assuming sample data):
       NEW: FIC
       FIC: GEN
    4) Create an item, set its location to NEW
    5) Check in the item, note its location is now FIC
    6) Check in the item again, note its location is now GEN
    7) Check in the item again, note its location remains GEN
    8) Test using _ALL_, _BLANK_ and _PERM_ for updates
    9) Try entering various incorrect syntax in the pref and note you are warned
    
    Sponsored by:
        Arcadia Public Library (http://library.ci.arcadia.ca.us/)
        Middletown Township Public Library (http://www.mtpl.org/)
        Round Rock Public Library (https://www.roundrocktexas.gov/departments/library/)
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 90b8fb62eef4504b149b12593cf3518ad5575eed
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Wed Apr 24 23:42:45 2019 +0000

    Bug 22764: Change marcfield to MARC field in alert message
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 63d942d84fbefb65226e65b7b07c2116bd126a3e
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Wed Apr 24 13:19:38 2019 +0000

    Bug 22764: More YUI grid cleanup
    
    This patch cleans up a few places where templates still contain YUI grid
    markup. Some other minor markup problems are also fixed.
    
     - additional-fields.tt:
       - Converts YUI grid to Bootstrap
       - Replaces obsolete <tt> tag with styled <span>
       - Adds _() function to string in embedded JavaScript
    
     - detail.tt:
       - Fixes some stray YUI grid classes
       - Fixes corresponding JavaScript to enable page adjustments
    
     - moredetail.tt:
       - Removes unnecessary YUI grid markup
    
    To test, apply the patch and view the affected pages, confirming that
    everything looks correct and that the page adjusts well to various
    browser widthds.
    
    When testing the bibliographic detail page, enable AmazonCoverImages and
    view a record with and without an Amazon cover image. The layout should
    work in both cases.
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 7dce351605e571c6bf6ae71b892f3b40fff2b3aa
Author: Liz Rea <wizzyrea at gmail.com>
Date:   Wed Apr 17 05:20:23 2019 +0000

    Bug 22664: More making acquisitions links more easily clickable
    
    To test:
    
    * create a basket with an order from a staged record, and an order from
    a suggestion
    * add that basket to a basket group when you close it.
    * note that the links to the basket in the first column, the link to the
    basket group in the second column, and the link to
    the suggester in the summary column are very small (only the ID# is
    linked)
    * apply this patch, restart the things
    * refresh the page, note that the previously ogled links are now bigger
    and easier to find and click, and that the links work and such
    * rejoice.
    
    Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>
    Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit c5bef78457a8d4cd57c91dc0a54ddcf2963785d0
Author: Liz Rea <wizzyrea at gmail.com>
Date:   Mon Apr 8 19:00:01 2019 +0000

    Bug 22664: Link names in order search results instead of numbers
    
    To test:
    Make up some orders, put some in basket groups.
    Search for your vendor's orders, note that the only thing linking to the
    order is a tiny number in parentheses.
    Apply this patch, restart the things.
    Refresh the results, note that te basket names *and* numbers are linked
    now.
    Rejoice.
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit f0fd89fd9c2ce397e01ccc6d63d2da9efd2aeda9
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Thu Apr 18 14:22:35 2019 +0000

    Bug 22734: Fund not marked as mandatory when ordering from a staged file
    
    This patch does some refactoring of JavaScript to make handling of
    required fields more robust. It also moves some template JavaScript to
    the footer and some to a separate file.
    
    A fallback "pattern" attribute is added to the quantity field, requiring
    0-9+ values.
    
    The "required" property of the funds dropdown is now dependent on the
    value set under the "Default accounting details" tab. If a default is
    selected, the individual item funds are preselected and not marked
    required.
    
    To test, apply the patch and begin the process of ordering from a staged
    file.
    
     - Select all items to import.
       - Under each item, the fund should be marked mandatory.
       - The quantity field should accept only numbers.
       - Select the "Default accounting details" tab and select a default
         fund.
         - Return to the "Select to import" tab. Your selected default fund
           should now be preselected under each item. The fund should no
           longer be marked required.
    
           Un-selecting a default fund should result in each item fund
           select becoming required.
    
    Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>
    Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit de20398db303a1ee45b62f9aa51f124597ed0cd8
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Mon May 28 16:45:29 2018 +0000

    Bug 20692: Extreme toggle checking for plack
    
    TEST PLAN
    ---------
    sudo koha-plack --disable
    sudo koha-plack --disable
    sudo koha-plack --enable
    
    sudo koha-plack --disable
    echo $?
    sudo koha-plack --disable
    echo $?
    sudo koha-list --noplack
    echo $?
    sudo koha-plack --enable
    echo $?
    sudo koha-plack --enable
    echo $?
    sudo koha-list --plack
    echo $?
    
    git bz apply 20692
    sudo perl ~/misc4dev/cp_debian_files.pl
    then repeat the test.
    
    It should also be noted, because the enable
    and disable are now split, if for some reason
    they become out of sync, an enable or disable
    should correct them.
    
    Because these are bash scripts, the test tool
    (/home/vagrant/qa-test-tools/koha-qa.pl)
    does not apply.
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit a6a2e29db85dd51f99a1b112947e449b26ad0a54
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Apr 25 11:10:29 2019 +0000

    Bug 22511: Fix type role->roll
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 9fff49444368dffa9032feda071a1f70d429afc0
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Apr 25 11:09:38 2019 +0000

    Bug 22511: DBRev 18.12.00.063
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 43e6b00f093e7641470afce92547fa41c5a08fe8
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Thu Apr 25 08:28:13 2019 +0000

    Bug 22511: (QA follow-up) Refactor status description in templates
    
    Test plan:
    
    Before this patch, some accounttypes does not show status (for example
            voided payment)
    
    After this patch, the status is always generated - defaults to empty
    string
    
    This behaviour should be same in intranet and opac
    
    In OPAC templates there was even bug (used variable account instead of
            ACCOUNt_LINE), so the status was not shown at all
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 1e95b94ea0c2e0115227c6cbf90cfae5dd0c5feb
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Thu Apr 25 08:25:42 2019 +0000

    Bug 22511: (QA follow-up) Fix update database
    
    Test plan:
    Run db update (and have some voided accountlines)
    --> without patch it fails with error message similar to:
        Can't use string ("Payment") as a HASH ref while "strict refs" in use at
        (eval 1393) line 19.
    --> with patch it runs as expected
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 69bd858712ece4811fbb7d8839c5c76cc749de3a
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Wed Apr 10 10:05:07 2019 +0100

    Bug 22511: (follow-up) Add DB Update
    
    This update takes old VOID accountlines and attempts to restore the
    original accounttypes using the offsets and set the status to 'VOID'
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 58195734ee7bfe91c448db49b0eea0327654cf8e
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Wed Mar 27 11:52:07 2019 +0000

    Bug 22511: (follow-up) Fix test plans
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit e0690dc84748f582553c7e45166d4fa8b174a266
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Fri Mar 22 12:00:00 2019 +0000

    Bug 22511: Update UI to use accountlines.status
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 1a25f1094d2d34163108b07b7486905cfbaac76f
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Fri Mar 15 14:07:24 2019 +0000

    Bug 22511: Update void method to use status
    
    We added a 'status' field to 'accountlines' in bug 22512 to allow for
    more fined grained control over 'types' and 'states'.
    
    This patch updates the void method to utilise this new field so we may
    keep the original credit type for later auditing should it be required.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 0db7b7a1c8e3c7d01971c93b311d2dc42d13c9cd
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Fri Mar 15 14:18:12 2019 +0000

    Bug 22511: Update tests
    
    Updated tests to check for 'status' change and fixed 'accounttype' and
    moved from t/db_dependent/Accounts.t to the more appropriate
    t/db_dependent/Koha/Account/Lines.t
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 4b97a67ae4b940cbac57f69cb47a7ae058980e6d
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date:   Wed Apr 24 14:58:41 2019 +0100

    Bug 21460: (follow-up) Fix bugs found in QA
    
    Fix silly bugs mentioned in comment #29
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 951b857a970e02cc10bf1b5a31005e8eccc96eaf
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date:   Tue Apr 23 10:18:31 2019 +0100

    Bug 21460: (follow-up) Filter params in .pl
    
    This patch filters the passed parameters in the .pl, rather than doing
    it in the template. As per comment 16
    (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460#c16)
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 3255525b59fa0ecd728a3b5942db89a21ab52f43
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date:   Tue Apr 23 10:09:33 2019 +0100

    Bug 21460: Simplify the code to have only 1 assignment
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit eb8f5c86fe5f3e1e20bea73fa8b646cdc092513a
Author: phette23 <phette23 at gmail.com>
Date:   Mon Apr 8 16:00:47 2019 -0700

    Bug 22551: Stray "//" appears at bottom of opac-detail.tt
    
    Removes a couple stray "//<![CDATA[" like comments which are artifacts of other
    code that since been removed. One of the comments causes two forward slashes to
    appear at the bottom of each OPAC detail page.
    
    Testing plan:
    
    - enable SocialNetworks
    - visit any OPAC detail page, observe "//" at bottom of page
    - apply patch
    - revisit page, slashes should be gone
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit aba8b130f8b96e5000e8a1eccecfb53d7b371c30
Author: Ere Maijala <ere.maijala at helsinki.fi>
Date:   Tue Mar 5 11:04:55 2019 +0200

    Bug 22413: Improve query string and desc creation for Elasticsearch
    
    Test plan:
    
    After each of the following steps, verify that the results and query description looks ok.
    
    1. Do a simple keyword query
    2. Change sort order
    3. Click a facet
    4. Do an advanced search with title and author
    5. Change sort order
    6. Click a facet
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Marjorie <marjorie.barry-vila at collecto.ca>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit ed6228de83dc57e624c3b3dc30632775df972277
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Apr 25 10:36:36 2019 +0000

    Bug 22339: DBRev 18.12.00.062
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 0047ede37e46a3334c9c47d7ebaed848907b6890
Author: Ere Maijala <ere.maijala at helsinki.fi>
Date:   Thu Mar 14 13:31:34 2019 +0200

    Bug 22339: Fix search field mappings of MARC fixed fields
    
    Fixes handling of /0 selector in addition to several fixed field positions. Note that ff7-01-02 is in fact 00-01 in Zebra and that has been replicated here.
    
    Test plan:
    1. Before applying a patch, check from Elasticsearch (e.g. localhost:9200/koha_biblios/_search?q=_id:123) what is indexed in Elasticsearch for a record for date-entered-on-file, ff7-00, ff7-01, ff7-02 and lleader.
    2. Apply the patch, update database and save the record again.
    3. Verify that the contents of the forementioned fields is now correct in Elasticsearch.
    4. Verify that tests pass:  prove -v t/Koha/SearchEngine/Elasticsearch.t
    
    Signed-off-by: Bj?rn Nyl?n <bjorn.nylen at ub.lu.se>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit bdf0d85c1de9cbb37cc8a40b0b4a2e86633d3aaf
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Jun 8 12:19:41 2018 -0300

    Bug 20891: Escape html then JSON
    
    To my understanding we need to escape first html chars then to JSON.
    
    If this patch works we will need to rethink the 'To' TT plugin.
    It was originally designed to have several escape methods, but with
    these changes it will not make sense to name it 'To' if used only to
    escape JSON
    
    IIRC we should keep the 2 different ways to use it:
     * [% To.json( string ) %]
     * [% string | $To %]
    otherwise it will be hard to use it when called in argument of
    patron-title.inc (`git grep To.json`)
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 2be0195895628ec491ee1f25368e60181c4f1eb2
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Jun 7 12:17:26 2018 -0300

    Bug 20891: Escape list's names in JSON
    
    When someone uses \ in the description of a list, the datatable in staff
    won't load and keeps processing.
    
    Test plan:
    - Create a list named "<script>alert('hola');</script>"
    - Create another list named "k\o\h\a"
    - Hit /cgi-bin/koha/virtualshelves/shelves.pl
    
    => Without this patch the lists will not be displayed, JSON is
    malformated
    => With this patch everything is ok
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit ab2e7730387156841adc18b1659241f427bde7ef
Author: Liz Rea <wizzyrea at gmail.com>
Date:   Tue Apr 9 19:37:13 2019 +0000

    Bug 20837: (QA follow-up) adding missing filter to make QA tool happy
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit bf1100fbf1f3e7e6895d3f05da82c86313ad8e98
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed May 30 16:05:04 2018 +0000

    Bug 20837: Use ReservesControlBranch to determine holdability of items
    
    To test:
     1 - Set a default holds plicy for an item type as 'from home library'
     2 - Set CircControl to 'logged in library'
     3 - Log in as staff from a library without the rule set
     4 - Note you can set holds for patrons of any library on items of type
    above
     5 - Toggle ReservesControlBranch and note that nothing changes
     6 - Toggle CircControl and note some combinations don't allow holds
     7 - Apply patch
     8 - Toggle ReservesControlBranch and note that holdability is affected
     9 - Toggle CircControl and note holdability does not change
    10 - Read the note on admin/smartrules.pl and confirm it makes sense
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 28e536892a609cd92c624ee4eca4d84cabba8893
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed May 30 17:29:57 2018 +0000

    Bug 20837: Unit tests
    
    To test:
    prove -v t/db_dependent/Holds.t
    prove -v t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit ef5adaff5ac045000b90c4b2b121d8c2ce2d5c59
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Apr 24 15:12:17 2019 +0000

    Bug 22650: Prevent multiple holds on individual items
    
    This patch corrects a missing id on the holds_to_place field and adds code to disable the box when an item is checked
    
    Additionally script login now places a single hold if an itemnumebr is passed and checks for holdability of the specific item
    
    To test:
     1 - Allow multiple holds per record in circ rules
     2 - In staff client, go to place a hold on a record
     3 - Select a patron
     4 - Increase the number of holds
     5 - Then select a specific item to hold
     6 - Patron now has multiple holds on a single item
     7 - Apply patch
     8 - Repeat, notice that count is disabled when item checked
     9 - Confirm count is enabled when 'Hold next available item' is checked
    10 - Set number to more than 1
    11 - Check an item and submit
    12 - Confirm only one item is reserved
    13 - Hit the script directly (with valid info):
         http://localhost:8081/cgi-bin/koha/reserve/placerequest.pl?biblionumber=1&checkitem=1&holds_to_place_count=2&borrowernumber=5
    14 - Confirm only one hold is placed
    15 - Confirm multiple hits of the url do not generate further holds
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit e2fa6d97ef45efb902086aa3a3d232137c054afa
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Tue Apr 16 17:21:01 2019 +0000

    Bug 19241: Waiting items show as available in the cart
    
    The cart uses the same item-status.inc that the details page uses, however, we don't
    set the waiting or reserved flags. This patch adds those flags to the script
    
    To test:
    1 - Find an item on the opac
    2 - Place a hold on the item
    3 - Check in the item to confirm the hold
    4 - Note the details page on OPAC shows 'On hold'
    5 - Add the item to a basket
    6 - Note the basket shows 'Available'
    7 - Apply patch
    8 - Check the cart, should show as 'On hold'
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 7be176cf1da5adb5f264bb9668667dfeb1d9a2ae
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Apr 19 11:25:43 2019 +0000

    Bug 22743: Add password modal to overdrive results page
    
    This patch also removes a line abotu ratings which was throwing an error.
    Confirm stars rating for OD results are still shown as expected
    
    To test:
     1 - Enable overdrive circulation with password required
     2 - Sign in to OPAC but not overdrive
     3 - Perform a search that returns overdrive results
     4 - Click in to results page
         http://localhost:8080/cgi-bin/koha/opac-overdrive-search.pl?q=cats
     5 - Note 'Login to OverDrive account' link
     6 - Click it
     7 - Nothing happens!
     8 - Apply patch
     9 - Repeat
    10 - Success!
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 18fd7538581a2993757ca6eb3601c0e7342e1432
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Apr 25 10:11:31 2019 +0000

    Bug 22729: (RM follow-up) Correct column in schema addition
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 41ef01098434aaa59b44368ac6b147b7d91939e1
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Apr 25 10:09:09 2019 +0000

    Bug 22729: DBRev 18.12.00.061
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 482664cb804758b164161fe02df0813814fbd01b
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Thu Apr 25 08:15:58 2019 +0100

    Bug 22729: (QA follow-up) Ensure no NULL values before setting NOT NULL
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 7021af687936054c2e7fb5ea8073ef54cf4784ba
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Wed Apr 17 15:06:44 2019 -0300

    Bug 22729: Adapt /patrons controller code to the change
    
    This patch makes the controller code aware of the flgAnonymized =>
    anonymized change.
    
    To test:
    - Run
      $ kshell
     k$ prove t/db_dependent/api/v1/patrons.t
    => SUCCESS: Tests pass!
    - Sign off :-D
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 5854e5de7f0082b94c85006c267a72cade2c5687
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Wed Apr 17 15:03:25 2019 -0300

    Bug 22729: Adapt Koha::Patron(s) and tests
    
    This patch adapts the Koha::Patron(s) code to the column change.
    To test:
    - Apply this patches
    - Run:
      $ kshell
     k$ prove t/db_dependent/Koha/Patrons.t
    => SUCCESS: Tests pass!
    - Sign off :-D
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 49cab949b4d8bd1dac3a3c0f25a9f83b5f167beb
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Wed Apr 17 15:01:47 2019 -0300

    Bug 22729: DB update
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit c1949cda9b2847bc6ecf7e1dbc07990c4055b69a
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Apr 19 09:28:35 2019 -0300

    Bug 22739: Test SelfCheckInTimeout <> 0, not just defined
    
    On sci-main.pl the preference value is tested for 'defined'. This patch
    tests it is different than empty string too. This was causing a
    JavaScript syntax error, that made it display a wrong message.
    
    To test:
    1 - Blank the syspref SelfCheckInTimeout
    2 - Attempt to checkin something via sci
    => FAIL: The 'Your request included no check-ins.' message is printed.
    3 - Apply this patch, reload the sci-main.pl page
    4 - Attempt to checkin something via sci
    => SUCCESS: The UI correctly stacks the scanned barcodes
    5 - Sign off :-D
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 680dd7f340ef445820864045127da9c65b3be0e2
Author: Agustin Moyano <agustinmoyano at theke.io>
Date:   Tue Apr 23 00:50:49 2019 +0000

    Bug 16232: Fix edit as new in Rancor
    
    When you edit a biblio as new, and you have enabled advanced editor,
    current record was opened, and was overwritten when saved. This patch
    effectively opens a new record based on the one selected.
    
    To test:
    1) Enable "EnableAdvancedCatalogingEditor" preference
    2) Go to cataloguing and click on advanced editor to save preference to the cookie
    3) Search for an item in catalog
    4) Click in "Edit as new (duplicate)"
    5) Advanced editor should appear.
    CHECK => browser url ends with #catalog/{original biblionumber}
          => Title above toolbar is "Editing catalog record #{original biblionumber}"
    6) Apply this patch
    7) Repeat steps 3 to 5
    SUCCESS => browser url ends with #duplicate/{original biblionumber}
            => Title above toolbar is "Editing duplicate record of #{original biblionumber}"
    8) Save
    SUCCESS => browser url ends with #catalog/{new biblionumber}
            => Title above toolbar is "Editing catalog record #{new biblionumber}"
    9) Sign off
    
    Sponsored-by: Carnegie
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 4e2c74fced685db861a78fc1aa151dd35ad0d5f2
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Wed Apr 17 13:58:57 2019 +0200

    Bug 22723: Correct syntax error on confess call in Koha/MetadataRecord/Authority.pm
    
    In Koha/MetadataRecord/Authority.pm the call to confess is missing string quotes.
    
    It may generates this error :
    
    Can't locate object method "confess" via package "Empty String at /usr/share/perl5/MARC/File/XML.pm line 448.
    " (perhaps you forgot to load "Empty String at /usr/share/perl5/MARC/File/XML.pm line 448.
    "?) at /home/koha/src/Koha/MetadataRecord/Authority.pm line 186.
    
    Simply missing double quotes.
    Also missing use Carp to call confess.
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 40cf22ab5f9dbdcaa37f46977fe5386a6303a42e
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Wed Apr 24 06:55:12 2019 +0000

    Bug 22753: Fix tabs pointed out by QA script
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit eb956eb4cf3d44f45ad54be58fe95d7355a2b8bf
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Tue Apr 23 18:03:33 2019 +0000

    Bug 22753: Fix hold priority adjustment, move to top
    
    Since the holds table can be split we need to calculate the
    first priority for each table. However, currently we use the
    first in the loop, not taking into account the waiting status.
    This patchset sets the first_priority to the first non-found hold
    
    Additionally, some clean-up is done to not display the alter
    priority arrows for waiting holds.
    
    To test:
    1 - Place several holds on a title
    2 - Confirm one of the holds to be waiting
    3 - Attempt to move the last hold to the top
    4 - Nothing happens
    5 - Apply patch
    6 - Note that the waiting hold has no options to move in the list
    7 - Attempt to move the last hold to the top
    8 - It moves as expected!
    9 - Split the holds queue by pickup library
    10 - PLace some holds for pickup at another branch
    11 - Confirm moving these holds works within their own table
    12 - Unsplit the queue
    13 - Ensure the holds end where you expect (moving in a split
         table didn't move above holds form another table)
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 2f60cd8dd23662ad2878cb6d189679fde125290f
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Apr 24 00:03:34 2019 -0400

    Bug 22762: Fix items.collection display on receiving
    
    Caused by
      commit 31c29fd31f557306233e6a2936148a5bb10b89a1
      Bug 21206: Replace C4::Items::GetItem
    
    The log says: The method Koha::Item->collection is not covered by tests!
    
    It has highlighted an older problem:
    Since
      commit bb1e9c500c810402c64436c53bcc00ffb9a0b857
      Bug 17248 - Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib
    the "Collection code" is not filled correctly (items.collection vs items.ccode).
    
    Test plan:
    - Set acqcreateitem to "when placing an order"
    - Receive an order with items
    => The "Collection code" column must be filled with the items.ccode value
    - Edit an item (You may need the patches on bug 22669)
    - Change the collection code value
    => The "Collection code" column must be filled with the new value
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm                                  |   44 ++++---
 C4/Items.pm                                        |   23 +---
 C4/Reserves.pm                                     |   24 ++--
 C4/UsageStats.pm                                   |    2 -
 Koha.pm                                            |    2 +-
 Koha/Account/Line.pm                               |    8 +-
 Koha/MetadataRecord/Authority.pm                   |    3 +-
 Koha/Patron.pm                                     |    4 +-
 Koha/Patrons.pm                                    |    4 +-
 Koha/REST/V1/Illrequests.pm                        |   13 +-
 Koha/REST/V1/Patrons.pm                            |    2 -
 Koha/Schema/Result/Borrower.pm                     |   20 +--
 Koha/Schema/Result/Deletedborrower.pm              |   18 +--
 Koha/SearchEngine/Elasticsearch.pm                 |    6 +-
 Koha/SearchEngine/Elasticsearch/QueryBuilder.pm    |   26 +++-
 Koha/Template/Plugin/To.pm                         |    9 +-
 acqui/orderreceive.pl                              |    2 +-
 admin/searchengine/elasticsearch/mappings.yaml     |   24 ++--
 api/v1/swagger/definitions/patron.json             |    6 +-
 catalogue/getitem-ajax.pl                          |    2 +-
 cataloguing/addbiblio.pl                           |    8 +-
 circ/returns.pl                                    |    3 +
 debian/scripts/koha-functions.sh                   |   54 +++++++-
 debian/scripts/koha-plack                          |   84 ++++++++++--
 ill/ill-requests.pl                                |   21 ++-
 installer/data/mysql/kohastructure.sql             |    4 +-
 installer/data/mysql/sysprefs.sql                  |    3 +-
 installer/data/mysql/updatedatabase.pl             |  130 +++++++++++++++++++
 .../intranet-tmpl/prog/en/includes/accounts.inc    |   45 +++----
 .../prog/en/includes/cateditor-ui.inc              |   15 +++
 .../intranet-tmpl/prog/en/includes/holds_table.inc |   74 ++++++-----
 .../prog/en/modules/acqui/acqui-home.tt            |   17 ++-
 .../prog/en/modules/acqui/addorderiso2709.tt       |  134 ++++----------------
 .../prog/en/modules/acqui/histsearch.tt            |    4 +-
 .../intranet-tmpl/prog/en/modules/acqui/parcel.tt  |   11 +-
 .../prog/en/modules/admin/additional-fields.tt     |   28 ++--
 .../prog/en/modules/admin/preferences.tt           |    2 +
 .../en/modules/admin/preferences/circulation.pref  |   31 +++--
 .../prog/en/modules/admin/smart-rules.tt           |    3 +-
 .../prog/en/modules/catalogue/detail.tt            |   21 ++-
 .../prog/en/modules/catalogue/moredetail.tt        |    3 +-
 .../intranet-tmpl/prog/en/modules/circ/returns.tt  |   30 ++++-
 .../prog/en/modules/ill/ill-requests.tt            |    2 +-
 .../prog/en/modules/reserve/request.tt             |    4 +-
 .../virtualshelves/tables/shelves_results.tt       |    4 +-
 koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js |  120 ++++++++++++++++++
 .../intranet-tmpl/prog/js/pages/preferences.js     |   19 +++
 .../bootstrap/en/includes/account-table.inc        |    4 +-
 .../opac-tmpl/bootstrap/en/modules/opac-detail.tt  |    6 -
 .../bootstrap/en/modules/opac-overdrive-search.tt  |    8 +-
 opac/opac-basket.pl                                |    3 +
 opac/sci/sci-main.pl                               |    2 +-
 reserve/placerequest.pl                            |    9 +-
 svc/checkin                                        |   12 --
 t/Koha/SearchEngine/Elasticsearch.t                |   14 +-
 t/db_dependent/Accounts.t                          |   68 +---------
 t/db_dependent/Circulation/Returns.t               |   48 +------
 t/db_dependent/Circulation/issue.t                 |   54 +++++++-
 t/db_dependent/Holds.t                             |    7 +-
 .../Holds/DisallowHoldIfItemsAvailable.t           |  106 +++++++---------
 t/db_dependent/Koha/Account/Lines.t                |   74 ++++++++++-
 t/db_dependent/Koha/Patrons.t                      |   10 +-
 .../Koha/SearchEngine/Elasticsearch/QueryBuilder.t |   13 +-
 t/db_dependent/UsageStats.t                        |    2 -
 64 files changed, 980 insertions(+), 576 deletions(-)
 create mode 100644 koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Thu Apr 25 15:41:22 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Thu, 25 Apr 2019 13:41:22 +0000
Subject: [koha-commits] main Koha release repository branch 18.11.x updated.
	v18.11.04-95-ga1f80ad
Message-ID: <E1hJecs-0002eP-0O@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  a1f80ad2950ea100e34260be7ae7d6e7f6f3bea7 (commit)
       via  f3b362120f0b8a75a89ad6846e7bdad93b2e37ca (commit)
       via  6055a519c4474ab3b9004ed99b9b2e76c9735076 (commit)
       via  a1ff52bef45884b9a292cc5f84fdc49fce1c2c36 (commit)
       via  b56789dbc58c217c0129d2728cc5c202c627c27e (commit)
       via  83affe394dfb9c983f79045d43ace06f3daab65d (commit)
       via  0d29ae30119e7f5be27c00afc4791ab4b2cbb627 (commit)
      from  383349f83fb9362a6f875cc11a9efbb5caed2956 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a1f80ad2950ea100e34260be7ae7d6e7f6f3bea7
Author: Christopher Brannon <cbrannon at cdalibrary.org>
Date:   Wed Dec 5 20:33:25 2018 +0000

    Bug 21346: Remove inline onclicks per comment 42
    
    To test:
    1)  Apply patch.
    2)  Check that there is no changed behavior with buttons or checkboxes.
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit d5d4501290704b9b3a0893a4a3df0a356abe445b)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit f3b362120f0b8a75a89ad6846e7bdad93b2e37ca
Author: Christopher Brannon <cbrannon at cdalibrary.org>
Date:   Sun Nov 4 03:47:30 2018 +0000

    Bug 21346: Convert dialogs to modals.
    
    This addresses most of the transfer dialogs.  There are some dialogs
    that I have not converted because I don't know what triggers them,
    therefore I cannot test them.
    
    The following scenarios have been addresses, and should be tested:
    
    FOR TRANSFERS
    
    1) Checkin with no issue, hold or transfer; not at home (AutomaticItemReturn set to Don't)
         * Should give 3 options - Yes, Yes with print, or No.
         * Yes and Yes with print should trigger a transfer back home.
         * No should do nothing.
         * Print should open a window for printing, with correct
         information.
         * All three options should close the modal.
    
         TO TEST:
         1) Set AutomaticItemREturn to Don't.
         2) Check in an item with no issues, holds or transfers set, at a
         location other than the owning library.
         3) Test conditions above.
    
    2) Checkin with no issue, hold or transfer; not at home (AutomaticItemReturn set to Do)
        * Should give 2 options - Print or OK.
        * Should automatically set transfer.
        * Print should open a window for printing, with correct information.
        * Both buttons should close modal.
    
        TO TEST:
        1) Set AutomaticItemReturn to Do.
        2) Check in an item with no issues, holds or transfers set, at a
        location other than the owning library.
        3) Test conditions above.
    
    3) Checkin with no issues or holds, but transfer already set
        * Should give 3 options - OK, Print or Cancel.
        * OK and print should not touch existing transfer.
        * Cancel should remove the exisiting transfer.
        * Print should open a window for printing, with correct information.
        * All three options should close the modal.
    
        TO TEST:
        1) Check in an item following step 2 of either test above.
        2) Check in item again, while a transfer exists.
        3) Test conditions above.
    
    WRONG BRANCH
    
    4) If AllowReturnToBranch is not set "to any library", and the item is not checked in at the appropriate branch, the wrong-branch-modal pops up:
        * Should give 1 option - OK.
        * Should not check anything in or initiate a transfer.
        * OK should close the modal.
    
        TO TEST:
        1) Set AllowReturnToBranch to "only the library the item is from".
        You can test the other settings, as long as you pay attention to
        where you are checking the item in at.
        2) Check in an item at a branch other than the owning library.
        3) Test conditions above.
    
    Signed-off-by: Lisette <lisetteslatah at gmail.com>
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 5ed171a45c46f63b18266ad3a3d0a978719ca285)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 6055a519c4474ab3b9004ed99b9b2e76c9735076
Author: Christopher Brannon <cbrannon at cdalibrary.org>
Date:   Thu Nov 1 21:08:19 2018 +0000

    Bug 21346: Remove double dialog
    
    To Test:
    1) Place a hold on an item for pickup at another branch.
    2) Check in item to trigger hold and transfer.
    3) Check in item again without changing location.  Note modal AND old
    dialog behind modal.
    4) Apply patch.
    5) Check in item again without changing location.  Note modal without
    the old dialog.
    
    Signed-off-by: Lisette <lisetteslatah at gmail.com>
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 230905e1d56a11cf5619f95c95920eb09803900c)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit a1ff52bef45884b9a292cc5f84fdc49fce1c2c36
Author: Christopher Brannon <cbrannon at cdalibrary.org>
Date:   Thu Nov 1 20:21:08 2018 +0000

    Bug 21346: Streamline logic in holds and transfers
    
    1) Replaced comparison with string to make testing branch easier.
    2) Replaced useless 0 values with undef.
    
    Does not change any behavior, only simplifies code.
    
    Signed-off-by: Lisette <lisetteslatah at gmail.com>
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 48787acc6f725686583bb05f45888acf3e1231d0)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit b56789dbc58c217c0129d2728cc5c202c627c27e
Author: Thatcher Leonard <thatcher.f.leonard at gmail.com>
Date:   Wed Apr 10 23:23:46 2019 +0000

    Bug 18584: Our legacy code contains trailing-spaces
    
    This patch removes trailing spaces and replaces tab characters with
    spaces in the branch transfer limits template.
    
    Mentored-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 8eb22efa0893849e2967e34c821c018c6405f8d3)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 83affe394dfb9c983f79045d43ace06f3daab65d
Author: Arthur Suzuki <arthur.suzuki at biblibre.com>
Date:   Wed Mar 27 15:49:04 2019 +0100

    Bug 22597: Remove "more_subfields_xml" from GetPatronInfo response
    
    Test plan
    1/ Set an item with some xml data in more_subfields_xml
    2/ Issue this item to a borrower
    3/ Query the webservice with GetPatronInfo methods and show_loans=1 params
    4/ Check no <more_subfields_xml> tags are returned in the xml response from the webservice
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 73bc117b057bd5ea73c4075d586b644b0cafe00b)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 0d29ae30119e7f5be27c00afc4791ab4b2cbb627
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Wed Feb 6 00:14:01 2019 +0000

    Bug 19648: Revise marc21_field_007.xml
    
    - Removes some doubled up entries
    - Fixes some whitespace issues
    - Adds some missing entries, for example:
        007, nonprojected graphic, secondary support material a-c
    
    To test:
      - Verify that the 007 cataloging plugin works correctly and
        matches standard:
        http://www.loc.gov/marc/bibliographic/bd007k.html
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 7b90dace95e4c289a2b36b5f95d9116dbd5440db)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/ILSDI/Services.pm                               |    1 +
 circ/returns.pl                                    |   10 +-
 .../prog/en/data/marc21_field_007.xml              |   89 ++++----
 .../en/modules/admin/branch_transfer_limits.tt     |   78 +++----
 .../intranet-tmpl/prog/en/modules/circ/returns.tt  |  213 +++++++++++++-------
 5 files changed, 227 insertions(+), 164 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Thu Apr 25 16:06:42 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Thu, 25 Apr 2019 14:06:42 +0000
Subject: [koha-commits] main Koha release repository branch 18.11.x updated.
	v18.11.04-105-gb415a67
Message-ID: <E1hJf1O-0003ir-Rn@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  b415a676f1a22b51fc89d35ea459ffa88b908706 (commit)
       via  72f0283c582b8f0454aa29771431a688cb437069 (commit)
       via  d07bbd7c44cd0036f9c66e058d261b4b38a6bcf0 (commit)
       via  14bec67add0d82706e6dfb63770fef7de044d643 (commit)
       via  6dd0d44e3cfbca24f52c854a66965b9fc2ad1398 (commit)
       via  bd938e1d9f49f34f641d4ebcd88ef889ca683ca1 (commit)
       via  ddd6d66f09c8cca419b99ae24bbdd2371ac3da28 (commit)
       via  1eae74da5654ad837e72e59077cbe9601217a47f (commit)
       via  27209dea6666c490431aa56485771d8e36c0125a (commit)
       via  f9cd8a272da9f097ba1259a005b636ff0956d286 (commit)
      from  a1f80ad2950ea100e34260be7ae7d6e7f6f3bea7 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit b415a676f1a22b51fc89d35ea459ffa88b908706
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Thu Apr 25 14:44:49 2019 +0100

    Bug 22069: Make log viewer find item renewals
    
    Without this patch renewals for checkouts wouldn't
    show in the log viewer. The log viewre was using
    RENEW, which we use for patrons, but for issue
    RENEWAL is used.
    
    The patch adds RENEWAL to the search params, when
    Renew was selected in the form, so both terms are
    included in the query.
    
    To test:
    - Make sure you have RenewalLog turned on
    - Make a patron renewal
    - Check something out and renew it
    - Go to Tools > Log viewer and test different
      searches
      - Modules All - Actions All
      - Modules All - Actions Renew
      - Modules Circulation - Actions Renew
      ...
    - Make sure results show as expected
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 3e7b24e023c7c88eb9b1a30308a537de9dcd8682)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 72f0283c582b8f0454aa29771431a688cb437069
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Thu Apr 11 17:15:51 2019 -0300

    Bug 22688: (QA follow-up) Use search_params as all() does
    
    It looks like selected would be passed all the way down to
    Koha::Libraries->search and this would fail all the time.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit a48d1a43df24a47f1d31cd437a54961934d50230)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit d07bbd7c44cd0036f9c66e058d261b4b38a6bcf0
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Apr 11 09:52:29 2019 -0400

    Bug 22688: TT plugin for pickup locations code wrong
    
    Test Plan:
    1) Apply this patch
    2) prove t/db_dependent/Koha/Libraries.t
    
    Signed-off-by: Agust?n Moyano <agustinmoyano at theke.io>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit ae18c4bb031a194302ced37f4b376c7439f77c99)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 14bec67add0d82706e6dfb63770fef7de044d643
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Thu Apr 11 17:14:05 2019 -0300

    Bug 22688: (follow-up) Unit tests
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 111068485d455d2020d68a69d29a562547e345c6)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 6dd0d44e3cfbca24f52c854a66965b9fc2ad1398
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Apr 11 10:13:58 2019 -0400

    Bug 22688: Unit tests
    
    Signed-off-by: Agust?n Moyano <agustinmoyano at theke.io>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 2c461fc508d6161c3ab60b523bd724eef20870b9)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit bd938e1d9f49f34f641d4ebcd88ef889ca683ca1
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Tue Feb 26 13:54:28 2019 +0000

    Bug 22451: Use Asset everywhere
    
    Test plan:
    Use installer and onboaarding tool, make sure the js and css files are
    loaded
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit f1c150c98fb60ea75eae7d3b55adbcb7620b7519)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit ddd6d66f09c8cca419b99ae24bbdd2371ac3da28
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Tue Feb 26 13:43:21 2019 +0000

    Bug 22451: Update test
    
    Test plan:
    prove t/db_dependent/Koha/Template/Plugin/Asset.t
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit be3c2abbdc3410ea0cd7e9aa908329d9b46d8c14)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 1eae74da5654ad837e72e59077cbe9601217a47f
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Tue Feb 26 13:30:20 2019 +0000

    Bug 22451: Make Asset plugin use Koha::version instead of version from db
    
    Test plan:
    Apply the patch a try to use Koha, css and js files should be used
    normally
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 4d3461a671f8ad95917aab9ac193cd69fe6c1691)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 27209dea6666c490431aa56485771d8e36c0125a
Author: Lyon3 Team <koha at univ-lyon3.fr>
Date:   Thu Apr 11 10:48:42 2019 +0200

    Bug 22652: Editing Course reserves is broken
    
    To test:
    1. Create a course reserve or go on an existing one
    2. Add items and add a change for the holdingbranch
    3. On the list of items in this course reserve
    (course_reserves/course-details.pl?course_id=xx), click on "edit" at the
    end of a row :
    
    Without the patch, you can't see the holdingbranch you have choose for
    this item, but you see "LEAVE UNCHANGED"
    
    With the patch, you can see the holdingbranch you have choose when
    adding this item in the course
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Mika?l Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit ba14e9ca7d40af664f7079c6a9f85a85e88fca9a)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit f9cd8a272da9f097ba1259a005b636ff0956d286
Author: Olivier Crouzet <kohateam at univ-lyon3.fr>
Date:   Mon Mar 11 15:00:23 2019 +0100

    Bug 20830: Make sure a fund is selected when ordering from a stage file
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 8cb24d65849aa881a0e6eb74271ca2d9c7ea455c)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/Template/Plugin/Asset.pm                      |    4 +-
 Koha/Template/Plugin/Branches.pm                   |    9 +-
 .../prog/en/includes/installer-doc-head-close.inc  |    8 +-
 .../prog/en/includes/installer-intranet-bottom.inc |   11 +-
 .../intranet-tmpl/prog/en/includes/select2.inc     |    2 +-
 .../prog/en/modules/acqui/addorderiso2709.tt       |   14 ++
 .../en/modules/course_reserves/add_items-step2.tt  |    2 +-
 .../prog/en/modules/onboarding/onboardingstep3.tt  |    4 +-
 .../intranet-tmpl/prog/en/modules/tools/viewlog.tt |    1 +
 .../opac-tmpl/bootstrap/en/modules/opac-reserve.tt |    2 +-
 t/db_dependent/Koha/Template/Plugin/Asset.t        |    7 +-
 t/db_dependent/Template/Plugin/Branches.t          |  185 +++++++++++++-------
 tools/viewlog.pl                                   |    1 +
 13 files changed, 164 insertions(+), 86 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Thu Apr 25 16:44:10 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Thu, 25 Apr 2019 14:44:10 +0000
Subject: [koha-commits] main Koha release repository branch master updated.
	v18.11.00-1347-g90a15e2
Message-ID: <E1hJfbe-0005Do-Fi@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  90a15e2d82cd345c6d2fd3cb3ddd1e318e3a79f7 (commit)
      from  bdc5cb00accf0464d352a8197d2d8ff86a774a64 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 90a15e2d82cd345c6d2fd3cb3ddd1e318e3a79f7
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Apr 25 14:25:06 2019 +0000

    Bug 20837: (RM follow-up) fix test count
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 t/db_dependent/Holds.t |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Thu Apr 25 16:49:10 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Thu, 25 Apr 2019 14:49:10 +0000
Subject: [koha-commits] main Koha release repository branch 18.11.x updated.
	v18.11.04-111-gfb73c4a
Message-ID: <E1hJfgU-0005Y8-GZ@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  fb73c4a3470b37058c41f216fbc95df60e3c9621 (commit)
       via  cf76b870033fcf709941d048e3fdbac7b7123e5e (commit)
       via  b1f2d795defee116ce30522eb76f4981ca21b804 (commit)
       via  89f0c3a9da9d009e7fea0c76f706676078dc9860 (commit)
       via  16846985e1032b89bb9df16f445c04f3c47dd375 (commit)
       via  5469ae4eea46416410bddaef4934aa1db6e767f9 (commit)
      from  b415a676f1a22b51fc89d35ea459ffa88b908706 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit fb73c4a3470b37058c41f216fbc95df60e3c9621
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Fri Dec 7 16:05:52 2018 +0100

    Bug 21975: Avoid unnecessary substitutions in automatic item modification by age
    
    Automatic item modification by age cronjob is based on rules with conditions and substitutions.
    When substitution value is equal to actual item value, the code should not call C4::Items::ModItem. It adds unnecessary action log and entry in zebraqueue.
    With a rule than can impact all catalogue you can explode your database with action logs.
    
    Test plan :
    1) Run prove t/db_dependent/Items/AutomaticItemModificationByAge.t
    2) Define a item modification by age with no condition
    3) Run several times misc/cronjobs/automatic_item_modification_by_age.pl
    4) Check it creates only one entry in action_logs and zebraqueue
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 3a3ffbc54b8dec8ee63332417fe2732ee93f3034)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit cf76b870033fcf709941d048e3fdbac7b7123e5e
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Fri Dec 7 15:21:48 2018 +0100

    Bug 21975: add Unit Test
    
    Added missing transaction rollback
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 0be8fd212067ebd4b36e00b4d139761aa0e021c3)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit b1f2d795defee116ce30522eb76f4981ca21b804
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Fri Dec 7 15:58:54 2018 +0100

    Bug 21975: get item field in substitutions
    
    substitutions field stores the item field with 'items.' prefix.
    Looks like call of C4::Items::ModItem() works but it will not if ORM object is used in the futur.
    So I prefer fix it now and it is needed for main patch.
    
    Test plan :
    Run t/db_dependent/Items/AutomaticItemModificationByAge.t
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 003b70b697f9c57da8bfb0aca1223c867a07ac97)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 89f0c3a9da9d009e7fea0c76f706676078dc9860
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Fri Apr 12 11:04:06 2019 +0000

    Bug 18011: Enrollment period date on patron category can be set in the past without any error/warning messages
    
    This patch modifies the patron category edit form so that the enrollment
    period datepicker widget cannot be used to select a date in the past.
    
    The <input> element had a "datepicker" class, which triggers a default
    datepicker configuration. This was overriding the configuration in the
    page-specific JavaScript file.
    
    To test, apply the patch and go to Administration -> Patron categories.
    
    Click the "Enrollment period -> Until date" field and verify that dates
    before today are disabled.
    
    Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 34c835ed141a3b4758ad77e5b72f30e83d57024f)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 16846985e1032b89bb9df16f445c04f3c47dd375
Author: Ere Maijala <ere.maijala at helsinki.fi>
Date:   Thu Mar 7 16:35:30 2019 +0200

    Bug 22474: Clone field config before adding fields to it
    
    Test plain:
    
    1. Reindex both authorities and biblios with the -d flag to recreate the index, e.g. "perl misc/search_tools/rebuild_elastic_search.pl -v -d"
    2. Check that authorities only contains authority-specific fields in Elasticsearch e.g. by fetching  http://localhost:9200/koha_dev_authorities/_mappings
    3. Reindex both without the -d flag and verify it works, e.g. "perl misc/search_tools/rebuild_elastic_search.pl -v"
    
    Signed-off-by: Bj?rn Nyl?n <bjorn.nylen at ub.lu.se>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 118f685dbf1519077ece65a47f83bff179efbf9b)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 5469ae4eea46416410bddaef4934aa1db6e767f9
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Sun Apr 7 18:23:32 2019 +0000

    Bug 22090: Add missing information to cash register CSV file
    
    Some information was missing from the CSV export file
    of the Cash register report: manager surname, patron surname
    and payment notes.
    
    Also pretties up the column headers a bit and makes the
    sequence between GUI and CSV export match.
    
    To test:
    - Make sure you have some fines and fees and payments in
      your system
    - Make a search with the Cash register report
    - Export results as CSV
    - Proof read hader line and make sure contents match headings
    - Verify first name and surname are shown for manager and patron
    - Verify notes show up
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 1a2572915b4bf4a11b3a65c3a65e506610263a03)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Installer/PerlDependencies.pm                   |    2 +-
 C4/Items.pm                                        |    6 +++++-
 Koha/SearchEngine/Elasticsearch.pm                 |   21 +++++++++++---------
 .../csv_headers/reports/cash_register_stats.tt     |    2 +-
 .../prog/en/modules/admin/categories.tt            |    2 +-
 .../prog/en/modules/reports/cash_register_stats.tt |    2 +-
 reports/cash_register_stats.pl                     |    6 +++---
 .../Items/AutomaticItemModificationByAge.t         |   12 +++++++++--
 8 files changed, 34 insertions(+), 19 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Fri Apr 26 04:09:30 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Fri, 26 Apr 2019 02:09:30 +0000
Subject: [koha-commits] main Koha release repository branch 18.05.x updated.
	v18.05.11-48-g6ba72fb
Message-ID: <E1hJqIs-00008h-F2@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  6ba72fb43b585ae2b2888dc3c50ada09014e86af (commit)
       via  3aa1a5d9edfc4f5692730da1a864214d31df079c (commit)
       via  237abf0a523a9b9aa278d85686f0a4a503fd5586 (commit)
       via  6aba59f6a18b9d01d7e1461a9df9eeb6719896e6 (commit)
      from  a6804721711904f1a95c18d6274d6d2c495431b7 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 6ba72fb43b585ae2b2888dc3c50ada09014e86af
Author: Christopher Brannon <cbrannon at cdalibrary.org>
Date:   Wed Dec 5 20:33:25 2018 +0000

    Bug 21346: Remove inline onclicks per comment 42
    
    To test:
    1)  Apply patch.
    2)  Check that there is no changed behavior with buttons or checkboxes.
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit d5d4501290704b9b3a0893a4a3df0a356abe445b)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit a1f80ad2950ea100e34260be7ae7d6e7f6f3bea7)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit 3aa1a5d9edfc4f5692730da1a864214d31df079c
Author: Christopher Brannon <cbrannon at cdalibrary.org>
Date:   Sun Nov 4 03:47:30 2018 +0000

    Bug 21346: Convert dialogs to modals.
    
    This addresses most of the transfer dialogs.  There are some dialogs
    that I have not converted because I don't know what triggers them,
    therefore I cannot test them.
    
    The following scenarios have been addresses, and should be tested:
    
    FOR TRANSFERS
    
    1) Checkin with no issue, hold or transfer; not at home (AutomaticItemReturn set to Don't)
         * Should give 3 options - Yes, Yes with print, or No.
         * Yes and Yes with print should trigger a transfer back home.
         * No should do nothing.
         * Print should open a window for printing, with correct
         information.
         * All three options should close the modal.
    
         TO TEST:
         1) Set AutomaticItemREturn to Don't.
         2) Check in an item with no issues, holds or transfers set, at a
         location other than the owning library.
         3) Test conditions above.
    
    2) Checkin with no issue, hold or transfer; not at home (AutomaticItemReturn set to Do)
        * Should give 2 options - Print or OK.
        * Should automatically set transfer.
        * Print should open a window for printing, with correct information.
        * Both buttons should close modal.
    
        TO TEST:
        1) Set AutomaticItemReturn to Do.
        2) Check in an item with no issues, holds or transfers set, at a
        location other than the owning library.
        3) Test conditions above.
    
    3) Checkin with no issues or holds, but transfer already set
        * Should give 3 options - OK, Print or Cancel.
        * OK and print should not touch existing transfer.
        * Cancel should remove the exisiting transfer.
        * Print should open a window for printing, with correct information.
        * All three options should close the modal.
    
        TO TEST:
        1) Check in an item following step 2 of either test above.
        2) Check in item again, while a transfer exists.
        3) Test conditions above.
    
    WRONG BRANCH
    
    4) If AllowReturnToBranch is not set "to any library", and the item is not checked in at the appropriate branch, the wrong-branch-modal pops up:
        * Should give 1 option - OK.
        * Should not check anything in or initiate a transfer.
        * OK should close the modal.
    
        TO TEST:
        1) Set AllowReturnToBranch to "only the library the item is from".
        You can test the other settings, as long as you pay attention to
        where you are checking the item in at.
        2) Check in an item at a branch other than the owning library.
        3) Test conditions above.
    
    Signed-off-by: Lisette <lisetteslatah at gmail.com>
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 5ed171a45c46f63b18266ad3a3d0a978719ca285)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit f3b362120f0b8a75a89ad6846e7bdad93b2e37ca)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit 237abf0a523a9b9aa278d85686f0a4a503fd5586
Author: Christopher Brannon <cbrannon at cdalibrary.org>
Date:   Thu Nov 1 21:08:19 2018 +0000

    Bug 21346: Remove double dialog
    
    To Test:
    1) Place a hold on an item for pickup at another branch.
    2) Check in item to trigger hold and transfer.
    3) Check in item again without changing location.  Note modal AND old
    dialog behind modal.
    4) Apply patch.
    5) Check in item again without changing location.  Note modal without
    the old dialog.
    
    Signed-off-by: Lisette <lisetteslatah at gmail.com>
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 230905e1d56a11cf5619f95c95920eb09803900c)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 6055a519c4474ab3b9004ed99b9b2e76c9735076)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit 6aba59f6a18b9d01d7e1461a9df9eeb6719896e6
Author: Christopher Brannon <cbrannon at cdalibrary.org>
Date:   Thu Nov 1 20:21:08 2018 +0000

    Bug 21346: Streamline logic in holds and transfers
    
    1) Replaced comparison with string to make testing branch easier.
    2) Replaced useless 0 values with undef.
    
    Does not change any behavior, only simplifies code.
    
    Signed-off-by: Lisette <lisetteslatah at gmail.com>
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 48787acc6f725686583bb05f45888acf3e1231d0)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit a1ff52bef45884b9a292cc5f84fdc49fce1c2c36)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 circ/returns.pl                                    |   37 +++-
 .../intranet-tmpl/prog/en/modules/circ/returns.tt  |  217 +++++++++++++-------
 2 files changed, 173 insertions(+), 81 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Fri Apr 26 14:22:00 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Fri, 26 Apr 2019 12:22:00 +0000
Subject: [koha-commits] main Koha release repository branch 18.11.x updated.
	v18.11.04-120-g4c44dfd
Message-ID: <E1hJzrc-0005kw-BJ@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  4c44dfd8fe2ee4e64acb283ef25f6cd21c969927 (commit)
       via  b1d1d5ab915b8b664e0ac321876a414655762ee4 (commit)
       via  1ed01089db28deb6f9689bbb64c30ee805559dbf (commit)
       via  98a50392900d7b7b6ef0fc187a26e3759844d095 (commit)
       via  36bf400905661afca5da0190af65cf088286cb78 (commit)
       via  eaed1f1e6bf5ff24981a91131e0a8be09dd79c30 (commit)
       via  6cc9e6086a2937954b05078d78d6034e2223daa5 (commit)
       via  2bf66d987a9511bd5da108cf27a9cfe2f47e3634 (commit)
       via  f53fe14580549266b098a303c4be389fee505b60 (commit)
      from  fb73c4a3470b37058c41f216fbc95df60e3c9621 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4c44dfd8fe2ee4e64acb283ef25f6cd21c969927
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue Apr 16 16:34:13 2019 +0000

    Bug 22716: Use gender-neutral pronouns in system preference descriptions
    
    This patch makes a few corrections to the .pref files which provide
    descriptions for system preferences. Language like "him or her" is
    replaced with "they/them" pronouns.
    
    To test, apply the patch and check the following preferences:
    
     - OPACFineNoRenewalsBlockAutoRenew
     - ExpireReservesMaxPickUpDelayCharge
     - PatronSelfRegistrationVerifyByEmail
    
    Signed-off-by: Lisette <lisettes at latahlibrary.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 4b3eb99ad6cd9fc8e9bac6627c38bd16600aa38a)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit b1d1d5ab915b8b664e0ac321876a414655762ee4
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Sun Apr 14 03:13:01 2019 +0000

    Bug 21172: Remove obsolete framework parameter from GetMarcFromKohaField
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 2a9b9a526bb3e1c73e09cbee499a2debcab74ee5)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 1ed01089db28deb6f9689bbb64c30ee805559dbf
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Aug 7 17:06:41 2018 -0300

    Bug 21172: Remove warning from addbiblio.pl
    
    Argument "01e" isn't numeric in numeric ne (!=) at
    /home/vagrant/kohaclone/cataloguing/addbiblio.pl line 507.
    
    A tagfield can be 01e and so raise a warning is compared with == or !=
    
    This patch also fixes few inconsistencies:
    - tagfield for items.itemnumber must be retrieved with GetMarcFromKohaField
    (to support other marcflavours)
    - do not use $_
    - loop only once on $usedTagsLib
    
    Test plan:
    For devs only, read the code and confirm the changes make sense.
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit f3afec0587f4baeff580e153ea592020d4d36be3)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 98a50392900d7b7b6ef0fc187a26e3759844d095
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Apr 17 10:11:04 2019 +0000

    Bug 22044: DBRev 18.11.04.003
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 4177d2e32942b16e65748852df881541406297bd)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 36bf400905661afca5da0190af65cf088286cb78
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Sun Apr 14 04:26:29 2019 +0000

    Bug 22044: Fix sysprefs.sql description to use circ column description
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit f6e143c73c9ba7f6b1daf76d592dc7a56e8694bb)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit eaed1f1e6bf5ff24981a91131e0a8be09dd79c30
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon Apr 15 13:32:12 2019 +0000

    Bug 22044: Correct syspref name
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit a3a3bf2dda3219b3385b587585985c51f6cc8498)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 6cc9e6086a2937954b05078d78d6034e2223daa5
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Dec 21 19:19:05 2018 +0000

    Bug 22044: Set default and add NoRenewalBeforePrecision preference for new/affected installs
    
    I am not sure the correct answer - for upgraded installs the pref was
    set to date, which changed behaviour
    
    For new installs the pref was unset, behaved as if 'exact_time' so we
    shouldn't change behaviour?
    
    If the perceived default is date then the code should be changed, or
    this shouldn't be a pref at all?
    
    To test:
    1 - Have a new system missing this pref
    2 - Note when searchign the pref in staff client if appears as 'date'
    3 - Check the db to confirm value is 'NULL'
    4 - Apply patch and run update
    5 - Pref is now set to 'exact_time'
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 4779cf845077ffd7f564b63b22f72ba99aa812ff)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 2bf66d987a9511bd5da108cf27a9cfe2f47e3634
Author: Lucas Gass <lucas at bywatersolutions.com>
Date:   Fri Apr 12 23:04:06 2019 +0000

    Bug 22702: circulation note on patron page should allow for HTML tags
    
    Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>
    Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 9f34d208d08fc89d2d0b4d3718fc43e3f32ff055)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit f53fe14580549266b098a303c4be389fee505b60
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Thu Apr 4 01:36:47 2019 +0000

    Bug 22154: Fix search for Braille from Advanced search page
    
    When you do an advanced search and choose the Format subtype
    Braille, it looks for l-format:fk, but that is not the right
    code for Braille.
    
    fk does not exist. It should be fb for Tactile material/Braille
    OR tc for Text/Braille
    
    To test:
    0) Catalog 2 records, one with 007 tc and another with fb
       Use value builder to verify both are for Braille.
    1) In Administration > System preferences, make sure 'Subtypes'
       is checked in either OpacAdvSearchMoreOptions or OpacAdvSearchOptions
    2) Go to Advanced search
    3) If necessary, click on 'More options'
    4) In the 'Subtype limits' section, choose 'Braille' from the 'Format'
       drop-down menu
    5) Click on 'Search'
    6) Verify both records were found
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 44a39929afc60ddda3182a93197ced098044a12d)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha.pm                                               |    2 +-
 cataloguing/addbiblio.pl                              |   17 ++++++++++-------
 installer/data/mysql/sysprefs.sql                     |    1 +
 installer/data/mysql/updatedatabase.pl                |   11 +++++++++++
 .../en/modules/admin/preferences/circulation.pref     |    4 ++--
 .../prog/en/modules/admin/preferences/opac.pref       |    2 +-
 .../prog/en/modules/catalogue/advsearch.tt            |    2 +-
 .../intranet-tmpl/prog/en/modules/circ/circulation.tt |    2 +-
 .../prog/en/modules/members/moremember.tt             |    2 +-
 .../opac-tmpl/bootstrap/en/modules/opac-advsearch.tt  |    2 +-
 10 files changed, 30 insertions(+), 15 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Fri Apr 26 14:57:49 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Fri, 26 Apr 2019 12:57:49 +0000
Subject: [koha-commits] main Koha release repository branch master updated.
	v18.11.00-1369-g90f8eb6
Message-ID: <E1hK0QH-00075W-Oi@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  90f8eb626d32694e3297a4cfe6566cbb9abe192b (commit)
       via  bfce1fea9652f84c2031f59e7213694b05e4ca8a (commit)
       via  bf473396ab1313867ead815ca3e8758b76233931 (commit)
       via  5743bb2945d3fb8900129123bf1f36f67310d843 (commit)
       via  831e9fc98fd99a52da09f0b5a6fdd88a37c66e1f (commit)
       via  21127d4a47bbebb74d44d32d5b51dac4bc470ce6 (commit)
       via  443c2fafb7be74aa74282eb4dee7ad5f3d827f31 (commit)
       via  80be039d6c6ccff18ac029b4e2081728aeba5748 (commit)
       via  6e6a6230a5e59ec1866a12174233471a07d616b8 (commit)
       via  428fcb3421d0176bdb92cc394fbaec00b84871a8 (commit)
       via  2b45630e42813f0e9a383cb7f97c63f68f30a4a3 (commit)
       via  6d93872d5a8f060a30104751997e312e74d21c33 (commit)
       via  7be6714148f35f3d33d848d4cc9dca251356971a (commit)
       via  27691d2db6b74fb42b8be169a5feb7577ff582eb (commit)
       via  696035229137ffb139446ba99f8ad41dab94a199 (commit)
       via  020da0e81712ca3d6856e31af4cd3b8d18346c01 (commit)
       via  f82d6acab668dfb86a227b155116679a2a540eea (commit)
       via  1d6e9ff44c19379a41e9ce688685a24788583e0c (commit)
       via  20496bc78b7830d812fda454a0fe243fae9c465c (commit)
       via  7e85754083bd66f45009f55a01e9dec9eda81504 (commit)
       via  6e641c5bcb7370556326fb64838fce1eefbc2c18 (commit)
       via  c9927a97ab814b18453f981b50ada546ca2ba064 (commit)
      from  90a15e2d82cd345c6d2fd3cb3ddd1e318e3a79f7 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 90f8eb626d32694e3297a4cfe6566cbb9abe192b
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Wed Apr 24 09:51:36 2019 -0400

    Bug 22765: Add class beside loggedinusername to indicate if logged in user is a superlibrarian
    
    It would be useful to know if a logged in user is a superlibrarian for the purpose of customization
    using Javascript and CSS.
    
    Test Plan:
    1) Apply this patch, restart all the things
    2) Log in as a superlibraraian
    3) Note the new class 'is_superlibrarian' next to the 'loggedinusername' class
    4) Log in as a non-superlibrarian
    5) Note the new class is not present
    
    Signed-off-by: Barton Chittenden <barton at bywatersolutions.com>
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit bfce1fea9652f84c2031f59e7213694b05e4ca8a
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Apr 26 12:04:57 2019 +0000

    Bug 15496: (QA follow-up) Fix new uses of Koha::Biblio::items in list context
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit bf473396ab1313867ead815ca3e8758b76233931
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Wed Apr 17 16:20:18 2019 +0000

    Bug 15496: (follow-up) Update interaction for deleting records
    
    This patch makes minor changes to markup and JavaScript to alter the
    interaction for deleting the record. Now a successful deletion will
    convert the dialog to a "message" type dialog and show only the success
    message.
    
    To test, apply the patch and test the process of attaching the last item
    from a record and deleting that record.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 5743bb2945d3fb8900129123bf1f36f67310d843
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Wed Apr 17 10:47:06 2019 +0000

    Bug 15496: (QA follow-up) Change success status on api
    
    DELETE response code must be 204, not 200 according to our API coding
    guidelines
    
    Test plan:
    
    prove t/db_dependent/api/v1/biblios.t
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 831e9fc98fd99a52da09f0b5a6fdd88a37c66e1f
Author: Liz Rea <wizzyrea at gmail.com>
Date:   Mon Apr 15 17:55:04 2019 +0000

    Bug 15496: (QA follow-up) remove text/javascript
    
    Make the QA tool happy for html5
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 21127d4a47bbebb74d44d32d5b51dac4bc470ce6
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Fri Apr 12 13:50:32 2019 -0400

    Bug 15496: Delete Bib After Moving Item
    
    Librarians have requested the ability to delete records with no items
    quickly and easily from the "Attach item" results page as items are
    moved from one record to another.
    
    Test Plan:
    1) Apply this patch
    2) Create 2 records with 2 items each
    3) Move one item from record A to record B
    4) You should see no change from pre-patch behavior
    5) Move the second item from record A to record B
    6) You should now see a "Delete record" button
    7) Click the button
    8) Note the record in question has been deleted
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 443c2fafb7be74aa74282eb4dee7ad5f3d827f31
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Apr 26 11:48:17 2019 +0000

    Bug 10300: DBRev 18.12.00.065
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 80be039d6c6ccff18ac029b4e2081728aeba5748
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Thu Feb 28 16:23:22 2019 +0100

    Bug 10300: (follow-up) add controls on transfers page
    
    This patch moves the check of IndependentBranchesTransfers pref to templates and adds permission test inside branchtransfers.pl.
    It also corrects the libraries combobox in branchtransfers.tt, this list can contain all libraries, it is the access to the page that may be protected.
    
    Additions to test plan :
    1)
    1.1) Enable CircSidebar
    1.2) In circulation home page check the effect of IndependentBranchesTransfers on "Transfer" link
    1.3) Go to return page and check then effect of IndependentBranchesTransfers on "Transfer" link
    
    2)
    2.1) In circ/branchtransfers.pl, with and without IndependentBranches you see all libraries are in combobox
    
    3)
    3.1) Set IndependentBranchesTransfers to no and go to circ/branchtransfers.pl
    3.2) You are redirected to page 403 unless you are superlibarian
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 6e6a6230a5e59ec1866a12174233471a07d616b8
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Aug 25 14:03:31 2016 +0000

    Bug 10300: Allow transferring of items to be have separate IndependentBranches syspref
    
    Some libraries want to have IndependentBranches enabled, but still be
    able to transfer items between themselves.
    
    Test Plan:
    1) Apply this patch
    2) Run updatedatabase.pl
    3) Enable IndpendentBranches and IndependentBranchesTransfers
    4) Log in as a super librarian
    5) Note you can transfer items
    6) Log in as a non-super librarian
    7) Note you cannot transfer items
    8) Disable IndependentBranchesTransfers
    9) Note you can now transfer items
    
    Signed-off-by: Maribeth Shafer <mshafer at ckls.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Bug 10300: (QA follow-up) Make database update idempotent
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 428fcb3421d0176bdb92cc394fbaec00b84871a8
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Fri Apr 12 13:07:18 2019 -0400

    Bug 15496: Tidy code block (Whitespace changes only)
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 2b45630e42813f0e9a383cb7f97c63f68f30a4a3
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Apr 11 10:05:14 2019 -0400

    Bug 15496: Add API endoint for deleting a bib
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 6d93872d5a8f060a30104751997e312e74d21c33
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Apr 26 10:52:41 2019 +0000

    Bug 22035: Compiled CSS
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 7be6714148f35f3d33d848d4cc9dca251356971a
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Wed Jan 16 18:27:54 2019 +0000

    Bug 22035: Improve local cover image browser page
    
    This patch makes changes to the way local cover images are handled on
    the image viewer page in the staff client. From this page you can now
    delete images or reach the upload images page.
    
    The patch also modifies slightly the process for deleting an image from
    the images tab on the bibliographic detail page.
    
    To test, apply the patch and regenerate the staff client CSS.
    LocalCoverImages and  AllowMultipleCovers should be enabled.
    
     - Open the detail view for a record which has multiple cover images
       attached. On the Images tab, click the "Delete image" link for an
       image. After confirming, the link should change to a spinner icon and
       image should fade out.
     - Click one of the cover images to open the image viewer page. The
       thumbnails should each have a delete link which looks like and
       behaves like the delete links on the biblio detail page.
     - Clicking an image thumbnail should load a spinner icon into the area
       where the full-sized image was, which should be replaced by the image
       you chose.
     - There should be a button for uploading images which takes you to the
       correct page for adding images to that record.
     - The page title and breadcrumbs should show the title of the record.
    
    Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 27691d2db6b74fb42b8be169a5feb7577ff582eb
Author: Hayley Mapley <hayleymapley at catalyst.net.nz>
Date:   Fri Apr 26 15:22:30 2019 +1200

    Bug 22056: Removed test directory, including search.pl and README
    
    Test plan: Check that this directory has been removed.
    
    Sponsored-by: Catalyst IT
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 696035229137ffb139446ba99f8ad41dab94a199
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Thu Apr 25 12:35:24 2019 +0100

    Bug 22200: (follow-up) Wrap accountline creation in a transaction
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 020da0e81712ca3d6856e31af4cd3b8d18346c01
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Thu Apr 18 09:44:01 2019 +0100

    Bug 22200: Add credit when forgiving overdue
    
    Prior to this patch the exemptfine option for_FixOverduesOnReturn would
    directly set the overdue amount to 0 rather than creating an appropriate
    credit of the type forgiven and offseting it against the debt.
    
    Test Plan:
    1) Find a checkout that is overdue with fines
    2) Check the item in with the forgive fines option checked
    3) Note that the users account details now shows the overdue as forgiven
    and a forgiven credit is added which matches the overdue amount (and is
    applied against it, i.e. both overdue and forgiven lines have 0
    amountoutstanding).
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit f82d6acab668dfb86a227b155116679a2a540eea
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Thu Apr 18 09:56:24 2019 +0100

    Bug 22200: Add Tests for change
    
    Unit tests to check for the addition of a credit of type 'FOR' when
    _FixOverduesOnReturn is called with $exemptfine set to true.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 1d6e9ff44c19379a41e9ce688685a24788583e0c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Apr 23 22:49:46 2019 -0400

    Bug 22621: Fix filters on subscription search results
    
    Caused by
      commit 4e698f7b478a094d7b32ebfeaa917bca05ebcc5b
      Bug 18426: Allow to edit subscriptions in batch
    
    There is a shift caused by a hidden column, which make the filters
    searching on the previous column.
    
    Test plan:
    - Add 1+ searchable additional field for subscription
    - Create a new subscription
    - Search for subscriptions
    - Use the column filters to filter the results
    => The results must be filtered accordingly
    
    Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 20496bc78b7830d812fda454a0fe243fae9c465c
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Wed Oct 17 14:43:11 2018 -0400

    Bug 21589: Series link formed from 830 field is incorrect
    
    Bug 13692 corrected the series link for records using a 490/800 combination
    
    When a record has a 490/830 conbination for series, the link is malformed (title is used as author, title is blank)
    
    Test Plan:
    1) Catalog two or more records with 830 fields
    2) Note the series links are broken
    3) Apply this patch
    4) Reload the record details page
    5) The series link should now work
    6) Repeat for the OPAC
    
    Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 7e85754083bd66f45009f55a01e9dec9eda81504
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Apr 25 17:47:14 2019 +0000

    Bug 22715: Remove extraneous html filter
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 6e641c5bcb7370556326fb64838fce1eefbc2c18
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Tue Apr 16 10:34:56 2019 -0400

    Bug 22715: Searching for patrons with "" in the circulation note hangs patron search
    
    To replicate:
    Edit a patron to have a circ note, include quoted text in it, such as "this is quoted string"
    Go to the patron search, search for a set of results that would include the patron with the quotes in the note
    Enjoy looking at "Processing" for forever.
    
    Test Plan:
    1) Apply this patch
    2) Attempt to replicate using the steps above
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    I took this a step further and used <script>"something in
    quotes"</script> for my test note and this worked just fine. YAY.
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit c9927a97ab814b18453f981b50ada546ca2ba064
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Apr 23 23:48:35 2019 -0400

    Bug 22669: Fix item editing on receiving an order
    
    Since
      commit 1253975389975a8ff11a9bb2ef84582aeb6bd08b
      Bug 21091: Move add item template JavaScript to a separate file
    
    items cannot longer be edited when receiving an order.
    When moving the code to the JS file, the JS variable "opisadd" was
    always set to "true":
      var opisadd = '[% opisadd | html %]';
    Even if the TT variable is 0, opisadd will be "0", which is evaluated to
    true in Javascript
    
    To clean the situation it is easier to remove this variable and use "op"
    instead.
    
    Test plan:
    - Make sure acqcreateitem is set to "when placing an order"
    - Create a basket with some orders
    - Close the basket
    - Go to your vendor and receive an order
    - On the receive page, try to edit your item
    => Without the patch, the pop up page will open and then close, not allowing the item to be edited.
    => With this patch applied you will see the item edit form. Save and
    confirm that the parent window is updated with the new value (actually
    it's refreshed)
    
    Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm                                  |   66 ++++++----
 C4/ILSDI/Services.pm                               |    2 +-
 Koha.pm                                            |    2 +-
 Koha/Biblio.pm                                     |   15 +--
 Koha/REST/V1/Biblios.pm                            |   76 +++++++++++
 api/v1/swagger/parameters.json                     |    3 +
 api/v1/swagger/parameters/biblio.json              |    9 ++
 api/v1/swagger/paths.json                          |    3 +
 .../{acquisitions_funds.json => biblios.json}      |   49 +++-----
 cataloguing/additem.pl                             |    1 -
 cataloguing/moveitem.pl                            |   53 ++++----
 circ/branchtransfers.pl                            |    6 +
 installer/data/mysql/sysprefs.sql                  |    1 +
 installer/data/mysql/updatedatabase.pl             |   11 ++
 .../intranet-tmpl/prog/css/src/staff-global.scss   |    1 +
 koha-tmpl/intranet-tmpl/prog/css/staff-global.css  |    2 +-
 .../intranet-tmpl/prog/en/includes/circ-nav.inc    |    2 +-
 .../intranet-tmpl/prog/en/includes/header.inc      |    3 +-
 .../prog/en/includes/str/cataloging_additem.inc    |    2 +-
 .../prog/en/modules/admin/preferences/admin.pref   |    7 ++
 .../prog/en/modules/catalogue/detail.tt            |    3 +-
 .../prog/en/modules/catalogue/imageviewer.tt       |  133 +++++++++++++-------
 .../prog/en/modules/cataloguing/additem.tt         |    4 +-
 .../prog/en/modules/cataloguing/moveitem.tt        |   40 ++++++
 .../prog/en/modules/circ/branchtransfers.tt        |    2 +-
 .../prog/en/modules/circ/circulation-home.tt       |    2 +-
 .../en/modules/members/tables/members_results.tt   |    2 +-
 .../prog/en/modules/serials/serials-search.tt      |   18 +--
 .../prog/en/xslt/MARC21slim2intranetDetail.xsl     |   33 ++++-
 .../intranet-tmpl/prog/js/cataloging_additem.js    |   10 +-
 .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl    |   32 ++++-
 t/db_dependent/Circulation.t                       |   12 +-
 t/db_dependent/Koha/Biblio.t                       |    2 +-
 t/db_dependent/api/v1/biblios.t                    |   72 +++++++++++
 test/README                                        |    3 -
 test/search.pl                                     |   70 -----------
 36 files changed, 517 insertions(+), 235 deletions(-)
 create mode 100644 Koha/REST/V1/Biblios.pm
 create mode 100644 api/v1/swagger/parameters/biblio.json
 copy api/v1/swagger/paths/{acquisitions_funds.json => biblios.json} (51%)
 create mode 100644 t/db_dependent/api/v1/biblios.t
 delete mode 100644 test/README
 delete mode 100755 test/search.pl


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Fri Apr 26 15:52:28 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Fri, 26 Apr 2019 13:52:28 +0000
Subject: [koha-commits] main Koha release repository branch 18.11.x updated.
	v18.11.04-121-g9535293
Message-ID: <E1hK1HA-0000x4-Mv@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  9535293c4a13fb4ef4ccf7a3314248ac94be7156 (commit)
      from  4c44dfd8fe2ee4e64acb283ef25f6cd21c969927 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 9535293c4a13fb4ef4ccf7a3314248ac94be7156
Author: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Date:   Wed Nov 28 13:14:21 2018 -0300

    Bug 21899: Update MARC21 frameworks to Update 27 (November 2018)
    
    This bug updates MARC21 english frameworks to Update 27
    
    Bibliographic
    -------------
     * New fields 251, 341 and 532 with corresponding subfields
     * New subfields 041$p, 041$q and 041$r
     * Renamed subfield 041$j
    
    Authorities
    -----------
     * New subfield 055$2
    
    To test:
    1) Remove all your frameworks
    2) Check mandatory bibliographic and authority files load without problem
    3) Check new fields/subfields
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit b31d314613994da218740b735139af70f009fca8)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 .../marc21/mandatory/authorities_normal_marc21.sql |    3 +-
 .../marc21/mandatory/marc21_framework_DEFAULT.sql  |   29 ++++++++++++++++++--
 2 files changed, 29 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Fri Apr 26 16:35:11 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Fri, 26 Apr 2019 14:35:11 +0000
Subject: [koha-commits] main Koha release repository branch 18.11.x updated.
	v18.11.04-130-g8bd2636
Message-ID: <E1hK1wV-0003aT-UA@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  8bd263601499ae1aa13587b37c62dfa27b4c7def (commit)
       via  7cf678b3211c5650f738b06ec24fc0cf7741ea2c (commit)
       via  ca4d24c1e2bbc27b46e8b7ca3272b06a51a403a1 (commit)
       via  09552018a9281a745f2d845bc150b882655ea313 (commit)
       via  7fd18db89def96f2b50e3ba4d89dcff97cca3c45 (commit)
       via  3e02dee64f8899e2dc141c85ff475c898187bfda (commit)
       via  b100fb160971242032eee104b70e7f8fc167f348 (commit)
       via  ba28ac67c2280622a197b3c7a053eee8549e6194 (commit)
       via  c1ef5545560ba1ad50f96db6514eb7a22507daca (commit)
      from  9535293c4a13fb4ef4ccf7a3314248ac94be7156 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 8bd263601499ae1aa13587b37c62dfa27b4c7def
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date:   Tue Feb 19 01:36:14 2019 +0000

    Bug 22365: Removing warn when accessing Log Viewer
    
    To test:
    Go to Tools -> Log Viewer and confirm the warn no longer shows after
    applying the patch.
    
    Sponsored-by: Catalyst IT
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 8adb2f8003e25f6fe8cc78506a823a618a837fa1)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 7cf678b3211c5650f738b06ec24fc0cf7741ea2c
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Wed Dec 19 00:19:07 2018 +0100

    Bug 21545: Translate new ACCOUNT_PAYMENT and ACCOUNT_WRITEOFF notices to German
    
    To test:
    - Apply patch
    - Run the German web installer
    - Verify the sample notices installs without error
    - Verify it looks 'German' in the GUI :)
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 6b610497ffba5008f4e2541dc6cb07727ac5a63a)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit ca4d24c1e2bbc27b46e8b7ca3272b06a51a403a1
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Wed Dec 19 00:06:55 2018 +0100

    Bug 21545: Translate 'Stock rotation slip'
    
    Throwing in some capitalization fixes for the English
    version of the notice as well.
    
    To test:
    - Verify the changes make sense and the SQL is still valid
      and executes
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit bc1a21ec65377c8e7b331b89b45ebcddf9a7e4c7)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 09552018a9281a745f2d845bc150b882655ea313
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Dec 5 21:05:32 2018 +0000

    Bug 21957: Add a flag to ModBiblio to avoid linking auths if called from linker
    
    To test:
    1 - prove -v t/db_dependent/Biblio.t
    2 - Set BiblioAddsAuthoorities and AutoCreateAuthorities
    3 - Modify a biblio to add a heading with no existing auth record
    4 - Ensure the record was created on saving
    5 - Ensure that editing works as normal otherwise
    6 - Run link_bibs_to_authorities
    7 - Ensure results are as expected
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit e600ae6c4b125ee40ce80346ce15f954a1fa424d)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 7fd18db89def96f2b50e3ba4d89dcff97cca3c45
Author: Kris Sinnaeve <kris.sinnaeve at etf.edu>
Date:   Tue Apr 16 21:37:17 2019 +0000

    Bug 22139: Fields of ACCTDETAILS email not populating
    
    To test:
    * Make sure AutoEmailOpacUser is set to "send"
    * Create a new patron with a username and password, and an email address
    * In Kohadevbox, check the mail (usually you can type "mail" and go down
    to the last message) - these do not go into the message queue and they
    are processed immediately.
    notice that the email does not have
    <<borrowers.title>> <<borrowers.firstname>> <<borrowers.surname>>
    
    Apply this patch, restart the things, retest as above.
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 086a0007d2d484ecbd6ae6d60317ed4f0d3434b1)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 3e02dee64f8899e2dc141c85ff475c898187bfda
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Fri Apr 26 14:35:18 2019 +0100

    Bug 22461: (follow-up) Use `exists` not `defined`
    
    Prior to this patch there is a regression in the LDAP replication
    functionality such that clearing a field become impossible. This patch
    restores that functionality.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit b100fb160971242032eee104b70e7f8fc167f348
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Wed Apr 10 14:39:40 2019 +0100

    Bug 22461: Clarify and correct the hash reduction
    
    There were a couple of bugs in the previous patch which meant it wasn't
    working as intended. This patch corrects those bugs and simplifies the
    code a little along the way.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit c9fa30a55b585b3351ece9c3f789fd18d9807fac)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit ba28ac67c2280622a197b3c7a053eee8549e6194
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Mar 21 14:05:49 2019 -0300

    Bug 22461: Filter ldap mapping before inserting patron's info
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 4e40784f99f883a4f2634ed938764221d818096c)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit c1ef5545560ba1ad50f96db6514eb7a22507daca
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Mar 15 20:16:41 2019 -0300

    Bug 22461: Fix LDAP user replication
    
    From bug 20287:
    -        $borrowernumber = C4::Members::AddMember(%borrower) or die "AddMember failed";
    +        Koha::Patron->new( \%borrower )->store;
             C4::Members::Messaging::SetMessagingPreferencesFromDefaults( { borrowernumber => $borrowernumber, categorycode => $borrower{'categorycode'} } );
    
    $borrowernumber is not updated with the value of the newly created patron
    
    This patch restores the previous behavior (as well as the die)
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit d482c7b27257f5a63425633a17efed0747c317a1)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Auth_with_ldap.pm                                |    9 ++++++++-
 C4/Biblio.pm                                        |   12 +++++++-----
 .../data/mysql/de-DE/mandatory/sample_notices.sql   |    8 ++++----
 .../data/mysql/en/mandatory/sample_notices.sql      |    2 +-
 .../data/mysql/es-ES/mandatory/sample_notices.sql   |    2 +-
 .../mysql/fr-FR/1-Obligatoire/sample_notices.sql    |    2 +-
 .../mysql/nb-NO/1-Obligatorisk/sample_notices.sql   |    2 +-
 .../data/mysql/pl-PL/mandatory/sample_notices.sql   |    2 +-
 .../data/mysql/ru-RU/mandatory/sample_notices.sql   |    2 +-
 .../data/mysql/ru-RU/optional/sample_notices.sql    |    2 --
 .../data/mysql/uk-UA/mandatory/sample_notices.sql   |    2 +-
 members/memberentry.pl                              |    1 +
 misc/link_bibs_to_authorities.pl                    |    3 ++-
 t/db_dependent/Biblio.t                             |   19 ++++++++++++++++++-
 tools/viewlog.pl                                    |    2 +-
 15 files changed, 48 insertions(+), 22 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Fri Apr 26 17:07:03 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Fri, 26 Apr 2019 15:07:03 +0000
Subject: [koha-commits] main Koha release repository branch 18.11.x updated.
	v18.11.04-137-gb99fbdd
Message-ID: <E1hK2RL-0005ho-Uv@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  b99fbdd8fc85beb989a51142bb531673748bc344 (commit)
       via  04a27425cd71841f4d87c1247ae5be979b865dd8 (commit)
       via  9689a71e1f24d2c17adf3452f136d81d0bf14c13 (commit)
       via  2b8d3fb61d85c0824793fadaa8a37d88752f5b68 (commit)
       via  9109d862a08a53dd6328eed902dd4ed45de7f673 (commit)
       via  a85edfb2be449cf65691d1e4b32080310ac7aad2 (commit)
       via  4852f974f53886e8d7f771107eccc93dca3e0c99 (commit)
      from  8bd263601499ae1aa13587b37c62dfa27b4c7def (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit b99fbdd8fc85beb989a51142bb531673748bc344
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Apr 19 06:49:48 2019 +0000

    Bug 22735: Resolve internal server error on missing item type
    
    Trivial fix, similar to opac-detail, applied to ISBD and MARC detail.
    
    Test plan:
    Enable ArticleRequests pref.
    Make sure you have a biblio with no item type in 942c. (Perhaps you need to
    make 942c not mandatory temporarily and save a biblio record without this
    field being filled.)
    If you are logged in, log out.
    Go to MARC or ISBD detail page. No crash anymore?
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit b78bd2faec703bb7d7c750dbc1070ba2449f29a9)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 04a27425cd71841f4d87c1247ae5be979b865dd8
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Apr 18 16:35:03 2019 +0000

    Bug 22501: (follow-up) Use raw filter for course note on details page
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 22deca9445cb02320a04abb69febc9ef83d4d58f)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 9689a71e1f24d2c17adf3452f136d81d0bf14c13
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Thu Apr 11 10:32:52 2019 +0100

    Bug 22687: Typo correction for Portuguese manual link
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 38d68299ce7405823c50a6a41ac0f5d18b0b9044)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 2b8d3fb61d85c0824793fadaa8a37d88752f5b68
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Tue Mar 12 11:19:35 2019 +0000

    Bug 22174: Add link to help page for API key management
    
    Makes the help link on the API key management page point
    to the proper section in the Koha manual.
    
    To test:
    - Activate RESTOAuth2ClientCredentials system preference
    - Go to any patron account
    - Go to More > Manage API keys
    - Click on the Help link in top right corner
    - Verify that the right section of the Koha manual displays
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit b969ccbf97c218da2bf6e22ab7773baf36c4fa71)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 9109d862a08a53dd6328eed902dd4ed45de7f673
Author: Fr?d?ric Demians <f.demians at tamil.fr>
Date:   Mon Dec 3 18:02:03 2018 +0100

    Bug 21937: Syspref autoBarcode annual doesn't increment properly barcode
    
    This patch fix the barcode annual builder. The test should pass.
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 31ace6a9347a8260532f6cc50d55fc36f87f1b44)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit a85edfb2be449cf65691d1e4b32080310ac7aad2
Author: Fr?d?ric Demians <f.demians at tamil.fr>
Date:   Mon Dec 3 18:27:08 2018 +0100

    Bug 21937: Add test to show autoBarcode annual increment bug
    
    This patch show the issue. If the DB contains a barcode (not auto attributed
    by Koha) which begin with the year used to generate automatically a new one,
    there may be a 'collision'.
    
    prove -v t/db_dependent/Barcodes_ValueBuilder.t
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 7262bc066784247b12ce7f25c390498086e1d72b)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 4852f974f53886e8d7f771107eccc93dca3e0c99
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Tue Dec 27 17:07:20 2016 +0000

    Bug 15505: Mark Hold Items 'On hold' instead of 'Available'
    
    This patch adds a 'pending hold' column to C4::Items:GetItemsInfo to
    allow for displaying status of an item when it has been selected for a
    hold by the holdsqueue and AllowItemsOnHoldCheckout is set to 'Don't
    allow'
    
    To test:
    00 - Set AllowItemsOnHoldCheckout to 'Allow'
    01 - Place a hold on an item
    02 - Build the holdsqueue (kohadevbox example below)
          sudo koha-shell kohadev
          perl misc/cronjobs/holds/build_holds_queue.pl
    03 - Search for the item on the OPAC
    04 - Note item shows as 'Available' in results and details
    05 - Toggle AllowItemsOnHOldCheckout to 'Don't allow'
    06 - Repeat search, note there is no change
    06 - Apply Patch
    07 - Search for the item on the OPAC
    08 - Note that item now shows as 'Pending hold'
    09 - Toggle AllowItemsOnHoldCheckout to Allow
    10 - Note item shows as available
    11 - prove -v t/db_dependent/Items.t
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 170085397b23d9b688628a56039f5e485fade6a5)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Barcodes/ValueBuilder.pm                             |    2 +-
 C4/Items.pm                                             |    3 +++
 C4/XSLT.pm                                              |    7 +++++--
 Koha/Manual.pm                                          |    3 ++-
 .../prog/en/modules/admin/preferences/cataloguing.pref  |    4 ++--
 .../prog/en/modules/admin/preferences/circulation.pref  |    2 +-
 .../opac-tmpl/bootstrap/en/includes/item-status.inc     |    5 +++++
 .../bootstrap/en/modules/opac-course-details.tt         |    2 +-
 .../bootstrap/en/xslt/MARC21slim2OPACResults.xsl        |    6 ++++++
 opac/opac-ISBDdetail.pl                                 |    5 ++++-
 opac/opac-MARCdetail.pl                                 |    5 ++++-
 t/db_dependent/Barcodes_ValueBuilder.t                  |    6 ++++++
 t/db_dependent/Items.t                                  |   15 ++++++++++++++-
 13 files changed, 54 insertions(+), 11 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Fri Apr 26 17:33:02 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Fri, 26 Apr 2019 15:33:02 +0000
Subject: [koha-commits] main Koha release repository branch 18.11.x updated.
	v18.11.04-144-g461c717
Message-ID: <E1hK2qU-0006lb-8h@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  461c7176735cbfd4ed7db97a9fa094b60ac2e0ca (commit)
       via  1269f7d6c7712b3c9115824660d5f12933ba6462 (commit)
       via  5acddea685c665463aa0ca755962734a75700ecb (commit)
       via  4863e59c5798fda6883c354eeb5096d4609e42bd (commit)
       via  b2f9cfe4528ecd57b1cc45f602a578147b282cd5 (commit)
       via  376004638699aa8d1712ba24621280927c40822b (commit)
       via  49c99ced88af8d9d17d433c69322b862d30aee8a (commit)
      from  b99fbdd8fc85beb989a51142bb531673748bc344 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 461c7176735cbfd4ed7db97a9fa094b60ac2e0ca
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Apr 19 11:25:43 2019 +0000

    Bug 22743: Add password modal to overdrive results page
    
    This patch also removes a line abotu ratings which was throwing an error.
    Confirm stars rating for OD results are still shown as expected
    
    To test:
     1 - Enable overdrive circulation with password required
     2 - Sign in to OPAC but not overdrive
     3 - Perform a search that returns overdrive results
     4 - Click in to results page
         http://localhost:8080/cgi-bin/koha/opac-overdrive-search.pl?q=cats
     5 - Note 'Login to OverDrive account' link
     6 - Click it
     7 - Nothing happens!
     8 - Apply patch
     9 - Repeat
    10 - Success!
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 7be176cf1da5adb5f264bb9668667dfeb1d9a2ae)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 1269f7d6c7712b3c9115824660d5f12933ba6462
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Apr 19 09:28:35 2019 -0300

    Bug 22739: Test SelfCheckInTimeout <> 0, not just defined
    
    On sci-main.pl the preference value is tested for 'defined'. This patch
    tests it is different than empty string too. This was causing a
    JavaScript syntax error, that made it display a wrong message.
    
    To test:
    1 - Blank the syspref SelfCheckInTimeout
    2 - Attempt to checkin something via sci
    => FAIL: The 'Your request included no check-ins.' message is printed.
    3 - Apply this patch, reload the sci-main.pl page
    4 - Attempt to checkin something via sci
    => SUCCESS: The UI correctly stacks the scanned barcodes
    5 - Sign off :-D
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit c1949cda9b2847bc6ecf7e1dbc07990c4055b69a)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 5acddea685c665463aa0ca755962734a75700ecb
Author: Agustin Moyano <agustinmoyano at theke.io>
Date:   Tue Apr 23 00:50:49 2019 +0000

    Bug 16232: Fix edit as new in Rancor
    
    When you edit a biblio as new, and you have enabled advanced editor,
    current record was opened, and was overwritten when saved. This patch
    effectively opens a new record based on the one selected.
    
    To test:
    1) Enable "EnableAdvancedCatalogingEditor" preference
    2) Go to cataloguing and click on advanced editor to save preference to the cookie
    3) Search for an item in catalog
    4) Click in "Edit as new (duplicate)"
    5) Advanced editor should appear.
    CHECK => browser url ends with #catalog/{original biblionumber}
          => Title above toolbar is "Editing catalog record #{original biblionumber}"
    6) Apply this patch
    7) Repeat steps 3 to 5
    SUCCESS => browser url ends with #duplicate/{original biblionumber}
            => Title above toolbar is "Editing duplicate record of #{original biblionumber}"
    8) Save
    SUCCESS => browser url ends with #catalog/{new biblionumber}
            => Title above toolbar is "Editing catalog record #{new biblionumber}"
    9) Sign off
    
    Sponsored-by: Carnegie
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 680dd7f340ef445820864045127da9c65b3be0e2)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 4863e59c5798fda6883c354eeb5096d4609e42bd
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Wed Apr 17 13:58:57 2019 +0200

    Bug 22723: Correct syntax error on confess call in Koha/MetadataRecord/Authority.pm
    
    In Koha/MetadataRecord/Authority.pm the call to confess is missing string quotes.
    
    It may generates this error :
    
    Can't locate object method "confess" via package "Empty String at /usr/share/perl5/MARC/File/XML.pm line 448.
    " (perhaps you forgot to load "Empty String at /usr/share/perl5/MARC/File/XML.pm line 448.
    "?) at /home/koha/src/Koha/MetadataRecord/Authority.pm line 186.
    
    Simply missing double quotes.
    Also missing use Carp to call confess.
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 4e2c74fced685db861a78fc1aa151dd35ad0d5f2)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit b2f9cfe4528ecd57b1cc45f602a578147b282cd5
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Wed Apr 24 06:55:12 2019 +0000

    Bug 22753: Fix tabs pointed out by QA script
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 40cf22ab5f9dbdcaa37f46977fe5386a6303a42e)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 376004638699aa8d1712ba24621280927c40822b
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Tue Apr 23 18:03:33 2019 +0000

    Bug 22753: Fix hold priority adjustment, move to top
    
    Since the holds table can be split we need to calculate the
    first priority for each table. However, currently we use the
    first in the loop, not taking into account the waiting status.
    This patchset sets the first_priority to the first non-found hold
    
    Additionally, some clean-up is done to not display the alter
    priority arrows for waiting holds.
    
    To test:
    1 - Place several holds on a title
    2 - Confirm one of the holds to be waiting
    3 - Attempt to move the last hold to the top
    4 - Nothing happens
    5 - Apply patch
    6 - Note that the waiting hold has no options to move in the list
    7 - Attempt to move the last hold to the top
    8 - It moves as expected!
    9 - Split the holds queue by pickup library
    10 - PLace some holds for pickup at another branch
    11 - Confirm moving these holds works within their own table
    12 - Unsplit the queue
    13 - Ensure the holds end where you expect (moving in a split
         table didn't move above holds form another table)
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit eb956eb4cf3d44f45ad54be58fe95d7355a2b8bf)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 49c99ced88af8d9d17d433c69322b862d30aee8a
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Apr 24 00:09:44 2019 -0400

    Bug 22762: Fix items.collection display on receiving
    
    Caused by
      commit 31c29fd31f557306233e6a2936148a5bb10b89a1
      Bug 21206: Replace C4::Items::GetItem
    
    The log says: The method Koha::Item->collection is not covered by tests!
    
    It has highlighted an older problem:
    Since
      commit bb1e9c500c810402c64436c53bcc00ffb9a0b857
      Bug 17248 - Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib
    the "Collection code" is not filled correctly (items.collection vs items.ccode).
    
    Test plan:
    - Set acqcreateitem to "when placing an order"
    - Receive an order with items
    => The "Collection code" column must be filled with the items.ccode value
    - Edit an item
    - Change the collection code value
    => The "Collection code" column must be filled with the new value
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/MetadataRecord/Authority.pm                   |    3 +-
 acqui/orderreceive.pl                              |    2 +-
 catalogue/getitem-ajax.pl                          |    2 +-
 cataloguing/addbiblio.pl                           |    2 +-
 .../prog/en/includes/cateditor-ui.inc              |   15 ++++
 .../intranet-tmpl/prog/en/includes/holds_table.inc |   74 +++++++++++---------
 .../bootstrap/en/modules/opac-overdrive-search.tt  |    8 ++-
 opac/sci/sci-main.pl                               |    2 +-
 8 files changed, 69 insertions(+), 39 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Fri Apr 26 17:41:16 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Fri, 26 Apr 2019 15:41:16 +0000
Subject: [koha-commits] main Koha release repository branch 18.11.x updated.
	v18.11.04-150-g5b8ed9c
Message-ID: <E1hK2yS-00079o-As@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  5b8ed9cc0fbb7a9be0963ae10a45b5501d69d95f (commit)
       via  b1290c060253806b9186aba66bdf87fbc66a4ab2 (commit)
       via  6bf436065ebf93cbda4e67c05a238b0e63c22d42 (commit)
       via  05ffb6c6af451aa764f0cb4be1d712d7334f1167 (commit)
       via  61289c5e7806c720c2a2301cb9d9850fd0de94fd (commit)
       via  17b2811d519ed0f4c59bbaafd3194566515cee34 (commit)
      from  461c7176735cbfd4ed7db97a9fa094b60ac2e0ca (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5b8ed9cc0fbb7a9be0963ae10a45b5501d69d95f
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Apr 25 10:36:36 2019 +0000

    Bug 22339: DBRev 18.11.04.004
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit ed6228de83dc57e624c3b3dc30632775df972277)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit b1290c060253806b9186aba66bdf87fbc66a4ab2
Author: Ere Maijala <ere.maijala at helsinki.fi>
Date:   Thu Mar 14 13:31:34 2019 +0200

    Bug 22339: Fix search field mappings of MARC fixed fields
    
    Fixes handling of /0 selector in addition to several fixed field positions. Note that ff7-01-02 is in fact 00-01 in Zebra and that has been replicated here.
    
    Test plan:
    1. Before applying a patch, check from Elasticsearch (e.g. localhost:9200/koha_biblios/_search?q=_id:123) what is indexed in Elasticsearch for a record for date-entered-on-file, ff7-00, ff7-01, ff7-02 and lleader.
    2. Apply the patch, update database and save the record again.
    3. Verify that the contents of the forementioned fields is now correct in Elasticsearch.
    4. Verify that tests pass:  prove -v t/Koha/SearchEngine/Elasticsearch.t
    
    Signed-off-by: Bj?rn Nyl?n <bjorn.nylen at ub.lu.se>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 0047ede37e46a3334c9c47d7ebaed848907b6890)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 6bf436065ebf93cbda4e67c05a238b0e63c22d42
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Jun 8 12:19:41 2018 -0300

    Bug 20891: Escape html then JSON
    
    To my understanding we need to escape first html chars then to JSON.
    
    If this patch works we will need to rethink the 'To' TT plugin.
    It was originally designed to have several escape methods, but with
    these changes it will not make sense to name it 'To' if used only to
    escape JSON
    
    IIRC we should keep the 2 different ways to use it:
     * [% To.json( string ) %]
     * [% string | $To %]
    otherwise it will be hard to use it when called in argument of
    patron-title.inc (`git grep To.json`)
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit bdf0d85c1de9cbb37cc8a40b0b4a2e86633d3aaf)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 05ffb6c6af451aa764f0cb4be1d712d7334f1167
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Jun 7 12:17:26 2018 -0300

    Bug 20891: Escape list's names in JSON
    
    When someone uses \ in the description of a list, the datatable in staff
    won't load and keeps processing.
    
    Test plan:
    - Create a list named "<script>alert('hola');</script>"
    - Create another list named "k\o\h\a"
    - Hit /cgi-bin/koha/virtualshelves/shelves.pl
    
    => Without this patch the lists will not be displayed, JSON is
    malformated
    => With this patch everything is ok
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 2be0195895628ec491ee1f25368e60181c4f1eb2)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 61289c5e7806c720c2a2301cb9d9850fd0de94fd
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Apr 24 15:12:17 2019 +0000

    Bug 22650: Prevent multiple holds on individual items
    
    This patch corrects a missing id on the holds_to_place field and adds code to disable the box when an item is checked
    
    Additionally script login now places a single hold if an itemnumebr is passed and checks for holdability of the specific item
    
    To test:
     1 - Allow multiple holds per record in circ rules
     2 - In staff client, go to place a hold on a record
     3 - Select a patron
     4 - Increase the number of holds
     5 - Then select a specific item to hold
     6 - Patron now has multiple holds on a single item
     7 - Apply patch
     8 - Repeat, notice that count is disabled when item checked
     9 - Confirm count is enabled when 'Hold next available item' is checked
    10 - Set number to more than 1
    11 - Check an item and submit
    12 - Confirm only one item is reserved
    13 - Hit the script directly (with valid info):
         http://localhost:8081/cgi-bin/koha/reserve/placerequest.pl?biblionumber=1&checkitem=1&holds_to_place_count=2&borrowernumber=5
    14 - Confirm only one hold is placed
    15 - Confirm multiple hits of the url do not generate further holds
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit ef5adaff5ac045000b90c4b2b121d8c2ce2d5c59)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 17b2811d519ed0f4c59bbaafd3194566515cee34
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Tue Apr 16 17:21:01 2019 +0000

    Bug 19241: Waiting items show as available in the cart
    
    The cart uses the same item-status.inc that the details page uses, however, we don't
    set the waiting or reserved flags. This patch adds those flags to the script
    
    To test:
    1 - Find an item on the opac
    2 - Place a hold on the item
    3 - Check in the item to confirm the hold
    4 - Note the details page on OPAC shows 'On hold'
    5 - Add the item to a basket
    6 - Note the basket shows 'Available'
    7 - Apply patch
    8 - Check the cart, should show as 'On hold'
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit e2fa6d97ef45efb902086aa3a3d232137c054afa)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha.pm                                            |    2 +-
 Koha/SearchEngine/Elasticsearch.pm                 |    6 +--
 Koha/Template/Plugin/To.pm                         |    9 +++-
 admin/searchengine/elasticsearch/mappings.yaml     |   24 ++++-----
 installer/data/mysql/updatedatabase.pl             |   56 ++++++++++++++++++++
 .../prog/en/modules/reserve/request.tt             |    4 +-
 .../virtualshelves/tables/shelves_results.tt       |    4 +-
 opac/opac-basket.pl                                |    3 ++
 reserve/placerequest.pl                            |    9 ++--
 t/Koha/SearchEngine/Elasticsearch.t                |   14 ++++-
 10 files changed, 107 insertions(+), 24 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Fri Apr 26 17:53:41 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Fri, 26 Apr 2019 15:53:41 +0000
Subject: [koha-commits] main Koha release repository branch 18.11.x updated.
	v18.11.04-153-g84adcb4
Message-ID: <E1hK3AT-00087X-Fy@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  84adcb4017e7be038e5e32c37a6b40e4ab9f59c7 (commit)
       via  286f0f3947b9034ea4d60e86544a20579538839a (commit)
       via  e2aa81da2c96b3896c36914ee84e555e073f34f7 (commit)
      from  5b8ed9cc0fbb7a9be0963ae10a45b5501d69d95f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 84adcb4017e7be038e5e32c37a6b40e4ab9f59c7
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Mon May 28 16:45:29 2018 +0000

    Bug 20692: Extreme toggle checking for plack
    
    TEST PLAN
    ---------
    sudo koha-plack --disable
    sudo koha-plack --disable
    sudo koha-plack --enable
    
    sudo koha-plack --disable
    echo $?
    sudo koha-plack --disable
    echo $?
    sudo koha-list --noplack
    echo $?
    sudo koha-plack --enable
    echo $?
    sudo koha-plack --enable
    echo $?
    sudo koha-list --plack
    echo $?
    
    git bz apply 20692
    sudo perl ~/misc4dev/cp_debian_files.pl
    then repeat the test.
    
    It should also be noted, because the enable
    and disable are now split, if for some reason
    they become out of sync, an enable or disable
    should correct them.
    
    Because these are bash scripts, the test tool
    (/home/vagrant/qa-test-tools/koha-qa.pl)
    does not apply.
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit de20398db303a1ee45b62f9aa51f124597ed0cd8)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 286f0f3947b9034ea4d60e86544a20579538839a
Author: phette23 <phette23 at gmail.com>
Date:   Mon Apr 8 16:00:47 2019 -0700

    Bug 22551: Stray "//" appears at bottom of opac-detail.tt
    
    Removes a couple stray "//<![CDATA[" like comments which are artifacts of other
    code that since been removed. One of the comments causes two forward slashes to
    appear at the bottom of each OPAC detail page.
    
    Testing plan:
    
    - enable SocialNetworks
    - visit any OPAC detail page, observe "//" at bottom of page
    - apply patch
    - revisit page, slashes should be gone
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit eb8f5c86fe5f3e1e20bea73fa8b646cdc092513a)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit e2aa81da2c96b3896c36914ee84e555e073f34f7
Author: Ere Maijala <ere.maijala at helsinki.fi>
Date:   Tue Mar 5 11:04:55 2019 +0200

    Bug 22413: Improve query string and desc creation for Elasticsearch
    
    Test plan:
    
    After each of the following steps, verify that the results and query description looks ok.
    
    1. Do a simple keyword query
    2. Change sort order
    3. Click a facet
    4. Do an advanced search with title and author
    5. Change sort order
    6. Click a facet
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Marjorie <marjorie.barry-vila at collecto.ca>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit aba8b130f8b96e5000e8a1eccecfb53d7b371c30)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/SearchEngine/Elasticsearch/QueryBuilder.pm    |   26 ++++--
 debian/scripts/koha-functions.sh                   |   54 ++++++++++++-
 debian/scripts/koha-plack                          |   84 ++++++++++++++++++--
 .../opac-tmpl/bootstrap/en/modules/opac-detail.tt  |    6 --
 .../Koha/SearchEngine/Elasticsearch/QueryBuilder.t |   13 ++-
 5 files changed, 155 insertions(+), 28 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Fri Apr 26 18:16:17 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Fri, 26 Apr 2019 16:16:17 +0000
Subject: [koha-commits] main Koha release repository branch 18.05.x updated.
	v18.05.11-49-g8fbf85e
Message-ID: <E1hK3WL-0001PZ-J3@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  8fbf85efd2179495cc50e8ec3609c382fc010094 (commit)
      from  6ba72fb43b585ae2b2888dc3c50ada09014e86af (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 8fbf85efd2179495cc50e8ec3609c382fc010094
Author: Lyon3 Team <koha at univ-lyon3.fr>
Date:   Thu Apr 11 10:48:42 2019 +0200

    Bug 22652: Editing Course reserves is broken
    
    To test:
    1. Create a course reserve or go on an existing one
    2. Add items and add a change for the holdingbranch
    3. On the list of items in this course reserve
    (course_reserves/course-details.pl?course_id=xx), click on "edit" at the
    end of a row :
    
    Without the patch, you can't see the holdingbranch you have choose for
    this item, but you see "LEAVE UNCHANGED"
    
    With the patch, you can see the holdingbranch you have choose when
    adding this item in the course
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Mika?l Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit ba14e9ca7d40af664f7079c6a9f85a85e88fca9a)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 27209dea6666c490431aa56485771d8e36c0125a)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 .../intranet-tmpl/prog/en/modules/course_reserves/add_items-step2.tt |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Fri Apr 26 18:19:18 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Fri, 26 Apr 2019 16:19:18 +0000
Subject: [koha-commits] main Koha release repository branch 18.11.x updated.
	v18.11.04-157-gb61c41f
Message-ID: <E1hK3ZG-0001fE-Ap@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  b61c41f0efebac66d561070d5a3e4533354d90d0 (commit)
       via  07fc6e0c53512882534af0364c3bb741be20c179 (commit)
       via  310330590a14757ac3b35a2956ba56512ee65534 (commit)
       via  57a7cea7200f69966089b06c54e1482d4daae5ef (commit)
      from  84adcb4017e7be038e5e32c37a6b40e4ab9f59c7 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit b61c41f0efebac66d561070d5a3e4533354d90d0
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Apr 23 22:49:46 2019 -0400

    Bug 22621: Fix filters on subscription search results
    
    Caused by
      commit 4e698f7b478a094d7b32ebfeaa917bca05ebcc5b
      Bug 18426: Allow to edit subscriptions in batch
    
    There is a shift caused by a hidden column, which make the filters
    searching on the previous column.
    
    Test plan:
    - Add 1+ searchable additional field for subscription
    - Create a new subscription
    - Search for subscriptions
    - Use the column filters to filter the results
    => The results must be filtered accordingly
    
    Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 1d6e9ff44c19379a41e9ce688685a24788583e0c)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 07fc6e0c53512882534af0364c3bb741be20c179
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Wed Oct 17 14:43:11 2018 -0400

    Bug 21589: Series link formed from 830 field is incorrect
    
    Bug 13692 corrected the series link for records using a 490/800 combination
    
    When a record has a 490/830 conbination for series, the link is malformed (title is used as author, title is blank)
    
    Test Plan:
    1) Catalog two or more records with 830 fields
    2) Note the series links are broken
    3) Apply this patch
    4) Reload the record details page
    5) The series link should now work
    6) Repeat for the OPAC
    
    Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 20496bc78b7830d812fda454a0fe243fae9c465c)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 310330590a14757ac3b35a2956ba56512ee65534
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Apr 25 17:47:14 2019 +0000

    Bug 22715: Remove extraneous html filter
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 7e85754083bd66f45009f55a01e9dec9eda81504)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 57a7cea7200f69966089b06c54e1482d4daae5ef
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Tue Apr 16 10:34:56 2019 -0400

    Bug 22715: Searching for patrons with "" in the circulation note hangs patron search
    
    To replicate:
    Edit a patron to have a circ note, include quoted text in it, such as "this is quoted string"
    Go to the patron search, search for a set of results that would include the patron with the quotes in the note
    Enjoy looking at "Processing" for forever.
    
    Test Plan:
    1) Apply this patch
    2) Attempt to replicate using the steps above
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    I took this a step further and used <script>"something in
    quotes"</script> for my test note and this worked just fine. YAY.
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 6e641c5bcb7370556326fb64838fce1eefbc2c18)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 .../en/modules/members/tables/members_results.tt   |    2 +-
 .../prog/en/modules/serials/serials-search.tt      |   18 ++++++-----
 .../prog/en/xslt/MARC21slim2intranetDetail.xsl     |   33 +++++++++++++++++++-
 .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl    |   32 ++++++++++++++++++-
 4 files changed, 74 insertions(+), 11 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Fri Apr 26 20:12:11 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Fri, 26 Apr 2019 18:12:11 +0000
Subject: [koha-commits] main Koha release repository branch master updated.
	v18.11.00-1371-g5a63c5b
Message-ID: <E1hK5KV-0006Tc-Ef@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  5a63c5baa23c5f8b1fdd343995f360147f519d4b (commit)
       via  9b7a216c53e7874a44cc7e28fc23ffa3ee5ad9d2 (commit)
      from  90f8eb626d32694e3297a4cfe6566cbb9abe192b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5a63c5baa23c5f8b1fdd343995f360147f519d4b
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Apr 26 14:09:13 2019 -0300

    Bug 15496: (QA follow-up) Fix remaining cases
    
    This patch fixes remaining cases of the list => scalar change.
    
    To test:
    - Run:
      $ kshell
     k$ prove t/db_dependent/Holds/HoldFulfillmentPolicy.t t/db_dependent/Reserves.t
    => FAIL: Tests fail
    - Apply this patch
    - Run:
     k$ prove t/db_dependent/Holds/HoldFulfillmentPolicy.t t/db_dependent/Reserves.t
    => SUCCESS: Tests pass
    - Sign off :-D
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 9b7a216c53e7874a44cc7e28fc23ffa3ee5ad9d2
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Fri Apr 26 14:35:18 2019 +0100

    Bug 22461: (follow-up) Use `exists` not `defined`
    
    Prior to this patch there is a regression in the LDAP replication
    functionality such that clearing a field become impossible. This patch
    restores that functionality.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Auth_with_ldap.pm                         |    2 +-
 C4/Circulation.pm                            |    2 +-
 t/db_dependent/Holds/HoldFulfillmentPolicy.t |    2 +-
 t/db_dependent/Reserves.t                    |    2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Mon Apr 29 18:37:55 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Mon, 29 Apr 2019 16:37:55 +0000
Subject: [koha-commits] main Koha release repository branch master updated.
	v18.11.00-1397-g7de4511
Message-ID: <E1hL9Hv-00026T-4S@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  7de4511cef9c7204ff039356775ff3d59ceefc44 (commit)
       via  0ecd8c2f8cbe50407babed026a462e98592a3010 (commit)
       via  e5dbc76fff52c63695b3670667e73a95c3309402 (commit)
       via  b46312dde9bd70a24cf744eacb3beeb37cc880b4 (commit)
       via  d99d32d033935f09b7c361177ac4b43f08b8c14a (commit)
       via  29c687bff71c2530adeaaf2bdfbfa1ea565ba5e5 (commit)
       via  ffb432df7801498e2eefe9daaa19dbb563090716 (commit)
       via  c5a98ed3e1dff26a6e0c1482663891694ec7cf98 (commit)
       via  f98037ac53f74a664f7ea1bdbe63d884fd5f4c6f (commit)
       via  26a61c97f07a5a7354e1ae123f43d4cf13fbc5fb (commit)
       via  de47e59be5482d7d6e2611c3ceea0e42928404b2 (commit)
       via  968eea155e676ceaf89ad34a6cf9a90f6ae0e37d (commit)
       via  d51054c8b45a1c18a4e2bcf5272258a1ea523c8f (commit)
       via  e890cc42fda64b2bab3b0f26d66f5db60d2bdf4d (commit)
       via  aa75553c3a84b89ac433aa3e1809b9855853f4bc (commit)
       via  e9f0212f352c01b83c1505226587b5e4da2a115b (commit)
       via  7d4126e278b0b4949e89afdb683c091ed6c089f5 (commit)
       via  81a614a0f5f79e7d54e0febf6d9ded0595a92977 (commit)
       via  40f6822dc1b6abc3e2c1b0a408db4d52d9c42eb5 (commit)
       via  d559f93151ceaff3036d6f1fbe6666fb2075756f (commit)
       via  99b2b2b6a70a6059ce862f3f89275c8dce99bd95 (commit)
       via  9fff134de69e59c047f54c1536a69b759ee11ab8 (commit)
       via  dd4877706a378ab939ba9c6094c6a949b112864e (commit)
       via  c5647b4f6275b987e0c73c638de2b1b4d3c26015 (commit)
       via  64cc8f737b42870b26488c2f372c26cf298a15f1 (commit)
       via  3d022dc20ea34ba5fb2d37f7399b6d07be3cdea8 (commit)
      from  5a63c5baa23c5f8b1fdd343995f360147f519d4b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 7de4511cef9c7204ff039356775ff3d59ceefc44
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon Apr 29 12:16:59 2019 -0400

    Bug 8995: Compiled CSS
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 0ecd8c2f8cbe50407babed026a462e98592a3010
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon Apr 29 16:12:15 2019 +0000

    Bug 8000: DBRev 18.12.00.067
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit e5dbc76fff52c63695b3670667e73a95c3309402
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon Apr 29 16:09:00 2019 +0000

    Bug 8995: DBRev 18.12.00.066
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit b46312dde9bd70a24cf744eacb3beeb37cc880b4
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Thu Apr 25 10:39:14 2019 +0100

    Bug 8995: (QA follow-up) Convert db update to perl
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit d99d32d033935f09b7c361177ac4b43f08b8c14a
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Mon Mar 11 21:27:52 2019 +0000

    Bug 8995: (follow-up) Add tests, move open_url/coins routines to Koha namespace
    
    Test plan:
    1) Ensure the COinS span tag is still included on this pages. You need
    to look into html source and search for span tag with class 'Z3988',
       which has COinS string in title.
       Staff client:
           catalogue -> ISBDdetail
           catalogue -> MARCdetail
           catalogue -> detail
           virtualshelves -> shelves
        OPAC (you should have COinSinOPACResults system preference enabled):
            opac detail
            opac search
            opac shelves
    2) Run tests:
    prove t/Biblio.t t/db_dependent/Biblio.t t/db_dependent/Koha/Biblio.t
    
    Signed-off-by: Magnus Enger <magnus at libriotech.no>
    Tested with all 9 current patches. Works as advertised, including
    OPACURLOpenInNewWindow. If a record has no items, no OpenURL link
    is displayed. All the suggested tests pass. I did not test with
    XSLT turned off.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 29c687bff71c2530adeaaf2bdfbfa1ea565ba5e5
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Sep 28 13:18:12 2016 +0100

    Bug 8995: Add IGNORE to the INSERT statement
    
    Signed-off-by: Magnus Enger <magnus at libriotech.no>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit ffb432df7801498e2eefe9daaa19dbb563090716
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Wed Nov 6 16:04:42 2013 +0100

    Bug 8995: Show OpenURL links in OPAC search results
    
    This patch use GetCOinS sub to provide an OpenURL link in OPAC search
    results. It uses 4 new system preferences:
      - OpenURLinOPACResults: enable or disable this feature
      - OpenURLResolverURL: url of the openURL resolver
      - OpenURLText: text of the link
      - OpenURLImageLocation: image of the link
    
    Link is displayed as an image if OpenURLImageLocation is defined, and as
    text otherwise.
    It works both with and without XSLT enabled.
    
    Changes made to GetCOinSBiblio:
    
    For 'journal':
    - Title should be in rft.jtitle instead of rft.title
    - rft.date, rft.aulast, rft.aufirst, rft.au, rft.pub and rft.pages have
      no meaning for a subscription, so they are simply removed from URL
    
    This patch refactors GetCOinSBiblio, so the construction of URL is done
    only at the end. This way we do not have ugly
      $var .= "&amp;$value"
    in the function body.
    
    Also use URI::Escape instead of custom regexps.
    
    This development consider the value of syspref OPACURLOpenInNewWindow
    when building the link.
    
    Test plan:
    1/ Enable syspref OPACShowOpenURL and put your OpenURL resolver URL in
    OpenURLResolverURL syspref (if you don't have one, just fill it with
    some fake URL, you'll have to check if OpenURL links are correct)
    2/ If you want, set the other sysprefs OpenURLImageLocation and
    OpenURLText
    3/ Fill syspref OPACOpenURLItemTypes with some (not all) of your
    item types.
    4/ Empty sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay
    5/ Go to OPAC and launch a search.
    6/ Check you have in the results (near the title) the OpenURL link (only
    for itemtypes that are in OPACOpenURLItemTypes).
    Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of
    the link is correct.
    7/ Go to the detail page of one of those and check you have the OpenURL
    link too. (Above tags)
    Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of
    the link is correct.
    8/ Set sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to
    "default" and repeat steps 5 to 7
    
    Signed-off-by: Paola Rossi <paola.rossi at cineca.it>
    
    Signed-off-by: Magnus Enger <magnus at libriotech.no>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit c5a98ed3e1dff26a6e0c1482663891694ec7cf98
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Apr 26 09:05:01 2019 +0000

    Bug 8000: (QA follow-up) Two lastminute fixes
    
    [1] Number of tests Letters.t
    [2] Resolving uninitialized warn on Letters, L1327
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit f98037ac53f74a664f7ea1bdbe63d884fd5f4c6f
Author: Maryse Simard <maryse.simard at inlibro.com>
Date:   Tue Feb 5 18:26:42 2019 -0500

    Bug 8000: (QA follow-up) Add email validation to system preferences
    
    This patch uses the JQuery validator plugin to add validation to preferences of class email in the system preferences page. A field containing an invalid value (even if not modified) should prevent saving.
    
    To test, confirm that when entering an invalid email address in the SendAllEmailsTo field, an error message appears and saving is prevented.
    Correcting the value should hide the message and let you save as normal.
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 26a61c97f07a5a7354e1ae123f43d4cf13fbc5fb
Author: Maryse Simard <maryse.simard at inlibro.com>
Date:   Tue Feb 5 18:24:23 2019 -0500

    Bug 8000: (QA follow-up) Update the to_address in the message queue
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit de47e59be5482d7d6e2611c3ceea0e42928404b2
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Mon Oct 29 21:35:00 2018 +0000

    Bug 8000: (QA follow-up) Fix accidently edited sysprefs.sql file
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 968eea155e676ceaf89ad34a6cf9a90f6ae0e37d
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Mon Oct 29 12:58:51 2018 +0000

    Bug 8000: (QA follow-up) Centralise Bcc too
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit d51054c8b45a1c18a4e2bcf5272258a1ea523c8f
Author: David Bourgault <david.bourgault at inlibro.com>
Date:   Fri Sep 15 15:06:13 2017 -0400

    Bug 8000: Redirect all emails to SendAllEmailsTo
    
    Rebased and squashed after changes to master.
    Only difference from previous patches are small adjustements to conflicts in t/db_dependent/Letters.t
    
    Test plan:
    
    1) Apply path
    2) Run updatedatabase.pl
    3) Clear all SendAllEmailsTo system preference
    4) Send mail to a patron of your choosing, email will go to patron's
       email address as usual.
    5) Set SendAllEmailsTo to a test email address
    6) Send mail to the patron, email will be redirected to the email set
       in the systempreference.
    7) Run prove -v t/db_dependent/Letters.t
    
    It does not affect messages in the message_queue.
    
    This patch obsoletes previous patches, because it achieves the same
    functionality in a much more centralized way. (4 lines of code!)
    
    Signed-off-by: Ed Veal <eveal at mckinneytexas.org>
    Signed-off-by: BWS Sandboxes <ByWaterSandboxes at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit e890cc42fda64b2bab3b0f26d66f5db60d2bdf4d
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Mon Apr 15 10:05:28 2019 +0000

    Bug 20421: (follow-up) Fix styling
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit aa75553c3a84b89ac433aa3e1809b9855853f4bc
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Tue Mar 13 14:57:49 2018 +0000

    Bug 20421: Inform staff that patron does have the title checked out during placing hold
    
    Test plan:
    1) Enable the CheckPrevCheckout and DisplayMultiPlaceHold system preferences
    2) Have a patron with some checkouts history
    3) Try to place hold on one of titles from history for this patron
    4) You should see an information at the top of confirm request page, but
    you still should be able to place a hold
    5) Try this with multiple titles - one or more of them should be from
    history
    6) You should see this information in "Information" column
    7) There is also new column placed at the beggining with checkbox, you
    could uncheck it for titles you do not want to place a hold on it
    8) Confirm the hold is placed only on checked titles
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Bin Wen <bin.wen at inlibro.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit e9f0212f352c01b83c1505226587b5e4da2a115b
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Wed Apr 24 23:56:30 2019 +0200

    Bug 21502: (QA follow-up) Rephrase warning slightly
    
    Test plan:
    Follow first test plan, look at warning, decide if you like it :)
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 7d4126e278b0b4949e89afdb683c091ed6c089f5
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Tue Apr 23 12:25:52 2019 +0000

    Bug 21502: Add ItemsDeniedRenewal system preference to check syntax
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 81a614a0f5f79e7d54e0febf6d9ded0595a92977
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Fri Oct 5 13:48:07 2018 +0000

    Bug 21502: Add UpdateItemLocationOnCheckin preference to YAML format check
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 40f6822dc1b6abc3e2c1b0a408db4d52d9c42eb5
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Fri Oct 5 13:43:54 2018 +0000

    Bug 21502: Add check for YAML formatted system preferences to about page
    
    So far there are these yaml formatted preferences:
        UpdateNotForLoanStatusOnCheckin
        OpacHiddenItems
        BibtexExportAdditionalFields
        RisExportAdditionalFields
        UpdateItemWhenLostFromHoldList
        MarcFieldsToOrder
        MarcItemFieldsToOrder
    
    Test plan:
    1) Add some badly formatted YAML into some of preferences listed above
    2) Check the System information tab on About page for appropriate warnings
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit d559f93151ceaff3036d6f1fbe6666fb2075756f
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Tue Apr 23 11:46:24 2019 +0000

    Bug 22757: Add CodeMirror highlighting on more YAML formatted preferences
    
    Test plan:
    Go to system preferences and ensure the code highlighting is used on
    these preferences:
        UpdateNotForLoanStatusOnCheckin
        BibtexExportAdditionalFields
        RisExportAdditionalFields
        UpdateItemWhenLostFromHoldList
        MarcFieldsToOrder
        MarcItemFieldsToOrder
        ItemsDeniedRenewal
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 99b2b2b6a70a6059ce862f3f89275c8dce99bd95
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Wed Apr 24 08:02:32 2019 +0000

    Bug 21757: (follow-up) Fix number of columns in checkouts table footer template
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 9fff134de69e59c047f54c1536a69b759ee11ab8
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Thu Apr 18 08:37:38 2019 +0000

    Bug 21757: (folow-up) Restore patron brief detail page
    
    Test plan
    1) Try to create patron with same name/datefobirth to trigger the
    duplicate patron check
    2) Click on "View existing record" link on "Duplicate patron record?"
    alert message
    3) You should see the patron data, but withou toolbar, menu, and so on.
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit dd4877706a378ab939ba9c6094c6a949b112864e
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Fri Nov 2 17:40:45 2018 +0000

    Bug 21757: Clenup of moremember.pl and its templates
    
    This patch:
      - removes unused templates
      - use objects as much as possible
      - remove many template params
    
    Test plan:
    1) Apply the patch
    2) Play with patron detail page and try to broke it anyhow ;)
    - messaging preferences
    - enhanced attributes
    - guarantors and guarantees
    - fines
    - messages
    - checkouts
    - overdues
    - use different date formats, price formats and address formats
    - ... there is many thinks you could try with this one page ;)
    
    Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit c5647b4f6275b987e0c73c638de2b1b4d3c26015
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon Apr 29 11:55:58 2019 +0000

    Bug 22772: Compiled CSS
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 64cc8f737b42870b26488c2f372c26cf298a15f1
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Thu Apr 25 15:23:15 2019 +0000

    Bug 22772: Menu link hover color incorrect in OPAC language choosers
    
    This patch makes a few corrections to OPAC CSS to fix colors in the
    language menus.
    
    To test, apply the patch and rebuild the OPAC CSS.
    
    - Enable multiple languages in the OPAC, including more than one
      language "variation" (fr-FR, fr-CA).
    - Set the OpacLangSelectorMode preference to "both."
    - In the OPAC, test the language menu in both the header and footer.
      When you hover over the sub-menu items the background should be green
      and the text color white.
    - Perform the same test in the self checkout and self checkin
      interfaces.
    
    Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 3d022dc20ea34ba5fb2d37f7399b6d07be3cdea8
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Fri Apr 26 13:55:31 2019 +0000

    Bug 22537: Suspend all hold button appears even if the hold can no longer be suspended.
    
    This patch adds to the user summary page in the OPAC a check for waiting
    or in-transit holds. If all holds are waiting or in transit the "Suspend
    all" controls will be hidden.
    
    This patch also adds a missing $KohaDates filter to the "suspended
    until" date.
    
    To test, apply the patch and log in to the OPAC as a patron with holds.
    Test these conditions:
    
     - All holds are waiting and/or in transit
       - The "Suspend holds" controls at the bottom of the page should not
         appear.
     - Some holds are waiting and/or in transit
       - The "Suspend holds" controls should appear.
    
    Signed-off-by: Marjorie <marjorie.barry-vila at collecto.ca>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Biblio.pm                                       |  153 ----------------
 C4/Letters.pm                                      |   58 +++---
 C4/XSLT.pm                                         |   32 +++-
 Koha.pm                                            |    2 +-
 Koha/Biblio.pm                                     |  192 ++++++++++++++++++++
 Koha/Email.pm                                      |   10 +
 about.pl                                           |   26 +++
 catalogue/ISBDdetail.pl                            |    2 +-
 catalogue/MARCdetail.pl                            |    4 +-
 catalogue/detail.pl                                |    4 +-
 installer/data/mysql/sysprefs.sql                  |    6 +
 installer/data/mysql/updatedatabase.pl             |   27 +++
 .../prog/en/includes/blocked-fines.inc             |    4 +-
 .../prog/en/includes/checkouts-table-footer.inc    |    8 +-
 koha-tmpl/intranet-tmpl/prog/en/modules/about.tt   |   10 +-
 .../prog/en/modules/admin/preferences.tt           |    1 +
 .../en/modules/admin/preferences/acquisitions.pref |    2 +
 .../prog/en/modules/admin/preferences/admin.pref   |    5 +
 .../en/modules/admin/preferences/cataloguing.pref  |    2 +
 .../en/modules/admin/preferences/circulation.pref  |    3 +
 .../prog/en/modules/admin/preferences/opac.pref    |   29 +++
 .../prog/en/modules/members/moremember-brief.tt    |   92 +++++-----
 .../prog/en/modules/members/moremember-receipt.tt  |   78 --------
 .../prog/en/modules/members/moremember.tt          |   37 ++--
 .../prog/en/modules/reserve/request.tt             |   28 ++-
 .../intranet-tmpl/prog/js/pages/preferences.js     |   24 +++
 koha-tmpl/opac-tmpl/bootstrap/css/opac.css         |    2 +-
 koha-tmpl/opac-tmpl/bootstrap/css/sco.css          |    2 +-
 koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss |   23 ++-
 koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss    |    4 +
 .../bootstrap/en/includes/holds-table.inc          |   44 +++--
 .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl    |   49 +++++
 .../bootstrap/en/xslt/MARC21slim2OPACResults.xsl   |   51 +++++-
 .../bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl   |   50 +++++
 .../bootstrap/en/xslt/UNIMARCslim2OPACResults.xsl  |   49 +++++
 members/moremember.pl                              |  173 +++---------------
 opac/opac-detail.pl                                |    4 +-
 opac/opac-search.pl                                |   16 +-
 opac/opac-shelves.pl                               |    2 +-
 reserve/request.pl                                 |   18 +-
 t/Biblio.t                                         |    8 +-
 t/db_dependent/Koha/Biblio.t                       |   42 ++++-
 t/db_dependent/Letters.t                           |   13 +-
 virtualshelves/shelves.pl                          |    2 +-
 44 files changed, 848 insertions(+), 543 deletions(-)
 delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-receipt.tt


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Tue Apr 30 08:29:03 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Tue, 30 Apr 2019 06:29:03 +0000
Subject: [koha-commits] main Koha release repository branch 17.11.x updated.
	v17.11.17-7-gd1e8a21
Message-ID: <E1hLMGF-0003pK-0O@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 17.11.x has been updated
       via  d1e8a21bc39210075537c567ef83200812c75a10 (commit)
       via  26e0254dde080eb8b14a16c1324b9e2378e89922 (commit)
       via  ac7c0cd48dda4e431e9d2849cd23f06854e88f3a (commit)
       via  e993a966f3f929803a296a61789fca804d5b4274 (commit)
      from  1f80eac9616f582012c591989d96643b2bc52b82 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d1e8a21bc39210075537c567ef83200812c75a10
Author: Hayley Mapley <hayleymapley at catalyst.net.nz>
Date:   Thu Mar 14 04:14:57 2019 +0000

    Bug 19497: Removed title (tooltip) from Edit button in items_search_fields.tt
    
    This patch removes the tooltip that appears when hovering over the Edit button
    of Item Search Fields in the staff client. This was done for consistency reasons,
    including that this tooltip is not translated and tooltips do not appear to be
    on the majority of buttons in the staff client.
    
    Test plan:
    1) In Home->Administration->Item search fields create a new search field
    if you haven't got any already
    2) Observe the tooltip that appears when hovering over the Edit button in
    the Item serach fields table.
    3) Apply the patch and observe that the tool tip no longer appears.
    
    Sponsored-by: Catalyst IT
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 968c888e1579ab28ec165819a011612d8b8f5570)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 634400f05c625a0724172c82004fc6209717bde1)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit a0b6a894fec0d2a3a804f86e9fdd076137b8c26e)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 26e0254dde080eb8b14a16c1324b9e2378e89922
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Fri Mar 8 10:12:50 2019 +0100

    Bug 21049: Set 007/00 when selecting material type (Rancor)
    
    There is a 1-1 relationship between the material type values and the
    position 00 of 007 field. Selecting a material type should set this
    position's value.
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 856425db1e156ee4faf1aae70b0a78845711ba43)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 16e250542de43eadf62bc9354329912be84c3420)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit c8eee1b25761c5f3867fffc48c2e03ceab56e4ce)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit ac7c0cd48dda4e431e9d2849cd23f06854e88f3a
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Wed Mar 6 08:43:18 2019 +0100

    Bug 21049: Fix value of material select for Rancor 007 widget
    
    The material type is selected in accordance with position 0 of 007
    
    Test plan:
    1. Create a new record using the advanced editor
    2. Select a material type for field 007 and set at least the position 0
       of this field
    3. Save the record and reload the page
    4. The material type should remain selected
    5. Try with all available material types
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit e85294a738da7cce2a4897998ffa795f977b4cd7)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit d5aa7655a643a5a4868a47b8aae5371438993580)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit b25c4196b8174b375d8c13ccb8dee145c5d784b6)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit e993a966f3f929803a296a61789fca804d5b4274
Author: Lyon3 Team <koha at univ-lyon3.fr>
Date:   Thu Apr 11 10:48:42 2019 +0200

    Bug 22652: Editing Course reserves is broken
    
    To test:
    1. Create a course reserve or go on an existing one
    2. Add items and add a change for the holdingbranch
    3. On the list of items in this course reserve
    (course_reserves/course-details.pl?course_id=xx), click on "edit" at the
    end of a row :
    
    Without the patch, you can't see the holdingbranch you have choose for
    this item, but you see "LEAVE UNCHANGED"
    
    With the patch, you can see the holdingbranch you have choose when
    adding this item in the course
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Mika?l Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit ba14e9ca7d40af664f7079c6a9f85a85e88fca9a)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 27209dea6666c490431aa56485771d8e36c0125a)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit 8fbf85efd2179495cc50e8ec3609c382fc010094)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-----------------------------------------------------------------------

Summary of changes:
 .../intranet-tmpl/lib/koha/cateditor/widget.js     |    2 +-
 .../prog/en/includes/cateditor-widgets-marc21.inc  |   33 +++++++++++++++++++-
 .../prog/en/modules/admin/items_search_fields.tt   |    4 +--
 .../en/modules/course_reserves/add_items-step2.tt  |    2 +-
 4 files changed, 36 insertions(+), 5 deletions(-)


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Tue Apr 30 15:59:35 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Tue, 30 Apr 2019 13:59:35 +0000
Subject: [koha-commits] main Koha release repository branch master updated.
	v18.11.00-1407-gdd35242
Message-ID: <E1hLTIF-00047z-ME@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  dd352428bb4fe9c5656bdf4921f913440db259a2 (commit)
       via  1ad52b371d028e4ffd65bce0599dcc0f6a412465 (commit)
       via  1a44ce023e3c5dc0e8a547b8535c080602674c26 (commit)
       via  10faf56c8eac5d9e9c1c8bddd267460f72116284 (commit)
       via  9e6be55a06bc44450845199dc3db25b4021da7ef (commit)
       via  d0e6a26558be8338af52a723a2664111abcbe861 (commit)
       via  6e7b8f6f675d8657c431d6a899e6a47bb1049762 (commit)
       via  7a44c9edb969cd92db4de0223a2c9db06d576451 (commit)
       via  4ca1d8e3b3f60722321f9f4b5f1f0caa461beecb (commit)
       via  59b740613e7a72bf6e5283c2876bad9444a7ef6a (commit)
      from  7de4511cef9c7204ff039356775ff3d59ceefc44 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit dd352428bb4fe9c5656bdf4921f913440db259a2
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Mon Apr 29 15:10:17 2019 +0000

    Bug 22424: (follow-up) Show blank value for empty status
    
    This patch updates the screen and CSV output of item searches so that if
    the item does not have a lost status a blank table cell is shown instead
    of "0."
    
    This patch also amends the table headers so that "Not for loan" statuses
    are explicitly labeled as such, and the "Lost" column has the header
    "Lost status."
    
    To test, apply the patch and perform an item search in the staff client
    which will return results with notforloan and lost items. Verify that
    the values display correctly in both onscreen and CSV output. Verify
    that the column headers look correct.
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 1ad52b371d028e4ffd65bce0599dcc0f6a412465
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Wed Feb 27 15:31:29 2019 +0000

    Bug 22424: Add search by all lost statuses to item search
    
    This patch changes the item search form so that searching by lost status
    includes options for all lost authorised values instead of just "yes" or
    "no."
    
    To test you should have multiple authorized values for LOST.
    
     - Apply the patch and open the item search form.
     - Test searches which limit by lost status. Confirm that results are
       correctly limited.
     - Confirm that lost statuses are correctly displayed in the search
       results.
     - Confirm that in the search results table, the column header for
       "Lost" includes a dropdown menu for filtering by all available
       authorized values for lost.
     - Test the CSV export function and confirm that lost status is
       correctly exported.
    
    Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 1a44ce023e3c5dc0e8a547b8535c080602674c26
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Tue Apr 30 13:04:24 2019 +0000

    Bug 22408: Compiled CSS
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 10faf56c8eac5d9e9c1c8bddd267460f72116284
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Mon Feb 25 16:28:10 2019 +0000

    Bug 22408: Subscription entry form cleanup
    
    This patch makes a number of changes to the subscription entry form:
    
      - Make the default layout single-column.
      - Switch the layout to two-column only when testing prediction
        pattern.
        - Add a button to hide the prediction pattern test pane.
      - Change the style of some buttons and links. Add Font Awesome icons
        to some.
      - Clean up some issues with capitalization and spacing.
      - Make it clearer when form fields are read-only: Move "locked" form
        field style from addbiblio.css to staff-global.css and improve it
        with regard to mouse interactions
    
    To test, apply the patch and regenerate the staff client CSS. Clear your
    browser cache if necessary.
    
     - Go to Serials -> New subscription.
     - Readonly fields under "Vendor" and "Record" should show a small
       padlock icon.
     - Test the process of adding a subscription, paying special attention
       to the advanced pattern controls: Showing, hiding, modifying,
       canceling.
     - Test the process of editing a subscription in the same way.
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 9e6be55a06bc44450845199dc3db25b4021da7ef
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Sat Apr 27 13:42:17 2019 +0000

    Bug 21364: (QA follow-up) Fix QA script complaints (tabs and filters)
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit d0e6a26558be8338af52a723a2664111abcbe861
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon Apr 22 20:00:37 2019 +0000

    Bug 21364: (follow-up) Check for standing status and uncertain prices
    
    Fetch 'uncertainprices' when getting basket info. A side effect is that styling on baskets with uncertain prices is restored by this bug. They will appear in red
    
    To test:
    1 - Add an order with an uncertainprice to the basket
    2 - Return to vendor baskets view
    3 - Note the actions now include "Uncertain prices"
    4 - Click that, resolve the uncertain prcie
    5 - Return to vendor basket view
    6 - Note you can now close the basket, but don't
    7 - Edit the basket, mark it as standing
    8 - Return to vendor basket view
    9 - Note you cannot close the basket
    
    Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 6e7b8f6f675d8657c431d6a899e6a47bb1049762
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Sun Sep 16 03:05:59 2018 +0000

    Bug 21364: Allow closing basket from vendor view/search
    
    To test:
    1 - Have a vendor
    2 - Add some empty baskets
    3 - Add some non-empty baskets
    4 - Search for vendor and note you now
        a - Can only 'View' empty or closed baskets
        b - Have a dropup menu to 'Add to ' or 'Close' open baskets
    5 - Confirm things look correct and buttons work
    6 - Confirm that basket name is now a link to view basket
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 7a44c9edb969cd92db4de0223a2c9db06d576451
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon Dec 17 13:35:09 2018 +0000

    Bug 22010: Check preferences for ebook integration
    
    To test:
    1 - Enable OverDrive and RecordedBooks (you can put anything in the
            prefs)
    2 - Search on the opac - verify you get results (or search error) on
    first page of results'
    3 - Go to second page of results - OD and RB are not searched
    4 - Apply patch
    5 - Verify nothing has changed
    
    If you have valid credentials:
    1 - Enable RB prefs
    2 - Sign in with an account that has an email matching your registered
    account for recordedbooks
    3 - Confirm you RB account loads on opac-user.pl
    
    Otherwise:
    Read the patches, verify it all makes sense
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 4ca1d8e3b3f60722321f9f4b5f1f0caa461beecb
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Sun Apr 28 21:40:21 2019 -0400

    Bug 22357: Do not duplicate report rows if several reports exist
    
    At the moment every time you run runreport.pl with the --store-results
    option another line will appear for your report in the saved
    reports table. This is not a data, but a display problem as the
    report is still only stored once.
    
    1) Create a report and note the report number
    2) Run from command line (replace X by report number) :
        misc/cronjobs/runreport.pl X --format=csv --csv-header --store-results
    3) Go to saved reports table
    4) Look at the table, each run of the cronjob will create a new row
       in the table instead of just updating the saved results column.
    5) Apply patch
    6) Veriy the table displays correctly again and there are no regressions
    
    QA: Run t/db_dependent/Reports/Guided.t
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 59b740613e7a72bf6e5283c2876bad9444a7ef6a
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Apr 26 20:49:14 2019 -0400

    Bug 22717: (bug 20287 follow-up) Fix Google OpenId auto registration
    
    Silly bug caused by:
      commit ef410fd62f279a10687636a4f26babb2c91ecadc
      Bug 20287: Replace occurrences of AddMember with Koha::Patron->new->store->borrowernumber
    
    Constructors take a hashref!
    
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Acquisition.pm                                  |    3 +-
 C4/External/OverDrive.pm                           |   18 ---
 C4/Reports/Guided.pm                               |    3 +-
 catalogue/itemsearch.pl                            |   24 +++-
 koha-tmpl/intranet-tmpl/prog/css/addbiblio.css     |    1 -
 .../intranet-tmpl/prog/css/src/staff-global.scss   |   28 +++--
 koha-tmpl/intranet-tmpl/prog/css/staff-global.css  |    2 +-
 .../en/includes/catalogue/itemsearch_item.csv.inc  |    3 +-
 .../en/includes/catalogue/itemsearch_item.json.inc |    1 +
 .../includes/csv_headers/catalogue/itemsearch.tt   |    2 +-
 .../prog/en/modules/acqui/booksellers.tt           |   55 +++++----
 .../prog/en/modules/catalogue/itemsearch.tt        |   15 ++-
 .../en/modules/serials/showpredictionpattern.tt    |    4 +
 .../prog/en/modules/serials/subscription-add.tt    |  126 +++++++++++---------
 .../intranet-tmpl/prog/js/subscription-add.js      |   19 ++-
 .../bootstrap/en/includes/opac-bottom.inc          |    5 +-
 .../bootstrap/en/modules/opac-overdrive-search.tt  |    2 +-
 .../opac-tmpl/bootstrap/en/modules/opac-results.tt |    7 +-
 opac/opac-search.pl                                |    6 +-
 opac/svc/auth/googleopenidconnect                  |    4 +-
 opac/svc/overdrive_proxy                           |    2 +-
 t/External/OverDrive.t                             |   55 ---------
 .../Acquisition/GetBasketsInfosByBookseller.t      |   16 ++-
 23 files changed, 217 insertions(+), 184 deletions(-)
 delete mode 100755 t/External/OverDrive.t


hooks/post-receive
-- 
main Koha release repository

From gitmaster at git.koha-community.org  Tue Apr 30 17:06:56 2019
From: gitmaster at git.koha-community.org (Git repo owner)
Date: Tue, 30 Apr 2019 15:06:56 +0000
Subject: [koha-commits] main Koha release repository branch master updated.
	v18.11.00-1408-g7687151
Message-ID: <E1hLULQ-0006qP-1s@git.koha-community.org>

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  76871516050103f986e50034bccadd4b82fcd2d7 (commit)
      from  dd352428bb4fe9c5656bdf4921f913440db259a2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 76871516050103f986e50034bccadd4b82fcd2d7
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Tue Apr 30 11:37:47 2019 -0300

    Bug 8995: (QA follow-up) Mock required sysprefs in the tests
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/XSLT.pm              |    2 +-
 t/db_dependent/Search.t |    6 ++++++
 2 files changed, 7 insertions(+), 1 deletion(-)


hooks/post-receive
-- 
main Koha release repository