[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.08-19-g70e95a7

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  70e95a7dc6fd2b45dbebfc3427b9101414c6546d (commit)
      from  3dc0aa4293c8997d4660c710727ea0e2235887f4 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 70e95a7dc6fd2b45dbebfc3427b9101414c6546d
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Aug 13 12:55:55 2018 -0300

    Bug 21192: Do not pick SelfRegistration hidden fields for SelfModification
    
    There was a mix up between "modification" and "edit" for $action in
    opac-memberentry.pl.
    
    If a patron is logged into the OPAC and they attempt to submit changes to their
    personal details without having actually changed anything, the page reloads with
    a message stating 'No changes were made.' However, the fields that now appear
    are those that have been allowed/hidden according to the preferences set for
    patron self registration, even if patron self registration is disabled. This can
    lead to problems if there are discrepancies between the fields allowed for self
    register settings and those allowed for patron self modification settings.
    
    To replicate:
    
    1.) In Administration › System preferences > OPAC, set PatronSelfRegistration to
    'don't allow'
    
    2.) Modify the unwanted fields for PatronSelfModificationBorrowerUnwantedField
    and PatronSelfRegistrationBorrowerUnwantedField so that at least one field is
    different between the two settings and save (for example, specify 'mobile' to be
    hidden in the former, but don't include in the list of fields to be hidden in
    the latter).
    
    3.) Log into the OPAC and navigate to the 'your personal details' tab. Notice
    that the editable fields correspond to those not hidden by
    PatronSelfModificationBorrowerUnwantedField
    
    4.) Without making any changes, click on 'Submit update request'.
    
    5.) Note that on this page the fields correspond to those not hidden by
    PatronSelfRegistrationBorrowerUnwantedField and are now editable (including any
    fields that would otherwise be hidden by the Self Modification settings).
    
    Reported-By: Chris Slone <cslone at camdencountylibrary.org>
    Signed-off-by: Devinim <kohadevinim at devinim.com.tr>
    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit e0b1f945f9cdb4efd8b4403855cdc995023dc8be)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 63ebdb815987f0072587b7e3df5dc54cada1accd)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 opac/opac-memberentry.pl |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
main Koha release repository