[koha-commits] main Koha release repository branch 18.11.x updated. v18.11.13-18-g3f0b11ad41

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  3f0b11ad416403f8f44c4d03236d95d62ec404e2 (commit)
      from  d58a654129205f5f903abb805b9d0aae87844ba6 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 3f0b11ad416403f8f44c4d03236d95d62ec404e2
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Jan 14 10:02:11 2020 +0100

    Bug 22868: Move suggestions_manage subperm out of acquisition perm
    
    Bug 11911 replaced the permission of suggestions.pl (create a purchase
    suggestion) from catalogue => 1 to acquisition => 'suggestions_manage'.
    However we have a lot of acquisition scripts that have lax permissions
    (acquisition => '*' which means any sub permissions of acquisition is
    enough).
    
    That causes problem when a circulation staff can create purchase
    suggestions but not access acquisition information.
    
    One solution is to move the suggestions_manage subpermission out of the
    acquisition permission and create a new suggestion permission.
    
    Test plan:
    0. Setup
    * Create a patron with several permission (and full acquisition
    permission)
    * Create another patron with several permission, and suggestions_manage
    permission
    * Create another patron without the suggestions_manage permission
    1. Apply the patch and execute the update database entry
    2. Note that the third patron you create still does not have
    suggestions_manage
    3. Confirm that you can create a purchase suggestion if you have
    suggestions_manage, but cannot access acquisition pages if you do not
    have any subpermissions of the acquisition permission
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
    (cherry picked from commit 462db680242b4a6cbfb82b3469ebec8912e69af3)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit f0c60dfe6f53ef32b2046fdfd1e0732e1d89dd95)
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>

-----------------------------------------------------------------------

Summary of changes:
 installer/data/mysql/atomicupdate/bug_22868.perl      | 19 +++++++++++++++++++
 installer/data/mysql/userflags.sql                    |  3 ++-
 installer/data/mysql/userpermissions.sql              |  2 +-
 .../prog/en/includes/acquisitions-menu.inc            |  2 +-
 .../intranet-tmpl/prog/en/includes/circ-menu.inc      |  2 +-
 .../intranet-tmpl/prog/en/includes/permissions.inc    |  3 ++-
 .../intranet-tmpl/prog/en/modules/acqui/acqui-home.tt |  2 +-
 .../intranet-tmpl/prog/en/modules/intranet-main.tt    |  2 +-
 members/purchase-suggestions.pl                       |  2 +-
 suggestion/suggestion.pl                              |  2 +-
 10 files changed, 30 insertions(+), 9 deletions(-)
 create mode 100644 installer/data/mysql/atomicupdate/bug_22868.perl


hooks/post-receive
-- 
main Koha release repository