[koha-commits] main Koha release repository branch master updated. v19.11.00-297-gfbf326f

Fri Jan 10 17:48:19 CET 2020

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  fbf326f8573c74359f3b1914184d132e629d89c6 (commit)
       via  bed334ee4dd8e8f0ec5205c1faabdc1e40e00061 (commit)
       via  9c0dc6efffa35bb6ecaf579a9c63cfb3e04137eb (commit)
       via  73ce2a36856f2738f304d4212d918ba424896263 (commit)
       via  c470d9cb2ba44edc100aa775bc658550b81bb0eb (commit)
       via  6bba5a35c0d901b6b0f9d4c22dacd64b4fc428bb (commit)
       via  5a4ac1577b17dcb1eab32766b258059049b608a8 (commit)
       via  790f0ee5728493719bb63b89a5e3007a499b4bd0 (commit)
       via  fd5e488c2b3c12b13b96adda86598ada6da626fa (commit)
       via  24fe303be11af93199f8d881a04170484a5571e7 (commit)
       via  da2f9e7500b08f4a8f942617a2d10bef922b16ed (commit)
       via  8c6cb79f660921d8d3dd35dcdbaa2aff18e3820f (commit)
       via  1599fb92e99f02bccfb8b02561495f4f4de028e7 (commit)
       via  5eceeb1bc823eb3602de698b2938d75cddd69a6d (commit)
       via  553f5f1944ef7e5afa62d20166afbf91ea16595e (commit)
      from  b7bf4bd354bbba55a00ddebe166048dc5d33b4e2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit fbf326f8573c74359f3b1914184d132e629d89c6
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Mon Jun 17 16:09:38 2019 +0200

    Bug 22426: Map 'loc' to 'location' when building ES queries

    A search made on Shelving location tab in advanced search gives 0 result.

    Test plan :
    Without patch:
        - in advanced search, choose a location in shelving location tab and start search (opac-search.pl?idx=kw&op=and&idx=kw&op=and&idx=kw&do=Search&limit=mc-loc)
        - 0 result
        - check that location exist by doing a simple search and filtering on the    location facet
        - have some results
    With patch:
        - in advanced search, choose a location in shelving location tab and start search (opac-search.pl?idx=kw&op=and&idx=kw&op=and&idx=kw&do=Search&limit=mc-loc)
        - found results

    Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit bed334ee4dd8e8f0ec5205c1faabdc1e40e00061
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Sep 25 19:04:13 2019 +0000

    Bug 23676: Use 'false' for opac suppression

    To test:
     1 - Enable ES
     2 - Enable OpacSuppression
     3 - Suppress a bib in staff client
         Edit 942n to be 1
     4 - Search the opac for anything
     5 - Tail the plack logs and note a deprecation warning
     6 - Apply patch
     7 - Restart all the things
     8 - Repeat search on opac
     9 - No error/warn in logs
    10 - Record is correctly suppressed

    Signed-off-by: Myka Kennedy Stephens <mkstephens at lancasterseminary.edu>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 9c0dc6efffa35bb6ecaf579a9c63cfb3e04137eb
Author: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Date:   Fri Aug 31 15:32:20 2018 +0300

    Bug 17885: Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings throws DBD::mysql Duplicate entry exceptions

    When executing
    Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings()
    against populated search engine mappings tables, one gets this
    exception:

    DBD::mysql::st execute failed: Duplicate entry '388-73' for key
    'PRIMARY' [for Statement \"INSERT INTO `search_marc_to_field` ( `facet`,
    `search_field_id`, `search_marc_map_id`, `sort`, `suggestible`) VALUES (
    ?, ?, ?, ?, ? )\" with ParamValues: 0='', 1='73', 2='388', 3=undef,
    4=''] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line
    1834.\nDBIx::Class::Storage::DBI::_dbh_execute(): Duplicate entry
    '388-73' for key 'PRIMARY' at /home/koha/Koha/Koha/SearchField.pm line
    38"

    This patch fixes this, by first deleting all entries, then adding the
    default ones.

    If a subroutine says reset_elasticsearch_mappings(), I expect it to
    reset the elasticsearch mappings without errors.  When writing tests it
    is better to call that one subroutine reset_elasticsearch_mappings
    instead of the bunch of code in
    admin/searchengine/elasticsearch/mappings.pl?op=reset_confirmed
    Also this promotes code reuse.

    TEST PLAN:

    a. perl -e 'use Koha::SearchEngine::Elasticsearch; Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings'
    b. Run misc/devel/populate_db.pl on an already populated DB and you eventually
    face this problem.

    After this patch, step a. works.

    This patch is adapted from the original patch made by Olli-Antti
    Kivilahti <olli-antti.kivilahti at jns.fi>.

    Signed-off-by: Johanna Raisa <johanna.raisa at gmail.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 73ce2a36856f2738f304d4212d918ba424896263
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Oct 31 13:52:05 2019 -0400

    Bug 23934: Item level holds not checked for LocalHoldsPriority in Holds Queue

    Test plan:
    - Set LocalHoldsPriority to "Give priority for filling holds to patrons
    whose pickup library matches the item's holding library"
    - set yourself at Library A
    - find at item at Library A
    - place an item-level hold (Hold 1) for item for pickup at Library B
    - set an item-level hold (Hold 2) for item for pickup at Library A
    - Confirm Hold 1 shows priority=1
    - Check in item
    - confirm item would be captured for Hold 2, ignore hold
    - run holds queue
    - check item in
    - confirm item is captured for Hold 2

    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit c470d9cb2ba44edc100aa775bc658550b81bb0eb
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Oct 31 13:51:33 2019 -0400

    Bug 23934: Unit test

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 6bba5a35c0d901b6b0f9d4c22dacd64b4fc428bb
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Tue Dec 31 10:30:32 2019 +0100

    Bug 15142: (follow-up) Remove facet configuration from .xsl file

    Removes last remaining bit of configuration for the Titles facet
    configuration.

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 5a4ac1577b17dcb1eab32766b258059049b608a8
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Tue Nov 26 09:44:08 2019 +0100

    Bug 15142: (follow-up) remove from Zebra UNIMARC config files

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 790f0ee5728493719bb63b89a5e3007a499b4bd0
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Fri Nov 22 15:16:51 2019 +0100

    Bug 15142: Remove titles facet for UNIMARC

    There is a facet using 500$a, 501$a and 503$a and Subject index.
    In UNIMARC 500$a, 501$a and 503$a are not indexed as Subject.
    I propose to remove this facet for UNIMARC, looks like it does not make
    sens.

    Test plan:
    1) Install UNIMARC database
    2) Edit some records to have 500$a
    3) Perform a search to find those records
    4) Check you dont see the titles facet

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit fd5e488c2b3c12b13b96adda86598ada6da626fa
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Jan 2 18:06:20 2020 +0000

    Bug 9156: Clarify order in the syspref

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 24fe303be11af93199f8d881a04170484a5571e7
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Dec 19 19:05:36 2019 +0000

    Bug 9156: (follow-up) Simplify code

    The MARC::Field as_string method can join multiple subfield using a delimiter, this simplifies the code here

    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit da2f9e7500b08f4a8f942617a2d10bef922b16ed
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue Nov 19 14:56:05 2019 +0000

    Bug 9156: itemcallnumber not pulling more than 2 subfields

    When the itemcallnumber system preference is defined, the item add form
    pulls data from the specified tag and subfield(s) to pre-populate the
    call number field. This update makes it possible to build the
    prepopulated callnumber from more than just the first two subfields.

    To test, apply the patch and update the itemcallnumber system preference
    so that it includes more than two subfields. For instance, "092abef"

     - Edit a bibliographic record and populate the specified subfields.
       e.g. subfield a -> "One", b-> "Two", e-> "Three", f-> "Four".
     - Save the record and go to the add/edit items screen.
     - The call number field should contain a string which contains each of
       the subfields you populated, concatenated with spaces: "One Two Three
       Four."
     - Test with other numbers of subfields.
     - Test with an empty itemcallnumber preference.

    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 8c6cb79f660921d8d3dd35dcdbaa2aff18e3820f
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Fri Jan 10 16:11:56 2020 +0000

    Bug 24206: DBRev 19.12.00.008

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 1599fb92e99f02bccfb8b02561495f4f4de028e7
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Sun Dec 22 13:07:46 2019 +0000

    Bug 24206: Update content of OpacSearchForTitleIn for existing installations

    This includes a database update for existing installations.
    Using the REPLACE function it makes the same changes to the URLs
    as the previous patch did for new installations:

    - Worldcat: now https
    - BookFinder: now https
    - OpenLibrary: remove / before search parameters

    To test:
    - Verify the current content of your preference OpacSearchForTitleIn
      (without changes from first patch!)
    - Run the database update
    - Verify everything still works, but changes have been made

    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 5eceeb1bc823eb3602de698b2938d75cddd69a6d
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Sun Dec 22 13:05:34 2019 +0000

    Bug 24206: Update URLs for default options in OPACSearchForTitleIn

    - Worldcat: now https
    - BookFinder: now https
    - OpenLibrary: remove / before search parameters

    To test:
    - Verify changes to the installer files are correct
    - Bonus: run the web installer for en, de-DE and nb-NO and
      verfiy the content of OPACSearchForTitleIn is correct

    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 553f5f1944ef7e5afa62d20166afbf91ea16595e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Jan 6 23:08:55 2020 +0100

    Bug 24358: (bug 21232) Make the alert string translatable

    "Bibliographic record does not exist!" was not translatable as it was
    defined in the .js file

    Test plan:
    Repeat test plan from bug 21232

    Bonus point: update and install a localized version and confirm that the
    message is translatable

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/HoldsQueue.pm                                   |    1 -
 C4/Koha.pm                                         |    6 -
 Koha.pm                                            |    2 +-
 Koha/SearchEngine/Elasticsearch.pm                 |    3 +
 Koha/SearchEngine/Elasticsearch/QueryBuilder.pm    |    3 +-
 admin/searchengine/elasticsearch/mappings.pl       |    2 -
 cataloguing/additem.pl                             |   12 +-
 .../unimarc/biblios/biblio-koha-indexdefs.xml      |    9 -
 .../unimarc/biblios/biblio-zebra-indexdefs.xsl     |   21 --
 .../mysql/de-DE/mandatory/system_preferences.sql   |    4 +-
 .../nb-NO/1-Obligatorisk/system_preferences.sql    |    2 +-
 installer/data/mysql/sysprefs.sql                  |    2 +-
 installer/data/mysql/updatedatabase.pl             |   10 +
 .../en/modules/admin/preferences/cataloguing.pref  |    2 +-
 .../prog/en/modules/serials/subscription-add.tt    |    1 +
 .../intranet-tmpl/prog/js/subscription-add.js      |    4 +-
 t/db_dependent/HoldsQueue.t                        |  229 ++++++++++++++++++--
 17 files changed, 237 insertions(+), 76 deletions(-)

hooks/post-receive
-- 
main Koha release repository