[koha-commits] main Koha release repository branch master updated. v20.05.00-406-gbc1b76be4a

Mon Jul 27 17:54:27 CEST 2020

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  bc1b76be4a35403239fbce6f349ee343435cc8a0 (commit)
       via  40b6e1b8a1a6e74cb4e9a1c422ffa4faa0bdefc0 (commit)
       via  0ec7ba72861f21c2ce83d3a98446af7db7a3e321 (commit)
       via  e025cd76437b212746717ad54b5da22e410bbe8f (commit)
       via  028e9a07db625845482eff1b550a9bbe86ec6fbc (commit)
       via  330c51c272d38831d1ba27ee39bd5ec2344b767a (commit)
       via  6fa926be88294bf8e14588dac0134eab506fdecb (commit)
       via  f8e73978a246780296a304164e551f66430a2d8a (commit)
       via  2a57e3d3db5cf7680a7e199b3c9b26d2e6bb3abc (commit)
       via  b38546f1d150edaf85180d4be2aa68df42674f27 (commit)
       via  757510c84c4427fb6a68c7d9bc1825c0a26a82cd (commit)
       via  fcd659b2d4cf62df48113567c59392e8dff9696f (commit)
      from  b4f3a0f0a6e813716b7f3995e69998f3abf5cc1d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit bc1b76be4a35403239fbce6f349ee343435cc8a0
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Wed Sep 18 10:28:33 2019 -0400

    Bug 23086: Search for collection is broken

    It appears that we are quoting the ccode values deep in the search code.
    Under ICU chains this breaks searching by limits

    To recreate
     1 - Setup Koha using Zebra and icuchains
     2 - Add ccode to AdvancedSearchTypes
     3 - In koha-conf.xml set zebra debug level to include request
      <zebra_loglevels>none,fatal,warn,request,info</zebra_loglevels>
     4 - Set some items into different ccodes
     5 - On opac perform a search for:
        ccode:NFIC
     6 - It works
     7 - tail -n 50 /var/log/koha/kohadev/zebra-output.log
     8 - Note search request like:
        Search biblios OK 26 1 1+0 RPN @attrset Bib-1 @attr 1=8009 NFIC
     9 - On opac go to advanced search, select Collection, and limit to smae code a s above
    10 - No results
    11 - Check the zebra-output.log:
        Search biblios OK 0 1 1+0 RPN @attrset Bib-1 @attr 1=8009 'NFIC'
    12 - Apply patch
    13 - Restart all
    14 - Repeat search by collection limit
    15 - Success!
    16 - Check the zebra-output.log:
        Search biblios OK 0 1 1+0 RPN @attrset Bib-1 @attr 1=8009 NFIC
    17 - Add a new ccode value: N)N
    18 - Set some items to that ccode
    19 - Confirm searching by that ccode works

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 40b6e1b8a1a6e74cb4e9a1c422ffa4faa0bdefc0
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Jul 15 15:33:18 2020 +0000

    Bug 23086: Unit test

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 0ec7ba72861f21c2ce83d3a98446af7db7a3e321
Author: Lucas Gass <lucas at bywatersolutions.com>
Date:   Mon Jul 6 20:38:42 2020 +0000

    Bug 25940: Check for reserve_id before Dopop

    TEST PLAN:
    1. Have an item belonging to a different branch and check it in.
    2. When the modal pops up hit 'Yes, print slip' or 'Print slip' if  AutomaticItemReturn is set to 'don't'
    3. The first print dialog should appear with a URL like '/cgi-bin/koha/circ/transfer-slip.pl?transferitem=18&&branchcode=CPL&op=slip'
    4. Close that print dialog and you will immediately see another one that says 'No slip template found'.
    5. Notice the URL of the second pop-up is:  /cgi-bin/koha/circ/hold-transfer-slip.pl?reserve_id=
    6. There is no reserve id so the template is not found.
    7. Apply patch
    8. Repeat 1-6
    9. You should no longer have two print dialogs

    Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit e025cd76437b212746717ad54b5da22e410bbe8f
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Jun 12 10:51:36 2020 +0000

    Bug 25724: Do not call ModReserveStatus when completing transfer

    I can not see how this code is useful here. It checks for a reserve with priority 0 and found = NULL
    That is not a status that should occur when filling a transfer. Either the found is 'T' if we are transferring due
    to the hold, or the hold was placed after the transfer was initiated, and so the priority is not 0

    Additional, AddReturn checks for reserves later and asks the staff to confirm waiting status.

    ModReserveStatus also calls CartToShelf regardless of what happens here.

    To test:
    1 - Set  UpdateItemLocationOnCheckin  to:
        _ALL_: CART
    2 - SetAutomaticItemReturn = Do
    3 - Check an item in at a different branch than it's homebranch to create a transfer
    4 - Check the item in at it's homebranch
    5 - View the item details page
    6 - Item is not in CART location
    7 - Apply patch
    8 - Repeat
    9 - Item is in CART location after completion of transfer

    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

    Signed-off-by: Jason Robb <jrobb at sekls.org>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 028e9a07db625845482eff1b550a9bbe86ec6fbc
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Jun 12 11:11:26 2020 +0000

    Bug 25724: Unit tests

    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

    Signed-off-by: Jason Robb <jrobb at sekls.org>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 330c51c272d38831d1ba27ee39bd5ec2344b767a
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Fri Jul 24 07:26:14 2020 -0400

    Bug 24279: Disable editing lost status in items editor if item is a return claim

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 6fa926be88294bf8e14588dac0134eab506fdecb
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Tue May 26 07:27:28 2020 -0400

    Bug 24279: Disable lost status select if item has a return claim

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit f8e73978a246780296a304164e551f66430a2d8a
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu May 7 12:33:17 2020 +0200

    Bug 24279: Display the tip in the title of the option

    This patch tells select2 to retrieve the title attribute from the
    original option node.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 2a57e3d3db5cf7680a7e199b3c9b26d2e6bb3abc
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Apr 23 09:04:25 2020 -0400

    Bug 24279: (QA follow-up) Show values disabled with tooltips

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit b38546f1d150edaf85180d4be2aa68df42674f27
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Mon Dec 30 08:04:29 2019 -0500

    Bug 24279: Claims Returned does not work when set from additem.pl

    Test Plan:
    1) Configure Claimes Returned
    2) Apply this patch
    3) Go to additem.pl for that item
    4) Note the claims returned lost status does not show in the lost status pulldown

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 757510c84c4427fb6a68c7d9bc1825c0a26a82cd
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Mon Dec 30 07:51:23 2019 -0500

    Bug 24279: Claims Returned does not work when set from moredetail.pl

    Test Plan:
    1) Configure Claimes Returned
    2) Apply this patch
    3) Go to moredetail.pl for that item
    4) Note the claims returned lost status does not show in the lost status pulldown

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit fcd659b2d4cf62df48113567c59392e8dff9696f
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Jul 27 15:15:44 2020 +0200

    Bug 25729: Prevent Charges/Fees.t to fail on slow server

    We must use t::lib::Dates::compare to compare dates

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm                                  |  2 --
 C4/Search.pm                                       |  3 +--
 cataloguing/additem.pl                             | 26 +++++++++++++++++-----
 .../intranet-tmpl/prog/en/includes/select2.inc     |  3 +++
 .../prog/en/modules/catalogue/moredetail.tt        | 17 +++++++++-----
 .../prog/en/modules/cataloguing/additem.tt         |  8 +++++--
 .../intranet-tmpl/prog/en/modules/circ/returns.tt  | 17 +++++++-------
 t/db_dependent/Circulation/issue.t                 | 12 +++++++++-
 t/db_dependent/Koha/Charges/Fees.t                 |  3 ++-
 t/db_dependent/Search.t                            |  8 ++++++-
 10 files changed, 70 insertions(+), 29 deletions(-)

hooks/post-receive
-- 
main Koha release repository