[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.11-7-gba884d407a

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.05.x has been updated
       via  ba884d407a4b7ac858b68b4958e3f234e1b616da (commit)
       via  015cc7d4fe81804388dfedd166c0fde5f43b4295 (commit)
      from  0f817f4da9439255850f583ba80cb1f0876967a0 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit ba884d407a4b7ac858b68b4958e3f234e1b616da
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon May 11 10:08:36 2020 -0300

    Bug 24458: Regression tests
    
    This patch introduces tests for searchResults. The idea is to set a
    subfield as hidden in OPAC and another on the staff interface, and see
    if searchResults honours this on the XSLTResultsRecord contents.
    
    To test:
    1. Apply this patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Search.t
    => FAIL: This is not really implemented
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
    
    (cherry picked from commit 448915cc3d8dcd92ce93736bea09a5a0a113dc03)

commit 015cc7d4fe81804388dfedd166c0fde5f43b4295
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon May 11 10:10:39 2020 -0300

    Bug 24458: Use the ViewPolicy filter on search results
    
    This patch implements the use of the ViewPolicy record processor filter
    inside C4::Search::searchResults. The idea is that the $record_processor
    is instantiated once and reused inside the loop. This leaves options for
    further optimizations I will do on a follow-up bug.
    
    The filter is applied to the MARC data before it is passed to the XSLT
    processor.
    
    To test:
    1. Apply the regression tests patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Search.t
    => FAIL: This is not implemented, tests fail
    3. Apply this patch
    4. Repeat 2
    5. Feel the joy in your body from a long standing bug being solved
    6. Sign off :-D
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
    
    (cherry picked from commit e78231f3f63ed49fc65ac653e57159a8aba7fbe2)

-----------------------------------------------------------------------

Summary of changes:
 C4/Search.pm            | 11 +++++++++++
 t/db_dependent/Search.t | 50 ++++++++++++++++++++++++++++++++++++++++++++++++-
 2 files changed, 60 insertions(+), 1 deletion(-)


hooks/post-receive
-- 
main Koha release repository