[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.06-27-gf1ca5b7473

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.11.x has been updated
       via  f1ca5b7473575b9c2ec13ba272fa99d044c4d990 (commit)
       via  974749935d349646d6ac0525a4cd80fabd1521a0 (commit)
       via  30b8235474db5ae8fa49fb59a8099415c6935dc2 (commit)
      from  35a82df24c380861b33ccbacc95cb8645db431d1 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit f1ca5b7473575b9c2ec13ba272fa99d044c4d990
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Thu Mar 19 17:04:31 2020 -0300

    Bug 24909: Add unprivileged route to get a bibliographic record
    
    This patch adds a route to get bibliographic records without privileged
    access. This needs to match the OPAC expected behaviour.
    
    Some things were considered on the implementation:
    - The ViewPolicy filter that hides/shows things based on the frameworks
      needded to be used, as in the OPAC.
    - OpacHiddenItems and OpacHiddenItemsExceptions need to be considered
      for hiding records the same way the OPAC is expected to.
    - Avoid using OpacHiddenItemsExceptions, but rely on the patron category
      instead (use Koha::Patron::Category->override_hidden_items abstraction
      is used instead so it should keep working once 22547 is moved
      forward).
    - Tests should cover all the use cases:
      * logged in user
      * anonymous user
      * logged in with category that overrides
      * logged in with category that doesn't override
    
    This is all implemented on the tests.
    
    To test:
    1. Apply the tests patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/api/v1/biblios.t
    => FAIL: Route not implemented
    3. Apply the rest of the patches
    4. Repeat 2
    => SUCCESS: Tests pass!
    5. Try it with your favourite API tool (Postman?)
    6. Sign off :-D
    
    Note: please notice there isn't a default fallback behaviour for when
    you don't specify the Accept header, so testing this on a regular
    browser will just print the accepted mime types instead of the record
    itself.
    
    To test this with a tool (like Postman) you should enable
    RESTBasicAuthe and make the tool use Basic authentication with valid
    credentials. And you need to specify any of the following strings on the
    Accept header:
    - application/marcxml+xml
    - application/marc-in-json
    - application/marc
    - text/plain
    
    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit b97158dd1342ea060a29297df3d691f05065c227)
    
    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

commit 974749935d349646d6ac0525a4cd80fabd1521a0
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Thu Mar 19 17:03:53 2020 -0300

    Bug 24909: Route spec
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 572f486697c18337ea6bb804a0b624e9c8912744)
    
    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

commit 30b8235474db5ae8fa49fb59a8099415c6935dc2
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Thu Mar 19 17:03:23 2020 -0300

    Bug 24909: Unit tests
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 9c66f9f320eab62cb7a0440fc6fc02142558eb1d)
    
    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/REST/V1/Biblios.pm           |  99 +++++++++++++++++++++++++-
 api/v1/swagger/paths.json         |   3 +
 api/v1/swagger/paths/biblios.json |  65 ++++++++++++++++++
 t/db_dependent/api/v1/biblios.t   | 141 +++++++++++++++++++++++++++++++++++++-
 4 files changed, 305 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
main Koha release repository