[koha-commits] main Koha release repository branch master updated. v20.05.00-1755-gebb437349e
Git repo owner
gitmaster at git.koha-community.org
Fri Nov 6 16:27:49 CET 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via ebb437349ebbadf90599c23a46126e5d8eda72da (commit)
via 76c95e585d7470905701ee469b1042474fce0604 (commit)
via 234768752fd7448fcafe69d54772507c3492a6c3 (commit)
via d1bc1015d9b61b4e9b67fd751e05275548d59f46 (commit)
via 1deb47e793b6b3c146839e9d5fc29ff535fd13a2 (commit)
via 8bd02f991942e307a8603304ffd29d8eb42343c4 (commit)
via 671b013961037ab535693c2edce2eabb0fe0f128 (commit)
via 1527fbd4ae3131611957a8d320f0890396b3d27f (commit)
via 7d93405e599a4840f75a9a0fde8884f4f14ff4d9 (commit)
via 0c6faea274318fd96311d91db28421f3886cb2db (commit)
via d643bf75a032fddc4d7cefb8489182ae13b899a5 (commit)
via 1008e21d430177ebf41f6a22ba29299228dba949 (commit)
via b59799f298aab7b04547bcd7c29a2777e015a106 (commit)
via e7d4bacfc67af5eaae7c477b2ac71753c76778ce (commit)
via 7a07e111288de820e535dd35c024917d141129ad (commit)
via ed0df15f5094c5cf5462488fd0aac48ddd613b35 (commit)
via 2f7d2e327cb8631e2f1099a2169f439acc42da94 (commit)
via c0830466c120ba9e0551cc40995b94e3c16ac7a1 (commit)
via a008ad788c9a551c689ea616ac6191e409098284 (commit)
via f806ae6277e95048851b32ecc70772e1793a5d43 (commit)
via 3de906ac139852793ea06a41d7af284d6059e7bf (commit)
via 351eb6c26d68342d8dc20fb8f68b7e28ba007820 (commit)
via 66205054352cde0f597ff4236e0d95c34ebc8519 (commit)
via ef8357437423e2b830af955b477be22ddb208d1c (commit)
via 22029a296bb6f2581fead171cf98f4410ef4acb2 (commit)
via 37f410a436ffc11a147f18e65911e9e2b17298aa (commit)
via 47b32572d4d9c3195cf52ba02f1b6f845173c173 (commit)
via d87090f3bb6d8761a485e35bbf4488339b84f6c1 (commit)
via 017036f695df46df1fe3c2106b96b6285b0b9e83 (commit)
via df2a7e4aa200ea9648d993241e75ef27e12fa103 (commit)
via b7dd0d62ddf324a6f54dd3c6f7cb6babcd61ad2d (commit)
via e5162d9135876227745f7e91fbd6fd9a61879a64 (commit)
via 89b0a0563ca77f82e2915390b55d9f94fed71e68 (commit)
via 47731f187f32d889ea45a2c2d567d67189d4753a (commit)
via f7030fc0e1eea06f783fc98bfa95fb5c655143ae (commit)
via 349591b3a4ee9620f4f4f337173efd84ab3227cf (commit)
via 3865e38ebbb945ae8b7943d301a119da0e28b5c9 (commit)
via 858c8943b7c3760fa7677077668c7d104dd5f9bc (commit)
via 27c6399fb0fd3bd394cc010d31dc44f57dff79ee (commit)
via c551b0719d40159fc145f56308eb368dea6f2acf (commit)
via d5e3f431e77be4d80405aedd2ca36c23a4e4c413 (commit)
via 085e5739db71e782fe5a848e0e2585c0f3c52f56 (commit)
via 66444caeebfe1939edb1e886373fd38b360b9335 (commit)
via 1e9b6e0e2aab88da4930e7cc35d0bec9c0c59f77 (commit)
via c153adac098096ce3fa491a4d7b7a419ffc9f960 (commit)
via 8ece86e769e4876f19df8e8a22c2d0774c55aed2 (commit)
via 1bc723b33c1b3cb6baa67c277fe3ce64779fede1 (commit)
via 114e851f8f3b3dd7c7d0fca627d3c0a4ff655302 (commit)
via 24804aa4c61de8044e3666d7c3d010f65ecaf493 (commit)
via 086927c9766faedce0dd73a5cd5a180000da2056 (commit)
via 30b23c5f1df45ab2ffadc94494021b1189e75e13 (commit)
via 5b1934312b87f8458de84d96421106774dbd95a8 (commit)
via 3e1e9ddfcb7063e02ec0384d35ddb485ac3292de (commit)
via f446debd6ea6410f57f26f4ccf63a65239710a09 (commit)
via 3cfc2ec7bd1becef4386404fe7fc9f12740e8c97 (commit)
via d5d736909ccd24b38e90e89b1484da73972d8645 (commit)
via bbf0d21284924d6b7529017fc78178b98242aaee (commit)
via b092bdd20d94a516db0b7c4533149ac52f96aac5 (commit)
via 1e37d9c5f7af0f7e0efb226c171da52f03bc80eb (commit)
via 709f307af7b51f42d79a68a09b31249daef32ec1 (commit)
via e2032ccfd3102247ed2fe639ed0117ba7ac602d8 (commit)
via d9a54e0d3387c3ad057a67c7e2b5c668154f65f6 (commit)
via f18118f18f8930d4765abecafe43776ef42877d4 (commit)
via 63960cbb89ec22c0f984c8d02d140e76af03c18a (commit)
via b0ce0d646323de43739c454d0b8e665370768df1 (commit)
via c1af56eb54043909f7e32b4597baa4f2d4d3e7dd (commit)
from 880c9242a976e1b824af2ab5f048b1a0aa7b5496 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit ebb437349ebbadf90599c23a46126e5d8eda72da
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu Nov 5 06:40:42 2020 -0500
Bug 26627: (QA follow-up) Remove barcode input by id
Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 76c95e585d7470905701ee469b1042474fce0604
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Nov 6 12:03:17 2020 +0000
Bug 14866: DBRev 20.06.00.063
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 234768752fd7448fcafe69d54772507c3492a6c3
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Nov 3 16:57:52 2020 +0100
Bug 14866: Trivial code simplification
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d1bc1015d9b61b4e9b67fd751e05275548d59f46
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Thu Oct 22 12:15:51 2020 +0000
Bug 14866: (QA follow-up) Add hint to system preferences
Adds a hint about the new configuration option to the existing
system preference sectoin.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 1deb47e793b6b3c146839e9d5fc29ff535fd13a2
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Mon Apr 20 14:31:27 2020 +0000
Bug 14866: Make high holds work with different item types
To test:
1) Apply patch, update database, restart services
2) Enable decreaseLoanHighHolds sysprefs if not already active
3) Go to circulation rules and set a value under 'Decrease loan holds
(day)' that is DIFFERENT from decreaseLoanHighHoldsDuration
4) Check out an item with holds and confirm that the value from the rule
is used instead of the system preference
5) Confirm tests pass before and after the patch
t/db_dependent/DecreaseLoanHighHolds.t
Sponsored-by: Catalyst IT
Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com>
Signed-off-by: Henry Bolshaw <bolshawh at parliament.uk>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 8bd02f991942e307a8603304ffd29d8eb42343c4
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Nov 6 12:03:17 2020 +0000
Bug 23091: DBRev 20.06.00.062
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 671b013961037ab535693c2edce2eabb0fe0f128
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Oct 19 08:47:50 2020 -0300
Bug 23091: (QA follow-up) POD fixes
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 1527fbd4ae3131611957a8d320f0890396b3d27f
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Oct 16 16:51:07 2020 -0300
Bug 23091: Simplify tests by turning off AccountAutoReconcile
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 7d93405e599a4840f75a9a0fde8884f4f14ff4d9
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Oct 16 16:30:49 2020 -0300
Bug 23091: Add tests for \->credits and \->debits
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 0c6faea274318fd96311d91db28421f3886cb2db
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Jul 15 11:23:38 2020 +0100
Bug 23091: Unit Tests
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d643bf75a032fddc4d7cefb8489182ae13b899a5
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Sep 3 17:12:47 2020 +0100
Bug 23091: Move _Restore to Koha::Item store trigger
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 1008e21d430177ebf41f6a22ba29299228dba949
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Fri Jun 5 09:19:48 2020 +0100
Bug 23091: Add template handling for new messages
This patch adds handling for the display of the two new messages added
by this patchset in the returns screen.
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit b59799f298aab7b04547bcd7c29a2777e015a106
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Tue Jul 14 13:59:06 2020 +0100
Bug 23091: Make relations more explicit
This patch simply makes the queries built for the ->debits and ->credits
relations in Koha::Account::Line more explicit.
Test plan
1/ Ensure tests continue to pass
2/ Run tests with DBIC_TRACE=1 DBIC_TRACE_PROFILE=console and note that
the related queries not include 'credit.' and 'debit.' as appropriate.
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit e7d4bacfc67af5eaae7c477b2ac71753c76778ce
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Mon Jul 13 15:51:24 2020 +0100
Bug 23091: Add tests for _RestoreOverdueForLostAndFound
This patch adds unit tests for the newly introduced
_RestoreOverdueForLostAndFound method in C4::Circulation.
Test plan
1/ Read the new tests added to t/db_dependent/Circuation.t to ensure
they make sense
2/ Run the tests and verify they pass
3/ Signoff
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 7a07e111288de820e535dd35c024917d141129ad
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Oct 23 11:32:28 2019 +0100
Bug 23091: Add handling for new lostreturn rules
This patch adds handing for the new values available for the lostreturn
policy settings.
* undef - Do nothing, leave fees and fines as they were at the point of
lose.
* refund - Refund the lost item fee only
* charge - Refund the lost item fee and charge a fresh overdue fine
dated for a return on the date the item is 'found'
* restore - Refund the lost item fee and restore the original overdue
fine (dated for a 'return' on the date the item was 'lost'
Test plan
1/ apply patch
2/ updatedatabase, restart_all
3/ verify finesmode and CalculateFinesOnReturn and WhenLostChargeReplacementFee are on
4/ verify WhenLostForgiveFine is set to "Forgive"
5/ verify circ rules include fines
6/ set Default lost item fee refund on return policy to "Refund lost item charge"
7/ create 4 overdue checkouts that will incur fines
8/ run fines.pl
9/ confirm 4 items checked out with accruing fines
10/ confirm all 4 items have a replacement price
Item 1
11/ mark the first item lost
12/ verify that fine is gone and lost fee has been charged
13/ check item in
14/ verify that lost fee is gone and overdue charge has not returned
Item 2
15/ set Default lost item fee refund on return policy to "Refund lost item charge and charge new overdue fine"
16/ mark second item lost
17/ verify that fine is gone and lost fee has been charged
18/ check item in
19/ verify that lost fee is gone and a new overdue charge has been made
Item 3
20/ set Default lost item fee refund on return policy to "Refund lost item charge and restore overdue fine"
21/ mark third item lost
22/ verify that fine is gone and lost fee has been charged
23/ check item in
24/ verify that lost fee is gone and the old overdue charge has been restored
Item 4
25/ set Default lost item fee refund on return policy to "Leave lost item charge"
26/ mark fourth item lost
27/ verify that fine is gone and lost fee has been charged
28/ check item in
29/ verify that lost fee remains and the overdue charge is still gone
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ed0df15f5094c5cf5462488fd0aac48ddd613b35
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Jun 3 16:25:31 2020 +0100
Bug 23091: Update unit test
This patch updates the unit test for get_lostreturn_policy to reflect
the rule_name and return code changes.
Test plan:
1/ Read the code changes in t/db_dependant/Koha/CirculationRules and
t/db_dependant/Koha/IssuingRules and confirm they make sense.
2/ Run the updated tests and ensure they pass.
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 2f7d2e327cb8631e2f1099a2169f439acc42da94
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Jun 3 16:01:39 2020 +0100
Bug 23091: Database update
This patch updates the 'refund' circulation rule to be called
'lostreturn' and populates the value with 'refund' where appropriate.
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c0830466c120ba9e0551cc40995b94e3c16ac7a1
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Nov 6 12:03:17 2020 +0000
Bug 24412: DBRev 20.06.00.061
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit a008ad788c9a551c689ea616ac6191e409098284
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Nov 6 12:01:11 2020 +0100
Bug 24412: DBIC schema changes
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f806ae6277e95048851b32ecc70772e1793a5d43
Author: Nicolas Legrand <nicolas.legrand at bulac.fr>
Date: Thu Nov 5 14:52:02 2020 +0100
Bug 24412: (follow-up) prevent js injection
Some js variables are not properly escaped and can be executed if
containing javascript.
1. have some waiting reserve attached to a desk
2. change this desk name to : <script>alert("❤");</script>
3. go to user's checkout page (circulation.pl) and click on the
Hold(s) tab
4. you should see some popup with a ❤ in it.
5. apply patch and refresh page
6. now you should see the desk name printed properly in the page:
<script>alert("❤");</script>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3de906ac139852793ea06a41d7af284d6059e7bf
Author: Nicolas Legrand <nicolas.legrand at bulac.fr>
Date: Thu Nov 5 14:10:09 2020 +0100
Bug 24412: (follow-up) prevent request.pl from failing
When no desk is defined request.pl returns an internal server
error. Check a desk is defined before asking for reservation deskname.
Plan test:
1. log in with a library with no desk
2. check in a reserved book so it'll be switch to “waiting reserve”
3. go to the book notice and click the Holds tab (request.pl page)
4. boum
5. apply patch, restart plack
6. refresh page
7. now loading properly
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 351eb6c26d68342d8dc20fb8f68b7e28ba007820
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Fri Oct 23 15:46:03 2020 +0100
Bug 24412: (QA follow-up) Change CASCADE DELETE to SET NULL
I don't believe waiting reserves should be removed if a desk is deleted,
we should instead simply unset the desk.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 66205054352cde0f597ff4236e0d95c34ebc8519
Author: Nicolas Legrand <nicolas.legrand at bulac.fr>
Date: Thu Oct 22 18:17:47 2020 +0200
Bug 24412: (follow-up) prevent error in svc/holds
don't fail if a hold has no desk attached.
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ef8357437423e2b830af955b477be22ddb208d1c
Author: Nicolas Legrand <nicolas.legrand at bulac.fr>
Date: Thu Oct 22 13:31:15 2020 +0200
Bug 24412: (follow-up) bad desk printing
forgot to update two pages when I wrote Hold->desk to replace
Desks.GetName.
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 22029a296bb6f2581fead171cf98f4410ef4acb2
Author: Nicolas Legrand <nicolas.legrand at bulac.fr>
Date: Wed Oct 21 13:29:00 2020 +0200
Bug 24412: (follow-up) qa-tools
fix obvious problems:
1. qa -c 8 -v 2
2. should be green
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 37f410a436ffc11a147f18e65911e9e2b17298aa
Author: Nicolas Legrand <nicolas.legrand at bulac.fr>
Date: Wed Oct 21 12:10:19 2020 +0200
Bug 24412: (follow-up) tests
Add some test for Koha::Hold->desk and Koha::Hold->set_waiting.
Test plan:
1. prove t/db_dependent/Koha/Holds.t
2. should be green!
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 47b32572d4d9c3195cf52ba02f1b6f845173c173
Author: Nicolas Legrand <nicolas.legrand at bulac.fr>
Date: Mon Jan 13 17:56:41 2020 +0100
Bug 24412: Attach waiting reserve to desk
When an item is checked in and marked 'Waiting' or already 'Waiting'
and there is a desk attached to the session, the item is marked
waiting at the current desk of the current library.
The information is displayed on the OPAC and on the intranet. The
patron can then know at which desk he can retrieve his document.
Desk Management (Bug 13881) is now useful.
Test plan :
1. apply Bug 24201
2. $KOHA_PATH/installer/data/mysql/updatedatabase.pl
3. Check out some document to someone
4. make another one reserve this document
5. check in the document
6. you can see the document is attach to the current library
7. create some desks and attach one to your session (see Bug 13881 and
Bug 24201)
8. cancel the preceding reserve and redo steps 3 to 5
9. you should see the document is waiting at the current library and
current desk on:
a. the intranet document request page
b. the intranet borrower holds tab
c. the item list where the document is listed on the bibliographic
details
d. the borrower's OPAC holds tab.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Bug 24412: (follow-up) QA
Following Josef Moravec QA comments :
- rewrite Koha::Hold->desk according to Object Oriented Koha
Guidelines and use it to fetch desk name in various templates
- remove unused Desks.GetName
- Check for columns existence in db update
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Bug 24412: (follow-up) QA: useless change
Maybe it was a relic of something usefull... anyway
not anymore.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Bug 24412: (follow-up) Fix POD
Koha::Desk and not Koha::Library...
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d87090f3bb6d8761a485e35bbf4488339b84f6c1
Author: Nicolas Legrand <nicolas.legrand at bulac.fr>
Date: Mon Jan 13 17:55:46 2020 +0100
Bug 24412: kohastructure and atomic update
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 017036f695df46df1fe3c2106b96b6285b0b9e83
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Oct 20 14:36:22 2020 -0300
Bug 24633: (follow-up) Tweak sample plugin targets
Sponsored-by: Theke Solutions
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit df2a7e4aa200ea9648d993241e75ef27e12fa103
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Oct 20 14:29:38 2020 -0300
Bug 24633: Add support for gitlab searching of plugins
This patch adds the option to add Gitlab repositories to look for
Koha plugins. As with Github, plugin projects need to be named
koha-plugin-* and the release file needs to be named with the .kpz
extension.
To test:
1. Apply this patchset
2. Check either koha-conf.xml or koha-conf.site.xml.in for sample
configurations of gitlab targets.
3. Tweak your koha-conf.xml accordingly. You could have:
<plugin_repos>
<repo>
<name>ByWater Solutions</name>
<org_name>bywatersolutions</org_name>
<service>github</service>
</repo-
<repo>
<name>Theke Solutions</name>
<org_name>thekesolutions</org_name>
<service>gitlab</service>
</repo>
<repo>
<name>PTFS Europe</name>
<org_name>ptfs-europe</org_name>
<service>github</service>
</repo>
</plugin_repos>
4. Flush memcached and restart plack:
$ flush_memcached
$ koha-plack --restart kohadev
5. Open the plugins page, search for anything, like 'gobi' or 'a'
=> SUCCESS: You get Theke results!
6. Pick a gitlab plugin for install
=> SUCCESS: It is installed!
7. Sign off :-D
Sponsored-by: Theke Solutions
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit b7dd0d62ddf324a6f54dd3c6f7cb6babcd61ad2d
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Fri Nov 6 12:48:28 2020 +0000
Bug 24665: (QA follow-up) Fix selection default
This patch updates the html_helper for the cash register selection block
to remove the 'empty option' such that it can be correclty set for each
select case and updates all existing cases where we used the process
block previously to include the relevant blank option '-- Select an
option --', '-- None --', 'Library default' and finally the new '-- All
--' options introduced with this bug.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit e5162d9135876227745f7e91fbd6fd9a61879a64
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Tue Jul 21 14:54:09 2020 +0100
Bug 24665: Add support for filtering by cash register
This patch makes it possible to filter on cash register
on the cash register statistics page.
To test:
- Activate UseCashRegisters
- Create a cash register or more to use
- Create some manual fees and fines
- Pay some of them off
- Go to Tools > Cash register statistics
- Test if the new filter for cash registers works as it should
Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 89b0a0563ca77f82e2915390b55d9f94fed71e68
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Fri Nov 6 14:42:42 2020 +0000
Bug 24786: (QA follow-up) Ensure tests pass with existing data
The tests for Koha::Template::Plugin::Registers assumed that no
registers were pre-set in the database. This patch updates the test to
ignore pre-existing data or take it into account in totals.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 47731f187f32d889ea45a2c2d567d67189d4753a
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Fri Nov 6 14:04:49 2020 +0000
Bug 24786: (QA follow-up) Reset beenSubmitted on validation failure
When the form submision fails due to validation errors we need to also
reset the preventFormDoubleSubmit state to allow for a second submission
with corrected form fields.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f7030fc0e1eea06f783fc98bfa95fb5c655143ae
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Fri Nov 6 11:51:30 2020 +0000
Bug 24786: (QA follow-up) Do not use 'hidden' attribute
The hidden attribute for loading an element hidden is known to have
issues and inconsistencies accross browsers.
This patch instead updates the relevent input options to use an inline
style of 'display: none' to hide the elements on page load and then
.show, .hide for subsquent changes linked to the library branch picker
change.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 349591b3a4ee9620f4f4f337173efd84ab3227cf
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Fri Nov 6 10:55:13 2020 +0000
Bug 24786: (QA follow-up) Hide archived registers
This patch hides archived registers from the list when useing the
Registers template plugin. It also includes a check for
UseCashRegisters so that if the preference is disabled after some
registers have been defined then the plugin will no longer return the
list regardless.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3865e38ebbb945ae8b7943d301a119da0e28b5c9
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Fri Nov 6 10:53:56 2020 +0000
Bug 24786: (QA follow-up) Handle no defined registers
This patch hides the register selection option from the login page if no
registers have yet been defined on the system.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 858c8943b7c3760fa7677077668c7d104dd5f9bc
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Nov 4 12:53:59 2020 +0000
Bug 24786: (QA follow-up) Remove trailing space in classes
The trailing space after branch in the class attribute for the register
select options cause issues in the 'hasClass' javascript selector
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 27c6399fb0fd3bd394cc010d31dc44f57dff79ee
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Nov 4 11:52:06 2020 +0000
Bug 24786: (QA follow-up) String fix
This patch updates 'Branch default' to 'Library default' on the login
page to match the coding terminology guidelines.
We also update the table heading on the cash registers management page
to match the terminology above for clarity.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c551b0719d40159fc145f56308eb368dea6f2acf
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Oct 15 17:03:04 2020 +0100
Bug 24786: (QA follow-up) Unit tests for Registers plugin
To test:
1. Run the new unit test: t/db_dependent/Koha/Template/Plugin/Registers.t
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d5e3f431e77be4d80405aedd2ca36c23a4e4c413
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Oct 15 13:41:16 2020 +0100
Bug 24786: (QA follow-up) Add validation to paycollect
This patch adds conditional validation to the cash register field on
paycollect such that if 'CASH' is selected as the payment type and cash
registers are enabled, then a cash register will be required.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 085e5739db71e782fe5a848e0e2585c0f3c52f56
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Oct 14 13:42:32 2020 +0100
Bug 24786: (QA follow-up) Fix Registers Plugin
For the QA script we do not set a userenv, so we result in a failure due
to a lack of checking for userenv prior to using it.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 66444caeebfe1939edb1e886373fd38b360b9335
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Oct 14 13:08:45 2020 +0100
Bug 24786: (QA follow-up) Make QA script happy with html_helpers
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 1e9b6e0e2aab88da4930e7cc35d0bec9c0c59f77
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Oct 14 13:01:38 2020 +0100
Bug 24786: (QA follow-up) POD Fixes
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c153adac098096ce3fa491a4d7b7a419ffc9f960
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Fri Oct 2 10:19:14 2020 +0100
Bug 24786: Add validation to point of sale
The Point of Sale page relied upon serverside validation prior to this
patch; As such with the introduction of the ability to select '--None--'
at the session register level (to require the librarian to pick their
register for every transaction) we could result in a server error page.
This patch introduced clientside validation to add checks for both the
'collected' and 'registerid' form fields.
Test plan:
1/ Select a branch with cash registers available
2/ Select the '--None--' option for the session cash register
3/ Navigate to the point of sale page
4/ Attempt to make a sale without having picked your cash register
5/ Note that the submission was prevented and the fiedl is highlighted
as required in red.
6/ Signoff
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 8ece86e769e4876f19df8e8a22c2d0774c55aed2
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Tue Aug 11 14:24:19 2020 +0100
Bug 24786: Default to 'branch default' on auth.
If no branch is selected (i.e. 'My library') then we should default to
'branch default' if one is defined for the users library at login.
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 1bc723b33c1b3cb6baa67c277fe3ce64779fede1
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Tue Aug 4 13:27:06 2020 +0100
Bug 24786: (follow-up) Cache the register_name in the session
This leads to one DB hit less per page load in the staff client when
cash registers are enabled.
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 114e851f8f3b3dd7c7d0fca627d3c0a4ff655302
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Tue Jul 21 10:52:49 2020 +0100
Bug 24786: Update borroaccount to use session register
This patch adds handling to allow for the use of the session cash
register by default if it has been set, otherwise it defaults to '--
None --' and requires the end user to select the register to proceed
with the refund or payout action.
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 24804aa4c61de8044e3666d7c3d010f65ecaf493
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Tue Jul 21 10:30:09 2020 +0100
Bug 24786: Update paycollect to use session register
This patch adds handling to allow for the use of the session cash
register by default if it has been set, otherwise it defaults to '--
None --' and requires the end user to select the register to proceed
with the payment.
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 086927c9766faedce0dd73a5cd5a180000da2056
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Tue Jul 21 13:08:18 2020 +0100
Bug 24786: Update point of sale to use session register
This patch adds handling to allow for the use of the session cash
register by default if it has been set, otherwise it defaults to '--
None --' and requires the end user to select the register to proceed
with the sale.
Test plan
1/ Enable cash registers via the 'UseCashRegisters' system preference
2/ Enable point of sale via the 'EnablePointOfSale' system preference
3/ Navigate to the point of sale page
4/ Note that if you are logged in at a branch with no cash registers yet
defined, then an alert should appear
5/ Note that when you are logged in at a branch with cash regsiters
defined, but without a cash register associated with your session then
the cash 'Cash register' select box is populated with '-- None --' and
you are required to select a register prior to submission
6/ Note that upon selection, the '-- None --' option is disabled
7/ Note that when you have a register associated with your session then
the 'Cash register' select box is pre-populated with that register.
8/ Signoff
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 30b23c5f1df45ab2ffadc94494021b1189e75e13
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Tue Jul 21 13:37:16 2020 +0100
Bug 24786: Allow selection of cash register at login
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 5b1934312b87f8458de84d96421106774dbd95a8
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Mon Jul 20 16:14:17 2020 +0100
Bug 24786: Allow setting a register for the session
This patch adds the ability to set a register for the current session
from the 'set library' page.
Upon entering the page, the current selection will be displayed.
Changing the branch will trigger the register select list to update to
display only those registers associated with the updated branch and will
automatically select either 'no register' or the 'branch default'
register. The user can then override that selection to choose a
different register for the session.
Test plan
1/ Enable cash registers with the 'UseCashRegisters' system preference
2/ Select the 'Set library' option from the top right menu
3/ Note that you can now select a cash register from the subsequent page
4/ Change the branch and note that the cash register selection is
updated to reflect the change
5/ Note that the 'branch default' register is auto-selected upon branch
selection if one has been defined, otherwise '-- None --' is selected
6/ You can then alter the selection before submitting the form
7/ Once submitted note that you are returned to the page you were on
prior to attempting to change the library and register
8/ Note the present of the register name next to the library name at the
top of the screen.
9/ Signoff
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3e1e9ddfcb7063e02ec0384d35ddb485ac3292de
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Nov 6 15:30:39 2020 +0100
Bug 25067: Move the tests to db_dependent
To not break the package workflow
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f446debd6ea6410f57f26f4ccf63a65239710a09
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sun Oct 4 18:07:08 2020 +0000
Bug 25067: (QA follow-up) Add +x on test files
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3cfc2ec7bd1becef4386404fe7fc9f12740e8c97
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Sun Mar 29 14:56:20 2020 +0200
Bug 25067: Move PO file manipulation code into gulp tasks
misc/translator/translate was doing three different things:
- extract translatable strings
- create or update PO files
- install translated templates
This patch separates responsibilities by moving the string extraction
code into several 'xgettext-like' scripts and adds gulp tasks to
automate string extraction and PO files update
This has several benefits:
- gulp runs tasks in parallel, so it's a lot faster (updating all PO
files is at least 10 times faster with my 4-cores CPU)
- there is no need for $KOHA_CONF to be defined
LangInstaller.pm relied on $KOHA_CONF to get the different paths
needed. I'm not sure why, since string extraction and PO update should
work on source files, not installed files
- string extraction code can be more easily tested
This patch also brings a couple of fixes and improvements:
- TT string extraction (strings wrapped in [% t(...) %]) was done with
Template::Parser and PPI, which was extremely slow, and had some
problems (see bug 24797).
This is now done with Locale::XGettext::TT2 (new dependency) which is
a lot faster, and fixes bug 24797
- Fix header in 4 PO files
For backward compatibility, 'create' and 'update' commands of
misc/translator/translate can still be used and will execute the
corresponding gulp task
Test plan:
1. Run `yarn install` and install Locale::XGettext::TT2
2. Run `gulp po:update`
3. Verify the contents of updated PO files
4. Run `cd misc/translator && ./translate install <lang>`
5. Verify that all (templates, sysprefs, xslt, installer files) is
correctly translated
6. Run `gulp po:create --lang <lang>` and verify that it created all PO
files for that language
7. Run `prove t/misc/translator`
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Need to install yarn & gulp, no errors
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d5d736909ccd24b38e90e89b1484da73972d8645
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Nov 3 18:00:57 2020 +0000
Bug 26727: (follow-up) More markup corrections
This patch makes more markup changes to the templates previously
modified in order to try to arrive at some agreeable solutions.
- In the value_builder EXAMPLE template, the <p> is unnecessary and is
removed. Also removed is the script "type" attribute and obsolete
CDATA markers.
- In the article request template an unnecessary <p> is removed.
- In the merge patrons template the submit button is now in a <fieldset
class="action"> as is consistent with other forms.
- In the MARC modifications template I've added <div>s around each
"line" in the form to add the line break, along with some CSS to add
margins.
- The submit button is now inside a <fieldset class="action"> and the
"Cancel" link now has the "cancel" class.
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit bbf0d21284924d6b7529017fc78178b98242aaee
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sun Oct 18 16:30:24 2020 +0000
Bug 26727: Fix <p/> appearing in the templates
The self-closing p is not valid in HTML5:
Error: Self-closing syntax (/>) used on a non-void HTML element.
Ignoring the slash and treating as a start tag.
To test:
1)
- Activate Article requests
- Search for a record to place an article request on in staff
- Look up the patron
- Verify the article request form looks ok
2)
- Search for a list of patrons
- Check 2 patrons and merge them using the button above the list
- Verify the distance between the button and the table looks ok
3)
- Create a new MARC modification template
- Create a new action
- Verify the distances between the first and second line of form
elements looks ok
4)
- Place a hold in staff
- Click on the Suspend link in the holds table (not below)
- Verify the modal looks ok
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit b092bdd20d94a516db0b7c4533149ac52f96aac5
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu Nov 5 11:53:43 2020 -0300
Bug 14708: (QA follow-up) Add tests
This patch adds tests for the change. It also simplifies the delete()
method structure a bit. It fixes the error 500 the tests were raising.
To test:
1. Run:
$ kshell
k$ prove t/db_dependent/api/v1/patrons.t
=> FAIL: Tests fail!
2. Apply this patch
3. Repeat 1
=> SUCCESS: Tests pass! The new behaviour (code 403) is tested!
4. Sign off :-D
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 1e37d9c5f7af0f7e0efb226c171da52f03bc80eb
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Nov 3 08:55:04 2020 -0500
Bug 14708: (QA follow-up) Use try/catch blocks when calling delete() on a patron
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 709f307af7b51f42d79a68a09b31249daef32ec1
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon Nov 2 08:11:58 2020 -0500
Bug 14708: (QA follow-up) Throw exception when deleting anonymous borrower
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit e2032ccfd3102247ed2fe639ed0117ba7ac602d8
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Wed Apr 29 07:22:26 2020 -0400
Bug 14708: Don't allow merging of other patron records into Anonymous Patron
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d9a54e0d3387c3ad057a67c7e2b5c668154f65f6
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Wed Apr 15 13:48:09 2020 -0400
Bug 14708: Don't allow merging of Anonymous Patron into other patron records
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f18118f18f8930d4765abecafe43776ef42877d4
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Wed Apr 15 13:31:59 2020 -0400
Bug 14708: Skip AnonymousPatron in GetBorrowersToExpunge
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 63960cbb89ec22c0f984c8d02d140e76af03c18a
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Wed Apr 15 12:48:02 2020 -0400
Bug 14708: Prevent deletion of Anonymous Patron at Koha::Patron::delete
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit b0ce0d646323de43739c454d0b8e665370768df1
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Wed Feb 27 12:00:03 2019 -0500
Bug 14708: Enforce restriction in delete_patrons.pl
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c1af56eb54043909f7e32b4597baa4f2d4d3e7dd
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Wed Feb 27 06:59:08 2019 -0500
Bug 14708: The patron set as the anonymous patron should not be deletable.
Right now it's possible to delete the anonymous patron at any time. When this happens the system will break just as if anonymouspatron was unset but patrons still have an "always anonymize" privacy setting.
This issue occurs more frequently than one would expect.
We should make it so that the patron set in AnonymousPatron is not deletable.
Test Plan:
1) Apply this patch
2) Set a patron to by AnonymousPatron
3) Attempt to delete that patron from the members toolbar
4) Note the error message!
Signed-off-by: Devinim <kohadevinim at devinim.com.tr>
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
-----------------------------------------------------------------------
Summary of changes:
C4/Auth.pm | 32 +-
C4/Circulation.pm | 86 ++-
C4/Context.pm | 22 +-
C4/Members.pm | 5 +
C4/Reserves.pm | 6 +-
Koha.pm | 2 +-
Koha/Account/Line.pm | 8 +-
Koha/CirculationRules.pm | 25 +-
Koha/Exceptions/Patron.pm | 3 +
Koha/Hold.pm | 16 +-
Koha/Item.pm | 191 +++--
Koha/Patron.pm | 9 +
Koha/REST/V1/Patrons.pm | 25 +-
Koha/Schema/Result/Desk.pm | 19 +-
Koha/Schema/Result/OldReserve.pm | 11 +-
Koha/Schema/Result/Reserve.pm | 32 +-
Koha/Template/Plugin/Registers.pm | 109 +++
admin/smart-rules.pl | 18 +-
circ/returns.pl | 11 +-
circ/set-library.pl | 31 +-
cpanfile | 2 +-
debian/templates/koha-conf-site.xml.in | 2 +-
docs/development/internationalization.md | 121 ++++
etc/koha-conf.xml | 2 +-
gulpfile.js | 302 +++++++-
installer/data/mysql/kohastructure.sql | 6 +-
installer/data/mysql/updatedatabase.pl | 32 +
installer/onboarding.pl | 1 +
koha-tmpl/intranet-tmpl/prog/css/login.css | 4 +
.../intranet-tmpl/prog/en/includes/header.inc | 27 +-
.../intranet-tmpl/prog/en/includes/holds_table.inc | 2 +-
.../prog/en/includes/html_helpers.inc | 16 +-
.../prog/en/includes/waiting_holds.inc | 2 +-
.../prog/en/modules/admin/cash_registers.tt | 6 +-
.../en/modules/admin/preferences/circulation.pref | 1 +
.../prog/en/modules/admin/smart-rules.tt | 94 ++-
koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt | 13 +
.../prog/en/modules/catalogue/detail.tt | 2 +-
.../modules/cataloguing/value_builder/EXAMPLE.tt | 6 +-
.../prog/en/modules/circ/request-article.tt | 1 -
.../intranet-tmpl/prog/en/modules/circ/returns.tt | 9 +-
.../prog/en/modules/circ/set-library.tt | 29 +-
.../prog/en/modules/members/boraccount.tt | 30 +-
.../prog/en/modules/members/merge-patrons.tt | 14 +-
.../prog/en/modules/members/moremember.tt | 4 +
.../prog/en/modules/members/paycollect.tt | 37 +-
koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt | 25 +-
.../prog/en/modules/reports/cash_register_stats.tt | 15 +-
.../modules/tools/marc_modification_templates.tt | 142 ++--
koha-tmpl/intranet-tmpl/prog/js/holds.js | 9 +-
.../intranet-tmpl/prog/js/register_selection.js | 27 +
.../bootstrap/en/includes/holds-table.inc | 1 +
members/boraccount.pl | 27 +-
members/deletemem.pl | 18 +-
members/paycollect.pl | 28 +-
misc/cronjobs/delete_patrons.pl | 8 +
misc/translator/LangInstaller.pm | 779 +++------------------
misc/translator/po/dz-pref.po | 10 +-
misc/translator/po/gd-pref.po | 10 +-
misc/translator/po/lv-pref.po | 10 +-
misc/translator/po/te-pref.po | 10 +-
misc/translator/tmpl_process3.pl | 122 +---
misc/translator/translate | 58 +-
misc/translator/xgettext-installer | 158 +++++
misc/translator/xgettext-pref | 151 ++++
misc/translator/xgettext-tt2 | 56 ++
misc/translator/xgettext.pl | 17 +-
package.json | 3 +
plugins/plugins-home.pl | 32 +
pos/pay.pl | 22 -
reports/cash_register_stats.pl | 9 +
reserve/request.pl | 1 +
svc/holds | 7 +
t/LangInstaller.t | 109 ---
t/db_dependent/Circulation.t | 466 +++++++++++-
t/db_dependent/DecreaseLoanHighHolds.t | 37 +-
t/db_dependent/Koha/Account/Line.t | 13 +-
t/db_dependent/Koha/CirculationRules.t | 60 +-
t/db_dependent/Koha/Holds.t | 42 +-
t/db_dependent/Koha/IssuingRules.t | 12 +-
t/db_dependent/Koha/Items.t | 334 ++++++++-
t/db_dependent/Koha/Patrons.t | 26 +-
t/db_dependent/Koha/Template/Plugin/Registers.t | 183 +++++
t/db_dependent/Members.t | 12 +-
t/db_dependent/api/v1/patrons.t | 8 +-
t/db_dependent/misc/translator/sample.pref | 14 +
.../misc/translator/sample.tt} | 2 +-
t/db_dependent/misc/translator/sample.yml | 15 +
.../misc/translator/xgettext-installer.t | 32 +
t/db_dependent/misc/translator/xgettext-pref.t | 54 ++
t/db_dependent/misc/translator/xgettext-tt2.t | 74 ++
t/lib/Mocks.pm | 11 +-
yarn.lock | 115 ++-
93 files changed, 3389 insertions(+), 1411 deletions(-)
create mode 100644 Koha/Template/Plugin/Registers.pm
create mode 100644 docs/development/internationalization.md
create mode 100644 koha-tmpl/intranet-tmpl/prog/js/register_selection.js
create mode 100755 misc/translator/xgettext-installer
create mode 100755 misc/translator/xgettext-pref
create mode 100755 misc/translator/xgettext-tt2
delete mode 100755 t/LangInstaller.t
create mode 100755 t/db_dependent/Koha/Template/Plugin/Registers.t
create mode 100644 t/db_dependent/misc/translator/sample.pref
rename t/{LangInstaller/templates/simple.tt => db_dependent/misc/translator/sample.tt} (96%)
create mode 100644 t/db_dependent/misc/translator/sample.yml
create mode 100755 t/db_dependent/misc/translator/xgettext-installer.t
create mode 100755 t/db_dependent/misc/translator/xgettext-pref.t
create mode 100755 t/db_dependent/misc/translator/xgettext-tt2.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list