[koha-commits] main Koha release repository branch master updated. v20.05.00-941-g83ebab049d
Git repo owner
gitmaster at git.koha-community.org
Thu Sep 3 15:32:53 CEST 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 83ebab049d8d3827226ef1700591ee63702ded17 (commit)
via e8a08cdfa7089f2b8147b3d75ce33c9521fd2cd6 (commit)
via 85405a2143c4dda5fb5c078a6ee78c5ab6d1b6d8 (commit)
via 2804d786c4e47dc0a3949d79f9ba944e8fb1d455 (commit)
via 5d05feac31edd214ff47facc8a6d9c78d074da65 (commit)
via d8696702cedb46e7667f9398165ee89627219809 (commit)
via 8cbf2841ad45dbbddda915873a85fb4569b3bb68 (commit)
via 72deefe8cf4f2d1cc24e7577ef2d2b8a44945f18 (commit)
via cb272f01f4191b681e25ca5528d87e1c67fb679f (commit)
via bed91ac8f73ca83235bf4dceee7123fbb4e14340 (commit)
via b48cdd227f12bb43decc9f7108e84ea562d8ebc9 (commit)
via 029bdb1fedf73f892f2807a675c0fd19fab06285 (commit)
via 002ae7504a856c65bdd9124c80499c008d98a960 (commit)
via c4f66a8514e6fada3c54baa1f1ea16f52cfdbd6e (commit)
via 5377bfc6240587b113f2b8ee26a8006f65e756a7 (commit)
via be92f7e79ce093e251c2489408dce3077f782c0d (commit)
via 89cc457ca25e0fbaccba28b249ceedeef6573abf (commit)
via 1733944b34499c145c2ae4c68c70efc87a5bec27 (commit)
via 089b85758614260b70f43509ccdbc6285629a883 (commit)
via 898cd3b82ee84682bdfad1c177e2eb6ae0881428 (commit)
via bb73c5343c072bf7e2ff9cc00f840554ce848be8 (commit)
via 8da73fe4283198ac93e2f15695f44e0cea7c490f (commit)
via 0291c1e7e7a8d24d608830d31a6fdd9d2273f1a7 (commit)
via f70df9b19479dc51ddaf76f29aaadafb7907a184 (commit)
via 8a37842e1af3fdc9e5e4eb2eb6ec9190ed31915e (commit)
via fde7bf5495dedf681acb3193891de44eec4d2bfa (commit)
via c53dfb5562a12c1a8d8b9d3d0c28cb17d001edb5 (commit)
via b729886216560fdf50d88dc8214c0dbb58720b5c (commit)
via b87dc492fe4ea009ad3c72aca43add0515d6da1c (commit)
via 2e421ed7a4e9bd3336b8e2b1eb9200c8c6342462 (commit)
from 017e19567af49a5e53f2d2fdf8713cbdd11666da (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 83ebab049d8d3827226ef1700591ee63702ded17
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Sep 3 12:20:57 2020 +0000
Bug 23682: DBRev 20.06.00.035
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit e8a08cdfa7089f2b8147b3d75ce33c9521fd2cd6
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Sep 3 14:11:46 2020 +0200
Bug 23682: Fix use Koha::Plugins::Handler statements
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 85405a2143c4dda5fb5c078a6ee78c5ab6d1b6d8
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon Aug 31 13:02:05 2020 -0400
Bug 23682: Dedup plugin calls my moving to a single call in process_invoice()
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 2804d786c4e47dc0a3949d79f9ba944e8fb1d455
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Tue Aug 25 14:18:32 2020 +0000
Bug 23682: INSERT IGORE systen preference in database update
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 5d05feac31edd214ff47facc8a6d9c78d074da65
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon Aug 24 13:21:26 2020 -0400
Bug 23682: (QA follow-up) Fix typo in syspref description
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d8696702cedb46e7667f9398165ee89627219809
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu Sep 26 10:39:36 2019 -0400
Bug 23682: Add ability to manually import EDI invoices as an alternative to automatic importing on download
Some library would like to delay the importing of invoices until
a time of their choosing. The invoices should be imported into
the database as they do now, but the invoice processing should
be skipped. Instead, any invoice file with a status of 'new'
should have an 'Import' button to process the invoice.
Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Enable the new syspref EdifactInvoiceImport
4) Run the edi cronjob to import a new invoice file
5) View EDI messages table at /acqui/edifactmsgs.pl
6) Note the invoice files is not processes, and retains the status of 'new'
7) Use the 'import' button to process the invoice
8) Note the invoice is now marked 'received' and the 'import' button is gone
9) Verify the invoice was actually processes
Signed-off-by: Debi Stears <DDStears at washoecounty.us>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 8cbf2841ad45dbbddda915873a85fb4569b3bb68
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Sep 3 12:20:57 2020 +0000
Bug 24197: DBRev 20.06.00.034
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 72deefe8cf4f2d1cc24e7577ef2d2b8a44945f18
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Sep 2 17:32:42 2020 +0000
Bug 24197: (QA follow-up) Shorten syspref name to AddressForFailedEmailNotices
If you define the address we use it, if not we fallback,
it's not really a redirect, and that just makes the name longer.
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit cb272f01f4191b681e25ca5528d87e1c67fb679f
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Sep 2 16:33:06 2020 +0100
Bug 24197: (QA follow-up) Embelished syspref description
As requested, I have embelished the syspref description to more
accurately depict the fallback sequence for email delivery.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit bed91ac8f73ca83235bf4dceee7123fbb4e14340
Author: Alex Buckley <alexbuckley at catalyst.net.nz>
Date: Wed Apr 22 00:01:58 2020 +0000
Bug 24197: Changed use of 'branch' terminology to 'library'
Sponsored-by: Catalyst IT
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit b48cdd227f12bb43decc9f7108e84ea562d8ebc9
Author: Alex Buckley <alexbuckley at catalyst.net.nz>
Date: Tue Apr 21 23:21:20 2020 +0000
Bug 24197: Added new local use syspref which sets the email address that failed overdue notices are set to.
Test plan:
1. Set no email addresses in patron record then checkout
items to the patron making the due date in the past
2. Visit patron's home library page: Administration > Libraries
Set a branch email and in global system preferences observe there is no syspref
named RedirectAddressForFailedOverdueNotices
3. Manually run overdue_notices.pl
4. Check the message_queue database table and observe there is a
print overdue notice and a email notice with to_address of the
branch email address
5. Apply patch
6. Run database update:
cd installer/data/mysql
sudo koha-shell <instance_name>
./updatedb.pl
7. Confirm there is a new system preference named:
RedirectAddressForFailedOverdueNotices
Give it a different email address to that in the branch email.
7. Repeat steps 1,3,4 and observe that the failed overdue notices have been
sent to the email defined in RedirectAddressForFailedOverdueNotices
Sponsored-By: Catalyst IT
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 029bdb1fedf73f892f2807a675c0fd19fab06285
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Sep 2 14:40:08 2020 +0100
Bug 25541: (QA follow-up) Default to disabled + Correct message
This patch defaults the 'holds_block_checkin' configuration to disabled
(to maintain current behaviour on upgrades). It also updates a
copy/paste for siplog logging to make the message triggered by this
action unique as expected.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 002ae7504a856c65bdd9124c80499c008d98a960
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Wed Sep 2 08:54:08 2020 -0400
Bug 25541: (QA follow-up) Rename no_holds_checkin to holds_block_checkin
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c4f66a8514e6fada3c54baa1f1ea16f52cfdbd6e
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Wed Aug 19 09:10:42 2020 -0400
Bug 25541: Add new param to debian sip config
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 5377bfc6240587b113f2b8ee26a8006f65e756a7
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue May 19 08:35:06 2020 -0400
Bug 25541: Add ability to prevent checkin via SIP of items with holds
Some libraries would like patrons to be unable to return items with
holds via SIP. Instead, the screen message should indicate that the
patron should return that item at the circ desk so a librarian can use
it to fill the next hold right away and place it on the hold shelf.
Test Plan:
1) Apply this patch.
2) Place a hold for an item.
3) Enable the new SIP option no_holds_checkin for a SIP account.
4) Restart the SIP server.
5) Check in the item using the SIP CLI tool using the SIP account
for which you set the new option.
6) Note the checkin fails with a screen message indicating you should
return the item to the circulation desk.
Signed-off-by: Peter Lau <peter.lau at yccece.edu.hk>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit be92f7e79ce093e251c2489408dce3077f782c0d
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Jul 22 13:28:44 2020 +0100
Bug 26041: Enable keyboard navigation without 'ctrl'
This patch enables keyboard navigation using the arrow keys without the
need to hold the control key for the jQuery UI datepicker.
Test plan
1/ Navigate to an item in the opac and attempt to place a hold
2/ On the resultant screen, use keyboard navigation to trigger the 'Show
more options' dropdown.
3/ Focus on one of the date inputs using keyboard navigation.
4/ Use 'ctrl + arrow' keys to navigate the datepicker.
5/ Note that prior to the patch using 'bare' arrow keys does not trigger
anything
6/ Apply the patch and confirm that the datepicker can now be naviated
using the arrow keys without holding the ctrl key.
7/ Confirm that using the ctrl key combinations continue to work as
expected too.
8/ Signoff
Signed-off-by: Brandon J <brandon.jimenez at inLibro.com>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 89cc457ca25e0fbaccba28b249ceedeef6573abf
Author: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Date: Thu Aug 27 18:03:14 2020 +0000
Bug 17801: Use issuedate for limits in Most Circulated Items
To test:
1 - Have two checkouts in old_issues
issue 1: timestamp 2020-08-01 00:00:00, issuedate 2019-08-01 00:00:00
issue 2: timestamp 2020-07-01 00:00:00, issuedate 2019-07-01 00:00:00
2 - Perform a Most Circulated Items search for checkout dates 2020-06-01 to 2020-09-01. Both checkouts appear in search
3 - Repeat search with checkout dates 2019-06-01 to 2019-09-01. Neither checkout appears in search
4 - apply patch, restart all
5 - Repeat search with checkout dates 2020-06-01 to 2020-09-01. Neither checkout appears in search
6 - Repeat search with checkout dates 2019-06-01 to 2019-09-01. Both checkouts appears in search
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 1733944b34499c145c2ae4c68c70efc87a5bec27
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Aug 18 13:33:33 2020 +0000
Bug 26236: Fix translating interface from DB term to readable term
When viewing the logs we try to swith the db values like 'cron' to friendly terms like
'Cron job'
The values we use for building the selectors on the page ar eupper case, but DB values are lower case
If we simply force upper case in the comparison we can ensure we always match correctly
To test:
1 - Enable some 'Logs' setting in System preferences
2 - Perform some action in koha that will log
Run a cronjob
Change a syspref
etc.
3 - Browse to Tools-> Log viewer
4 - Click 'Submit' to see all logs
5 - Note the 'Interface' column contains lower case DB values
6 - Apply patch
7 - Reload the page
8 - Values in interface are now Camel cased and more friendly
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 089b85758614260b70f43509ccdbc6285629a883
Author: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Date: Fri Aug 21 16:23:38 2020 +0300
Bug 26271: Add null to the list of accepted account_line data types
The database schema for accountlines table allows the
manager_id/user_id column to be NULL. If request to
/api/v1/patrons/<patron_id>/account returns such an accountline where
it is NULL we get 500 error as response. Adding NULL to allowed data
types fixes this issue.
To test:
1) Run prove t/db_dependent/api/v1/patrons_accounts.t and notice it
doesn't fail
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 898cd3b82ee84682bdfad1c177e2eb6ae0881428
Author: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Date: Fri Aug 21 16:21:42 2020 +0300
Bug 26271: Add failing test to reveal issue with patrons API endpoint
When manager_id is null/undef the API returns error code 500.
To test:
1) Notice failure when running
prove t/db_dependent/api/v1/patrons_accounts.t
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit bb73c5343c072bf7e2ff9cc00f840554ce848be8
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Tue Sep 1 03:37:22 2020 +0000
Bug 15851: (QA follow-up) Fix booleans to uppercase to make this work for Elasticsearch and UseControlNumber
Same test plan as before, but with UseControlNumber = Use and
Elasticsearch.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 8da73fe4283198ac93e2f15695f44e0cea7c490f
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Jul 17 09:44:46 2020 -0300
Bug 15851: (follow-up) Only display the analytics link when required (staff)
This patch replicates the introduced behaviour, for the admin interface.
To test, follow the test plan from the OPAC, but on the intranet.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 0291c1e7e7a8d24d608830d31a6fdd9d2273f1a7
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Jun 24 14:50:37 2020 -0300
Bug 15851: Only display the analytics link when required
This patch makes opac-detail.pl query for analytics the same way it
would do with the generated link (i.e. based on UseControlNumber) and
passes a flag to the XSLT so it displays (or not) the 'Analytics' link.
To test:
1. Apply the first patch
2. Have a known record without analytics
3. Open the record in the OPAC
=> FAIL: It shows the 'Analytics' link
4. Have a record known to have analytics and open in OPAC, on a separate
tab
=> SUCCESS: It shows the 'Analytics' link
5. Apply this patch and restart_all
6. Reload the tabs
=> SUCCESS: It shows the link where it has to, and hides it where it
shouldn't be displayed
7. Sign off :-D
Sponsored-by: Orex Digital
Signed-off-by: Hugo Agud <hagud at orex.es>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f70df9b19479dc51ddaf76f29aaadafb7907a184
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Jun 24 13:08:25 2020 -0300
Bug 15851: Display analytics links for more cases
The current XSLT displays the link to linked analytics only for serials.
This patch makes it show for all the relevant position 7 on the leader
values. I left out a and b as recommended by expert librarians on my
team, but I can revert that if required.
The current implementation adds a new CSS class for each case, so
libraries willing to keep the current behaviour or just have more
granular control on the cases they want the link to display, just can.
This patch makes sense with the follow-up one, which will display the
link only if there are really related records.
To test:
1. Open a non-serial record, notice there's no link to analytics
2. Apply this patch and reload
=> SUCCESS: There's an 'Analytics' link
3. Inspect the produced HTML
=> SUCCESS: A special class with analytic_* value has been added, and
thus we now can control its display through CSS
4. Sign off :-D
Sponsored-by: Orex Digital
Signed-off-by: Hugo Agud <hagud at orex.es>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 8a37842e1af3fdc9e5e4eb2eb6ec9190ed31915e
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Tue Sep 1 21:22:31 2020 +0200
Bug 26313: (follow-up) Fix OPAC and "Show volumes" links
Elasticsearch requires the booleans in search requests to
be uppercase. This fixes the "Show analytics" link in
OPAC (same as first patch for intranet) and the "Show volume"
link.
To test both patches:
Set UseControlNumber = Use
1) "Show analytics"
- Turn SearchEngine to Elasticsearch and make sure it works
- Pick any serial record in your database, make sure 001 is set
- Go to new > new child record
- Fill in 245 and save
- For both staff and OPAC:
- Click on the "In" link, it should bring you to the parent record
- Click on "Show analytics", it should show your analytical record
- Switch to "Zebra" - verify links still work.
2) "Show volumes"
- Turn SearchEngine to Elasticsearch again
- Pick any serial record in your database, make sure 001 is set
- Set LDR, pos. 19 = a - Set
- Note 001 value
- Find another record and edit it
- Set LDR, pos. 19 = a or b, LDR 7 not a or b (m will work)
- Set 773$ title of set record $w 001 of set record
- For both staff and OPAC:
- Click on the "In: link, it should bring up your set record
- Click on the "Show volumes" link, it should bring up the volume
- Switch to "Zebra" - verify all links still work.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit fde7bf5495dedf681acb3193891de44eec4d2bfa
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Sep 1 12:32:56 2020 +0000
Bug 26313: "Show analytics" link must use uppercase for booleans
In elasticsearch we only treat AND and OR as boolean operators if
they are capitalized
To test:
- Turn SearchEngine to Elasticsearch and make sure it works
- Pick any serial record in your database, make sure 001 is set
- Go to new > new child record
- Fill in 245 and save
- Click on the "In" link, it should bring you to the parent record
- Click on "Show analytics" => there will be no result
- Apply patch
- restart and reload
- Try again
- It works!
- Switch SearchEngine syspref to 'Zebra'
- Test again
- It still works!
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c53dfb5562a12c1a8d8b9d3d0c28cb17d001edb5
Author: David Cook <dcook at prosentient.com.au>
Date: Tue Sep 1 15:19:14 2020 +1000
Bug 26331: Make svc/letters/preview executable
Without this patch, you can't preview letters when running Koha in CGI mode.
To test:
1. Run Koha as CGI (and not Plack)
2. Go to /cgi-bin/koha/tools/letter.pl?op=add_form&branchcode=&module=circulation&code=CHECKIN
3. Try to preview the notice (using a valid barcode)
4. Note in the browser console that svc/letters/preview is generating a 500 error
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit b729886216560fdf50d88dc8214c0dbb58720b5c
Author: David Cook <dcook at prosentient.com.au>
Date: Thu Sep 3 05:40:57 2020 +0000
Bug 26362: Show correct libraries in overdues report
Currently the overdues report does the following display:
Patron library = home branch
Home library = holding branch
Holding library = patron branch
This patch corrects the display of libraries in the overdues report.
To test:
0) Do not apply patch
1) Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51
2) Go to http://localhost:8081/cgi-bin/koha/circ/set-library.pl
3) Choose "Troy"
4) http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51
5) Checkout "39999000004571" with due date of "09/01/2019 23:59"
Note the facts:
Patron library = Centerville
Home library = Fairview
Holding library = Troy
6) Go to http://localhost:8081/cgi-bin/koha/circ/overdue.pl
7) Change "Columns" visibility to show Holding and Home libraries
8) Note that the libraries are incorrect:
Patron library appears to be: Fairview
Home library appears to be: Troy
Holding library appears to be: Centerville
9) Apply the patch
10) koha-plack --restart kohadev
11) Go to http://localhost:8081/cgi-bin/koha/circ/overdue.pl
12) Change "Columns" visibility to show Holding and Home libraries
13) Note that the libraries are correct:
Patron library appears to be: Centerville
Home library appears to be: Fairview
Holding library appears to be: Troy
Signed-off-by: Emmi Takkinen <emmi.takkinen at outlook.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit b87dc492fe4ea009ad3c72aca43add0515d6da1c
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Aug 27 15:03:17 2020 +0000
Bug 26309: Make cxn_pool configurable
In get_elasticsearch_params we set the conf to static if undefined,
but we never defined it
To test:
1 - Apply unit test patch
2 - prove -v t/Koha/SearchEngine/Elasticsearch.t
3 - It fails
4 - Apply this patch
5 - It succeeds
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 2e421ed7a4e9bd3336b8e2b1eb9200c8c6342462
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Aug 27 15:03:07 2020 +0000
Bug 26309: Unit tests
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
-----------------------------------------------------------------------
Summary of changes:
C4/SIP/ILS.pm | 12 +++++-
C4/SIP/ILS/Transaction/Checkin.pm | 15 ++++++--
C4/SIP/Sip/MsgType.pm | 2 +-
Koha.pm | 2 +-
Koha/EDI.pm | 24 ++++++++++--
Koha/SearchEngine/Elasticsearch.pm | 9 ++---
acqui/edifactmsgs.pl | 12 +++++-
api/v1/swagger/definitions/account_line.json | 5 ++-
catalogue/detail.pl | 29 ++++++++++++--
debian/templates/SIPconfig.xml | 1 +
etc/SIPconfig.xml | 3 +-
installer/data/mysql/sysprefs.sql | 2 +
installer/data/mysql/updatedatabase.pl | 20 ++++++++++
.../prog/en/modules/acqui/edifactmsgs.tt | 3 ++
.../en/modules/admin/preferences/acquisitions.pref | 8 ++++
.../prog/en/modules/admin/preferences/admin.pref | 6 +++
.../intranet-tmpl/prog/en/modules/circ/overdue.tt | 4 +-
.../intranet-tmpl/prog/en/modules/tools/viewlog.tt | 2 +-
.../prog/en/xslt/MARC21slim2intranetDetail.xsl | 44 +++++++++++++++-------
.../opac-tmpl/bootstrap/en/includes/calendar.inc | 16 ++++++++
.../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 44 +++++++++++++++-------
misc/cronjobs/edi_cron.pl | 40 ++++++--------------
misc/cronjobs/overdue_notices.pl | 4 +-
opac/opac-detail.pl | 18 ++++++++-
reports/cat_issues_top.pl | 30 +++++++--------
svc/letters/preview | 0
t/db_dependent/Koha/SearchEngine/Elasticsearch.t | 12 +++++-
t/db_dependent/SIP/Message.t | 25 +++++++++++-
t/db_dependent/api/v1/patrons_accounts.t | 36 +++++++++++++++++-
29 files changed, 324 insertions(+), 104 deletions(-)
mode change 100644 => 100755 svc/letters/preview
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list