[Koha-cvs] koha/C4/Circulation Circ2.pm [dev_week]

Kyle Hall kyle.m.hall at gmail.com
Wed Oct 31 16:37:05 CET 2007


CVSROOT:	/sources/koha
Module name:	koha
Branch:		dev_week
Changes by:	Kyle Hall <kylemhall>	07/10/31 15:37:05

Modified files:
	C4/Circulation : Circ2.pm 

Log message:
	You can't just comment out critical functionality.
	If Koha starts saying it's doing something, then doesn't actually do it, that is bad for everyone.
	If this isn't working for some reason, just recomment it out, and have it tell the librarian to return the  book by hand.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/koha/C4/Circulation/Circ2.pm?cvsroot=koha&only_with_tag=dev_week&r1=1.87.2.14.2.33&r2=1.87.2.14.2.34

Patches:
Index: Circ2.pm
===================================================================
RCS file: /sources/koha/koha/C4/Circulation/Attic/Circ2.pm,v
retrieving revision 1.87.2.14.2.33
retrieving revision 1.87.2.14.2.34
diff -u -b -r1.87.2.14.2.33 -r1.87.2.14.2.34
--- Circ2.pm	21 Aug 2007 12:50:19 -0000	1.87.2.14.2.33
+++ Circ2.pm	31 Oct 2007 15:37:05 -0000	1.87.2.14.2.34
@@ -3,7 +3,7 @@
 
 package C4::Circulation::Circ2;
 
-# $Id: Circ2.pm,v 1.87.2.14.2.33 2007/08/21 12:50:19 kylemhall Exp $
+# $Id: Circ2.pm,v 1.87.2.14.2.34 2007/10/31 15:37:05 kylemhall Exp $
 
 #package to deal with Returns
 #written 3/11/99 by olwen at katipo.co.nz
@@ -496,7 +496,9 @@
 	if ($currentborrower) {
 		# I get an error slowing down the system for deep recursion so I'm commenting
 		# this out -- JF
-		#returnbook($barcode, $fbr);
+		# You can't comment out critical functionality. Shouldn't you fix it instead?
+		# At the very least, make the librarian return it by hand instead.
+		returnbook($barcode, $fbr);
 		$messages->{'WasReturned'} = $currentborrower;
 	}
 	# find reserves.....





More information about the Koha-cvs mailing list