[Koha-devel] [bug 6458]: need some help for a parsing problem in 'misc/translator/TTParser.pm'

[Frère Sébastien Marie]

On Tue, Jul 19, 2011 at 12:14:53PM +0200, Paul Poulain wrote:
> Le 19/07/2011 12:02, Frère Sébastien Marie a écrit :
> > but should we open bug report for each "miss-used" templates ? (warning, simple grep report 56 occurences)
> > and not all generate a problem (in my case, only when contains also a translated string: an invalid template is produced)
> don't hesistate to do so ! (opening a bugreport)

I wrote a simple parser in order to found easily these issues.

Resulting: 
  - 6 files unable to parse: CDATA are open but not closed
  - 1 file  unable to parse: an attribute is opened but not closed (exactly, closed and not opened)
  - 253 occurrences found, in 38 files

Does exist any batch processing for opening bug report ?

or could I open only one bug report, and populate with multiples patchs ?


I attach my log file (report of errors found). The format is:
filename: xxx yyy zzz

where 'xxx', 'yyy', 'zzz' are line number, where a directive (search for "[%") is found in a tag (something between '<' and '>') and not in an attribute value (something between '"' and '"').

error of parsing are: '(EOF in ...)'

For example:
./koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt: 318 318 346 346 362 362
./koha-tmpl/intranet-tmpl/prog/en/modules/tools/stage-marc-import.tt: 106 (EOF in Attribute Value)

First, in './koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt', two times on each lines: 318, 346 and 362.

Second, in './koha-tmpl/intranet-tmpl/prog/en/modules/tools/stage-marc-import.tt', line 106 and the parse could be terminated because of EOF occurs in a attribute. Here, beware: the parser is too simple to report correctly the error: it only note that an attribute has a bad pair of '"'. And as he continue parsing, the reported error are bad. (here the error is line 97: <option value=ISO_8859-1">, and after correction not problem with DIRECTIVE in TAG). 


If need, I could also share the parser, but is written in haskell...


> and if you fix some of those bugs, pls do a patch for each template (or
> logical group of templates, like "circulation", "members" ...) That
> would be easier to have small patches (less rebase conflicts if it takes
> time to have them merged onto master)

there are generally simple issues, but there are numberous...

-- 
Frère Sébastien Marie
Abbaye Notre Dame de La Trappe
61380 Soligny-la-Trappe
Tél: 02.33.84.17.00
Fax: 02.33.34.98.57
Web: http://www.latrappe.fr/
-------------- next part --------------
./koha-tmpl/opac-tmpl/prog/en/modules/opac-messaging.tt: 74 84 
./koha-tmpl/opac-tmpl/prog/en/modules/sco/sco-main.tt: 135 135 222 222 
./koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt: 427 427 
./koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt: 318 318 346 346 362 362 
./koha-tmpl/intranet-tmpl/prog/en/modules/rotating_collections/editCollections.tt: 92 92 101 101 
./koha-tmpl/intranet-tmpl/prog/en/modules/rotating_collections/addItems.tt: 47 47 
./koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt: 91 91 128 128 132 132 139 139 142 142 263 263 296 296 300 300 307 307 310 310 
./koha-tmpl/intranet-tmpl/prog/en/modules/admin/clone-rules.tt: 41 41 55 55 
./koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt: 104 104 109 109 114 118 122 
./koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt: 102 
./koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tt: 149 149 
./koha-tmpl/intranet-tmpl/prog/en/modules/admin/branch_transfer_limits.tt: 133 133 
./koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt: 1111 1111 
./koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues-full.tt: 46 46 
./koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt: 543 543 
./koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt: 43 43 239 239 
./koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt: 68 68 
./koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt: 47 47 
./koha-tmpl/intranet-tmpl/prog/en/modules/reports/reserves_stats.tt: 49 49 
./koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt: 321 321 322 322 323 323 324 324 325 325 326 326 327 327 328 328 329 329 330 330 331 331 332 332 
./koha-tmpl/intranet-tmpl/prog/en/modules/tools/csv-profiles.tt: 104 104 
./koha-tmpl/intranet-tmpl/prog/en/modules/tools/stage-marc-import.tt: 106 (EOF in Attribute Value)
./koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt: 160 
./koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt: 782 859 859 
./koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt: 145 145 
./koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt: 167 167 180 180 183 183 
./koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_field_008.tt: 5 
./koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_field_006.tt: 5 
./koha-tmpl/intranet-tmpl/prog/en/modules/labels/spinelabel-print.tt: 3 3 
./koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt: 281 
./koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt: 133 133 134 134 135 135 136 136 268 268 269 269 270 270 271 271 324 324 325 325 326 326 327 327 
./koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt: 678 678 
./koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt: 41 41 104 104 
./koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt: 93 93 102 102 
./koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt: 225 225 232 232 275 275 276 276 
./koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt: 181 181 182 182 183 183 254 254 
./koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt: 447 447 548 548 
./koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt: 193 193 195 195 245 245 256 256 301 301 319 319 328 328 369 369 391 391 401 401 412 412 445 445 456 456 471 471 482 482 492 492 502 502 513 513 523 523 543 543 553 553 583 583 593 593 603 603 613 613 638 638 648 648 658 658 668 668 698 698 708 708 718 718 816 816 831 831 853 853 1006 1006 1081 1081 
./koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-layout.tt: (EOF in CDATA)
./koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/image-manage.tt: (EOF in CDATA)
./koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/manage.tt: (EOF in CDATA)
./koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-template.tt: (EOF in CDATA)
./koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt: (EOF in CDATA)
./koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-profile.tt: (EOF in CDATA)
./koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt: 212 212 308 308 309 309 310 310 311 311