[Koha-devel] Expected behaviod when printing serials - add reserve?

Jonathan Druart jonathan.druart at bugs.koha-community.org
Mon Mar 13 17:25:43 CET 2017


Hi devs,

I found an obvious bug in serials/routing-preview.pl.
If the script is called with ok=1 (hum... yes...), the script will add or
modify a hold placed on the bibliographic records existing in the routing
list.
So from /serials/serials-collection.pl?subscriptionid=1, click on "Print
list" you get a pop-up with a print and close button.
When the pop-up is generated, we already have the ok=1 and the go through:
  66: my ($count2, at bibitems) = GetBiblioItemByBiblioNumber($biblio);
Then later:
 96
AddReserve($branch,$routing->{borrowernumber},$biblio,\@bibitems,$routing->{ranking},
undef, undef, $notes,$title);

The problem is that GetBiblioItemByBiblioNumber will always return only 1
value (for obvious reasons) and @bibitems will always be empty => reserve
is placed at bib level

The thing is that this bug exists for ages (at least 2006, maybe always).
What is the expected behaviour?

No need to tell you that I was going to kick GetBiblioItemByBiblioNumber
when I found that bug.

Cheers,
Jonathan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20170313/1c043b29/attachment.html>


More information about the Koha-devel mailing list