<div dir="ltr">There isn't necessarily to much logic in the templates, as long as it is 'display' logic. To me, it makes sense to calculate totals and such in the templates and not in perl, because that is purely for display only ( though it'd be better to do the totals at the db level anyway ). Not the best example, but's all I can think of atm ; )<div>
<br></div><div style>I think the key to what you are writing about is to push more template logic into TT Plugins, so we aren't repeating TT code over and over.</div><div><br></div><div>Kyle</div></div><div class="gmail_extra">
<br clear="all"><div><a href="http://www.kylehall.info" target="_blank">http://www.kylehall.info</a><br>ByWater Solutions ( <a href="http://bywatersolutions.com" target="_blank">http://bywatersolutions.com</a> )<br>Meadville Public Library ( <a href="http://www.meadvillelibrary.org" target="_blank">http://www.meadvillelibrary.org</a> )<br>
Crawford County Federated Library System ( <a href="http://www.ccfls.org" target="_blank">http://www.ccfls.org</a> )<br>Mill Run Technology Solutions ( <a href="http://millruntech.com" target="_blank">http://millruntech.com</a> )<br>
</div>
<br><br><div class="gmail_quote">On Wed, Apr 10, 2013 at 7:37 AM, Marcel de Rooy <span dir="ltr"><<a href="mailto:M.de.Rooy@rijksmuseum.nl" target="_blank">M.de.Rooy@rijksmuseum.nl</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div style="direction:ltr;font-size:10pt;font-family:Tahoma">
<p>+1 for going into this direction</p>
<p>Probably, there is too much logic in the templates too? And related to translation as well? Take e.g. some statuses; if the template decides in nested if-then-else's how to display a status (in various languages), we'd better move the logic into a module
and send the translated status to the template or have something unified and more intelligent deal with translating that message.</p>
<p> </p>
<p>Marcel</p>
<p> </p>
<div style="font-size:16px;font-family:Times New Roman">
<hr>
<div style="DIRECTION:ltr"><font color="#000000" face="Tahoma"><b>Van:</b> <a href="mailto:koha-devel-bounces@lists.koha-community.org" target="_blank">koha-devel-bounces@lists.koha-community.org</a> [<a href="mailto:koha-devel-bounces@lists.koha-community.org" target="_blank">koha-devel-bounces@lists.koha-community.org</a>] namens Kyle Hall [<a href="mailto:kyle.m.hall@gmail.com" target="_blank">kyle.m.hall@gmail.com</a>]<br>
<b>Verzonden:</b> woensdag 10 april 2013 13:23<br>
<b>To:</b> MJ Ray<br>
<b>Cc:</b> Koha Devel<br>
<b>Onderwerp:</b> Re: [Koha-devel] Koha.next: Consolidate OPAC themes?<br>
</font><br>
</div><div><div class="h5">
<div></div>
<div>
<div dir="ltr">This these have been my thoughts exactly as well. I think it would be best if the templates were pure unstyled html that are well classed and all elements should have unique id's as well. Each theme should just be css and presentation javascript.
<div><br>
</div>
<div>In addition, I think we should completely remove the necessity of passing in system preferences to the templates from perl scripts, and switch to using a TT plugin for accessing system preferences.</div>
<div><br>
</div>
<div>Ian also has a very good point about standard naming conventions. It would be great to get all the variations on naming wrangled into one standard version.</div>
<div><br>
</div>
<div>Another thought I've had that would simplify Koha and keep it more DRY would be to implement ajax based widgets. For instance, both
<a href="http://circulation.pl" target="_blank">circulation.pl</a> and <a href="http://moremember.pl" target="_blank">
moremember.pl</a> display a list of holds in a tab, but each is a separate implementation. If we just made this code a widget ( or even just a .inc file with all the required html and javascript ) we could reuse it on any page we wanted to.<br>
<div><br>
</div>
<div>Kyle</div>
</div>
</div>
<div class="gmail_extra"><br clear="all">
<div><a href="http://www.kylehall.info" target="_blank">http://www.kylehall.info</a><br>
ByWater Solutions ( <a href="http://bywatersolutions.com" target="_blank">http://bywatersolutions.com</a> )<br>
Meadville Public Library ( <a href="http://www.meadvillelibrary.org" target="_blank">
http://www.meadvillelibrary.org</a> )<br>
Crawford County Federated Library System ( <a href="http://www.ccfls.org" target="_blank">
http://www.ccfls.org</a> )<br>
Mill Run Technology Solutions ( <a href="http://millruntech.com" target="_blank">
http://millruntech.com</a> )<br>
</div>
<br>
<br>
<div class="gmail_quote">On Mon, Apr 8, 2013 at 12:17 PM, MJ Ray <span dir="ltr">
<<a href="mailto:mjr@phonecoop.coop" target="_blank">mjr@phonecoop.coop</a>></span> wrote:<br>
<blockquote style="BORDER-LEFT:#ccc 1px solid;MARGIN:0px 0px 0px 0.8ex;PADDING-LEFT:1ex" class="gmail_quote">
Galen Charlton <<a href="mailto:gmc@esilibrary.com" target="_blank">gmc@esilibrary.com</a>><br>
<div>> Consequently, I think the next version of Koha should unify the<br>
> templates of the prog and CCSR themes. If we decide to continue<br>
> offering both appearances as stock options, the visual and layout<br>
> differences between the two should be managed strictly through the use<br>
</div>
> of CSS. [...]<br>
> Thoughts?<br>
<br>
I think this is right. Having a good base theme, especially if there<br>
are basically examples of the right way to adapt it with CSS,<br>
would be a good way for Koha to learn from Evergreen's experience.<br>
<br>
Thanks,<br>
<span><font color="#888888">--<br>
MJ Ray (slef), member of <a href="http://www.software.coop" target="_blank">www.software.coop</a>, a for-more-than-profit co-op.<br>
<a href="http://koha-community.org" target="_blank">http://koha-community.org</a> supporter, web and library systems developer.<br>
In My Opinion Only: see <a href="http://mjr.towers.org.uk/email.html" target="_blank">
http://mjr.towers.org.uk/email.html</a><br>
Available for hire (including development) at <a href="http://www.software.coop/" target="_blank">
http://www.software.coop/</a><br>
</font></span>
<div>
<div>_______________________________________________<br>
Koha-devel mailing list<br>
<a href="mailto:Koha-devel@lists.koha-community.org" target="_blank">Koha-devel@lists.koha-community.org</a><br>
<a href="http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel" target="_blank">http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel</a><br>
website : <a href="http://www.koha-community.org/" target="_blank">http://www.koha-community.org/</a><br>
git : <a href="http://git.koha-community.org/" target="_blank">http://git.koha-community.org/</a><br>
bugs : <a href="http://bugs.koha-community.org/" target="_blank">http://bugs.koha-community.org/</a><br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div></div></div>
</div>
</div>
<br>_______________________________________________<br>
Koha-devel mailing list<br>
<a href="mailto:Koha-devel@lists.koha-community.org">Koha-devel@lists.koha-community.org</a><br>
<a href="http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel" target="_blank">http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel</a><br>
website : <a href="http://www.koha-community.org/" target="_blank">http://www.koha-community.org/</a><br>
git : <a href="http://git.koha-community.org/" target="_blank">http://git.koha-community.org/</a><br>
bugs : <a href="http://bugs.koha-community.org/" target="_blank">http://bugs.koha-community.org/</a><br></blockquote></div><br></div>