<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><blockquote type="cite" style="font-size: 13px; "><br><div dir="ltr">Mason,<div class="gmail_extra"><br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; position: static; z-index: auto; ">
Owen and I were talking recently about a plan to improve the current OPAC directory structure...<br>
<br>
the big problem is there is currently much duplication of unnecessary dirs/files.<br>
each theme has many duplicated files - and each language for each theme has many duplicated files<br>
<br>
all this duplication means that subtle bugs can occur...<br>
now that we have got the awesome new CCSR theme added, the next step is to fix the OPAC dir structure to accommodate multiple themes easily and safely :)<br></blockquote><div><br></div><div>Agreed, but I have some reservations about your proposal (described below). </div>
<div><br></div><blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; position: static; z-index: auto; ">
each theme's dir (eg: prog or ccsr) only needs a 'css' dir,<br>
all other theme's existing subdirs can be moved to the shared top-level 'lib' and 'images' dirs<br></blockquote><div><br></div><div>If this is prescriptive (i.e. "nothing but CSS can go in a theme"), I think this would be a problem. The entire point of themes is that you can do more than just change opac.css and colors.css. If that's all themes did, we wouldn't need them because we have system preferences to change opac.css and colors.css.</div></div></div></div></blockquote><div style="font-size: 13px; "><br></div><div style="font-size: 13px; "><br></div><div style="font-size: 13px; ">yes, a great question! what exactly is a 'theme' going to be in Koha…?</div><div style="font-size: 13px; "><br></div><div style="font-size: 13px; ">i think, a theme can only have custom css, and image files, and that is all</div><div style="font-size: 13px; ">a theme must *not* have custom template, xslt, and include files (history has shown, to allow this would be impossible to maintain safely)</div><div style="font-size: 13px; "><br></div><div style="font-size: 13px; ">i hope most agree on this point? :)</div><div style="font-size: 13px; "><br></div><div style="font-size: 13px; "><br></div><div style="font-size: 13px; ">also, i have realized i have missed some important bits of the redesign...</div><div style="font-size: 13px; "><br></div><div style="font-size: 13px; ">1/ each theme also needs its own 'images' subdir</div><div style="font-size: 13px; "><br></div><div style="font-size: 13px; ">2/ a top-level 'css' dir should be added, that contains 'css' content that is shared between all themes</div><div style="font-size: 13px; "><br></div><div style="font-size: 13px; ">so, the basic idea is that we have shared top-level 'images' and 'css' dirs. that contains content that is *common* between all themes</div><div style="font-size: 13px; ">and some theme specific 'css' and 'images' subdirs, that contains only *unique* content, to that theme</div><div style="font-size: 13px; "><br></div><div style="font-size: 13px; ">remember 90%+ of this css/images content is common between all themes</div><div style="font-size: 13px; "><br></div><div style="font-size: 13px; "><br></div><div style="font-size: 13px; ">i think,the most urgent 'bug' to fix before all this, is that each theme has its own 'includes' dir</div><div style="font-size: 13px; ">we need to fix this before the redesign can start</div><div style="font-size: 13px; "><br></div><div style="font-size: 13px; "><br></div><div style="font-size: 13px; ">so, as a first step, we symlink CCSR's 'includes' dir to PROG's 'includes' dir (as we currently do with CCSR's 'modules' dir)</div><div style="font-size: 13px; ">and test/fix any breakage that may occur</div><div style="font-size: 13px; "><br></div><div style="font-size: 13px; ">…after that change is stable, we can then start the redesign proper</div><div style="font-size: 13px; "><br></div><div><div><span class="Apple-style-span" style="font-size: 13px;"><br></span></div><div><span class="Apple-style-span" style="font-size: 13px;">fyi: heres an example of the additional css and images dirs…</span></div><div><span class="Apple-style-span" style="font-size: 13px;"><br></span></div><div><span class="Apple-style-span" style="font-size: 13px;">opac-tmpl</span></div><div><span class="Apple-style-span" style="font-size: 13px;">└── themes</span></div><div><span class="Apple-style-span" style="font-size: 13px;"> ├── ccsr</span></div><div><span class="Apple-style-span" style="font-size: 13px;"> │ └── css</span></div><div><span class="Apple-style-span" style="font-size: 13px;"> │ └── images</span></div><div><span class="Apple-style-span" style="font-size: 13px;"> └── prog</span></div><div><span class="Apple-style-span" style="font-size: 13px;"> │ └── css</span></div><div><span class="Apple-style-span" style="font-size: 13px;"> │ └── images</span></div><div><span class="Apple-style-span" style="font-size: 13px; ">├── css</span></div><div style="font-size: 13px; ">├── images</div></div><div style="font-size: 13px; "><br></div><div style="font-size: 13px; "><br></div><blockquote type="cite" style="font-size: 13px; "><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br></div><div>While we are reorganizing things, it might be nice to reorganize the YUI files so that we organize them the same way that the official YUI package is organized.</div></div></div></div></blockquote><div style="font-size: 13px; "><br></div><div style="font-size: 13px; ">awesome, sounds great</div><div style="font-size: 13px; "><br></div></div><br><div><br></div><div><br></div></body></html>