<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Baskerville;
panose-1:2 2 5 2 6 3 6 2 3 3;}
@font-face
{font-family:"Minion Pro";
panose-1:2 4 5 3 5 2 1 2 2 3;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Arial","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Ballontekst Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";}
p.MsoNoSpacing, li.MsoNoSpacing, div.MsoNoSpacing
{mso-style-priority:1;
margin:0cm;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Arial","sans-serif";}
span.BallontekstChar
{mso-style-name:"Ballontekst Char";
mso-style-priority:99;
mso-style-link:Ballontekst;
font-family:"Tahoma","sans-serif";
mso-fareast-language:NL;}
p.Default, li.Default, div.Default
{mso-style-name:Default;
margin:0cm;
margin-bottom:.0001pt;
text-autospace:none;
font-size:12.0pt;
font-family:"Baskerville","serif";
color:black;}
p.Basisalinea, li.Basisalinea, div.Basisalinea
{mso-style-name:"\[Basisalinea\]";
mso-style-priority:99;
margin:0cm;
margin-bottom:.0001pt;
line-height:120%;
text-autospace:none;
font-size:12.0pt;
font-family:"Minion Pro","serif";
color:black;}
span.E-mailStijl22
{mso-style-type:personal;
font-family:"Arial","sans-serif";
color:windowtext;}
span.E-mailStijl23
{mso-style-type:personal-reply;
font-family:"Arial","sans-serif";
color:black;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:595.3pt 841.9pt;
margin:72.0pt 90.0pt 72.0pt 90.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="NL" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:black">The commits below date back from end of July. Is there any additional relation to the Bcrypt patches pushed more recently?
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:black"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:black"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span style="font-family:"Tahoma","sans-serif"">Van:</span></b><span style="font-family:"Tahoma","sans-serif""> koha-devel-bounces@lists.koha-community.org [mailto:koha-devel-bounces@lists.koha-community.org]
<b>Namens </b>Marcel de Rooy<br>
<b>Verzonden:</b> donderdag 10 oktober 2013 12:17<br>
<b>Aan:</b> koha-devel@lists.koha-community.org<br>
<b>Onderwerp:</b> [Koha-devel] Crashes on new Opac Recent Searches cookie in older Koha versions<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Hi,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Recently two commits were added that move the search history cookie to a new format.
<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">commit 961617765ef25bde32cb050ad016f3b063661ef8 (no bug number, from Galen)<o:p></o:p></p>
<p class="MsoNormal">commit 488a3d6fed57b4e0d773157ee4a6ab7e4775e7a4 (no bug number, from Galen)<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I have been looking for these patches on Bugzilla, but I cannot find them. Perhaps they are there, but I may have used the wrong search terms.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">These patches have a nasty side-effect. If you use an older Koha version and also current master on the same system for testing, the old Koha version will stumble over this (shared) cookie:<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"> Storable binary image v45.123 more recent than I am (v2.8) at /usr/lib64/perl5/Storable.pm line 416, at /usr/share/koha/maintclone/C4/Auth.pm line 293.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">So to overcome this problem, you must delete the KohaOpacRecentSearches cookie AND set preference EnableOpacSearchHistory to off in the old system.
<o:p></o:p></p>
<p class="MsoNormal">Deleting the search cookie every time, as updated by the master clone, is not really an option :)<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Since I cannot find the bug where this development was documented, I do not know if this side-effect was discussed, tested etc.
<o:p></o:p></p>
<p class="MsoNormal">But for changes like this, a question like: Can this change affect older Koha versions somehow? would be fine to address at the least..<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Marcel<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</body>
</html>