<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Baskerville;
panose-1:2 2 5 2 6 3 6 2 3 3;}
@font-face
{font-family:"Minion Pro";
panose-1:2 4 5 3 5 2 1 2 2 3;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Arial","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Ballontekst Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";}
p.MsoNoSpacing, li.MsoNoSpacing, div.MsoNoSpacing
{mso-style-priority:1;
margin:0cm;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Arial","sans-serif";}
span.E-mailStijl17
{mso-style-type:personal-compose;
font-family:"Arial","sans-serif";
color:windowtext;}
p.Default, li.Default, div.Default
{mso-style-name:Default;
margin:0cm;
margin-bottom:.0001pt;
text-autospace:none;
font-size:12.0pt;
font-family:"Baskerville","serif";
color:black;}
p.Basisalinea, li.Basisalinea, div.Basisalinea
{mso-style-name:"\[Basisalinea\]";
mso-style-priority:99;
margin:0cm;
margin-bottom:.0001pt;
line-height:120%;
text-autospace:none;
font-size:12.0pt;
font-family:"Minion Pro";
color:black;}
span.BallontekstChar
{mso-style-name:"Ballontekst Char";
mso-style-priority:99;
mso-style-link:Ballontekst;
font-family:"Tahoma","sans-serif";
mso-fareast-language:NL;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";
mso-fareast-language:EN-US;}
@page WordSection1
{size:595.3pt 841.9pt;
margin:72.0pt 90.0pt 72.0pt 90.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="NL" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal">Hi all,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">How do we deal with database changes now DBIx::Class is in place?
<o:p></o:p></p>
<p class="MsoNormal">We have the db structure now in at least two places: installer/data/mysql/kohastructure.sql and the separate files in Koha/Schema/Result (per table).
<o:p></o:p></p>
<p class="MsoNormal">Can we get rid of that redundancy in short time? DBIx::Class should now build a new database instead of kohastructure.. (How exactly btw?)<o:p></o:p></p>
<p class="MsoNormal">About the result sets, do we really need to keep track of the same things in two places there (pod line and in add_columns again)?
<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">If a patch presents a dbrev the old way (with updatedatabase and kohastructure), should we reject it now?
<o:p></o:p></p>
<p class="MsoNormal">How does the new-style dbrev actually look like in updatedatabase (upgrade part) ? Which call should we make there to DBIx::Class or Koha::Database ?
<o:p></o:p></p>
<p class="MsoNormal">Probably calling e.g. add_column in updatedatabase and adding the column in the result class file? Or is there a nicer way to say to DBIx “update my items table” or “sync the whole db structure” (if that does not take too much time) ?<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Should a new style patch currently also update the old style files too? Most probably, yes. Even more reason to eliminate that redundancy.<o:p></o:p></p>
<p class="MsoNormal">We should also update the wiki and inform developers what we do expect now.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Marcel<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</body>
</html>