<div dir="ltr">Marcel,<div><br></div><div>As you say, it would be easy to make the matching case-insensitive. I have no opinion on whether that would be a good idea.</div><div><br></div><div>Regards,</div><div>Jared</div><div>
<br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jan 27, 2014 at 4:32 AM, Marcel de Rooy <span dir="ltr"><<a href="mailto:M.de.Rooy@rijksmuseum.nl" target="_blank">M.de.Rooy@rijksmuseum.nl</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="NL" link="blue" vlink="purple">
<div>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Arial","sans-serif"">Thanks, Jared.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Arial","sans-serif"">Just to be more complete: I meant with an uppercase variant in this case the variant starting with only the first character in uc (like Number-local-acquisition).<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Arial","sans-serif"">I scrolled through the QueryParser code and came at the lines 855-857 of OpenILS/QueryParser.pm where three regexes are used to search for fields and aliases.
<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Arial","sans-serif"">Is it an idea to make these regexes case insensitive?
<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Arial","sans-serif"">This would make QueryParser behave case insensitive as to index names, just like C4/Search.pm now is when you disable QueryParser. (compare BZ 6786)
<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Arial","sans-serif"">As an example, the Number-local-acquisition index of BZ 10544 could be mentioned. QueryParser does not recognize the index name with capital N, but since it prefixes
the string with pqf=, C4/Search will not change it either. <u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Arial","sans-serif""><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Arial","sans-serif"">Copying dev list for additional feedback?
<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Arial","sans-serif""><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Arial","sans-serif"">Marcel
<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Arial","sans-serif""><u></u> <u></u></span></p>
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">Van:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Jared Camins-Esakov [mailto:<a href="mailto:jcamins@cpbibliography.com" target="_blank">jcamins@cpbibliography.com</a>]
<br>
<b>Verzonden:</b> donderdag 23 januari 2014 16:02<br>
<b>Aan:</b> Marcel de Rooy<br>
<b>Onderwerp:</b> Re: QueryParser question<u></u><u></u></span></p><div><div class="h5">
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">Marcel,<u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Upper-case indexes seem odd to me, but it would be easy to add them. For example, the following change in Koha/QueryParser/Driver/PQF.pm:<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">97 $self->add_search_field_alias( $class => $field => uc $field );<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Regards,<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">Jared<u></u><u></u></p>
</div>
</div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><u></u> <u></u></p>
<div>
<p class="MsoNormal">On Thu, Jan 23, 2014 at 8:32 AM, Marcel de Rooy <<a href="mailto:M.de.Rooy@rijksmuseum.nl" target="_blank">M.de.Rooy@rijksmuseum.nl</a>> wrote:<u></u><u></u></p>
<div>
<div>
<p>Hi Jared,<u></u><u></u></p>
<p> <u></u><u></u></p>
<p>This question came up when looking at report <a href="http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544" target="_blank">
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544</a><u></u><u></u></p>
<p> <u></u><u></u></p>
<p>The index names in the config file seem to be lower case. Upper case variants do not seem to work.
<u></u><u></u></p>
<p> <u></u><u></u></p>
<p>Is it possible to add uppercase names? Or is it possible to have all variants work in some case insensitive manner?
<u></u><u></u></p>
<p> <u></u><u></u></p>
<p>Thanks,<u></u><u></u></p>
<p><span style="color:#888888"> <u></u><u></u></span></p>
<p><span style="color:#888888">Marcel<u></u><u></u></span></p>
</div>
</div>
</div>
<p class="MsoNormal"><br>
<br clear="all">
<u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<p class="MsoNormal">-- <br>
Jared Camins-Esakov<u></u><u></u></p>
<div>
<p class="MsoNormal">Bibliographer, C & P Bibliography Services, LLC<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">(phone) <a href="tel:%2B1%20%28917%29%20727-3445" value="+19177273445" target="_blank">+1 (917) 727-3445</a><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">(e-mail) <a href="mailto:jcamins@cpbibliography.com" target="_blank">
jcamins@cpbibliography.com</a><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">(web) <a href="http://www.cpbibliography.com/" target="_blank">
http://www.cpbibliography.com/</a><u></u><u></u></p>
</div>
</div>
</div></div></div>
</div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br>Jared Camins-Esakov<div>Bibliographer, C & P Bibliography Services, LLC</div><div>(phone) +1 (917) 727-3445</div><div>(e-mail) <a href="mailto:jcamins@cpbibliography.com" target="_blank">jcamins@cpbibliography.com</a></div>
<div>(web) <a href="http://www.cpbibliography.com/" target="_blank">http://www.cpbibliography.com/</a></div>
</div>