<p dir="ltr">+1 to both removing from codebase and adding to guidline with suggested text.</p>
<div class="gmail_quote">On 28 Apr 2014 17:56, "Tomas Cohen Arazi" <<a href="mailto:tomascohen@gmail.com">tomascohen@gmail.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">+1 for removal.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Apr 28, 2014 at 12:26 PM, Galen Charlton <span dir="ltr"><<a href="mailto:gmc@esilibrary.com" target="_blank">gmc@esilibrary.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<div><br>
On Mon, Apr 28, 2014 at 7:43 AM, Tomas Cohen Arazi <<a href="mailto:tomascohen@gmail.com" target="_blank">tomascohen@gmail.com</a>> wrote:<br>
> The latest Ubuntu LTS release includes Perl 5.18. One of the main noticeable<br>
> consequences of this is that some 5.10 features are now marked as<br>
> experimental, and hence warnings appear everywhere.<br>
><br>
> One example could be the use of '~~' (C4/Search.pm:536). These warnings can<br>
> be avoided using the following pragma [1]:<br>
><br>
> no if $] >= 5.018, 'warnings', "experimental::feature_name";<br>
<br>
</div>In my view, we should not use the pragma to hide the warning messages<br>
-- we should remove use of the experimental constructs, including the<br>
smartmatch operator. There have already been a couple recent-ish<br>
patches pushed [1] to remove uses of smartmatch.<br>
<br>
This is because, as the link you included in your email states,<br>
features that the Perl developers have marked as experimental are<br>
subject to change, which could lead to surprises as future versions of<br>
Perl get released.<br>
<br>
I have opened a new bug [2] for removing the remaining uses of the<br>
smartmatch operator, and I suggest that we add a new coding guideline<br>
to this effect:<br>
<br>
=== PERL19: The use of the Perl smartmatch operator is forbidden ===<br>
<br>
The Perl smartmatch operator, including ~~ and given/when, has been<br>
[<a href="http://perldoc.perl.org/5.18.0/perldelta.html#The-smartmatch-family-of-features-are-now-experimental" target="_blank">http://perldoc.perl.org/5.18.0/perldelta.html#The-smartmatch-family-of-features-are-now-experimental</a><br>
marked experimental] as of Perl 5.18.0. Since the meaning of the<br>
smartmatch operator is subject to change, and since using it will by<br>
default add warnings to the error log, new code should not use it.<br>
<br>
[1] Bugs 11468 and 11479<br>
[2] <a href="http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12151" target="_blank">http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12151</a><br>
<br>
Regards,<br>
<br>
Galen<br>
<span><font color="#888888">--<br>
Galen Charlton<br>
Manager of Implementation<br>
Equinox Software, Inc. / The Open Source Experts<br>
email: <a href="mailto:gmc@esilibrary.com" target="_blank">gmc@esilibrary.com</a><br>
direct: <a href="tel:%2B1%20770-709-5581" value="+17707095581" target="_blank">+1 770-709-5581</a><br>
cell: <a href="tel:%2B1%20404-984-4366" value="+14049844366" target="_blank">+1 404-984-4366</a><br>
skype: gmcharlt<br>
web: <a href="http://www.esilibrary.com/" target="_blank">http://www.esilibrary.com/</a><br>
Supporting Koha and Evergreen: <a href="http://koha-community.org" target="_blank">http://koha-community.org</a> &<br>
<a href="http://evergreen-ils.org" target="_blank">http://evergreen-ils.org</a><br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><div>Tomás Cohen Arazi</div><div>Prosecretaría de Informática</div><div>Universidad Nacional de Córdoba</div><div>✆ <a href="tel:%2B54%20351%204333190%20ext%2013168" value="+543514333190" target="_blank">+54 351 4333190 ext 13168</a></div>
<div>GPG: B76C 6E7C 2D80 551A C765 E225 0A27 2EA1 B2F3 C15F</div></div>
</div>
<br>_______________________________________________<br>
Koha-devel mailing list<br>
<a href="mailto:Koha-devel@lists.koha-community.org">Koha-devel@lists.koha-community.org</a><br>
<a href="http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel" target="_blank">http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel</a><br>
website : <a href="http://www.koha-community.org/" target="_blank">http://www.koha-community.org/</a><br>
git : <a href="http://git.koha-community.org/" target="_blank">http://git.koha-community.org/</a><br>
bugs : <a href="http://bugs.koha-community.org/" target="_blank">http://bugs.koha-community.org/</a><br></blockquote></div>